HomePhabricator
Diffusion MITK a76157a181ea

multiple fixes
Auditeda76157a181ea
Actions

Description

multiple fixes

Signed-off-by: Andre Klein <andre.klein@dkfz-heidelberg.de>

Details

Auditors
kislinsk
Provenance
• kleinaAuthored on Nov 25 2016, 2:09 PM
• kleinaPushed on Nov 25 2016, 2:09 PM
Parents
rMITKa6db67d78af6: Added functionality to plot statistics on figure. Added show/hide subchart…
Branches
Unknown
Tags
Unknown
References
T19708-upgrade-histogram-to-c3js-and-qwebengine

Event Timeline

• kleina committed rMITKa76157a181ea: multiple fixes (authored by • kleina).Nov 25 2016, 2:09 PM
kislinsk raised a concern with this commit.Nov 25 2016, 2:17 PM
kislinsk added a subscriber: kislinsk.
kislinsk added inline comments.
/Modules/C3js/include/QmitkC3Data.h
32–33

Typo: Changed

41

General rule, not only here: begin parameters in lower case.

43

Same as above, i.e., yData instead of YData.

68–69

Typo

• kleina marked 4 inline comments as done.Nov 28 2016, 10:11 AM

Typos and Variable names fixed in T19609-integration-branch2.

I merged the development branch into this integration branch to test the new charts with the new statistics. A few minor bugs need to be fixed.

kislinsk accepted this commit.Nov 28 2016, 10:13 AM

Changes (6)

PathSizePackages
Modules/
C3js/
include/
resource/
src/
Plugins/
org.mitk.gui.qt.measurementtoolbox/
src/
internal/
O1: MITK Reviewer Group I

rMITKa76157a181ea

View Options

Modules/C3js/include/QmitkC3Data.h

Loading...
View Options

Modules/C3js/include/QmitkC3jsWidget.h

Loading...
View Options

Modules/C3js/resource/Histogram.js

Loading...
View Options

Modules/C3js/src/QmitkC3Data.cpp

Loading...
View Options

Modules/C3js/src/QmitkC3jsWidget.cpp

Loading...
View Options

Plugins/org.mitk.gui.qt.measurementtoolbox/src/internal/QmitkImageStatisticsView.cpp

Loading...
MITK · MIC · IMSY · DKFZ