Diffusion MITK b3e02403b5db

Fixed T29139 - Fixed warnings when creating a 4D statistic with a 3D mask…
b3e02403b5db
Actions

Description

Fixed T29139 - Fixed warnings when creating a 4D statistic with a 3D mask (wrong time mapping)

Summary:

fixed the correct mapping of time point to time step of mask
Avoid cloning of images in Mask generator
Improved const correctness and const support in some statistic classes

Test Plan: code review, unit test, test of workbench (see instruction of T29139)

Reviewers: O3 MITK Reviewer Group II, O1 MITK Reviewer Group I, kislinsk

Reviewed By: O3 MITK Reviewer Group II, O1 MITK Reviewer Group I, kislinsk

Subscribers: kislinsk

Differential Revision: https://phabricator.mitk.org/D647

Details

Provenance

floca	Authored on May 13 2022, 9:08 PM
floca	Pushed on May 16 2022, 11:51 AM

Reviewer

O3: MITK Reviewer Group II

Differential Revision

Restricted Differential Revision

Parents

rMITKfb1fc9101d2c: fixed gcc error and missed compile errors.
rMITK01b95b178454: Merge branch 'T25991-Update-semantic-relations-test' into develop

Branches

Unknown

Tags

Unknown

Tasks

T29139: [Image statistics] Warning is shown for 4D image with 3D mask

Event Timeline

floca committed rMITKb3e02403b5db: Fixed T29139 - Fixed warnings when creating a 4D statistic with a 3D mask… (authored by floca).May 16 2022, 11:51 AM

floca added an edge: Restricted Differential Revision.

floca added a task: T29139: [Image statistics] Warning is shown for 4D image with 3D mask.

kislinsk mentioned this in T29226: 2022 Week 28 (Mid July).Jul 11 2022, 7:17 AM

Merged Changes

fb1fc9101d2c fixed gcc error and missed compile errors.
Author
floca
Browse Repository
No Builds
No Audits
359dbcfcc6d6 fixed gcc errors
Author
floca
Browse Repository
No Builds
No Audits
89a7f0dc4b7f BREAKING: MaskGenerators now return masks as const.
Author
floca
Browse Repository
No Builds
No Audits

Changes (19)

Path

Size

Packages

Modules/

Classification/

CLMiniApps/

CLPlanarFigureToNrrd.cpp

ImageStatistics/

Testing/

mitkImageStatisticsHotspotTest.cpp

O1: MITK Reviewer Group I

mitkHotspotMaskGenerator.cpp

O1: MITK Reviewer Group I

mitkHotspotMaskGenerator.h

O1: MITK Reviewer Group I

mitkIgnorePixelMaskGenerator.cpp

O1: MITK Reviewer Group I

mitkIgnorePixelMaskGenerator.h

O1: MITK Reviewer Group I

mitkImageMaskGenerator.cpp

O1: MITK Reviewer Group I

mitkImageMaskGenerator.h

O1: MITK Reviewer Group I

mitkImageStatisticsCalculator.cpp

O1: MITK Reviewer Group I

mitkImageStatisticsCalculator.h

O1: MITK Reviewer Group I

mitkMaskGenerator.cpp

O1: MITK Reviewer Group I

mitkMaskGenerator.h

O1: MITK Reviewer Group I

mitkMaskUtilities.h

O1: MITK Reviewer Group I

mitkMaskUtilities.tpp

O1: MITK Reviewer Group I

mitkPlanarFigureMaskGenerator.cpp

O1: MITK Reviewer Group I

mitkPlanarFigureMaskGenerator.h

O1: MITK Reviewer Group I

ImageStatisticsUI/

Qmitk/

QmitkImageStatisticsCalculationJob.cpp

O3: MITK Reviewer Group II

QmitkImageStatisticsCalculationRunnable.cpp

O3: MITK Reviewer Group II

Segmentation/

Algorithms/

mitkFeatureBasedEdgeDetectionFilter.cpp

O1: MITK Reviewer Group I

rMITKb3e02403b5db

View Options

Modules/Classification/CLMiniApps/CLPlanarFigureToNrrd.cpp

View Options

Modules/ImageStatistics/Testing/mitkImageStatisticsHotspotTest.cpp

View Options

Modules/ImageStatistics/mitkHotspotMaskGenerator.cpp

View Options

Modules/ImageStatistics/mitkHotspotMaskGenerator.h

View Options

Modules/ImageStatistics/mitkIgnorePixelMaskGenerator.cpp

View Options

Modules/ImageStatistics/mitkIgnorePixelMaskGenerator.h

View Options

Modules/ImageStatistics/mitkImageMaskGenerator.cpp

View Options

Modules/ImageStatistics/mitkImageMaskGenerator.h

View Options

Modules/ImageStatistics/mitkImageStatisticsCalculator.cpp

View Options

Modules/ImageStatistics/mitkImageStatisticsCalculator.h

View Options

Modules/ImageStatistics/mitkMaskGenerator.cpp

View Options

Modules/ImageStatistics/mitkMaskGenerator.h

View Options

Modules/ImageStatistics/mitkMaskUtilities.h

View Options

Modules/ImageStatistics/mitkMaskUtilities.tpp

View Options

Modules/ImageStatistics/mitkPlanarFigureMaskGenerator.cpp

View Options

Modules/ImageStatistics/mitkPlanarFigureMaskGenerator.h

View Options

Modules/ImageStatisticsUI/Qmitk/QmitkImageStatisticsCalculationJob.cpp

View Options

Modules/ImageStatisticsUI/Qmitk/QmitkImageStatisticsCalculationRunnable.cpp

View Options

Modules/Segmentation/Algorithms/mitkFeatureBasedEdgeDetectionFilter.cpp

Fixed T29139 - Fixed warnings when creating a 4D statistic with a 3D mask…b3e02403b5dbActions

Description

Details

Event Timeline

Merged Changes

Changes (19)

rMITKb3e02403b5db

Modules/Classification/CLMiniApps/CLPlanarFigureToNrrd.cpp

Modules/ImageStatistics/Testing/mitkImageStatisticsHotspotTest.cpp

Modules/ImageStatistics/mitkHotspotMaskGenerator.cpp

Modules/ImageStatistics/mitkHotspotMaskGenerator.h

Modules/ImageStatistics/mitkIgnorePixelMaskGenerator.cpp

Modules/ImageStatistics/mitkIgnorePixelMaskGenerator.h

Modules/ImageStatistics/mitkImageMaskGenerator.cpp

Modules/ImageStatistics/mitkImageMaskGenerator.h

Modules/ImageStatistics/mitkImageStatisticsCalculator.cpp

Modules/ImageStatistics/mitkImageStatisticsCalculator.h

Modules/ImageStatistics/mitkMaskGenerator.cpp

Modules/ImageStatistics/mitkMaskGenerator.h

Modules/ImageStatistics/mitkMaskUtilities.h

Modules/ImageStatistics/mitkMaskUtilities.tpp

Modules/ImageStatistics/mitkPlanarFigureMaskGenerator.cpp

Modules/ImageStatistics/mitkPlanarFigureMaskGenerator.h

Modules/ImageStatisticsUI/Qmitk/QmitkImageStatisticsCalculationJob.cpp

Modules/ImageStatisticsUI/Qmitk/QmitkImageStatisticsCalculationRunnable.cpp

Modules/Segmentation/Algorithms/mitkFeatureBasedEdgeDetectionFilter.cpp

Fixed T29139 - Fixed warnings when creating a 4D statistic with a 3D mask…
b3e02403b5db
Actions