HomePhabricator
Diffusion MITK b6992664bb45

Remove emplacement for lineType & clarify naming of it
Auditedb6992664bb45
Actions

Description

Remove emplacement for lineType & clarify naming of it

Details

Auditors
kalali
Provenance
j762eAuthored on Nov 27 2019, 5:45 PM
j762ePushed on Nov 27 2019, 5:45 PM
Parents
rMITKbb4e83cc238f: Remove unnecessary variables
Branches
Unknown
Tags
Unknown

Event Timeline

j762e committed rMITKb6992664bb45: Remove emplacement for lineType & clarify naming of it (authored by j762e).Nov 27 2019, 5:45 PM
kalali raised a concern with this commit.Nov 29 2019, 6:51 PM
kalali added a subscriber: kalali.
kalali added inline comments.
/Plugins/org.mitk.gui.qt.chartExample/src/internal/QmitkChartExampleView.cpp
103

Why do you need to convert to lower-string?

This commit now has outstanding concerns.Nov 29 2019, 6:51 PM
kalali accepted this commit.Jan 17 2020, 12:25 PM
All concerns with this commit have now been addressed.Jan 17 2020, 12:25 PM

Changes (3)

PathSizePackages
Modules/
Chart/
src/
O3: MITK Reviewer Group II
Plugins/
org.mitk.gui.qt.chartExample/
src/
internal/

rMITKb6992664bb45

View Options

Modules/Chart/src/QmitkChartWidget.cpp

Loading...
View Options

Plugins/org.mitk.gui.qt.chartExample/src/internal/QmitkChartExampleView.cpp

Loading...
View Options

Plugins/org.mitk.gui.qt.chartExample/src/internal/QmitkChartExampleView.h

Loading...
MITK · MIC · IMSY · DKFZ