HomePhabricator
Diffusion MITK b7f3afaa22c5

Refactoring if Qmitk statistics classes

Description

Refactoring if Qmitk statistics classes

Summary:
Interim commit (home office transfer)

Compiles again, but rework not finisched.

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

First complete refactoring draft for statistics data generator

  • cleaned up the statistics view
  • compiles, but tests are missing, and generator logic has still some flaws.

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Started unit test for QmitkImageStatisticsDataGenerator

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Added unit test for QmitkImageStatisticsDataGenerator

  • fixed/improved implementation of tested class

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Introduced "IgnoreZero" and "HistogramNBin" awarness to QmitkImageStatisticsTreeModel and widget

  • also add WIP awarness to model

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Integrate new generator and model features into QmitkImageStatisticsView

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Optimized QmitkDataGeneratorBase logic to reduce unnecessary checking

  • fixed glitsches in QmitkImageStatisticsTreeModel

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Fixed wrong usage of mitk::WeakPointer in QmitkDataStarageTreeModel

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Improved documentation

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Test Plan: Unit test and review

Reviewers: O3 MITK Reviewer Group II, O1 MITK Reviewer Group I, kislinsk, kalali

Reviewed By: O3 MITK Reviewer Group II, O1 MITK Reviewer Group I, kislinsk

Maniphest Tasks: T27205

Differential Revision: https://phabricator.mitk.org/D267

Details

Provenance
flocaAuthored on Mar 31 2020, 6:57 PM
flocaPushed on Mar 31 2020, 9:06 PM
Reviewer
O3: MITK Reviewer Group II
Differential Revision
Restricted Differential Revision
Parents
rMITKac639fc20cae: Fixed review remarks.
rMITK9c01922520fd: Remove out of ref image bounds check for planar figures
Branches
Unknown
Tags
Unknown
Tasks
T27205: Refactor statistic generation by introduce generators drafted for RT statistics

Merged Changes