HomePhabricator
Diffusion MITK cdda996996fd

Add Function to update existing data
Auditedcdda996996fd
Actions

Description

Add Function to update existing data

Details

Auditors
kalali
Provenance
j762eAuthored on Nov 4 2019, 4:01 PM
j762ePushed on Nov 5 2019, 1:56 PM
Parents
rMITK39cfb5c5df5e: Remove override
Branches
Unknown
Tags
Unknown

Event Timeline

j762e committed rMITKcdda996996fd: Add Function to update existing data (authored by j762e).Nov 4 2019, 4:01 PM
kalali added a subscriber: kalali.Nov 15 2019, 11:48 AM
kalali added inline comments.
/Plugins/org.mitk.gui.qt.chartExample/src/internal/ChartExample.cpp
461

The functionality above could be put into a separate private function. Maybe ConvertToText already does what you want?

491

Similar to the comment above.

kalali raised a concern with this commit.Nov 15 2019, 12:05 PM
This commit now has outstanding concerns.Nov 15 2019, 12:05 PM
kalali added inline comments.Nov 15 2019, 5:57 PM
/Plugins/org.mitk.gui.qt.chartExample/src/internal/ChartExample.cpp
507

Text of combo box can be directly set.

kalali accepted this commit.Jan 17 2020, 12:30 PM
All concerns with this commit have now been addressed.Jan 17 2020, 12:30 PM

Changes (2)

PathSize
Plugins/
org.mitk.gui.qt.chartExample/
src/
internal/

rMITKcdda996996fd

View Options

Plugins/org.mitk.gui.qt.chartExample/src/internal/ChartExample.cpp

Loading...
View Options

Plugins/org.mitk.gui.qt.chartExample/src/internal/ChartExample.h

Loading...
MITK · MIC · IMSY · DKFZ