Enalbe NodeChanged event trigger and pre-check if update is necessary
Description
Description
Details
Details
- Auditors
floca kalali - Provenance
kalali Authored on Jan 15 2020, 6:26 PM kalali Pushed on Jan 15 2020, 6:27 PM - Parents
- rMITK0bb2c01d5b33: Revert changes for updating the view of the inspector manually
- Branches
- Unknown
- Tags
Event Timeline
| /Modules/QtWidgets/src/QmitkDataStorageDefaultListModel.cpp | ||
|---|---|---|
| 39 | Please verify the logic of this function. | |
Comment Actions
Logic is correct. But I would condense it to remove redundancy (see inline comment).
| /Modules/QtWidgets/src/QmitkDataStorageDefaultListModel.cpp | ||
|---|---|---|
| 43–55 | Can be condensed to if (m_NodePredicate.IsNull() || m_NodePredicate->CheckNode(node)) { UpdateModelData(); return; } | |
| /Modules/QtWidgets/src/QmitkDataStorageDefaultListModel.cpp | ||
|---|---|---|
| 43–55 | You're absolutely right! | |