Page MenuHomePhabricator

Reading a series of image files does not work with QT4 app
Closed, InvalidPublic

Description

It seems that the QT4 application (in contrast to the QT3 one) does not offer to read a series of image files yet: there does not seem to be a menu entry or other possibility to do that.

Event Timeline

ivo added a subscriber: ivo.

just three lines of code changed.

The attached patch solves the problem at least partially: Dropping ONE file of an image series while HOLDING the CRTL-key (which means "link" according to usual conventions => here: "link" images of a series to a single mitk::Image) will try to load a series of images.

Your solution sounds ok to me (Although a "load series dialog" and a "load raw image" dialog would be even nicer).

However, your patch contains this strange line:

if (!usedNewDTNF && !( m_FileName != "" ) && !(m_Serie == false))

Is this on purpose? Looks like it will only work if NO filename is given?

It could be formulated in a more simple way:

if ( !usedNewDTNF && m_FileName.empty() && m_Serie )

(In reply to comment #3)

Your solution sounds ok to me (Although a "load series dialog" and a "load raw
image" dialog would be even nicer).

D'accord - the patch is definitely only a "partial" solution.

However, your patch contains this strange line:

if (!usedNewDTNF && !( m_FileName != "" ) && !(m_Serie == false))

Is this on purpose? Looks like it will only work if NO filename is given?

Sorry, I forgot to comment on this: The strange line is the original, the patch removes the "not" in front of m_FileName.
Thus:
"if ( !usedNewDTNF && !m_FileName.empty() && m_Serie )"

Reason (and indeed, there is more work to be done to make it really nice):
The currently implemented method for reading file series takes a filename (stored in m_FileName) as an example to guess the prefix and the filepattern from this. The members m_FilePrefix and m_FilePattern are ignored (!), see
mitk::FileSeriesReader::GenerateFileList which is called by mitk::DataNodeFactory::ReadFileSeriesTypeITKImageSeriesReader.

[SVN revision 28820]
DOC (#4357): added feature to load a series of 2D images to 3D volume

[SVN revision 28822]
ENH (#4357): added feature to load a series of 2D images to 3D volume

[SVN revision 28825]
ENH (#4357): added feature to load a series of 2D images to 3D volume

I just tried to load 3 images at one time it looks like this works now...
Can the bug be closed?

Maybe it worked 2011, but not anymore.
A single image is loaded again when opening a bitmap / jpeg etc. series.

Cause:
In Ivo's patch, the Drag&Drop set the mitkDataNodeFactory to read a series.
It seems Sascha remodeled Drag&Drop, which does no do this anymore.

So, mitkDataNodeFactory has a member m_Serie, which is initialized to false and never used again. When I set this to true manually, series are loaded again.

kislinsk changed the task status from Invalid to Spite.Jun 27 2018, 1:33 PM
kislinsk added a project: Bulk Edit.
kislinsk changed the task status from Spite to Invalid.Jun 27 2018, 1:37 PM
kislinsk removed a project: Bulk Edit.