Page MenuHomePhabricator

Fix unit tests that fail since T29038
Closed, ResolvedPublic

Description

Two unit tests fail:

  1. usModuleManifestTest
  2. mitkGIFCurvatureStatisticTest

The fix for test 1 is trivial: JsonCpp changed the way it recognizes double values and explicitly includes ints und uints. To compensate, we simply must check first for int and then for double to restore previous behavior.

The fix for test 2 is trivial but not very satisfying: Some expected statistic values must be updated. This is due to changes in the vtkCurvatures class, which was numerically stabilized / updated and is used in the test. See https://github.com/Kitware/VTK/commit/14eecaf670e5387265fb496446fc32079f961aab.