Page MenuHomePhabricator

kislinsk (Stefan Dinkelacker)
UserAdministrator

Projects (15)

User Details

User Since
Aug 1 2016, 11:50 AM (180 w, 4 d)
Roles
Administrator

Recent Activity

Today

kislinsk committed rMITK4c24e3cba37d: Merge branch 'T26976-InstallPythonQtOnMacOs' (authored by kislinsk).
Merge branch 'T26976-InstallPythonQtOnMacOs'
Fri, Jan 17, 9:53 AM
kislinsk committed rMITKf02562b637bc: Ignore Python executable in macOS Python.framework (authored by kislinsk).
Ignore Python executable in macOS Python.framework
Fri, Jan 17, 9:52 AM

Yesterday

kislinsk added a reverting change for rMITK343d9f435f57: Discover and fixup all executables before verifying the bundle on macOS: rMITKc6e9a6caff41: Revert "Discover and fixup all executables before verifying the bundle on macOS".
Thu, Jan 16, 2:21 PM
kislinsk committed rMITKc6e9a6caff41: Revert "Discover and fixup all executables before verifying the bundle on macOS" (authored by kislinsk).
Revert "Discover and fixup all executables before verifying the bundle on macOS"
Thu, Jan 16, 2:21 PM
kislinsk placed T26992: Rendering tests do not run on Windows and macOS up for grabs.
Thu, Jan 16, 12:51 PM · MITK
kislinsk placed T26745: MITK's interaction not the first to handle events anymore -- QVTKOpenGLWidget::event() changed since VTK 7.0.0 (MITK 2016.11) up for grabs.
Thu, Jan 16, 12:51 PM · MITK (2018-04-4), Pull Request
kislinsk placed T25930: [Segmentation] Fill/Erase crashes at non-zero timestep / Issue with ArbitraryTimeGeometry up for grabs.
Thu, Jan 16, 12:51 PM · Request for Discussion, Restricted Project, MITK (2018-04-4)
kislinsk committed rMITK343d9f435f57: Discover and fixup all executables before verifying the bundle on macOS (authored by kislinsk).
Discover and fixup all executables before verifying the bundle on macOS
Thu, Jan 16, 12:50 PM
kislinsk added a comment to T26976: PythonQt is not installed on macOS when creating an MITK installer.

https://gitlab.kitware.com/cmake/cmake/issues/20165

Thu, Jan 16, 10:53 AM · MITK

Tue, Jan 14

kislinsk committed rMITK258838df6a80: Merge branch 'T26992-FixRenderingTestHelper' (authored by kislinsk).
Merge branch 'T26992-FixRenderingTestHelper'
Tue, Jan 14, 4:24 PM
kislinsk committed rMITKf2e9c3aeb49a: Add missing header (macOS) (authored by kislinsk).
Add missing header (macOS)
Tue, Jan 14, 4:23 PM
kislinsk added a comment to T26992: Rendering tests do not run on Windows and macOS.

For now, re-introduce a check for OpenGL support until we found a solution.

Tue, Jan 14, 4:03 PM · MITK
kislinsk committed rMITKe5aeb4ab1fe5: Merge branch 'T26992-FixRenderingTestHelper' (authored by kislinsk).
Merge branch 'T26992-FixRenderingTestHelper'
Tue, Jan 14, 4:01 PM
kislinsk committed rMITKdd8d6da2f746: Reintroduce enhanced OpenGL support test (authored by kislinsk).
Reintroduce enhanced OpenGL support test
Tue, Jan 14, 4:01 PM
kislinsk committed rMITK2c98c94e9afb: Remove dangling declarations (authored by kislinsk).
Remove dangling declarations
Tue, Jan 14, 4:01 PM

Mon, Jan 13

kislinsk added a comment to T26992: Rendering tests do not run on Windows and macOS.

Test now do run on Windows but they fail because of OpenGL context creation issues. I guess it has something to do with using the Windows client in "headless" mode.

Mon, Jan 13, 3:44 PM · MITK
kislinsk committed rMITK31796e4f314d: Merge branch 'T26992-FixRenderingTestHelper' (authored by kislinsk).
Merge branch 'T26992-FixRenderingTestHelper'
Mon, Jan 13, 3:09 PM
kislinsk committed rMITKce4bd875017f: Remove flawed OpenGL detection code (authored by kislinsk).
Remove flawed OpenGL detection code
Mon, Jan 13, 3:08 PM
kislinsk added a comment to T26992: Rendering tests do not run on Windows and macOS.

Pushed new branch T26992-FixRenderingTestHelper.

Mon, Jan 13, 3:07 PM · MITK
kislinsk triaged T26992: Rendering tests do not run on Windows and macOS as Normal priority.
Mon, Jan 13, 3:04 PM · MITK
kislinsk placed T26835: Crash on change of Surface interpolation from Phong to Flat up for grabs.
Mon, Jan 13, 1:47 PM · Pull Request, MITK

Thu, Jan 9

kislinsk edited projects for T18761: Verify view navigator works after BlueBerry merge, added: MITK (2018-04-4); removed MITK.
Thu, Jan 9, 2:52 PM · MITK (2018-04-4), Bugzilla
kislinsk edited projects for T26970: [Segmentation] Picking tool: When no region is picked, selected not just gets unselected, added: MITK (2018-04-4); removed MITK.
Thu, Jan 9, 2:52 PM · MITK (2018-04-4)
kislinsk edited projects for T18866: Highlighting in View Navigator is not updated, added: MITK (2018-04-4); removed MITK.
Thu, Jan 9, 2:52 PM · MITK (2018-04-4), Restricted Project, Bugzilla
kislinsk edited projects for T26969: [Segmentation] New segmentation dialog: Change color twice and aborting the second time chages color to red, added: MITK (2018-04-4); removed MITK.
Thu, Jan 9, 2:52 PM · MITK (2018-04-4)
kislinsk edited projects for T26963: Dicom Browser progressbar not showing, added: MITK (2018-04-4); removed MITK.
Thu, Jan 9, 2:52 PM · MITK (2018-04-4), Restricted Project
kislinsk edited projects for T22391: Correction tool doesn't work in empty slice, added: MITK (2018-04-4); removed MITK.
Thu, Jan 9, 2:52 PM · MITK (2018-04-4), Restricted Project
kislinsk edited projects for T22395: Live wire tool deactivate leads to confirm segmentation, added: MITK (2018-04-4); removed MITK.
Thu, Jan 9, 2:52 PM · MITK (2018-04-4), Restricted Project
kislinsk edited projects for T24398: Dicom plugin: wdb Retrieve does not work, added: MITK (2018-04-4); removed MITK (2018-04).
Thu, Jan 9, 2:52 PM · MITK (2018-04-4)
kislinsk edited projects for T26957: LevelWindow context menu entries change default level-window, added: MITK (2018-04-4); removed MITK.
Thu, Jan 9, 2:52 PM · MITK (2018-04-4), Restricted Project
kislinsk edited projects for T26956: LevelWindow slider does not expand the level/window scale, added: MITK (2018-04-4); removed MITK.
Thu, Jan 9, 2:52 PM · MITK (2018-04-4)
kislinsk edited projects for T26959: Newly created LabelSet segmentation is not displayed as "outline binary", added: MITK (2018-04-4); removed MITK.
Thu, Jan 9, 2:52 PM · MITK (2018-04-4)
kislinsk edited projects for T26964: Version number not correctly displayed in Debug mode, added: MITK (2018-04-4); removed MITK.
Thu, Jan 9, 2:52 PM · MITK (2018-04-4)
kislinsk edited projects for T26958: LevelWindow Preset Dialog does not work correctly, added: MITK (2018-04-4); removed MITK.
Thu, Jan 9, 2:52 PM · MITK (2018-04-4)
kislinsk edited projects for T26966: [Segmentation] Help button in threshold dialogs have no function, added: MITK (2018-04-4); removed MITK.
Thu, Jan 9, 2:52 PM · MITK (2018-04-4)
kislinsk edited projects for T26967: [Segmentation] Pressing the X button on threshold confirm dialogs does not stop the execution, added: MITK (2018-04-4); removed MITK.
Thu, Jan 9, 2:52 PM · MITK (2018-04-4)
kislinsk edited projects for T26968: [DataManager] "Show only selected nodes" button causes 2D widgets in the 3D renderwindow to vanish , added: MITK (2018-04-4); removed MITK.
Thu, Jan 9, 2:52 PM · MITK (2018-04-4)
kislinsk edited projects for T26972: Dialog and plugin layout seems to be not shown correctly on laptops, added: MITK (2018-04-4); removed MITK.
Thu, Jan 9, 2:52 PM · MITK (2018-04-4)
kislinsk edited projects for T26973: [Segmentation] RegionGrowing3D preview only in 3D Widget, added: MITK (2018-04-4); removed MITK.
Thu, Jan 9, 2:52 PM · MITK (2018-04-4)
kislinsk edited projects for T26975: 2D Fast Marching for 4D data intermediate state displays segmentation in other timesteps, added: MITK (2018-04-4); removed MITK.
Thu, Jan 9, 2:52 PM · MITK (2018-04-4), Restricted Project
kislinsk edited projects for T26974: Region Growing 3D with 4D dataset not working, added: MITK (2018-04-4); removed MITK.
Thu, Jan 9, 2:52 PM · MITK (2018-04-4), Restricted Project
kislinsk edited projects for T26978: [Segmentation] Autocrop with MITK Multilabel Image Reader does not work with multilabel images, added: MITK (2018-04-4); removed MITK.
Thu, Jan 9, 2:52 PM · MITK (2018-04-4), Request for Discussion
kislinsk edited projects for T26979: Debug error when loading a measurement or pointset and then an image, added: MITK (2018-04-4); removed MITK.
Thu, Jan 9, 2:52 PM · MITK (2018-04-4)
kislinsk edited projects for T26980: MITK_CREATE_MACRO should prohibit dependencies against autoload modules, added: MITK (2018-04-4); removed MITK.
Thu, Jan 9, 2:52 PM · MITK (2018-04-4)
kislinsk edited projects for T26981: [Segmentation] Multiple Segmentations under one parent node aren't displayed, added: MITK (2018-04-4); removed MITK.
Thu, Jan 9, 2:52 PM · MITK (2018-04-4)
kislinsk edited projects for T26903: DICOM Seg writing is broken due to changes in DICOMSEGIOMimeType, added: MITK (2018-04-4); removed MITK.
Thu, Jan 9, 2:52 PM · MITK (2018-04-4), Request for Discussion
kislinsk committed rMITK7b5540fce06a: Remove moc header files without Qt classes (authored by kislinsk).
Remove moc header files without Qt classes
Thu, Jan 9, 10:36 AM
kislinsk committed rMITK4b302e31d894: Remove unused code (authored by kislinsk).
Remove unused code
Thu, Jan 9, 10:08 AM
kislinsk added a comment to T26977: Fix Nightly warnings.

Pushed new branch T26977-FixWarnings.

Thu, Jan 9, 10:07 AM · MITK
kislinsk triaged T26977: Fix Nightly warnings as Low priority.
Thu, Jan 9, 9:44 AM · MITK
kislinsk committed rMITK16c4a3d324d0: Remove invalid link-time dependency to auto-load service (authored by kislinsk).
Remove invalid link-time dependency to auto-load service
Thu, Jan 9, 8:56 AM
kislinsk added a comment to T26976: PythonQt is not installed on macOS when creating an MITK installer.

Also, BasicImageProcessing has an invalid link-time dependency to the auto-load service MatchPointRegistrationIO. We should consider extending our mitk_create_module macro to check if there's a link-time dependency to a service.

Thu, Jan 9, 8:48 AM · MITK
kislinsk committed rMITK6e1b92791898: Manually install PythonQt (authored by kislinsk).
Manually install PythonQt
Thu, Jan 9, 8:35 AM
kislinsk added a comment to T26976: PythonQt is not installed on macOS when creating an MITK installer.

Pushed new branch T26976-InstallPythonQtOnMacOs.

Thu, Jan 9, 8:34 AM · MITK
kislinsk triaged T26976: PythonQt is not installed on macOS when creating an MITK installer as Normal priority.
Thu, Jan 9, 8:32 AM · MITK

Wed, Jan 8

kislinsk closed T26971: MitkREST module tests affect each other when run in parallel as Resolved.
Wed, Jan 8, 3:02 PM · MITK
kislinsk closed T26971: MitkREST module tests affect each other when run in parallel, a subtask of T26888: MITK_BUILD_CONFIGURATION "All" reveals some failing tests on CI build clients, as Resolved.
Wed, Jan 8, 3:02 PM · MITK
kislinsk committed rMITK8abd6f7dca36: Merge branch 'T26971-RunRESTTestsSerial' (authored by kislinsk).
Merge branch 'T26971-RunRESTTestsSerial'
Wed, Jan 8, 3:02 PM
kislinsk committed rMITK86879bb05edd: Run tests serial (authored by kislinsk).
Run tests serial
Wed, Jan 8, 3:01 PM
kislinsk added a comment to T26971: MitkREST module tests affect each other when run in parallel.

Pushed new branch T26971-RunRESTTestsSerial.

Wed, Jan 8, 3:01 PM · MITK
kislinsk triaged T26971: MitkREST module tests affect each other when run in parallel as Normal priority.
Wed, Jan 8, 3:00 PM · MITK
kislinsk renamed T26966: [Segmentation] Help button in threshold dialogs have no function from Help button in dialogs have no function to [Segmentation] Help button in threshold dialogs have no function.
Wed, Jan 8, 2:19 PM · MITK (2018-04-4)
kislinsk renamed T26967: [Segmentation] Pressing the X button on threshold confirm dialogs does not stop the execution from Pressing the X button on Confirm dialogs does not stop the execution to [Segmentation] Pressing the X button on threshold confirm dialogs does not stop the execution.
Wed, Jan 8, 2:18 PM · MITK (2018-04-4)
kislinsk closed T26965: MitkREST module tests fail on Windows when executed via ctest but work when executed directly, a subtask of T26888: MITK_BUILD_CONFIGURATION "All" reveals some failing tests on CI build clients, as Resolved.
Wed, Jan 8, 2:17 PM · MITK
kislinsk closed T26965: MitkREST module tests fail on Windows when executed via ctest but work when executed directly as Resolved.
Wed, Jan 8, 2:17 PM · MITK
kislinsk committed rMITK49cd8819e818: Merge branch 'T26965-FixTestPathEnv' (authored by kislinsk).
Merge branch 'T26965-FixTestPathEnv'
Wed, Jan 8, 2:14 PM
kislinsk committed rMITK9fe461be1f57: Append to PATH instead of overriding PATH (authored by kislinsk).
Append to PATH instead of overriding PATH
Wed, Jan 8, 2:12 PM
kislinsk added a comment to T26965: MitkREST module tests fail on Windows when executed via ctest but work when executed directly.

Pushed new branch T26965-FixTestPathEnv.

Wed, Jan 8, 2:12 PM · MITK
kislinsk triaged T26965: MitkREST module tests fail on Windows when executed via ctest but work when executed directly as Normal priority.
Wed, Jan 8, 2:10 PM · MITK

Tue, Jan 7

kislinsk closed T26955: MitkQtPythonTest fails because of missing library dependencies on Linux as Resolved.
Tue, Jan 7, 4:33 PM · MITK
kislinsk closed T26955: MitkQtPythonTest fails because of missing library dependencies on Linux, a subtask of T26888: MITK_BUILD_CONFIGURATION "All" reveals some failing tests on CI build clients, as Resolved.
Tue, Jan 7, 4:33 PM · MITK
kislinsk committed rMITK113ddd8808d2: Merge branch 'T26955-FixPythonTestEnv' (authored by kislinsk).
Merge branch 'T26955-FixPythonTestEnv'
Tue, Jan 7, 4:33 PM
kislinsk committed rMITK8b6094784d76: Reactivate test on Windows (authored by kislinsk).
Reactivate test on Windows
Tue, Jan 7, 4:32 PM
kislinsk added a comment to T19153: Python tests can't be run on the dartclient on Windows.

We noticed in T26955 that the test is able to run on Windows.

Tue, Jan 7, 4:31 PM · Bugzilla, MITK
kislinsk committed rMITK1260dfb17afe: Add hint to Phabricator task. (authored by kislinsk).
Add hint to Phabricator task.
Tue, Jan 7, 4:22 PM
kislinsk committed rMITKb89b18f9faa8: Use LD_LIBRARY_PATH to execute mitkPythonTest (authored by kislinsk).
Use LD_LIBRARY_PATH to execute mitkPythonTest
Tue, Jan 7, 4:19 PM
kislinsk added a comment to T26955: MitkQtPythonTest fails because of missing library dependencies on Linux.

Pushed new branch T26955-FixPythonTestEnv.

Tue, Jan 7, 4:18 PM · MITK
kislinsk triaged T26955: MitkQtPythonTest fails because of missing library dependencies on Linux as Normal priority.
Tue, Jan 7, 12:52 PM · MITK

Mon, Dec 23

kislinsk triaged T26949: DICOM SEG - 3D segmentations with only one slice cannot be reloaded as DICOM SEG as Normal priority.
Mon, Dec 23, 2:55 PM · MITK
kislinsk triaged T26951: DICOM SEG - DicomSegIO should just use properties of the passed segmentation object as Normal priority.
Mon, Dec 23, 2:54 PM · MITK
kislinsk triaged T26953: DICOM SEG - Cannot rewrite segmentations as DICOM SEG as Normal priority.
Mon, Dec 23, 2:54 PM · MITK
kislinsk closed T26954: Use Visual Studio project folder feature for MITK and MITK extensions as Resolved.
Mon, Dec 23, 2:53 PM · Noteworthy, MITK (2018-04-4)
kislinsk added a comment to T26954: Use Visual Studio project folder feature for MITK and MITK extensions.

In Visual Studio, all MITK targets are now categorized in folders. MITK extension targets have their own root folder.

Mon, Dec 23, 2:53 PM · Noteworthy, MITK (2018-04-4)
kislinsk committed rMITKfcd6631834ea: Merge branch 'T26954-UseFolders' into releases/2018-04 (authored by kislinsk).
Merge branch 'T26954-UseFolders' into releases/2018-04
Mon, Dec 23, 2:52 PM
kislinsk committed rMITK0e0bcfc78ed1: Merge remote-tracking branch 'origin/T26954-UseFolders' (authored by kislinsk).
Merge remote-tracking branch 'origin/T26954-UseFolders'
Mon, Dec 23, 2:51 PM
kislinsk committed rMITK8e156483616c: Merge remote-tracking branch 'origin/T26954-UseFolders' (authored by kislinsk).
Merge remote-tracking branch 'origin/T26954-UseFolders'
Mon, Dec 23, 2:51 PM
kislinsk committed rMITK51ee1c19203d: Merge remote-tracking branch 'origin/T26954-UseFolders' (authored by kislinsk).
Merge remote-tracking branch 'origin/T26954-UseFolders'
Mon, Dec 23, 2:51 PM
kislinsk committed rMITKe3782b339f55: Merge remote-tracking branch 'origin/T26954-UseFolders' (authored by kislinsk).
Merge remote-tracking branch 'origin/T26954-UseFolders'
Mon, Dec 23, 2:51 PM
kislinsk committed rMITK02265dcc26d1: Move MatchPointAlgorithms into Modules (authored by kislinsk).
Move MatchPointAlgorithms into Modules
Mon, Dec 23, 2:51 PM
kislinsk committed rMITKbac1e5791cb9: Mix missing property name (authored by kislinsk).
Mix missing property name
Mon, Dec 23, 2:45 PM
kislinsk committed rMITKc57f76b198ca: Put command-line apps into Modules/Executables folder (authored by kislinsk).
Put command-line apps into Modules/Executables folder
Mon, Dec 23, 2:45 PM
kislinsk committed rMITKac1c3bd39b0f: Categorize remaining targets (authored by kislinsk).
Categorize remaining targets
Mon, Dec 23, 2:38 PM
kislinsk committed rMITKf04b1ca5b861: Use folders for target/project organization (authored by kislinsk).
Use folders for target/project organization
Mon, Dec 23, 2:10 PM
kislinsk added a comment to T26954: Use Visual Studio project folder feature for MITK and MITK extensions.

Pushed new branch T26954-UseFolders.

Mon, Dec 23, 2:10 PM · Noteworthy, MITK (2018-04-4)
kislinsk triaged T26954: Use Visual Studio project folder feature for MITK and MITK extensions as Wishlist priority.
Mon, Dec 23, 1:59 PM · Noteworthy, MITK (2018-04-4)

Fri, Dec 20

kislinsk added a comment to T26930: Crash Ubuntu 18.04.3 Qt 5.12.4.

TL;DR: MitkWorkbench --BlueBerry.clean works again.

Fri, Dec 20, 8:03 PM · MITK
kislinsk closed T26930: Crash Ubuntu 18.04.3 Qt 5.12.4 as Resolved.
Fri, Dec 20, 8:00 PM · MITK
kislinsk added a comment to T26930: Crash Ubuntu 18.04.3 Qt 5.12.4.

It's a GCC bug that bit us in the past already and that's why we were pre-loading org.mitk.gui.qt.common. Now it's org.blueberry.core.expressions.

Fri, Dec 20, 8:00 PM · MITK
kislinsk committed rMITKba83f51a8ff9: Merge branch 'T26930-FixPreloading' (authored by kislinsk).
Merge branch 'T26930-FixPreloading'
Fri, Dec 20, 7:46 PM
kislinsk committed rMITKf22aa6c62e6b: Fix pre-loading of org.blueberry.core.expressions (authored by kislinsk).
Fix pre-loading of org.blueberry.core.expressions
Fri, Dec 20, 7:39 PM