Page MenuHomePhabricator

kislinsk (Stefan Dinkelacker)
UserAdministrator

Projects (14)

User Details

User Since
Aug 1 2016, 11:50 AM (245 w, 4 d)
Roles
Administrator

Recent Activity

Wed, Apr 14

kislinsk reassigned T28446: Migrate MatchPoint to ITK v5.1 from kislinsk to floca.

https://phabricator.mitk.org/source/matchpoint/history/T28446-MigrateToITKv5.1/

Wed, Apr 14, 2:31 PM · MatchPoint, MITK (v2021.10)
kislinsk committed rMPe001b8fbc029: Do more mutex fixes (authored by kislinsk).
Do more mutex fixes
Wed, Apr 14, 2:30 PM
kislinsk committed rMP7da4216a857d: MappingTaskBatch needs a more thorough migration (authored by kislinsk).
MappingTaskBatch needs a more thorough migration
Wed, Apr 14, 2:30 PM
kislinsk committed rMP110d8364c3b5: Fix more NULL smart pointer initializations (authored by kislinsk).
Fix more NULL smart pointer initializations
Wed, Apr 14, 2:30 PM
kislinsk committed rMP15b61e51f6ae: Do more enum replacements (authored by kislinsk).
Do more enum replacements
Wed, Apr 14, 2:30 PM
kislinsk committed rMP6ecafd4d4b7a: Adapt threading-related API to ITK v5 (authored by kislinsk).
Adapt threading-related API to ITK v5
Wed, Apr 14, 2:30 PM
kislinsk committed rMPad4619bd536d: [DOUBLE-CHECK THIS COMMIT] Migrate spatial objects (authored by kislinsk).
[DOUBLE-CHECK THIS COMMIT] Migrate spatial objects
Wed, Apr 14, 2:30 PM
kislinsk committed rMP255e513cf781: Replace unsigned long return type of GetMTime() with itk::ModifiedTimeType (authored by kislinsk).
Replace unsigned long return type of GetMTime() with itk::ModifiedTimeType
Wed, Apr 14, 2:30 PM
kislinsk committed rMP38d25ea84a08: Replace itksys::String with std::string (authored by kislinsk).
Replace itksys::String with std::string
Wed, Apr 14, 2:30 PM
kislinsk committed rMP0837e06d97ff: Replace vcl_ math functions with std:: math functions (authored by kislinsk).
Replace vcl_ math functions with std:: math functions
Wed, Apr 14, 2:30 PM
kislinsk committed rMP1a3628a9c04b: Replace ITK smart pointer NULL initialization with (implicit) nullptr… (authored by kislinsk).
Replace ITK smart pointer NULL initialization with (implicit) nullptr…
Wed, Apr 14, 2:30 PM
kislinsk committed rMPc733cb3de98f: Replace itk::ImageIOBase enums with itk::IO...Enum enums (authored by kislinsk).
Replace itk::ImageIOBase enums with itk::IO...Enum enums
Wed, Apr 14, 2:30 PM
kislinsk committed rMPeb6be9df7d3f: Replace itk::LoggerBase::PriorityLevelType with itk::LoggerBaseEnums… (authored by kislinsk).
Replace itk::LoggerBase::PriorityLevelType with itk::LoggerBaseEnums…
Wed, Apr 14, 2:30 PM
kislinsk committed rMP9168cd710920: Replace ITK mutexes with std mutexes (authored by kislinsk).
Replace ITK mutexes with std mutexes
Wed, Apr 14, 2:30 PM
kislinsk added a member for MatchPoint: kislinsk.
Wed, Apr 14, 2:30 PM
kislinsk triaged T28446: Migrate MatchPoint to ITK v5.1 as High priority.
Wed, Apr 14, 9:56 AM · MatchPoint, MITK (v2021.10)
kislinsk claimed T27437: Migrate MITK to use ITK 5.x .
Wed, Apr 14, 9:19 AM · MITK (v2021.10)

Mon, Apr 12

kislinsk raised the priority of T27437: Migrate MITK to use ITK 5.x from Normal to High.
Mon, Apr 12, 10:55 AM · MITK (v2021.10)
kislinsk edited projects for T27437: Migrate MITK to use ITK 5.x , added: MITK (v2021.10); removed MITK.
Mon, Apr 12, 10:54 AM · MITK (v2021.10)

Thu, Apr 8

kislinsk added a revision to T28439: [Segmentation] Support custom background/outside values in image masking: Unknown Object (Differential Revision).
Thu, Apr 8, 7:19 PM · MITK (v2021.10)
kislinsk triaged T28439: [Segmentation] Support custom background/outside values in image masking as Normal priority.
Thu, Apr 8, 7:10 PM · MITK (v2021.10)
kislinsk raised the priority of T28264: [Segmentation Utilities] Various issues from Normal to High.
Thu, Apr 8, 7:08 PM · MITK (v2021.10)
kislinsk triaged T28437: 3D region growing may have issues when the seed point is on a pixel with value 0 as High priority.
Thu, Apr 8, 9:44 AM · MITK (v2021.10)
kislinsk added a comment to T28422: Multilabel color map does not produce unique colors.

Will be fixed with D480.

Thu, Apr 8, 8:03 AM · MITK (v2021.10)
kislinsk added a revision to T28422: Multilabel color map does not produce unique colors: Unknown Object (Differential Revision).
Thu, Apr 8, 8:03 AM · MITK (v2021.10)
kislinsk added a comment to T28421: Use whole image grey value must always be executed when switching colormap to 'Multilabel'.

Hm, while D480 resolves the issue, I think that the original approach for handling the Multilabel colormap in T23589 is already a workaround. Changing the level window to the maximum possible range is just an emulation of "do not use the level window". We actually have that mode in MITK already. The Image Rendering.Mode property is usually set to LOOKUPTABLE_LEVELWINDOW_COLOR but there is also LOOKUPTABLE_COLOR which is exactly what we need here. The thing is, that LOOKUPTABLE_COLOR is not implemented correctly in the 2-d image mapper, as the level window filter is not reset and instead is using the previously set range. So I will extent D480 to actually use the correct mode and fix the 2-d image mapper.

Thu, Apr 8, 7:27 AM · MITK (v2021.10)
kislinsk added a comment to T28422: Multilabel color map does not produce unique colors.

If the image is converted to a segmentation (context menu -> Convert to segmentation), it is rendered correctly even though the very same lookup table is used. So I guess the issue is to be found within the 2d image mapper.

Thu, Apr 8, 6:25 AM · MITK (v2021.10)
kislinsk added a comment to T28422: Multilabel color map does not produce unique colors.

The lookup table is set correctly but the rendered colors do not match.

Thu, Apr 8, 6:16 AM · MITK (v2021.10)
kislinsk claimed T28422: Multilabel color map does not produce unique colors.

This really shouldn't happen. A first look at the code revealed that the intention is to have at least 26 different colors that are repeatedly cycled through one after another for all 2^16 values.

Thu, Apr 8, 5:32 AM · MITK (v2021.10)
kislinsk added a revision to T28421: Use whole image grey value must always be executed when switching colormap to 'Multilabel': Unknown Object (Differential Revision).
Thu, Apr 8, 5:27 AM · MITK (v2021.10)
kislinsk added a comment to T28421: Use whole image grey value must always be executed when switching colormap to 'Multilabel'.

Found the issue. After setting the level window to "Multilabel" in QmitkDataNodeColorMapAction::OnActionTriggered, the previous level window is checked if it is a "Multilabel" level window, instead of the new level window. Hence the observation above that it works when applying it twice.

Thu, Apr 8, 5:20 AM · MITK (v2021.10)
kislinsk claimed T28421: Use whole image grey value must always be executed when switching colormap to 'Multilabel'.

This issue was already resolved by @kalali in T23589: Multilabel Segmentations not loaded with multilabel colormap, resp. {D172} for MITK v2018.04.2 but I can confirm that the issue exists for the example image.

Thu, Apr 8, 5:12 AM · MITK (v2021.10)

Wed, Apr 7

kislinsk edited projects for T28039: DICOM Seg loading error, added: MITK (v2021.10); removed Next Milestone, MITK, Missing Info, Request for Discussion.
Wed, Apr 7, 9:14 AM · MITK (v2021.10)
kislinsk edited projects for T24398: Dicom plugin: Retrieve does not work, added: MITK (v2021.10); removed Next Milestone, MITK.
Wed, Apr 7, 9:12 AM · MITK (v2021.10)

Tue, Apr 6

kislinsk edited projects for T27432: Error loading DCE-MRI DICOM image, added: MITK (v2021.10); removed MITK, Next Milestone.
Tue, Apr 6, 4:29 PM · MITK (v2021.10), DICOM, Cleared
kislinsk closed T28263: [2-d surface mapper] Surface is drawn in every time step even if it has limited time bounds as Resolved.
Tue, Apr 6, 4:28 PM · MITK (v2021.02)
kislinsk added a comment to T27413: MITK 2020 Workflow Q&A.

We now have some manuals but we still need an example-based guide for reviews/Arcanist.

Tue, Apr 6, 4:24 PM · MITK (v2021.10)
kislinsk updated the task description for T27413: MITK 2020 Workflow Q&A.
Tue, Apr 6, 4:23 PM · MITK (v2021.10)
kislinsk edited projects for T27701: Overhaul or remove PluginGenerator, added: MITK (v2021.10); removed MITK, Next Milestone.
Tue, Apr 6, 4:21 PM · MITK (v2021.10)
kislinsk lowered the priority of T27578: 2021.1 Linux installer does not work on Fedora from Unbreak Now! to High.
Tue, Apr 6, 4:21 PM · MITK (v2021.10)
kislinsk edited projects for T28172: Include MITK-ProjectTemplate in MITK Differential builds, added: MITK (v2021.10); removed Next Milestone, MITK.
Tue, Apr 6, 4:12 PM · MITK (v2021.10), CI
kislinsk edited projects for T28422: Multilabel color map does not produce unique colors, added: MITK (v2021.10); removed MITK.
Tue, Apr 6, 4:12 PM · MITK (v2021.10)
kislinsk edited projects for T28421: Use whole image grey value must always be executed when switching colormap to 'Multilabel', added: MITK (v2021.10); removed MITK.
Tue, Apr 6, 4:11 PM · MITK (v2021.10)
kislinsk added a hashtag to MITK (v2021.10): #mitk-2021-10.
Tue, Apr 6, 4:11 PM
kislinsk triaged T28421: Use whole image grey value must always be executed when switching colormap to 'Multilabel' as High priority.
Tue, Apr 6, 12:48 AM · MITK (v2021.10)
kislinsk triaged T28422: Multilabel color map does not produce unique colors as High priority.
Tue, Apr 6, 12:46 AM · MITK (v2021.10)
kislinsk created MITK (v2021.10).
Tue, Apr 6, 12:41 AM
kislinsk triaged T28428: Re-enable code coverage testing in MITK CI as Normal priority.
Tue, Apr 6, 12:40 AM · CI, MITK

Sat, Mar 27

kislinsk closed T26969: [Segmentation] New segmentation dialog: Change color twice and aborting the second time chages color to red, a subtask of T28176: [Segmentation] Inspection of module and plugin, as Resolved.
Sat, Mar 27, 4:48 PM · MITK (v2021.10)
kislinsk closed T26969: [Segmentation] New segmentation dialog: Change color twice and aborting the second time chages color to red as Resolved.
Sat, Mar 27, 4:48 PM · MITK
kislinsk closed T28383: [Multilabel Segmentation] In case of two layers, a change of visibility is not updated automatically as Resolved.
Sat, Mar 27, 4:47 PM · Next Milestone, MITK

Fri, Mar 26

kislinsk closed T28420: 2021 Week 12 (Late March) as Resolved.
Fri, Mar 26, 4:44 PM · MITK
kislinsk edited the content of Changelog.
Fri, Mar 26, 4:43 PM · MITK
kislinsk added a comment to T28420: 2021 Week 12 (Late March).

Deleted branch from rMITK MITK: release/T28420-2021-Week-12.

Fri, Mar 26, 4:40 PM · MITK
kislinsk committed rMITK9ccbc4d1310b: Merge branch 'master' into develop (authored by kislinsk).
Merge branch 'master' into develop
Fri, Mar 26, 4:40 PM
kislinsk committed rMITK4bf9b4da41b5: Make build system aware of a new patch for ITK (authored by kislinsk).
Make build system aware of a new patch for ITK
Fri, Mar 26, 4:39 PM
kislinsk committed rMITK3447b0ecffd5: Multilabel segmentation label visibility (authored by thomass).
Multilabel segmentation label visibility
Fri, Mar 26, 4:39 PM
kislinsk committed rMITK0a6dee813c1e: Merge remote-tracking branch 'origin/develop' into release/T28420-2021-Week-12 (authored by kislinsk).
Merge remote-tracking branch 'origin/develop' into release/T28420-2021-Week-12
Fri, Mar 26, 4:39 PM
kislinsk committed rMITKd77d800c1ace: Merge branch 'arcpatch-D477' into release/T28420-2021-Week-12 (authored by kislinsk).
Merge branch 'arcpatch-D477' into release/T28420-2021-Week-12
Fri, Mar 26, 4:39 PM
kislinsk committed rMITKaadc05393e01: 2021 Week 12 (Late March) (authored by kislinsk).
2021 Week 12 (Late March)
Fri, Mar 26, 4:39 PM
kislinsk edited the content of 2021 Week 12 (Late March).
Fri, Mar 26, 4:34 PM
kislinsk edited the content of MITK v2021.02.
Fri, Mar 26, 3:54 PM
kislinsk added a comment to T28420: 2021 Week 12 (Late March).

Pushed new branch to rMITK MITK: release/T28420-2021-Week-12.

Fri, Mar 26, 3:09 PM · MITK
kislinsk triaged T28420: 2021 Week 12 (Late March) as Normal priority.
Fri, Mar 26, 3:08 PM · MITK
kislinsk created an object: 2021 Week 12 (Late March).
Fri, Mar 26, 3:07 PM
kislinsk added a comment to T28413: MITK (resp. OpenJPEG in ITK) doesn't build with Visual Studio 16.9 2019 (Release configuration).

Deleted branch from rMITK MITK: bugfix/T28413-PatchOpenJPEGInITKForMSVC16.9.

Fri, Mar 26, 12:41 PM · MITK
kislinsk committed rMITK9e9737797b79: Patch ITK/OpenJPEG to work with MSVC 16.9 (authored by kislinsk).
Patch ITK/OpenJPEG to work with MSVC 16.9
Fri, Mar 26, 12:40 PM
kislinsk closed T28413: MITK (resp. OpenJPEG in ITK) doesn't build with Visual Studio 16.9 2019 (Release configuration) as Resolved by committing rMITK2f8b1fac95e7: Patch ITK/OpenJPEG to work with MSVC 16.9.
Fri, Mar 26, 12:40 PM · MITK
kislinsk committed rMITK2f8b1fac95e7: Patch ITK/OpenJPEG to work with MSVC 16.9 (authored by kislinsk).
Patch ITK/OpenJPEG to work with MSVC 16.9
Fri, Mar 26, 12:40 PM
kislinsk added a revision to T28413: MITK (resp. OpenJPEG in ITK) doesn't build with Visual Studio 16.9 2019 (Release configuration): Unknown Object (Differential Revision).
Fri, Mar 26, 5:08 AM · MITK
kislinsk added a comment to T28413: MITK (resp. OpenJPEG in ITK) doesn't build with Visual Studio 16.9 2019 (Release configuration).

Pushed new branch to rMITK MITK: bugfix/T28413-PatchOpenJPEGInITKForMSVC16.9.

Fri, Mar 26, 5:02 AM · MITK
kislinsk triaged T28413: MITK (resp. OpenJPEG in ITK) doesn't build with Visual Studio 16.9 2019 (Release configuration) as High priority.
Fri, Mar 26, 4:59 AM · MITK

Tue, Mar 23

kislinsk added a member for MITK-MBI: kahl.
Tue, Mar 23, 10:30 AM

Mar 17 2021

kislinsk triaged T28380: [MultLabel Segmentation, MITK FlowBench] Segmentation not recognized as segmentation in Release v2021.02 as Normal priority.
Mar 17 2021, 9:16 AM · MITK
kislinsk updated subscribers of T28380: [MultLabel Segmentation, MITK FlowBench] Segmentation not recognized as segmentation in Release v2021.02.

Yes, as soon as there is a new tag that includes your necessary changes, just change the tag and click on build.

Mar 17 2021, 9:08 AM · MITK

Mar 12 2021

kislinsk added a comment to T28172: Include MITK-ProjectTemplate in MITK Differential builds.

Started with Ubuntu 18.04 and 20.04 clients by adding the following script before the actual build. This is roughly what we are doing already in the Dashboard script.

Mar 12 2021, 10:10 AM · MITK (v2021.10), CI

Mar 11 2021

kislinsk triaged T28358: Data Manager context menu items added multiple times for multi-selections as Normal priority.
Mar 11 2021, 7:50 AM · MITK (v2021.10)
kislinsk added a project to T28356: MITK v2021.02 does not recognize loaded mask as segmentation: Next Milestone.
Mar 11 2021, 7:48 AM · Next Milestone, MITK
kislinsk updated subscribers of T28356: MITK v2021.02 does not recognize loaded mask as segmentation.

I had a first quick check and for example T1.nrrd and S.nrrd (and S.nrrd converted to LabelSetImage) have the same geometries. My first assumption would have been that they are different. @floca Any idea?

Mar 11 2021, 7:46 AM · Next Milestone, MITK

Mar 10 2021

kislinsk placed T27033: Clean up stale remote branches up for grabs.
Mar 10 2021, 9:43 AM · MITK
kislinsk placed T27196: Rewrite packaging of MITK up for grabs.

Currently not actively working on this. Packaging seems to work for the moment except for Python (never did). I think this task will soon be revived with the work on Python in MITK by Kim-Celine and Ashis.

Mar 10 2021, 9:16 AM · MITK (v2021.10), Cleared
kislinsk archived MITK (v2021.02).
Mar 10 2021, 9:09 AM
kislinsk edited projects for T25305: Property enums of DICOM module are not supported by scene serialization, added: MITK, Next Milestone; removed MITK (v2021.02).
Mar 10 2021, 9:09 AM · Next Milestone, MITK, Restricted Project
kislinsk edited projects for T26294: Should we move DICOMPropertyPath helper to Core, added: MITK, Next Milestone; removed MITK (v2021.02).
Mar 10 2021, 9:09 AM · Next Milestone, MITK, DICOM
kislinsk edited projects for T26970: [Segmentation] Picking tool: When no region is picked, selected node just gets unselected, added: MITK, Next Milestone; removed MITK (v2021.02).
Mar 10 2021, 9:09 AM · MITK (v2021.10), Cleared
kislinsk edited projects for T27099: [MITKDoc] Revise Clipping Plane Plugin Documentation, added: MITK, Next Milestone; removed MITK (v2021.02).
Mar 10 2021, 9:09 AM · Next Milestone, MITK, Cleared
kislinsk edited projects for T27149: [Segmentation] Interpolation nodes / position nodes are not correctly hidden, added: MITK, Next Milestone; removed MITK (v2021.02).
Mar 10 2021, 9:09 AM · MITK (v2021.10)
kislinsk edited projects for T27834: [MITKDoc] Revise CEST views documentation, added: MITK, Next Milestone; removed MITK (v2021.02).
Mar 10 2021, 9:09 AM · Next Milestone, MITK
kislinsk edited projects for T27608: [MITKDoc] Documentation Refurbish - Developer Manual, added: MITK, Next Milestone; removed MITK (v2021.02).
Mar 10 2021, 9:09 AM · Next Milestone, MITK, Cleared
kislinsk edited projects for T27711: Rename segmentation image selection label, added: MITK, Next Milestone; removed MITK (v2021.02).
Mar 10 2021, 9:09 AM · MITK (v2021.10)
kislinsk edited projects for T27846: [MITKDoc] Segmentation Flow view documentation, added: MITK, Next Milestone; removed MITK (v2021.02).
Mar 10 2021, 9:09 AM · Next Milestone, MITK
kislinsk edited projects for T28278: Image cropper doesn't work with PACS like mouse interaction, added: MITK, Next Milestone; removed MITK (v2021.02).
Mar 10 2021, 9:09 AM · Next Milestone, MITK
kislinsk edited projects for T18014: write tool interaction tests for segmentation, added: MITK, Next Milestone; removed MITK (v2021.02).
Mar 10 2021, 9:09 AM · MITK (v2021.10), Bugzilla
kislinsk edited projects for T25445: MultiLabel segmentation mapper is very slow, added: MITK, Next Milestone; removed MITK (v2021.02).
Mar 10 2021, 9:09 AM · MITK (v2021.10)
kislinsk edited projects for T25098: Mapper (partially?) do not handle images correctly if they are out of time bound, added: MITK, Next Milestone; removed MITK (v2021.02).
Mar 10 2021, 9:09 AM · MITK (v2021.10)
kislinsk edited projects for T26972: Dialog and plugin layout seems to be not shown correctly on laptops, added: MITK, Next Milestone; removed MITK (v2021.02).
Mar 10 2021, 9:09 AM · MITK (v2021.10), Missing Info
kislinsk edited projects for T27184: Clipping plane deformation tool doesn't show updates in 3d window, added: MITK, Next Milestone; removed MITK (v2021.02).
Mar 10 2021, 9:09 AM · Next Milestone, MITK, Missing Info, Restricted Project
kislinsk edited projects for T27320: No LocalStorage for PlaneGeometryDataVtkMapper3D, added: MITK, Next Milestone; removed MITK (v2021.02).
Mar 10 2021, 9:09 AM · MITK (v2021.10), Pull Request
kislinsk edited projects for T27455: Go through pull requests, added: MITK, Next Milestone; removed MITK (v2021.02).
Mar 10 2021, 9:09 AM · MITK (v2021.10), Cleared
kislinsk edited projects for T27414: Adapt CMake version macro to generate version description with "no official release", added: MITK, Next Milestone; removed MITK (v2021.02).
Mar 10 2021, 9:09 AM · Restricted Project, MITK (v2021.10), CI