Page MenuHomePhabricator | MITK

kislinsk (Stefan Dinkelacker)Administrator
User

Projects (13)

User Details

User Since
Aug 1 2016, 11:50 AM (132 w, 5 d)
Roles
Administrator

Recent Activity

Wed, Feb 6

kislinsk committed rMITK3453840afeeb: Allow external tool names containing white space (authored by kislinsk).
Allow external tool names containing white space
Wed, Feb 6, 10:26 AM

Tue, Feb 5

kislinsk committed rMITK44d71a9a47f6: Unregister tool factories (authored by kislinsk).
Unregister tool factories
Tue, Feb 5, 12:58 PM
kislinsk closed T25985: Make segmentation contour thickness customizable as Invalid.

There's already a property for this: labelset.contour.width.

Tue, Feb 5, 9:39 AM · MITK

Thu, Jan 31

kislinsk committed rMITK0d53baa18cc0: Fix unused local typedef in GCC 5.4 (authored by kislinsk).
Fix unused local typedef in GCC 5.4
Thu, Jan 31, 12:40 PM
kislinsk committed rMITK988a28efd4e1: Merge branch 'T25944-UpgradePocoToVersion1.9' into releases/2018-04 (authored by kislinsk).
Merge branch 'T25944-UpgradePocoToVersion1.9' into releases/2018-04
Thu, Jan 31, 11:06 AM
kislinsk closed T25944: Upgrade Poco from version 1.6 to version 1.9 as Resolved.
Thu, Jan 31, 11:06 AM · MITK (2018-04-2)
kislinsk committed rMITK526c02391f40: Upgrade Poco to version 1.9 (authored by kislinsk).
Upgrade Poco to version 1.9
Thu, Jan 31, 11:05 AM
kislinsk added a comment to T25944: Upgrade Poco from version 1.6 to version 1.9.

Pushed new branch T25944-UpgradePocoToVersion1.9.

Thu, Jan 31, 11:05 AM · MITK (2018-04-2)
kislinsk triaged T25944: Upgrade Poco from version 1.6 to version 1.9 as Wishlist priority.
Thu, Jan 31, 11:01 AM · MITK (2018-04-2)

Mon, Jan 28

kislinsk updated the task description for T25930: [Segmentation] Fill/Erase crashes at non-zero timestep / Issue with ArbitraryTimeGeometry.
Mon, Jan 28, 10:24 AM · MITK (2018-04-2)
kislinsk placed T25930: [Segmentation] Fill/Erase crashes at non-zero timestep / Issue with ArbitraryTimeGeometry up for grabs.
Mon, Jan 28, 10:23 AM · MITK (2018-04-2)
kislinsk renamed T25930: [Segmentation] Fill/Erase crashes at non-zero timestep / Issue with ArbitraryTimeGeometry from [Segmentation] Fill/Erase crashes at non-zero timestep / Issue with ArbitraryTimeGeopmetry to [Segmentation] Fill/Erase crashes at non-zero timestep / Issue with ArbitraryTimeGeometry.
Mon, Jan 28, 10:23 AM · MITK (2018-04-2)
kislinsk renamed T25930: [Segmentation] Fill/Erase crashes at non-zero timestep / Issue with ArbitraryTimeGeometry from [Segmentation] Fill/Erase crashes at non-zero timestep to [Segmentation] Fill/Erase crashes at non-zero timestep / Issue with ArbitraryTimeGeopmetry.
Mon, Jan 28, 10:23 AM · MITK (2018-04-2)
kislinsk added a comment to T25930: [Segmentation] Fill/Erase crashes at non-zero timestep / Issue with ArbitraryTimeGeometry.

These are the details of the time geometry of 3D+t-Heart. The 103 seems to come from the time bounds at the bottom:

Mon, Jan 28, 10:21 AM · MITK (2018-04-2)
kislinsk added a comment to T25930: [Segmentation] Fill/Erase crashes at non-zero timestep / Issue with ArbitraryTimeGeometry.

The actual error is happening sooner. I added a check to BaseRenderer::GetTimeStep(mitk::BaseData) to trigger when the timestep is > 100, which triggers even before I start to fill. Eventually TimeGeometry::TimePointToTimeStep() is called on the data and the time point is already 103. The time point is calculated in BaseRenderer::GetTime() by calling TimeStepToTimePoint() on the world geometry of the renderer.

Mon, Jan 28, 9:57 AM · MITK (2018-04-2)
kislinsk added a comment to T25930: [Segmentation] Fill/Erase crashes at non-zero timestep / Issue with ArbitraryTimeGeometry.

Sometimes I have to change the timesteps multiple times to run into this error. The message differs a little bit, though:

Mon, Jan 28, 9:36 AM · MITK (2018-04-2)
kislinsk triaged T25930: [Segmentation] Fill/Erase crashes at non-zero timestep / Issue with ArbitraryTimeGeometry as High priority.
Mon, Jan 28, 9:25 AM · MITK (2018-04-2)

Fri, Jan 25

kislinsk added a member for Hyppopy: s635r.
Fri, Jan 25, 9:33 AM
kislinsk created Hyppopy.
Fri, Jan 25, 9:33 AM

Wed, Jan 23

kislinsk committed rMITK6c207cfa1e61: Change drop site to e071-jenkins/cdash (authored by kislinsk).
Change drop site to e071-jenkins/cdash
Wed, Jan 23, 9:46 AM

Jan 9 2019

kislinsk triaged T25823: [Segmentation]Warnings not displayed in red as Low priority.

@floca I think I remember you worked on theme-specific warning colors at the last hacking week. Can you give us a hint how to use it, please? :-)

Jan 9 2019, 12:21 PM · MITK
kislinsk triaged T25825: [Segmentation]Crash using Watershed on different time steps as Normal priority.
Jan 9 2019, 12:17 PM · MITK
kislinsk triaged T25805: Standardize/Rework DICOM module naming as Wishlist priority.
Jan 9 2019, 12:15 PM · Request for Discussion, MITK

Jan 8 2019

kislinsk added a member for MITK: kraeuter.
Jan 8 2019, 1:09 PM
kislinsk reassigned T25619: Remaining Todos for MITK v2018.04 from kislinsk to nolden.
Jan 8 2019, 11:25 AM · MITK (2018-04)
kislinsk closed T25799: Make segmentation to surface conversion truely multi label aware, a subtask of T25747: Things I came across when correcting fully automatic segmentations, as Resolved.
Jan 8 2019, 11:24 AM · MITK
kislinsk closed T25799: Make segmentation to surface conversion truely multi label aware as Resolved.
Jan 8 2019, 11:24 AM · MITK (2018-04-2)
kislinsk committed rMITK1c79aeaf7f7d: Merge branch 'T25799-MakeSegmentationToSurfaceConversionTruelyMultilabelAware'… (authored by kislinsk).
Merge branch 'T25799-MakeSegmentationToSurfaceConversionTruelyMultilabelAware'…
Jan 8 2019, 10:28 AM
kislinsk committed rMITK20c486df4a04: Remove QmitkCreatePolygonModelAction clone (authored by kislinsk).
Remove QmitkCreatePolygonModelAction clone
Jan 8 2019, 8:49 AM
kislinsk added a comment to T25799: Make segmentation to surface conversion truely multi label aware.

Wohoo, nice surprise, 3D+t is already working, I totally forgot that I fixed it before Christmas when I focussed on the race condition thingy. I'll create a new installer and if it works for you, @full, I'll merge it into the release branch.

Jan 8 2019, 8:46 AM · MITK (2018-04-2)

Jan 7 2019

kislinsk added a comment to T25799: Make segmentation to surface conversion truely multi label aware.

I am able now to create surfaces either smoothed or not (only 3D now, though) but the former case seemed to work only on a single PC. I found the reason. QmitkCreatePolygonModelAction once was copied from the segmentation plugin to the multilabel plugin and for a certain time, the actions appeared twice in the context menu as both plugin.xml files added the context menu entries. This was then fixed so that only the segmentation plugin adds the actions as it should also work without the multilabel plugin. However, I just noted that there's a race condition as still both plugin activators register their classes with the same class name. So the eventual implementation that is chosen is totally up to a race condition.

Jan 7 2019, 2:30 PM · MITK (2018-04-2)

Dec 21 2018

kislinsk committed rMITK53e9fddd9ee1: Make label set image to surface conversion less chatty (authored by kislinsk).
Make label set image to surface conversion less chatty
Dec 21 2018, 9:10 PM
kislinsk committed rMITKb78cd0591bd4: Switch active layer to create label mask (authored by kislinsk).
Switch active layer to create label mask
Dec 21 2018, 9:00 PM
kislinsk added a comment to T25798: Saving segmentations as .dcm (DICOM SEG) does not work.

Ah, nice, I see. Testing 3d images was obviously too obvious for me. :D If the 4d case isn't fixed until the bugfix release, we could also check for the dimensionality to decide if the writer supports the image, right?

Dec 21 2018, 5:52 PM · MITK (2018-04-2)
kislinsk committed rMITKd360027db172: WIP (authored by kislinsk).
WIP
Dec 21 2018, 5:47 PM
kislinsk committed rMITK5cdc2c73f822: Unify parameter type (authored by kislinsk).
Unify parameter type
Dec 21 2018, 4:23 PM
kislinsk added a comment to T25798: Saving segmentations as .dcm (DICOM SEG) does not work.

Almost forgot: Deadline for the first bugfix release is probably middle of January.

Dec 21 2018, 4:18 PM · MITK (2018-04-2)
kislinsk placed T25798: Saving segmentations as .dcm (DICOM SEG) does not work up for grabs.
Dec 21 2018, 4:18 PM · MITK (2018-04-2)
kislinsk added a comment to T25798: Saving segmentations as .dcm (DICOM SEG) does not work.

Yeah, one could lower the confidence level, but it still would expose a broken writer to the user, so I see no reason to enable it until it is fixed. or do I miss something? How could someone suddenly write DICOM SEGs?

Dec 21 2018, 4:17 PM · MITK (2018-04-2)
kislinsk committed rMITK4a1e84a47162: Fix number of expected progress steps (authored by kislinsk).
Fix number of expected progress steps
Dec 21 2018, 4:11 PM
kislinsk added a comment to T25798: Saving segmentations as .dcm (DICOM SEG) does not work.

The problem is that the writer currently isn't able to write anything (at least I was not able to find something that might work). AFAIR, Marco updated DCMQI a few months ago to at least prevent the writer from crashing, which doesn't happen anymore, but the update didn't intent to completely fix the writer.

Dec 21 2018, 1:54 PM · MITK (2018-04-2)
kislinsk committed rMITK4d0545cd94ae: Fix/enhance surface creation of label set images (authored by kislinsk).
Fix/enhance surface creation of label set images
Dec 21 2018, 12:31 PM
kislinsk committed rMITK3fe61746cdb7: Unify parameter types (authored by kislinsk).
Unify parameter types
Dec 21 2018, 12:31 PM
kislinsk committed rMITK6196bf259009: Allow label mask creation from arbitrary layer (authored by kislinsk).
Allow label mask creation from arbitrary layer
Dec 21 2018, 12:30 PM
kislinsk committed rMITK26717b9df83b: WIP (authored by kislinsk).
WIP
Dec 21 2018, 7:30 AM
kislinsk added a comment to T25799: Make segmentation to surface conversion truely multi label aware.

Pushed new branch T25799-MakeSegmentationToSurfaceConversionTruelyMultilabelAware.

Dec 21 2018, 7:30 AM · MITK (2018-04-2)
kislinsk triaged T25799: Make segmentation to surface conversion truely multi label aware as Wishlist priority.
Dec 21 2018, 7:10 AM · MITK (2018-04-2)

Dec 20 2018

kislinsk closed T25798: Saving segmentations as .dcm (DICOM SEG) does not work as Resolved.
NOTE: I had some trouble when I simply changed the confidence level. Somehow the writer was registered twice and one time it still returned Supported. The debugger said that it couldn't find a matching .cpp file as the obvious choice would differ from the resulting binary. I manually had to delete the IO service DLLs for Multilabel, DicomSegmentation, and DICOMQI. I guess it has something to do with differences between the master branch and the release branch and switching between the branches may result in inconsistencies of the copied service DLLs.
Dec 20 2018, 5:52 PM · MITK (2018-04-2)
kislinsk committed rMITKcd4608f42a83: Merge branch 'T25798-DeactivateDICOMSEGWriter' into releases/2018-04 (authored by kislinsk).
Merge branch 'T25798-DeactivateDICOMSEGWriter' into releases/2018-04
Dec 20 2018, 5:47 PM
kislinsk committed rMITKa519284e5b2d: Deactivate DICOM SEG writer (authored by kislinsk).
Deactivate DICOM SEG writer
Dec 20 2018, 5:47 PM
kislinsk added a comment to T25798: Saving segmentations as .dcm (DICOM SEG) does not work.

Pushed new branch T25798-DeactivateDICOMSEGWriter.

Dec 20 2018, 5:46 PM · MITK (2018-04-2)
kislinsk triaged T25798: Saving segmentations as .dcm (DICOM SEG) does not work as High priority.
Dec 20 2018, 5:44 PM · MITK (2018-04-2)
kislinsk added a comment to T25791: Take Data Manager selection into account when deciding on initial directory in Open/Save File dialogs.

When saving nodes manually, the path property is now set to the saved file name. Consecutive saves then default to the same directory.

Dec 20 2018, 4:07 PM · MITK (2018-04-2)
kislinsk closed T25791: Take Data Manager selection into account when deciding on initial directory in Open/Save File dialogs as Resolved.
Dec 20 2018, 4:05 PM · MITK (2018-04-2)
kislinsk closed T25791: Take Data Manager selection into account when deciding on initial directory in Open/Save File dialogs, a subtask of T25747: Things I came across when correcting fully automatic segmentations, as Resolved.
Dec 20 2018, 4:05 PM · MITK
kislinsk committed rMITKf8ff40e1b841: Merge branch 'T25791-ImproveSelectionOfInitialDirectoryInOpenAndSaveFileDialogs… (authored by kislinsk).
Merge branch 'T25791-ImproveSelectionOfInitialDirectoryInOpenAndSaveFileDialogs…
Dec 20 2018, 4:04 PM
kislinsk committed rMITK1e90c38ef2b7: Set path property when saving data (authored by kislinsk).
Set path property when saving data
Dec 20 2018, 3:54 PM
kislinsk committed rMITKf6bf7fb0b0e7: Allow to set path property when saving data (authored by kislinsk).
Allow to set path property when saving data
Dec 20 2018, 3:54 PM
kislinsk reopened T25791: Take Data Manager selection into account when deciding on initial directory in Open/Save File dialogs as "Open".
Dec 20 2018, 3:51 PM · MITK (2018-04-2)
kislinsk reopened T25791: Take Data Manager selection into account when deciding on initial directory in Open/Save File dialogs, a subtask of T25747: Things I came across when correcting fully automatic segmentations, as Open.
Dec 20 2018, 3:51 PM · MITK
kislinsk updated the task description for T25747: Things I came across when correcting fully automatic segmentations.
Dec 20 2018, 2:40 PM · MITK
kislinsk closed T25791: Take Data Manager selection into account when deciding on initial directory in Open/Save File dialogs as Resolved.
Dec 20 2018, 12:58 PM · MITK (2018-04-2)
kislinsk closed T25791: Take Data Manager selection into account when deciding on initial directory in Open/Save File dialogs, a subtask of T25747: Things I came across when correcting fully automatic segmentations, as Resolved.
Dec 20 2018, 12:58 PM · MITK
kislinsk committed rMITK003eab4c42e5: Merge branch 'T25791-ImproveSelectionOfInitialDirectoryInOpenAndSaveFileDialogs… (authored by kislinsk).
Merge branch 'T25791-ImproveSelectionOfInitialDirectoryInOpenAndSaveFileDialogs…
Dec 20 2018, 12:57 PM
kislinsk committed rMITK97eb4504e657: Get initial directory from parent when saving a data node (authored by kislinsk).
Get initial directory from parent when saving a data node
Dec 20 2018, 12:56 PM
kislinsk reopened T25791: Take Data Manager selection into account when deciding on initial directory in Open/Save File dialogs as "Open".

Actually I think this could be further improved in case of saving a node without a path property that is derived from another node.

Dec 20 2018, 11:17 AM · MITK (2018-04-2)
kislinsk reopened T25791: Take Data Manager selection into account when deciding on initial directory in Open/Save File dialogs, a subtask of T25747: Things I came across when correcting fully automatic segmentations, as Open.
Dec 20 2018, 11:17 AM · MITK
kislinsk closed T25791: Take Data Manager selection into account when deciding on initial directory in Open/Save File dialogs as Resolved.
Dec 20 2018, 11:09 AM · MITK (2018-04-2)
kislinsk closed T25791: Take Data Manager selection into account when deciding on initial directory in Open/Save File dialogs, a subtask of T25747: Things I came across when correcting fully automatic segmentations, as Resolved.
Dec 20 2018, 11:09 AM · MITK
kislinsk committed rMITK4bfc8770406b: Merge branch 'T25791-ImproveSelectionOfInitialDirectoryInOpenAndSaveFileDialogs… (authored by kislinsk).
Merge branch 'T25791-ImproveSelectionOfInitialDirectoryInOpenAndSaveFileDialogs…
Dec 20 2018, 11:09 AM
kislinsk committed rMITK1b7a346c19f9: Improve selection of initial directory in file save dialog (authored by kislinsk).
Improve selection of initial directory in file save dialog
Dec 20 2018, 11:08 AM
kislinsk committed rMITK8fad41a854af: Improve selection of initial directory in file open dialog (authored by kislinsk).
Improve selection of initial directory in file open dialog
Dec 20 2018, 11:08 AM
kislinsk added a comment to T25791: Take Data Manager selection into account when deciding on initial directory in Open/Save File dialogs.

Pushed new branch T25791-ImproveSelectionOfInitialDirectoryInOpenAndSaveFileDialogs.

Dec 20 2018, 11:08 AM · MITK (2018-04-2)
kislinsk triaged T25791: Take Data Manager selection into account when deciding on initial directory in Open/Save File dialogs as Wishlist priority.
Dec 20 2018, 10:45 AM · MITK (2018-04-2)
kislinsk placed T25747: Things I came across when correcting fully automatic segmentations up for grabs.
Dec 20 2018, 10:39 AM · MITK

Dec 19 2018

kislinsk lowered the priority of T25760: MITK crashes when deleting files from Data Manager from High to Normal.
Dec 19 2018, 1:42 PM · MITK (2018-04-2)
kislinsk moved T25787: Merge T25784-ExtensibleToolSelectionBox into MITK-ProjectTemplate master branch from Backlog to Release Management on the MITK (2018-04-2) board.
Dec 19 2018, 1:41 PM · MITK (2018-04-2)
kislinsk triaged T25787: Merge T25784-ExtensibleToolSelectionBox into MITK-ProjectTemplate master branch as Wishlist priority.
Dec 19 2018, 1:40 PM · MITK (2018-04-2)
kislinsk closed T25784: Automatically add external tools to segmentation tool selection box as Resolved.

Tool GUIs work as well now. Merged into releases/2018-04. I documented the feature in the example tool of the project template and wrote the Nvidia guys.

Dec 19 2018, 1:38 PM · MITK (2018-04-2)
kislinsk committed rMPTc8760678c8ee: Add note about compatibility (authored by kislinsk).
Add note about compatibility
Dec 19 2018, 10:53 AM
kislinsk committed rMPTef590e600440: Add documentation for segmentation tools (authored by kislinsk).
Add documentation for segmentation tools
Dec 19 2018, 10:45 AM
kislinsk committed rMPTb0120a8fc375: Add tool GUI to ExampleSegTool2D (authored by kislinsk).
Add tool GUI to ExampleSegTool2D
Dec 19 2018, 9:54 AM
kislinsk committed rMITK35eb049a3e41: Unmark MITK_EXTENSION_DIRS as advanced variable (authored by kislinsk).
Unmark MITK_EXTENSION_DIRS as advanced variable
Dec 19 2018, 9:51 AM
kislinsk committed rMITKa41d3d66b21f: Merge branch 'T25784-ExtensibleToolSelectionBox' into releases/2018-04 (authored by kislinsk).
Merge branch 'T25784-ExtensibleToolSelectionBox' into releases/2018-04
Dec 19 2018, 9:51 AM
kislinsk committed rMITKd2dfb8f9e9fb: Fix tool cursor handling when switching to tool without cursor (authored by kislinsk).
Fix tool cursor handling when switching to tool without cursor
Dec 19 2018, 9:50 AM
kislinsk committed rMITKbd01ed5dc11f: Allow for tool GUIs without Qmitk class name prefix (authored by kislinsk).
Allow for tool GUIs without Qmitk class name prefix
Dec 19 2018, 9:50 AM

Dec 18 2018

kislinsk added a comment to T25784: Automatically add external tools to segmentation tool selection box.

I created a branch with the same name in rMPT MITK-ProjectTemplate. It provides an example segmentation tool with a styled icon and a custom state machine. It does not yet come with a tool GUI, which I will add tomorrow.

Dec 18 2018, 6:33 PM · MITK (2018-04-2)
kislinsk added a comment to T25784: Automatically add external tools to segmentation tool selection box.
  • Theme-adaptive SVG icons are now supported as tool icons
  • Tool state machines external to the MitkSegmentation module are now supported
Dec 18 2018, 6:30 PM · MITK (2018-04-2)
kislinsk committed rMPT4c45d608fe30: Add segmentation tool example (authored by kislinsk).
Add segmentation tool example
Dec 18 2018, 6:27 PM
kislinsk committed rMITKa70c15ef0f52: Allow usage of module-external interactions in tools (authored by kislinsk).
Allow usage of module-external interactions in tools
Dec 18 2018, 6:16 PM
kislinsk committed rMITKda9892a7d7f6: Support external segmentation tools in segmentation views (authored by kislinsk).
Support external segmentation tools in segmentation views
Dec 18 2018, 6:16 PM
kislinsk committed rMITK412ccb28cda8: Support tool buttons with styled SVG icons (authored by kislinsk).
Support tool buttons with styled SVG icons
Dec 18 2018, 6:16 PM
kislinsk added a comment to T25784: Automatically add external tools to segmentation tool selection box.

Pushed new branch T25784-ExtensibleToolSelectionBox.

Dec 18 2018, 6:16 PM · MITK (2018-04-2)
kislinsk added a comment to T25784: Automatically add external tools to segmentation tool selection box.

Here's the solution: We extend the segmentation views to also add all tools to the appropriate category by regex-matching their class name to either SegTool2D$ or SegTool3D$ (for example, their class name ends in either SegTool2D or SegTool3D like MyAwesomeSegTool2D).

Dec 18 2018, 4:36 PM · MITK (2018-04-2)
kislinsk triaged T25784: Automatically add external tools to segmentation tool selection box as Wishlist priority.
Dec 18 2018, 4:31 PM · MITK (2018-04-2)
kislinsk added a comment to T25760: MITK crashes when deleting files from Data Manager.

Can you please try to crash it again at your workstation, but this time close the segmentation view before you delete the nodes.

Dec 18 2018, 2:16 PM · MITK (2018-04-2)
kislinsk triaged T25774: Segmentation cannot be display when more than one segmetation-raw-image-pair is in Data Manager as Normal priority.

Guess what, cannot reproduce this... :/

Dec 18 2018, 2:12 PM · MITK (2018-04-2)
kislinsk placed T25760: MITK crashes when deleting files from Data Manager up for grabs.
Dec 18 2018, 2:08 PM · MITK (2018-04-2)
kislinsk added a comment to T25760: MITK crashes when deleting files from Data Manager.

Also cannot reproduce it with Ubuntu 16.04.

Dec 18 2018, 2:07 PM · MITK (2018-04-2)
kislinsk added a comment to T25760: MITK crashes when deleting files from Data Manager.

Peter showed me the bug at his workplace. I cannot reproduce it with Windows. Trying to crash it with Ubuntu as well...

Dec 18 2018, 1:54 PM · MITK (2018-04-2)