User Details
- User Since
- Aug 1 2016, 11:50 AM (233 w, 3 d)
- Roles
- Administrator
Today
Deleted branch from rMITK MITK: bugfix/T28189-FixDoxygenWarnings.
Pushed new branch to rMITK MITK: bugfix/T28189-FixDoxygenWarnings.
I used the snapshot client configurations as baseline and created Jenkins jobs in MITK/Release. I also extended the Git hook to trigger these jobs. Hard to test, though, as I do not want to temporarily push test tags. Fingers crossed.
Tue, Jan 19
Deleted branch from rMITK MITK: bugfix/T28173-CMakeWarnings.
Pushed new branch to rMITK MITK: bugfix/T28173-CMakeWarnings.
Mon, Jan 18
Deleted branch from rMPT MITK-ProjectTemplate: bugfix/T28171-MigrateToCurrentMITKDevelopBranch.
Pushed new branch to rMPT MITK-ProjectTemplate: bugfix/T28171-MigrateToCurrentMITKDevelopBranch.
Deleted branch from rMPT MITK-ProjectTemplate: bugfix/T28170-TestHooks.
Pushed new branch to rMPT MITK-ProjectTemplate: bugfix/T28170-TestHooks.
Deleted branch from rMPT MITK-ProjectTemplate: bugfix/T28170-TestHooks.
Pushed new branch to rMPT MITK-ProjectTemplate: bugfix/T28170-TestHooks.
Deleted branch from rMPT MITK-ProjectTemplate: bugfix/T28170-TestHooks.
It depends. NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION is only for checking in predicates; not for constant use throughout MITK while are there calculations after calculations after calculations and so the values may drift away from the actual truth, right? So for a temporary fix, I'm okay. But we should definitely check what is going on in DCMQI and fix on that side preferably.
Deleted branch bugfix/T28164-CopyrightDate.
Pushed new branch bugfix/T28164-CopyrightDate.
Thanks for looking into this issue as well. :-) I think 1e-5 is okay. We/you already introduced NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION not long ago since we had similar issues and 1e-5 should still be conservative enough the purpose of geometries.
Fri, Jan 15
I understand. :-) Just wanted to give you more options to think about as it is probably only a temporal solution. Sooner or later (currently read "later"), our minimum version requirements won't match again with the OS-provided Qt version. So we cannot run away from it forever I guess. :D
Thu, Jan 14
As it already works (?) and we will stay at least another year with Qt 5 we can do this. But in general, do you know of the new Qt Installer Framework with command-line interface? It's much easier now to install Qt with a single command and there a a few possibilities to provide credentials if that's an issue. See here for examples: https://phabricator.mitk.org/T27960#214043
Deleted branch feature/T28155-MakeQtLogMessagesOptional.
Pushed new branch feature/T28155-MakeQtLogMessagesOptional.
Wed, Jan 13
Since we need to patch VTK anyway, I took the opportunity to upgrade from VTK 9.0.0 to 9.0.1.
Deleted branch bugfix/T28151-FixVTKOnMacOSXCode12.
Pushed new branch bugfix/T28151-FixVTKOnMacOSXCode12.
Mon, Jan 11
Deleted branch bugfix/T27717-FixMacOSInstallerOpenApp.
Pushed new branch bugfix/T27717-FixMacOSInstallerOpenApp.
I set the GIT_TAG of DCMQI locally to v1.2.3 and I can confirm that the data from above can be loaded.
Was removed in rMITK66bb0d67 and forgotten to get restored in rMITK02a46548.
Deleted branch bugfix/T28137-FixMissingContextMenuEntries.
Pushed new branch bugfix/T28137-FixMissingContextMenuEntries.
Thanks @kalali, nice find and hint. A sneaky line is missing in DataManager's plugin.xml: <extension-point id="contextMenuActions" name="Context menu actions"/>.
Dec 21 2020
Deleted branch release/T28126-2020-Week-52.
Pushed new branch release/T28126-2020-Week-52.
Dec 18 2020
Deleted branch bugfix/T26237-ImprovePerformance.