Page MenuHomePhabricator

kislinsk (Stefan Dinkelacker)
UserAdministrator

Projects (15)

User Details

User Since
Aug 1 2016, 11:50 AM (191 w, 3 d)
Roles
Administrator

Recent Activity

Yesterday

kislinsk moved T27143: Matchpoint Registration Evaluator- Colorblend Bug from Backlog to Registration on the MITK (2020) board.
Thu, Apr 2, 2:58 PM · MITK (2020), Restricted Project
kislinsk moved T27200: [Registration] Crash in frame corrector from Backlog to Registration on the MITK (2020) board.
Thu, Apr 2, 2:58 PM · MITK (2020)
kislinsk moved T27201: [Registration] Executor layout in mask box is broken from Backlog to Registration on the MITK (2020) board.
Thu, Apr 2, 2:58 PM · MITK (2020)
kislinsk moved T27208: [Registration] Potential crash in manipulator from Backlog to Registration on the MITK (2020) board.
Thu, Apr 2, 2:58 PM · MITK (2020)
kislinsk moved T27209: [Registration] Mapper does not allow to select ML segmentation as input from Backlog to Registration on the MITK (2020) board.
Thu, Apr 2, 2:58 PM · MITK (2020)
kislinsk moved T25192: Enable DICOM SEG conversion for nrrd segmentations from Backlog to Segmentation on the MITK (2020) board.
Thu, Apr 2, 2:57 PM · MITK (2020), MICO (Demo MICCAI 2018)
kislinsk moved T25988: LabelSetImageIO should support time geometries and property serialization from Backlog to Segmentation on the MITK (2020) board.
Thu, Apr 2, 2:57 PM · MITK (2020)
kislinsk moved T26950: Add rule class for DICOM Seg relations to source image from Backlog to Segmentation on the MITK (2020) board.
Thu, Apr 2, 2:56 PM · MITK (2020)
kislinsk moved T26951: DICOM SEG - DicomSegIO should just use properties of the passed segmentation object from Backlog to Segmentation on the MITK (2020) board.
Thu, Apr 2, 2:56 PM · MITK (2020)
kislinsk moved T26952: Implement helper to correct (DICOM conformal) set the properties of a segmentation (DICOM SEG) from Backlog to Segmentation on the MITK (2020) board.
Thu, Apr 2, 2:56 PM · MITK (2020)
kislinsk moved T26953: DICOM SEG - Cannot rewrite segmentations as DICOM SEG from Backlog to Segmentation on the MITK (2020) board.
Thu, Apr 2, 2:56 PM · MITK (2020)
kislinsk moved T26959: Newly created LabelSet segmentation is not displayed as "outline binary" from Backlog to Segmentation on the MITK (2020) board.
Thu, Apr 2, 2:56 PM · MITK (2020)
kislinsk moved T27085: 2D region growing tool fails for low intensity regions from Backlog to Segmentation on the MITK (2020) board.
Thu, Apr 2, 2:56 PM · MITK (2020)
kislinsk moved T26098: Histogram Statistics need to be tested from Backlog to Statistics on the MITK (2020) board.
Thu, Apr 2, 2:53 PM · MITK (2020), Restricted Project
kislinsk moved T27229: [ImageStatistic] Copy to clipboard from statistic table should be directly usabel in Excel from Backlog to Statistics on the MITK (2020) board.
Thu, Apr 2, 2:52 PM · MITK (2020), Restricted Project
kislinsk moved T27285: QmitkChart widget should support ID or allow control over labels from Backlog to Statistics on the MITK (2020) board.
Thu, Apr 2, 2:52 PM · MITK (2020)
kislinsk moved T27271: [Image Statistics] Double clicking to isolate one graph only works on already enabled graphs from Backlog to Statistics on the MITK (2020) board.
Thu, Apr 2, 2:52 PM · MITK (2020)
kislinsk moved T27270: Planar figures are inconsistently bound by reference image from Backlog to Statistics on the MITK (2020) board.
Thu, Apr 2, 2:52 PM · Request for Discussion, MITK (2020)
kislinsk moved T27269: PlanarCircle shrinks in size when moved towards image boundaries from Backlog to Statistics on the MITK (2020) board.
Thu, Apr 2, 2:52 PM · MITK (2020)
kislinsk moved T27266: [Image Statistics] Planar figures cannot be read or written until one of the quantification views is open from Backlog to Statistics on the MITK (2020) board.
Thu, Apr 2, 2:52 PM · MITK (2020)
kislinsk moved T27258: [statistics] Deprecate QmitkImageStatisticsGeneratorJob from Backlog to Statistics on the MITK (2020) board.
Thu, Apr 2, 2:52 PM · MITK (2020)
kislinsk moved T27267: [Image Statistics] Removal of image and planar figure from data storage does not affect statistics widget from Backlog to Statistics on the MITK (2020) board.
Thu, Apr 2, 2:50 PM · MITK (2020)
kislinsk moved T27268: [Image Statistics] Moving/modifying a planar figure that is shown in statistics keeps adding graphs from Backlog to Statistics on the MITK (2020) board.
Thu, Apr 2, 2:50 PM · MITK (2020)
kislinsk moved T27284: ImageStatisticView Histogram is only supported with one image and <=1 ROI from Backlog to Statistics on the MITK (2020) board.
Thu, Apr 2, 2:50 PM · MITK (2020)

Wed, Apr 1

kislinsk created challengeR (v1.0).
Wed, Apr 1, 9:38 AM

Tue, Mar 31

kislinsk updated the task description for T27271: [Image Statistics] Double clicking to isolate one graph only works on already enabled graphs.
Tue, Mar 31, 8:10 AM · MITK (2020)

Mon, Mar 30

kislinsk committed rMITK9c01922520fd: Remove out of ref image bounds check for planar figures (authored by kislinsk).
Remove out of ref image bounds check for planar figures
Mon, Mar 30, 2:07 PM
kislinsk removed a project from T27272: Double-clicking an entry in the new selection widget should select it and close the selection dialog: Request for Discussion.
Mon, Mar 30, 12:09 AM · Noteworthy, MITK (2020)

Sat, Mar 28

kislinsk added a comment to T27266: [Image Statistics] Planar figures cannot be read or written until one of the quantification views is open.

So we have to make an auto load module for the planar figure IO. Right?

Sat, Mar 28, 2:15 PM · MITK (2020)
kislinsk added a project to T27272: Double-clicking an entry in the new selection widget should select it and close the selection dialog: Request for Discussion.
Sat, Mar 28, 4:06 AM · Noteworthy, MITK (2020)
kislinsk triaged T27272: Double-clicking an entry in the new selection widget should select it and close the selection dialog as Wishlist priority.
Sat, Mar 28, 4:06 AM · Noteworthy, MITK (2020)
kislinsk committed rMITKd34b39c2f25c: Remove unused variable (authored by kislinsk).
Remove unused variable
Sat, Mar 28, 3:56 AM
kislinsk committed rMITK19234007a74e: Remove out of ref image bounds check for planar figures (authored by kislinsk).
Remove out of ref image bounds check for planar figures
Sat, Mar 28, 3:49 AM
kislinsk triaged T27271: [Image Statistics] Double clicking to isolate one graph only works on already enabled graphs as Normal priority.
Sat, Mar 28, 3:21 AM · MITK (2020)
kislinsk updated the task description for T27269: PlanarCircle shrinks in size when moved towards image boundaries.
Sat, Mar 28, 3:16 AM · MITK (2020)
kislinsk updated the task description for T27269: PlanarCircle shrinks in size when moved towards image boundaries.
Sat, Mar 28, 3:16 AM · MITK (2020)
kislinsk triaged T27270: Planar figures are inconsistently bound by reference image as Normal priority.
Sat, Mar 28, 3:13 AM · Request for Discussion, MITK (2020)
kislinsk triaged T27269: PlanarCircle shrinks in size when moved towards image boundaries as High priority.
Sat, Mar 28, 3:10 AM · MITK (2020)
kislinsk triaged T27268: [Image Statistics] Moving/modifying a planar figure that is shown in statistics keeps adding graphs as High priority.
Sat, Mar 28, 3:00 AM · MITK (2020)
kislinsk triaged T27267: [Image Statistics] Removal of image and planar figure from data storage does not affect statistics widget as High priority.
Sat, Mar 28, 2:51 AM · MITK (2020)
kislinsk triaged T27266: [Image Statistics] Planar figures cannot be read or written until one of the quantification views is open as High priority.
Sat, Mar 28, 2:48 AM · MITK (2020)
kislinsk added a comment to T27264: Extent Movie Maker to directly create gifs.

Hm, my observation during the past years is that people say GIF, but they actually mean MP4s or WEBMs without sound. These formats are usually supported on all sites and typical GIF meme sites like Giphy actually use MP4s as primary format as the format is also supported natively by all browsers and HTML5. Are you sure you really want the GIF file format? :)

Sat, Mar 28, 2:21 AM · MITK

Fri, Mar 27

kislinsk removed a member for SuSI: kislinsk.
Fri, Mar 27, 2:13 PM
kislinsk added a member for SuSI: kislinsk.
Fri, Mar 27, 1:21 PM
kislinsk moved T27190: Clang format style for * and & at variables from MITK Meeting to Backlog on the Request for Discussion board.

We should meet and discuss about conventions in detail, before we apply a repository wide reformat. @nolden @kalali @floca

Fri, Mar 27, 11:16 AM · Request for Discussion, MITK
kislinsk moved T27090: Provide standard NodePredicates from MITK Meeting to Backlog on the Request for Discussion board.
Fri, Mar 27, 11:06 AM · Request for Discussion, MITK
kislinsk assigned T19477: Select which dicom tags are used to create a nodes name to floca.
Fri, Mar 27, 11:04 AM · Request for Discussion, Bugzilla, MITK
kislinsk committed rMITKddb3c1bc348a: In DICOM plugin, remove link-time dependency to auto-load DicomRTIO module (authored by kislinsk).
In DICOM plugin, remove link-time dependency to auto-load DicomRTIO module
Fri, Mar 27, 9:47 AM
kislinsk committed rMITKb8797590b4d0: Prefer std::make_unique() to std::unique_ptr::reset() (authored by kislinsk).
Prefer std::make_unique() to std::unique_ptr::reset()
Fri, Mar 27, 9:41 AM
kislinsk added a comment to T27152: BlueBerry CustomViewer (Spartan Viewer) not migrated to new CTK version.

I also encountered the indexer warnings in the MitkWorkbench when opening the DICOM browser.

Fri, Mar 27, 9:30 AM · MITK

Thu, Mar 26

kislinsk closed T27243: DICOM plugin depends on autoload module as Resolved.
Thu, Mar 26, 4:47 PM · MITK (2020)
kislinsk committed rMITK525971477cc1: In DICOM plugin, remove link-time dependency to auto-load DicomRTIO module (authored by kislinsk).
In DICOM plugin, remove link-time dependency to auto-load DicomRTIO module
Thu, Mar 26, 4:38 PM
kislinsk committed rMITK126f92d880e3: Fix memory leaks and static initialization order issues (authored by kislinsk).
Fix memory leaks and static initialization order issues
Thu, Mar 26, 4:34 PM
kislinsk reopened T27243: DICOM plugin depends on autoload module as "Open".

DicomRT tests do fail now. For example:

Thu, Mar 26, 3:22 PM · MITK (2020)
kislinsk closed T27243: DICOM plugin depends on autoload module as Resolved.
Thu, Mar 26, 2:16 PM · MITK (2020)
kislinsk committed rMITKf379735e54e5: In DICOM plugin, remove link-time dependency to auto-load DicomRTIO module (authored by kislinsk).
In DICOM plugin, remove link-time dependency to auto-load DicomRTIO module
Thu, Mar 26, 2:15 PM

Wed, Mar 25

kislinsk committed rMITKc6e8be8ab1d8: Add CppMicroservices module initialization (authored by kislinsk).
Add CppMicroservices module initialization
Wed, Mar 25, 11:37 PM
kislinsk committed rMITKf772f230f6ff: Directly query DicomRT readers by their CustomMimeType (authored by kislinsk).
Directly query DicomRT readers by their CustomMimeType
Wed, Mar 25, 11:37 PM
kislinsk committed rMITK6cabf12f417e: Move DicomRTIOMimeTypes in DicomRTIO module to DicomRTMimeTypes in DicomRT… (authored by kislinsk).
Move DicomRTIOMimeTypes in DicomRTIO module to DicomRTMimeTypes in DicomRT…
Wed, Mar 25, 11:37 PM
kislinsk closed T27022: CTest returns error code if subproject does not have tests as Resolved.
Wed, Mar 25, 8:30 AM · Restricted Project, Restricted Project, CI, MITK
kislinsk moved T27022: CTest returns error code if subproject does not have tests from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Mar 25, 8:30 AM · Restricted Project, Restricted Project, CI, MITK
kislinsk moved T27022: CTest returns error code if subproject does not have tests from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Mar 25, 8:30 AM · Restricted Project, Restricted Project, CI, MITK
kislinsk added a project to T27022: CTest returns error code if subproject does not have tests: Restricted Project.

It worked. The nightlies are sunny now and the documentation was uploaded to docs.mitk.org. I changed every MITK and eMITK job to use CMake 3.17 now and passed --no-tests=ignore to CTest.

Wed, Mar 25, 8:30 AM · Restricted Project, Restricted Project, CI, MITK
kislinsk awarded T27022: CTest returns error code if subproject does not have tests a Party Time token.
Wed, Mar 25, 8:27 AM · Restricted Project, Restricted Project, CI, MITK
kislinsk added a comment to T27196: Rewrite packaging of MITK.
NOTE: GetPrerequisites is deprecated since CMake 3.16 and was superseded by file(GET_RUNTIME_DEPENDENCIES).
Wed, Mar 25, 8:13 AM · MITK
kislinsk updated the task description for T27196: Rewrite packaging of MITK.
Wed, Mar 25, 8:10 AM · MITK

Tue, Mar 24

kislinsk moved T27022: CTest returns error code if subproject does not have tests from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Tue, Mar 24, 2:10 PM · Restricted Project, Restricted Project, CI, MITK
kislinsk added a project to T27022: CTest returns error code if subproject does not have tests: Restricted Project.
Tue, Mar 24, 2:10 PM · Restricted Project, Restricted Project, CI, MITK
kislinsk moved T27022: CTest returns error code if subproject does not have tests from Backlog to In Progress on the CI board.

CMake 3.17 is out now. I configured the MITK Nightlies to use CMake 3.17 from tonight on and added the new --no-tests=ignore argument to the call of CTest.

Tue, Mar 24, 2:09 PM · Restricted Project, Restricted Project, CI, MITK

Mon, Mar 23

kislinsk committed rMITKde47e74d9598: Throw exception if file reader cannot be found (authored by kislinsk).
Throw exception if file reader cannot be found
Mon, Mar 23, 10:40 PM
kislinsk added a revision to T27243: DICOM plugin depends on autoload module: Unknown Object (Differential Revision).
Mon, Mar 23, 11:48 AM · MITK (2020)
kislinsk committed rMITK2511fa894bc9: Use FileReaderRegistry to indirectly access DicomRTIO services (authored by kislinsk).
Use FileReaderRegistry to indirectly access DicomRTIO services
Mon, Mar 23, 11:43 AM
kislinsk committed rMITKfb88d369d978: Fix module dependencies (authored by kislinsk).
Fix module dependencies
Mon, Mar 23, 11:43 AM
kislinsk committed rMITK193d1d7b620c: Disallow dependencies to auto-load modules (authored by kislinsk).
Disallow dependencies to auto-load modules
Mon, Mar 23, 10:41 AM
kislinsk added a comment to T27243: DICOM plugin depends on autoload module.

Pushed new branch T27243-FixAutoloadDependency.

Mon, Mar 23, 10:41 AM · MITK (2020)
kislinsk claimed T27243: DICOM plugin depends on autoload module.
Mon, Mar 23, 9:57 AM · MITK (2020)

Fri, Mar 20

kislinsk closed T27245: Set Doxygen output dir before extension point documentation handling as Resolved.
Fri, Mar 20, 5:22 AM · MITK
kislinsk committed rMITK1fc10de191fa: Merge branch 'T27245-DoxygenExtensionPoint' (authored by kislinsk).
Merge branch 'T27245-DoxygenExtensionPoint'
Fri, Mar 20, 5:22 AM
kislinsk committed rMITK1e07bc112a98: Prevent creation of directory in root directory (authored by kislinsk).
Prevent creation of directory in root directory
Fri, Mar 20, 5:21 AM
kislinsk added a comment to T27245: Set Doxygen output dir before extension point documentation handling.

Pushed new branch T27245-DoxygenExtensionPoint.

Fri, Mar 20, 5:21 AM · MITK
kislinsk triaged T27245: Set Doxygen output dir before extension point documentation handling as Low priority.
Fri, Mar 20, 5:18 AM · MITK

Thu, Mar 19

kislinsk updated the task description for T27243: DICOM plugin depends on autoload module.
Thu, Mar 19, 4:27 PM · MITK (2020)
kislinsk triaged T27243: DICOM plugin depends on autoload module as High priority.
Thu, Mar 19, 4:26 PM · MITK (2020)
kislinsk closed T27087: Remove Autoload-Modul-Workarround in the FixMacOS script as Resolved.

Was removed meanwhile and revealed errors regarding plugins that depend on autoload modules.

Thu, Mar 19, 4:22 PM · MITK
kislinsk renamed T27242: Exclude test drivers from packaging from Fix MITK packaging to Exclude test drivers from packaging.
Thu, Mar 19, 4:20 PM · MITK (2020)
kislinsk committed rMITK5a51e19f7bd4: Merge branch 'T27242-FixPackaging' (authored by kislinsk).
Merge branch 'T27242-FixPackaging'
Thu, Mar 19, 4:19 PM
kislinsk committed rMITKe89106816638: Do not package test drivers (authored by kislinsk).
Do not package test drivers
Thu, Mar 19, 3:03 PM
kislinsk added a comment to T27242: Exclude test drivers from packaging.

Pushed new branch T27242-FixPackaging.

Thu, Mar 19, 3:03 PM · MITK (2020)
kislinsk triaged T27242: Exclude test drivers from packaging as High priority.
Thu, Mar 19, 3:01 PM · MITK (2020)

Tue, Mar 17

kislinsk created challengeR.
Tue, Mar 17, 12:40 PM

Mon, Mar 16

kislinsk updated subscribers of T23345: Save nrrd segmentation as DICOM.
Mon, Mar 16, 3:49 PM · MITK
kislinsk triaged T27187: MitkCLMatchPointReg silently not built. as Normal priority.
Mon, Mar 16, 3:40 PM · MITK
kislinsk triaged T27189: REST API for data storage as Wishlist priority.
Mon, Mar 16, 3:38 PM · Restricted Project, Request for Discussion, MITK

Tue, Mar 10

kislinsk committed rMITK389bf1243c68: Merge remote-tracking branch 'origin/T27170-MinimalBuild' (authored by kislinsk).
Merge remote-tracking branch 'origin/T27170-MinimalBuild'
Tue, Mar 10, 10:16 AM
kislinsk committed rMITK6fac19f31b83: Explicitly disable Qwt (authored by kislinsk).
Explicitly disable Qwt
Tue, Mar 10, 9:53 AM

Mon, Mar 9

kislinsk added a comment to T27206: Use new Qt5 signal-slot syntax.

The recommended way of using QtOverload seems to be via macros. There are also macros for const overloads and explicitly non-const overloads:
https://doc.qt.io/qt-5/qtglobal.html#qOverload

Mon, Mar 9, 10:40 AM · MITK
kislinsk added a comment to T27206: Use new Qt5 signal-slot syntax.

+1

Mon, Mar 9, 10:37 AM · MITK
kislinsk added a comment to T27206: Use new Qt5 signal-slot syntax.

Also, concerning the super ugly version, I did this sometimes (although I'd prefer the QtOverload-way):

connect(mySpinBox, static_cast<void (QSpinBox::*)(int)>(&QSpinBox::valueChanged), mySlider, &QSlider::setValue);
Mon, Mar 9, 10:01 AM · MITK

Sat, Mar 7

kislinsk renamed T27203: QmitkAbstractNodeSelectionWidgetTest regularly fails on headless Linux from QmitkAbstractNodeSelectionWidgetTest regularily fails on headless Linux to QmitkAbstractNodeSelectionWidgetTest regularly fails on headless Linux.
Sat, Mar 7, 7:35 AM · MITK
kislinsk closed T27203: QmitkAbstractNodeSelectionWidgetTest regularly fails on headless Linux as Resolved.
Sat, Mar 7, 7:34 AM · MITK