Page MenuHomePhabricator

kislinsk (Stefan Dinkelacker)
UserAdministrator

Projects (14)

User Details

User Since
Aug 1 2016, 11:50 AM (260 w, 5 d)
Roles
Administrator

Recent Activity

Mon, Jul 26

kislinsk claimed T27701: Overhaul or remove PluginGenerator.
Mon, Jul 26, 9:36 AM · MITK (v2021.10)
kislinsk triaged T28585: The MITK-Tutorial Step 9 missing inheritence as Normal priority.
Mon, Jul 26, 9:35 AM · MITK (v2021.10)
kislinsk added a subtask for T27701: Overhaul or remove PluginGenerator: T28585: The MITK-Tutorial Step 9 missing inheritence.
Mon, Jul 26, 9:35 AM · MITK (v2021.10)
kislinsk added a parent task for T28585: The MITK-Tutorial Step 9 missing inheritence: T27701: Overhaul or remove PluginGenerator.
Mon, Jul 26, 9:35 AM · MITK (v2021.10)
kislinsk added a project to T28585: The MITK-Tutorial Step 9 missing inheritence: MITK (v2021.10).
Mon, Jul 26, 9:34 AM · MITK (v2021.10)

Wed, Jul 21

kislinsk added a comment to T28635: [Segmentation] Remove deprecated classes.

When deprecated classes are still around for a long time it is a valid base assumption that the reason is just that they were either forgotten since they weren't used or seen for a long time, or that it is surprisingly difficult to actually get rid of them since there's no real replacement for example but they are still in heavy use. The latter reason is something seen rather often in the core unfortunately.

Wed, Jul 21, 11:51 PM · Cleared, MITK (v2021.10)
kislinsk updated the task description for T28635: [Segmentation] Remove deprecated classes.
Wed, Jul 21, 11:47 PM · Cleared, MITK (v2021.10)

Tue, Jul 20

kislinsk added a comment to T28616: Allow fixed-size point set markers in VTK mapper.

Deleted branch from rMITK MITK: feature/T28616-FixedSizeVisualizationForPointSets.

Tue, Jul 20, 9:43 AM · Pull Request, MITK (v2021.10)
kislinsk committed rMITK51054fb39226: Merge remote-tracking branch 'slafebre/feature/T28616-fixed-size-markers-for… (authored by kislinsk).
Merge remote-tracking branch 'slafebre/feature/T28616-fixed-size-markers-for…
Tue, Jul 20, 9:42 AM
kislinsk committed rMITK5788efe2d52a: Fix glyph scaling when switching back to non-fixed point sizes (authored by kislinsk).
Fix glyph scaling when switching back to non-fixed point sizes
Tue, Jul 20, 9:42 AM
kislinsk committed rMITK461a2db73b4e: Fix glyph scaling of selected glyphs (authored by kislinsk).
Fix glyph scaling of selected glyphs
Tue, Jul 20, 9:42 AM
kislinsk committed rMITKfe35a091a085: Add option to visualize point sets as fixed-size markers (authored by kislinsk).
Add option to visualize point sets as fixed-size markers
Tue, Jul 20, 9:42 AM
kislinsk closed T28616: Allow fixed-size point set markers in VTK mapper as Resolved by committing rMITKfe35a091a085: Add option to visualize point sets as fixed-size markers.
Tue, Jul 20, 9:42 AM · Pull Request, MITK (v2021.10)

Wed, Jul 14

kislinsk lowered the priority of T16153: [Segmentation] Jump to center of mass of segmentation on click from Normal to Wishlist.
Wed, Jul 14, 11:31 AM · MITK (v2021.10), Bugzilla
kislinsk lowered the priority of T28262: TimeGeometry inconsistent documentation and implementation of time bounds and checks from Unbreak Now! to High.
Wed, Jul 14, 11:09 AM · MITK (v2021.10), Request for Discussion

Tue, Jul 13

kislinsk updated the task description for T27437: Migrate MITK to use ITK 5.x .
Tue, Jul 13, 2:22 PM · MITK (v2021.10)
kislinsk added a comment to T27437: Migrate MITK to use ITK 5.x .

I continued migrating MITK. Without explicitly switching on any plugins, the Workbench already compiles and run. Switching on the WorkbenchRelease configuration (without MatchPoint, since I cannot currently compile it because of a compiler bug) compiles as well except for the following two classes which need a rewrite of their multi-threaded implementation, since the ITK base class changed its implementation in that regard:

Tue, Jul 13, 4:10 AM · MITK (v2021.10)

Sat, Jul 10

kislinsk changed the status of T28614: [Segmentation] Replace ITK filter pipeline for 2-d interpolation with single filter that does the same job from Resolved to Wontfix.
Sat, Jul 10, 1:42 AM · MITK (v2021.10)
kislinsk added a comment to T28614: [Segmentation] Replace ITK filter pipeline for 2-d interpolation with single filter that does the same job.

Deleted branch from rMITK MITK: bugfix/T28614-Revert.

Sat, Jul 10, 1:41 AM · MITK (v2021.10)
kislinsk added a reverting change for rMITK4aa264835117: Replace 2-d interpolation filter pipeline with equivalent ITK filter: rMITK4ab8a5898b8d: Revert "Replace 2-d interpolation filter pipeline with equivalent ITK filter".
Sat, Jul 10, 1:41 AM
kislinsk committed rMITK4ab8a5898b8d: Revert "Replace 2-d interpolation filter pipeline with equivalent ITK filter" (authored by kislinsk).
Revert "Replace 2-d interpolation filter pipeline with equivalent ITK filter"
Sat, Jul 10, 1:41 AM
kislinsk committed rMITK648a34ce6f0e: Merge branch 'bugfix/T28614-Revert' into develop (authored by kislinsk).
Merge branch 'bugfix/T28614-Revert' into develop
Sat, Jul 10, 1:41 AM
kislinsk added a comment to T28614: [Segmentation] Replace ITK filter pipeline for 2-d interpolation with single filter that does the same job.

Pushed new branch to rMITK MITK: bugfix/T28614-Revert.

Sat, Jul 10, 1:40 AM · MITK (v2021.10)

Fri, Jul 9

kislinsk added a comment to T28614: [Segmentation] Replace ITK filter pipeline for 2-d interpolation with single filter that does the same job.

Deleted branch from rMITK MITK: bugfix/T28614-Simplify2DInterpolationFilterPipeline.

Fri, Jul 9, 2:49 PM · MITK (v2021.10)
kislinsk committed rMITK4aa264835117: Replace 2-d interpolation filter pipeline with equivalent ITK filter (authored by kislinsk).
Replace 2-d interpolation filter pipeline with equivalent ITK filter
Fri, Jul 9, 2:48 PM
kislinsk committed rMITK3e08285283ef: Replace 2-d interpolation filter pipeline with equivalent ITK filter (authored by kislinsk).
Replace 2-d interpolation filter pipeline with equivalent ITK filter
Fri, Jul 9, 2:48 PM
kislinsk closed T28614: [Segmentation] Replace ITK filter pipeline for 2-d interpolation with single filter that does the same job as Resolved by committing rMITK3e08285283ef: Replace 2-d interpolation filter pipeline with equivalent ITK filter.
Fri, Jul 9, 2:48 PM · MITK (v2021.10)
kislinsk moved T28616: Allow fixed-size point set markers in VTK mapper from Backlog to Cycle on the MITK (v2021.10) board.
Fri, Jul 9, 11:31 AM · Pull Request, MITK (v2021.10)
kislinsk added a revision to T28616: Allow fixed-size point set markers in VTK mapper: Unknown Object (Differential Revision).
Fri, Jul 9, 11:26 AM · Pull Request, MITK (v2021.10)
kislinsk added a comment to T28616: Allow fixed-size point set markers in VTK mapper.

Pushed new branch to rMITK MITK: feature/T28616-FixedSizeVisualizationForPointSets.

Fri, Jul 9, 10:28 AM · Pull Request, MITK (v2021.10)
kislinsk claimed T28616: Allow fixed-size point set markers in VTK mapper.
Fri, Jul 9, 10:23 AM · Pull Request, MITK (v2021.10)
kislinsk added a project to T28616: Allow fixed-size point set markers in VTK mapper: Pull Request.

Thanks!

Fri, Jul 9, 10:22 AM · Pull Request, MITK (v2021.10)
kislinsk added a comment to T28385: [Segmentation] Erosion crashes the MITK Workbench after interpolation.

Deleted branch from rMITK MITK: bugfix/T28385-AddNullptrCheck.

Fri, Jul 9, 9:56 AM · Cleared, MITK (v2021.10)
kislinsk committed rMITK5071cbec8de1: Add nullptr check (authored by kislinsk).
Add nullptr check
Fri, Jul 9, 9:56 AM
kislinsk committed rMITKcbf0c82a8caa: Merge branch 'bugfix/T28385-AddNullptrCheck' into develop (authored by kislinsk).
Merge branch 'bugfix/T28385-AddNullptrCheck' into develop
Fri, Jul 9, 9:55 AM
kislinsk added a comment to T28385: [Segmentation] Erosion crashes the MITK Workbench after interpolation.

Pushed new branch to rMITK MITK: bugfix/T28385-AddNullptrCheck.

Fri, Jul 9, 9:55 AM · Cleared, MITK (v2021.10)
kislinsk added a comment to T28606: [Segmentation] Accelerate do/undo mechanism for segmentations.

Deleted branch from rMITK MITK: bugfix/T28606-StoreImageDimension.

Fri, Jul 9, 9:39 AM · MITK (v2021.10)
kislinsk committed rMITK40adb64e9980: Explicitly store and restore image dimension (authored by kislinsk).
Explicitly store and restore image dimension
Fri, Jul 9, 9:38 AM
kislinsk committed rMITK454aee539fff: Merge branch 'bugfix/T28606-StoreImageDimension' into develop (authored by kislinsk).
Merge branch 'bugfix/T28606-StoreImageDimension' into develop
Fri, Jul 9, 9:38 AM
kislinsk added a comment to T28606: [Segmentation] Accelerate do/undo mechanism for segmentations.

Pushed new branch to rMITK MITK: bugfix/T28606-StoreImageDimension.

Fri, Jul 9, 9:38 AM · MITK (v2021.10)
kislinsk triaged T28616: Allow fixed-size point set markers in VTK mapper as Wishlist priority.

Thanks for the suggestion and patch! 👍

Fri, Jul 9, 8:25 AM · Pull Request, MITK (v2021.10)
kislinsk closed T28606: [Segmentation] Accelerate do/undo mechanism for segmentations as Resolved.
Fri, Jul 9, 8:01 AM · MITK (v2021.10)
kislinsk added a comment to T28606: [Segmentation] Accelerate do/undo mechanism for segmentations.

Deleted branch from rMITK MITK: bugfix/T28606-UseLZ4InCompressedImageContainerClass.

Fri, Jul 9, 7:59 AM · MITK (v2021.10)
kislinsk committed rMITK25d18deac4a7: Add lz4 as third-party dependency (authored by kislinsk).
Add lz4 as third-party dependency
Fri, Jul 9, 7:58 AM
kislinsk committed rMITK31a4130fcacc: Rewrite CompressedImageContainer to use LZ4 compression (authored by kislinsk).
Rewrite CompressedImageContainer to use LZ4 compression
Fri, Jul 9, 7:58 AM
kislinsk committed rMITK14632b174db4: Merge branch 'bugfix/T28606-UseLZ4InCompressedImageContainerClass' into develop (authored by kislinsk).
Merge branch 'bugfix/T28606-UseLZ4InCompressedImageContainerClass' into develop
Fri, Jul 9, 7:58 AM
kislinsk committed rMITK83eab9c57a25: Migrate unit test to changed API (authored by kislinsk).
Migrate unit test to changed API
Fri, Jul 9, 7:58 AM
kislinsk committed rMITKafe3b0b3c036: Merge branch 'develop' into bugfix/T28606-UseLZ4InCompressedImageContainerClass (authored by kislinsk).
Merge branch 'develop' into bugfix/T28606-UseLZ4InCompressedImageContainerClass
Fri, Jul 9, 7:58 AM
kislinsk added a comment to T28385: [Segmentation] Erosion crashes the MITK Workbench after interpolation.

Deleted branch from rMITK MITK: bugfix/T28385-InterpolationCrashOnMorphologicalOperations.

Fri, Jul 9, 7:49 AM · Cleared, MITK (v2021.10)
kislinsk committed rMITK6d56f81401b8: Handle uninitialized segmentations (authored by kislinsk).
Handle uninitialized segmentations
Fri, Jul 9, 7:49 AM
kislinsk committed rMITKe2a033fa4497: Disable interpolation if interpolator aborted (authored by kislinsk).
Disable interpolation if interpolator aborted
Fri, Jul 9, 7:49 AM
kislinsk committed rMITKb1020c733309: Reset feedback node when interpolation was aborted (authored by kislinsk).
Reset feedback node when interpolation was aborted
Fri, Jul 9, 7:49 AM
kislinsk committed rMITKbb5598e1083a: Release own reference to segmentation if it is invalid (authored by kislinsk).
Release own reference to segmentation if it is invalid
Fri, Jul 9, 7:49 AM
kislinsk closed T28385: [Segmentation] Erosion crashes the MITK Workbench after interpolation as Resolved by committing rMITKb7299f54c209: Handle uninitialized segmentations in interpolator.
Fri, Jul 9, 7:49 AM · Cleared, MITK (v2021.10)
kislinsk committed rMITKb7299f54c209: Handle uninitialized segmentations in interpolator (authored by kislinsk).
Handle uninitialized segmentations in interpolator
Fri, Jul 9, 7:49 AM

Thu, Jul 8

kislinsk closed T28615: [Segmentation] First 2-d interpolation is only performed after the current slice was changed as Wontfix.
Thu, Jul 8, 2:34 PM · MITK (v2021.10)
kislinsk moved T28615: [Segmentation] First 2-d interpolation is only performed after the current slice was changed from Backlog to Cycle on the MITK (v2021.10) board.
Thu, Jul 8, 12:33 PM · MITK (v2021.10)
kislinsk triaged T28615: [Segmentation] First 2-d interpolation is only performed after the current slice was changed as Normal priority.
Thu, Jul 8, 12:33 PM · MITK (v2021.10)
kislinsk merged T28516: 2D slice interpolation should use multiprocessing into T28491: Slice interpolation 'confirm for all slices' not working for large images.
Thu, Jul 8, 12:29 PM · MITK (v2021.10)
kislinsk merged task T28516: 2D slice interpolation should use multiprocessing into T28491: Slice interpolation 'confirm for all slices' not working for large images.
Thu, Jul 8, 12:29 PM · MITK (v2021.10)
kislinsk renamed T28385: [Segmentation] Erosion crashes the MITK Workbench after interpolation from [Segmentation Utilities] Erosion crashes the MITK Workbench after interpolation to [Segmentation] Erosion crashes the MITK Workbench after interpolation.
Thu, Jul 8, 12:23 PM · Cleared, MITK (v2021.10)
kislinsk added a revision to T28606: [Segmentation] Accelerate do/undo mechanism for segmentations: Unknown Object (Differential Revision).
Thu, Jul 8, 12:22 PM · MITK (v2021.10)
kislinsk renamed T28606: [Segmentation] Accelerate do/undo mechanism for segmentations from Accelerate do/undo mechanism for segmentations to [Segmentation] Accelerate do/undo mechanism for segmentations.
Thu, Jul 8, 12:21 PM · MITK (v2021.10)
kislinsk placed T28480: [Checklist] [Test data] Define publicly available location to store user test data up for grabs.
Thu, Jul 8, 12:21 PM · MITK (v2021.10)
kislinsk moved T28614: [Segmentation] Replace ITK filter pipeline for 2-d interpolation with single filter that does the same job from Backlog to Cycle on the MITK (v2021.10) board.
Thu, Jul 8, 12:19 PM · MITK (v2021.10)
kislinsk added a revision to T28614: [Segmentation] Replace ITK filter pipeline for 2-d interpolation with single filter that does the same job: Unknown Object (Differential Revision).
Thu, Jul 8, 12:17 PM · MITK (v2021.10)
kislinsk added a comment to T28614: [Segmentation] Replace ITK filter pipeline for 2-d interpolation with single filter that does the same job.

Pushed new branch to rMITK MITK: bugfix/T28614-Simplify2DInterpolationFilterPipeline.

Thu, Jul 8, 12:16 PM · MITK (v2021.10)
kislinsk triaged T28614: [Segmentation] Replace ITK filter pipeline for 2-d interpolation with single filter that does the same job as Normal priority.
Thu, Jul 8, 12:14 PM · MITK (v2021.10)
kislinsk added a revision to T28385: [Segmentation] Erosion crashes the MITK Workbench after interpolation: Unknown Object (Differential Revision).
Thu, Jul 8, 7:57 AM · Cleared, MITK (v2021.10)

Wed, Jul 7

kislinsk added a comment to T28385: [Segmentation] Erosion crashes the MITK Workbench after interpolation.

Pushed new branch to rMITK MITK: bugfix/T28385-InterpolationCrashOnMorphologicalOperations.

Wed, Jul 7, 10:55 PM · Cleared, MITK (v2021.10)
kislinsk added a comment to T28385: [Segmentation] Erosion crashes the MITK Workbench after interpolation.

We can fix it in the SegmentationInterpolationController by explicitly handling the situation that the modified image is not initialized (IsInitialized() == false).

Wed, Jul 7, 5:23 PM · Cleared, MITK (v2021.10)
kislinsk claimed T28385: [Segmentation] Erosion crashes the MITK Workbench after interpolation.
Wed, Jul 7, 5:14 PM · Cleared, MITK (v2021.10)
kislinsk edited projects for T28385: [Segmentation] Erosion crashes the MITK Workbench after interpolation, added: Cleared; removed Missing Info.
Wed, Jul 7, 12:02 PM · Cleared, MITK (v2021.10)
kislinsk added a comment to T28385: [Segmentation] Erosion crashes the MITK Workbench after interpolation.

@floca I just tested it with my latest changes and the issue still persists. The connection to interpolation seems to be that the SegmentationInterpolationController is still holding a reference to the image and is notified about a modification. When changing the segmentation volume to the new segmentation eventually the ImageTimeSelector crashes when trying to clone an ImageDataItem that already seems to be null (this is 0x00000000). Here's a part of the call stack:

Wed, Jul 7, 12:00 PM · Cleared, MITK (v2021.10)

Mon, Jul 5

kislinsk added a comment to T28606: [Segmentation] Accelerate do/undo mechanism for segmentations.

Pushed new branch to rMITK MITK: bugfix/T28606-UseLZ4InCompressedImageContainerClass.

Mon, Jul 5, 11:32 PM · MITK (v2021.10)
kislinsk added a comment to T28606: [Segmentation] Accelerate do/undo mechanism for segmentations.

With the same test data as in T28491, I was already able to virtually eliminate the time spent on compression with LZ4.

Mon, Jul 5, 11:03 PM · MITK (v2021.10)
kislinsk moved T28606: [Segmentation] Accelerate do/undo mechanism for segmentations from Backlog to Segmentation on the MITK (v2021.10) board.
Mon, Jul 5, 10:51 PM · MITK (v2021.10)
kislinsk triaged T28606: [Segmentation] Accelerate do/undo mechanism for segmentations as Normal priority.
Mon, Jul 5, 10:51 PM · MITK (v2021.10)

Fri, Jul 2

kislinsk closed T28602: 2021 Week 26 (Very Early July) as Resolved.
Fri, Jul 2, 10:50 AM · MITK
kislinsk edited the content of Changelog.
Fri, Jul 2, 10:49 AM · MITK
kislinsk added a comment to T28602: 2021 Week 26 (Very Early July).

Deleted branch from rMITK MITK: release/T28602-2021-Week-26.

Fri, Jul 2, 10:45 AM · MITK
kislinsk committed rMITK3349cb419412: Merge branch 'master' into develop (authored by kislinsk).
Merge branch 'master' into develop
Fri, Jul 2, 10:45 AM
kislinsk committed rMITKce85d3e8c908: 2021 Week 26 (Very Early July) (authored by kislinsk).
2021 Week 26 (Very Early July)
Fri, Jul 2, 10:44 AM
kislinsk edited the content of 2021 Week 26 (Very Early July).
Fri, Jul 2, 10:36 AM
kislinsk edited the content of 2021 Week 17 (Very Late April).
Fri, Jul 2, 9:45 AM
kislinsk added a comment to T28602: 2021 Week 26 (Very Early July).

Pushed new branch to rMITK MITK: release/T28602-2021-Week-26.

Fri, Jul 2, 9:42 AM · MITK
kislinsk triaged T28602: 2021 Week 26 (Very Early July) as Normal priority.
Fri, Jul 2, 9:40 AM · MITK
kislinsk created T28602: 2021 Week 26 (Very Early July).
Fri, Jul 2, 9:40 AM · MITK
kislinsk created an object: 2021 Week 26 (Very Early July).
Fri, Jul 2, 9:40 AM

Jul 1 2021

kislinsk closed T28491: Slice interpolation 'confirm for all slices' not working for large images as Resolved.

I will create another task for an optimization of the diff image operations in the do/undo stack.

Jul 1 2021, 10:10 AM · MITK (v2021.10)
kislinsk added a comment to T28491: Slice interpolation 'confirm for all slices' not working for large images.

Deleted branch from rMITK MITK: bugfix/T28491-SpeedUp2DInterpolationsOfLargeSegmentations.

Jul 1 2021, 10:08 AM · MITK (v2021.10)
kislinsk committed rMITK014bc90c3796: Cleanup QmitkSlicesInterpolator::AcceptAllInterpolations() (authored by kislinsk).
Cleanup QmitkSlicesInterpolator::AcceptAllInterpolations()
Jul 1 2021, 10:08 AM
kislinsk committed rMITKc92776202a35: Clean up mitk::SegmentationInterpolationController::Interpolate() (authored by kislinsk).
Clean up mitk::SegmentationInterpolationController::Interpolate()
Jul 1 2021, 10:08 AM
kislinsk committed rMITK83e828cf2778: Implement simple caching of distance images (authored by kislinsk).
Implement simple caching of distance images
Jul 1 2021, 10:08 AM
kislinsk committed rMITK7814683ed6f3: Add optional parameter to allow caching of calculations (authored by kislinsk).
Add optional parameter to allow caching of calculations
Jul 1 2021, 10:08 AM
kislinsk committed rMITK72a664bc86d6: Cache some calculations for repeated 2d-interpolation (authored by kislinsk).
Cache some calculations for repeated 2d-interpolation
Jul 1 2021, 10:08 AM
kislinsk committed rMITK1c0d3e8cba5e: Derive cache size from number of H/W threads (authored by kislinsk).
Derive cache size from number of H/W threads
Jul 1 2021, 10:08 AM
kislinsk committed rMITK7f8aff5a2781: Implement optional slice extraction cache for lower and upper slices (authored by kislinsk).
Implement optional slice extraction cache for lower and upper slices
Jul 1 2021, 10:08 AM
kislinsk committed rMITK3efa9373b497: Use slice extraction cache for repeated 2d-interpolations (authored by kislinsk).
Use slice extraction cache for repeated 2d-interpolations
Jul 1 2021, 10:08 AM
kislinsk committed rMITKedebc008c3c9: Secure caches with mutexes for safe multithreading (authored by kislinsk).
Secure caches with mutexes for safe multithreading
Jul 1 2021, 10:08 AM