Page MenuHomePhabricator

kislinsk (Stefan Dinkelacker)
UserAdministrator

Projects (15)

User Details

User Since
Aug 1 2016, 11:50 AM (175 w, 21 h)
Roles
Administrator

Recent Activity

Fri, Dec 6

kislinsk assigned T26854: Unattended Qt installation to kalali.
Fri, Dec 6, 3:55 PM · CI, Restricted Project, MITK
kislinsk placed T26854: Unattended Qt installation up for grabs.
Fri, Dec 6, 3:47 PM · CI, Restricted Project, MITK
kislinsk closed T26849: Remove polling loop from continuous CDash scripts as Resolved.
Fri, Dec 6, 3:43 PM · CI, MITK (2018-04-4)
kislinsk closed T25256: MITK license file features "Division of Medical and Biological Informatics" as Resolved.
Fri, Dec 6, 3:40 PM · MITK
kislinsk committed rMPTdc1554a13695: Unify license and copyright headers (authored by kislinsk).
Unify license and copyright headers
Fri, Dec 6, 3:35 PM
kislinsk closed T26893: GitHub doesn't recognize our license as Wontfix.

I give up, it makes no sense to put much time into this until Github clearly communicates the heuristic to detect the license.

Fri, Dec 6, 3:08 PM · MITK
kislinsk committed rMITK56c0ba1005be: Merge branch 'T26893-GitHubCompatibleLicenseFile' (authored by kislinsk).
Merge branch 'T26893-GitHubCompatibleLicenseFile'
Fri, Dec 6, 2:38 PM
kislinsk committed rMITKa724ab165f2e: Move COPYRIGHT_HEADER to Templates/copyright_header.txt (authored by kislinsk).
Move COPYRIGHT_HEADER to Templates/copyright_header.txt
Fri, Dec 6, 2:37 PM
kislinsk archived Mint Medical GmbH.
Fri, Dec 6, 2:01 PM
kislinsk committed rMITKb1ef2d248b65: Merge branch 'T26893-GitHubCompatibleLicenseFile' (authored by kislinsk).
Merge branch 'T26893-GitHubCompatibleLicenseFile'
Fri, Dec 6, 1:52 PM
kislinsk committed rMITK385425e1a97f: Make license recognizable by GitHub (authored by kislinsk).
Make license recognizable by GitHub
Fri, Dec 6, 1:51 PM
kislinsk added a comment to T26893: GitHub doesn't recognize our license.

Pushed new branch T26893-GitHubCompatibleLicenseFile.

Fri, Dec 6, 1:51 PM · MITK
kislinsk removed a project from T16153: Jump to center of mass of segmentation on click: Request for Discussion.

We decided in the MITK meeting that is a complex issue regarding UI-integration at other places as soon as you have multi-label segmentations. That's why we propose to keep the functionality at your plugin for the moment.

Fri, Dec 6, 9:57 AM · Bugzilla, MITK
kislinsk removed a project from T26712: DICOM StructuredReport export for planar figures - right place for the contribution: Request for Discussion.
Fri, Dec 6, 9:47 AM · d:cipher, MITK
kislinsk removed a project from T26451: DICOM plugin cannot parse DICOM directories in macOS installer: Request for Discussion.

We came to the conclusion that we need example data to reproduce this issue on our site. Can we arrange a transfer (see above)?

Fri, Dec 6, 9:46 AM · MITK (2018-04-4)

Thu, Dec 5

kislinsk committed rMITKeb0b237d7c3e: Merge branch 'T26888-FixUpBundleWritePermissionsOnMacOS' (authored by kislinsk).
Merge branch 'T26888-FixUpBundleWritePermissionsOnMacOS'
Thu, Dec 5, 1:30 PM
kislinsk committed rMITKe7aa9ff9efc7: Mark bundle items writable before calling install_name_tool (authored by kislinsk).
Mark bundle items writable before calling install_name_tool
Thu, Dec 5, 1:28 PM
kislinsk added a comment to T26888: MITK_BUILD_CONFIGURATION "All" reveals some failing tests on CI build clients.

Pushed new branch T26888-FixUpBundleWritePermissionsOnMacOS.

Thu, Dec 5, 1:28 PM · MITK
kislinsk added a comment to T26897: Build error: Could not find git for clone of qRestAPI.

Maybe Git is not in PATH?

Thu, Dec 5, 10:23 AM · MITK
kislinsk triaged T26893: GitHub doesn't recognize our license as Normal priority.
Thu, Dec 5, 9:13 AM · MITK

Wed, Dec 4

kislinsk committed rMITK78a8dc37f609: Merge branch 'T25256-UnifyLicenseAndCopyright' (authored by kislinsk).
Merge branch 'T25256-UnifyLicenseAndCopyright'
Wed, Dec 4, 11:53 PM
kislinsk committed rMITKce5dc8011723: Unified license text and copyright headers (authored by kislinsk).
Unified license text and copyright headers
Wed, Dec 4, 11:53 PM
kislinsk added a comment to T26501: Patching on windows fails.

This happens on Windows systems with the wrong checkout type for line endings. So not really a bug. We should investigate if the binary option is worth it anyway, as it is currently a big hassle to get patches right in the first place on Windows.

Wed, Dec 4, 11:38 PM · MITK
kislinsk closed T26889: OpenIGTLink does not link on Linux with CMake 3.16 as Wontfix.

Will be fixed in CMake 3.16.1.

Wed, Dec 4, 11:31 PM · MITK
kislinsk added a comment to T25256: MITK license file features "Division of Medical and Biological Informatics".

TODO: rMPT MITK-ProjectTemplate

Wed, Dec 4, 6:41 PM · MITK
kislinsk committed rMITK12e52aeac5c9: Merge branch 'T25256-UnifyLicenseAndCopyright' (authored by kislinsk).
Merge branch 'T25256-UnifyLicenseAndCopyright'
Wed, Dec 4, 6:40 PM
kislinsk committed rMITK1d57ec84fc1d: Unified license text and copyright headers (authored by kislinsk).
Unified license text and copyright headers
Wed, Dec 4, 6:39 PM
kislinsk added a comment to T25256: MITK license file features "Division of Medical and Biological Informatics".

Pushed new branch T25256-UnifyLicenseAndCopyright.

Wed, Dec 4, 6:38 PM · MITK
kislinsk claimed T25256: MITK license file features "Division of Medical and Biological Informatics".
Wed, Dec 4, 5:32 PM · MITK
kislinsk added a comment to T26889: OpenIGTLink does not link on Linux with CMake 3.16.

Found a very recent GItHub issue: https://github.com/openigtlink/OpenIGTLink/issues/218

Wed, Dec 4, 8:29 AM · MITK
kislinsk added a comment to T26889: OpenIGTLink does not link on Linux with CMake 3.16.

A script to easily reproduce the error:

Wed, Dec 4, 7:44 AM · MITK
kislinsk triaged T26889: OpenIGTLink does not link on Linux with CMake 3.16 as Normal priority.
Wed, Dec 4, 6:52 AM · MITK
kislinsk triaged T26888: MITK_BUILD_CONFIGURATION "All" reveals some failing tests on CI build clients as Normal priority.
Wed, Dec 4, 6:27 AM · MITK

Tue, Dec 3

kislinsk closed T26887: Upgrade OpenCV to support Visual Studio 2019 as Resolved.
Tue, Dec 3, 4:32 PM · MITK
kislinsk edited projects for T26887: Upgrade OpenCV to support Visual Studio 2019, added: MITK; removed MITK (2018-04-4).
Tue, Dec 3, 4:21 PM · MITK
kislinsk committed rMITK40e721dba80e: Merge branch 'T26887-OpenCVUpgrade' (authored by kislinsk).
Merge branch 'T26887-OpenCVUpgrade'
Tue, Dec 3, 4:05 PM
kislinsk committed rMITKeb3058d3772a: Upgrade OpenCV from version 3.4.2 to 3.4.8 (authored by kislinsk).
Upgrade OpenCV from version 3.4.2 to 3.4.8
Tue, Dec 3, 4:04 PM
kislinsk added a comment to T26887: Upgrade OpenCV to support Visual Studio 2019.

Pushed new branch T26887-OpenCVUpgrade.

Tue, Dec 3, 4:03 PM · MITK
kislinsk edited projects for T26887: Upgrade OpenCV to support Visual Studio 2019, added: MITK (2018-04-4); removed MITK.
Tue, Dec 3, 3:57 PM · MITK
kislinsk triaged T26887: Upgrade OpenCV to support Visual Studio 2019 as Normal priority.
Tue, Dec 3, 3:49 PM · MITK
kislinsk committed rMITK243727aebfd5: Merge branch 'T26883-TestContinuousBuildJobTriggers' (authored by kislinsk).
Merge branch 'T26883-TestContinuousBuildJobTriggers'
Tue, Dec 3, 1:47 PM
kislinsk committed rMITK28c51b6bc45c: Test continuous build job triggers (authored by kislinsk).
Test continuous build job triggers
Tue, Dec 3, 1:47 PM

Thu, Nov 28

kislinsk raised the priority of T24536: Create more Nightlies with minimum configuration etc. from Wishlist to Normal.
Thu, Nov 28, 1:09 PM · CI, MITK
kislinsk moved T26854: Unattended Qt installation from Backlog to In Progress on the CI board.
Thu, Nov 28, 1:09 PM · CI, Restricted Project, MITK
kislinsk renamed T24536: Create more Nightlies with minimum configuration etc. from Create "stupid" dart client to Create more Nightlies with minimum configuration etc..
Thu, Nov 28, 11:18 AM · CI, MITK
kislinsk claimed T26854: Unattended Qt installation.
Thu, Nov 28, 10:53 AM · CI, Restricted Project, MITK
kislinsk renamed T26854: Unattended Qt installation from Install Qt via command line to Unattended Qt installation.
Thu, Nov 28, 10:53 AM · CI, Restricted Project, MITK
kislinsk added a comment to T26854: Unattended Qt installation.

Currently, the script is unfortunately the only option until Qt 6 possibly introduces package management. BTW, we should create a CI or FS-E scripts repository were I can push my script. Currently I am working on the script to also install the correct Visual Studio runtime on clean clients. Also OpenSSL is included in the latest installers but has to be selected explicitly.

Thu, Nov 28, 10:53 AM · CI, Restricted Project, MITK
kislinsk committed rMITK8cb91ec4fd2b: Update minimum required Qt version in documentation (authored by kislinsk).
Update minimum required Qt version in documentation
Thu, Nov 28, 8:52 AM

Tue, Nov 26

kislinsk triaged T26853: IGT tutorial step 1 and step 2 do not start as High priority.
Tue, Nov 26, 5:12 PM · IGT, MITK

Mon, Nov 25

kislinsk created HiGHmed.
Mon, Nov 25, 10:16 PM
kislinsk created HAF.
Mon, Nov 25, 10:14 PM
kislinsk committed rMITK5d54e493202e: Merge remote-tracking branch 'origin/T26849-NoContinuousPolling' (authored by kislinsk).
Merge remote-tracking branch 'origin/T26849-NoContinuousPolling'
Mon, Nov 25, 2:34 PM
kislinsk committed rMITK0d10d51858bb: Merge branch 'T26849-NoContinuousPolling' into releases/2018-04 (authored by kislinsk).
Merge branch 'T26849-NoContinuousPolling' into releases/2018-04
Mon, Nov 25, 2:33 PM
kislinsk committed rMITK36eb5a6ccfb7: Disable SCM polling in continuous mode (authored by kislinsk).
Disable SCM polling in continuous mode
Mon, Nov 25, 2:32 PM
kislinsk added a comment to T26849: Remove polling loop from continuous CDash scripts.

Pushed new branch T26849-NoContinuousPolling.

Mon, Nov 25, 2:32 PM · CI, MITK (2018-04-4)
kislinsk triaged T26849: Remove polling loop from continuous CDash scripts as Normal priority.
Mon, Nov 25, 2:31 PM · CI, MITK (2018-04-4)
kislinsk closed T26845: Remove old ProjectTemplate tests as Resolved.

I also made MITK_FAST_TESTING available as advanced superbuild option.

Mon, Nov 25, 10:33 AM · MITK (2018-04-4)
kislinsk committed rMITK045f03221f1a: Merge remote-tracking branch 'origin/T26845-RemoveProjectTemplateTests' (authored by kislinsk).
Merge remote-tracking branch 'origin/T26845-RemoveProjectTemplateTests'
Mon, Nov 25, 10:31 AM
kislinsk committed rMITK5d558f63c621: Merge branch 'T26845-RemoveProjectTemplateTests' into releases/2018-04 (authored by kislinsk).
Merge branch 'T26845-RemoveProjectTemplateTests' into releases/2018-04
Mon, Nov 25, 10:30 AM
kislinsk committed rMITK0dc5ae9cf856: Make MITK_FAST_TESTING available as advanced option (authored by kislinsk).
Make MITK_FAST_TESTING available as advanced option
Mon, Nov 25, 10:29 AM
kislinsk committed rMITK2a05d0d4e062: Remove old ProjectTemplate tests (authored by kislinsk).
Remove old ProjectTemplate tests
Mon, Nov 25, 10:19 AM
kislinsk added a comment to T26845: Remove old ProjectTemplate tests.

Pushed new branch T26845-RemoveProjectTemplateTests.

Mon, Nov 25, 10:19 AM · MITK (2018-04-4)
kislinsk triaged T26845: Remove old ProjectTemplate tests as Normal priority.
Mon, Nov 25, 10:17 AM · MITK (2018-04-4)

Fri, Nov 22

kislinsk committed rMITK61e73e57d4be: Update minimum required Qt version in documentation (authored by kislinsk).
Update minimum required Qt version in documentation
Fri, Nov 22, 9:35 AM

Thu, Nov 21

kislinsk committed rMITKf84a9cbb3768: Merge branch 'T26752-Boost-RPATH-2' (authored by kislinsk).
Merge branch 'T26752-Boost-RPATH-2'
Thu, Nov 21, 1:51 PM
kislinsk committed rMITKa24f3f773eed: Fix dependencies between Boost dylibs (authored by kislinsk).
Fix dependencies between Boost dylibs
Thu, Nov 21, 1:50 PM
kislinsk added a comment to T26752: [macOS] Make Boost libraries use RPATH.

Pushed new branch T26752-Boost-RPATH-2.

Thu, Nov 21, 1:50 PM · MITK
kislinsk triaged T26837: Create preference for anti-aliasing as Wishlist priority.
Thu, Nov 21, 1:35 PM · MITK
kislinsk closed T26815: New multi render window widget architecture breaks rendering mode handling as Resolved.
Thu, Nov 21, 1:34 PM · Noteworthy, MITK
kislinsk committed rMITK7b0736a0dcd7: Merge branch 'T26815-Fixes' (authored by kislinsk).
Merge branch 'T26815-Fixes'
Thu, Nov 21, 12:48 PM
kislinsk committed rMITK99152957745e: Remove unused parameter names (authored by kislinsk).
Remove unused parameter names
Thu, Nov 21, 12:48 PM
kislinsk added a comment to T26815: New multi render window widget architecture breaks rendering mode handling.

Pushed new branch T26815-Fixes.

Thu, Nov 21, 12:47 PM · Noteworthy, MITK
kislinsk committed rMITK7d3e2a1aafa3: Remove RenderingManager parameters and RenderingMode (authored by kislinsk).
Remove RenderingManager parameters and RenderingMode
Thu, Nov 21, 12:28 PM
kislinsk closed T26701: Build errors with Python 3.7 and latest gcc as Resolved.
Thu, Nov 21, 9:22 AM · MITK

Wed, Nov 20

kislinsk updated jenkins.
Wed, Nov 20, 9:21 AM

Tue, Nov 19

kislinsk added a revision to T26815: New multi render window widget architecture breaks rendering mode handling: Unknown Object (Differential Revision).
Tue, Nov 19, 2:58 PM · Noteworthy, MITK
kislinsk updated jenkins.
Tue, Nov 19, 9:29 AM

Fri, Nov 15

kislinsk added a comment to T26815: New multi render window widget architecture breaks rendering mode handling.
  • Remove any mitk::RenderingManager and mitk::BaseRenderer::RenderingMode::Type parameters from function calls that generate corresponding compiler errors
  • Unify access to the rendering manager by always using the static method mitk::RenderingManager::GetInstance()
Fri, Nov 15, 5:14 PM · Noteworthy, MITK
kislinsk committed rMITK5e0e87c36865: Handle RenderingManager like the singleton it is (authored by kislinsk).
Handle RenderingManager like the singleton it is
Fri, Nov 15, 5:08 PM
kislinsk committed rMITKc348fdb4d8c8: Set default rendering mode to FXAA (authored by kislinsk).
Set default rendering mode to FXAA
Fri, Nov 15, 5:08 PM
kislinsk committed rMITKa2a69caf2013: Merge remote-tracking branch 'origin/T26811-RenderingModePreference' into… (authored by kislinsk).
Merge remote-tracking branch 'origin/T26811-RenderingModePreference' into…
Fri, Nov 15, 5:08 PM
kislinsk added a comment to T26815: New multi render window widget architecture breaks rendering mode handling.

Pushed new branch T26815-RemovePassingOfRenderingManagerAsParameter.

Fri, Nov 15, 5:08 PM · Noteworthy, MITK
kislinsk added a comment to T26815: New multi render window widget architecture breaks rendering mode handling.

Thanks for the comments. The rendering manager is already designed to be a singleton and only a singleton. There's flexibilty in terms of a rendering manager factory that is used to determine the actual implementation of a rendering manager (like the QmitkRenderingManager) but still a singleton one. So I think we would not loose anything with the new approach compared to the current situation. I even think that the rendering manager should stay a singleton in the future as it is kind of a bridge to VTK and at the end of the day to the single OpenGL context of the application despite all the possible renderers (sharing that context). Calling RequestUpdateAll() all over the place is a caller issue anyway in my opinion and not a callee issue. If this should ever be a relevant performance issue with multiple editors, we could check if we really need to update specific render windows based on their visibility, if we're not already doing this.

Fri, Nov 15, 12:14 AM · Noteworthy, MITK

Thu, Nov 14

kislinsk updated the task description for T26815: New multi render window widget architecture breaks rendering mode handling.
Thu, Nov 14, 5:01 PM · Noteworthy, MITK
kislinsk triaged T26815: New multi render window widget architecture breaks rendering mode handling as Normal priority.
Thu, Nov 14, 4:58 PM · Noteworthy, MITK
kislinsk created T26815: New multi render window widget architecture breaks rendering mode handling.
Thu, Nov 14, 4:58 PM · Noteworthy, MITK
kislinsk closed T26811: Default preferences do not work as expected as Resolved.
Thu, Nov 14, 4:25 PM · MITK (2018-04-4)
kislinsk committed rMITK848604959b86: Merge branch 'T26811-RenderingModePreference' into releases/2018-04 (authored by kislinsk).
Merge branch 'T26811-RenderingModePreference' into releases/2018-04
Thu, Nov 14, 3:31 PM
kislinsk committed rMITK20ecc5df4581: Sync rendering mode preference with actual rendering mode (authored by kislinsk).
Sync rendering mode preference with actual rendering mode
Thu, Nov 14, 3:30 PM
kislinsk added a comment to T26811: Default preferences do not work as expected.

Pushed new branch T26811-RenderingModePreference.

Thu, Nov 14, 3:30 PM · MITK (2018-04-4)
kislinsk claimed T26811: Default preferences do not work as expected.
Thu, Nov 14, 3:25 PM · MITK (2018-04-4)

Wed, Nov 13

kislinsk triaged T26811: Default preferences do not work as expected as Normal priority.
Wed, Nov 13, 3:03 PM · MITK (2018-04-4)
kislinsk committed rMDba22141a1dba: Update reference screenshots for dual depth peeling (authored by kislinsk).
Update reference screenshots for dual depth peeling
Wed, Nov 13, 2:24 PM
kislinsk committed rMITKc6a443f12af4: Merge branch 'T26653-MasterIntegrationFixes' (authored by kislinsk).
Merge branch 'T26653-MasterIntegrationFixes'
Wed, Nov 13, 2:08 PM
kislinsk committed rMITK41b49b3ca47c: Replace RenderingMode::Standard by FastApproximateAntiAliasing (authored by kislinsk).
Replace RenderingMode::Standard by FastApproximateAntiAliasing
Wed, Nov 13, 2:07 PM
kislinsk added a comment to T26653: Github pull request 263 (Forward vtkInformation objects to MITK mappers - allow for VTK depth peeling).

Pushed new branch T26653-MasterIntegrationFixes.

Wed, Nov 13, 2:07 PM · MITK (2018-04-4), Noteworthy, Pull Request
kislinsk closed T26653: Github pull request 263 (Forward vtkInformation objects to MITK mappers - allow for VTK depth peeling) as Resolved.
Wed, Nov 13, 1:12 PM · MITK (2018-04-4), Noteworthy, Pull Request
kislinsk committed rMITK1a024cf7b34a: Merge remote-tracking branch 'origin/releases/2018-04' (authored by kislinsk).
Merge remote-tracking branch 'origin/releases/2018-04'
Wed, Nov 13, 1:02 PM
kislinsk committed rMITKa140adda1005: Merge branch 'T26653-ReenableDepthPeeling' into releases/2018-04 (authored by kislinsk).
Merge branch 'T26653-ReenableDepthPeeling' into releases/2018-04
Wed, Nov 13, 12:45 PM