Page MenuHomePhabricator

kislinsk (Stefan Dinkelacker)
UserAdministrator

Projects (14)

User Details

User Since
Aug 1 2016, 11:50 AM (186 w, 19 h)
Roles
Administrator

Recent Activity

Yesterday

kislinsk created Python Ontology Populator.
Mon, Feb 24, 2:05 PM
kislinsk closed T27135: Disable precompiled headers in OpenCV as Resolved.
Mon, Feb 24, 10:01 AM · MITK
kislinsk committed rMITK41f1350d6201: Merge remote-tracking branch 'origin/T27135-DisablePrecompiledHeadersInOpenCV' (authored by kislinsk).
Merge remote-tracking branch 'origin/T27135-DisablePrecompiledHeadersInOpenCV'
Mon, Feb 24, 10:00 AM
kislinsk triaged T27152: BlueBerry CustomViewer (Spartan Viewer) not migrated to new CTK version as Normal priority.
Mon, Feb 24, 9:00 AM · MITK

Sun, Feb 16

kislinsk closed T27137: Check why package target on OpenStack Linux instances fail as Resolved.

Works.

Sun, Feb 16, 9:07 PM · CI
kislinsk added a comment to T27137: Check why package target on OpenStack Linux instances fail.

sudo apt install libxcomposite1 libxcursor1

Sun, Feb 16, 9:00 PM · CI
kislinsk added a comment to T27137: Check why package target on OpenStack Linux instances fail.
Analyzed prerequisites of /home/ubuntu/jenkins-agent/workspace/MITK/Nightly/Linux/build/MITK-build/_CPack_Packages/Linux/TGZ/MITK-experiments/sDMAS-2018.07-2899-g1ea959aa27-linux-x86_64/bin/MitkCLVoxelFeatures
verified='0'
info='external prerequisites found:
f='/home/ubuntu/jenkins-agent/workspace/MITK/Nightly/Linux/build/MITK-build/_CPack_Packages/Linux/TGZ/MITK-experiments/sDMAS-2018.07-2899-g1ea959aa27-linux-x86_64/bin/QtWebEngineProcess'
external_prereqs='libXcomposite.so.1;libXcursor.so.1'
'
Sun, Feb 16, 8:57 PM · CI
kislinsk triaged T27137: Check why package target on OpenStack Linux instances fail as Normal priority.
Sun, Feb 16, 8:54 PM · CI

Sat, Feb 15

kislinsk added a revision to T27135: Disable precompiled headers in OpenCV: Unknown Object (Differential Revision).
Sat, Feb 15, 8:24 AM · MITK
kislinsk committed rMITK764873c9e8a3: Disable precompiled headers in OpenCV (authored by kislinsk).
Disable precompiled headers in OpenCV
Sat, Feb 15, 8:14 AM
kislinsk added a comment to T27135: Disable precompiled headers in OpenCV.

Pushed new branch T27135-DisablePrecompiledHeadersInOpenCV.

Sat, Feb 15, 8:14 AM · MITK
kislinsk triaged T27135: Disable precompiled headers in OpenCV as Normal priority.
Sat, Feb 15, 8:08 AM · MITK

Fri, Feb 14

kislinsk added a comment to T27069: OpenGL error / crash when opening context menu.

Yes. This solved the problem. Still do not understand why only LabelSetImages where that problematic, but thanks for having a look. The second pair of eyes really helped.

Fri, Feb 14, 10:51 PM · MITK
kislinsk added a comment to T27069: OpenGL error / crash when opening context menu.

The fix is to replace the calls of repaint() with update() in QmitkNodeSelectionButton.cpp. More info: https://doc.qt.io/qt-5/qwidget.html#repaint

Fri, Feb 14, 5:35 PM · MITK
kislinsk added a comment to T27069: OpenGL error / crash when opening context menu.

I deactivated FXAA in the RenderingManager and BaseRenderer and while the error output is still the same, the crash doesn't happen anymore. Instead, one of the four render windows is black until it is redrawn for example by clicking in it.

Fri, Feb 14, 2:16 PM · MITK
kislinsk added a comment to T27069: OpenGL error / crash when opening context menu.

Did a first test on my PC and the exception is thrown from the Nvidia OpenGL driver (nvoglv64.dll) because of a null pointer access. So whatever causes it to happen, there is at least also a bug in the driver.

Fri, Feb 14, 2:03 PM · MITK
kislinsk renamed T27131: Should we refactor or deprecate QmitkDataSelectionWidget? from Should we refactor or depricate QmitkDataSelectionWidget? to Should we refactor or deprecate QmitkDataSelectionWidget?.
Fri, Feb 14, 12:52 PM · Request for Discussion, MITK
kislinsk closed T27130: Remove Qt variables from Dashboard scripts as Resolved.
Fri, Feb 14, 12:36 PM · Noteworthy, CI, MITK
kislinsk committed rMITKa8f8c174c509: Merge branch 'T27130-RemoveQtVariablesFromDashboardScripts' (authored by kislinsk).
Merge branch 'T27130-RemoveQtVariablesFromDashboardScripts'
Fri, Feb 14, 12:19 PM
kislinsk committed rMITK4e1a1ebf6b32: Remove Qt variables from dashboard scripts (authored by kislinsk).
Remove Qt variables from dashboard scripts
Fri, Feb 14, 10:39 AM
kislinsk added a comment to T27130: Remove Qt variables from Dashboard scripts.

Pushed new branch T27130-RemoveQtVariablesFromDashboardScripts.

Fri, Feb 14, 10:39 AM · Noteworthy, CI, MITK
kislinsk triaged T27130: Remove Qt variables from Dashboard scripts as High priority.
Fri, Feb 14, 10:32 AM · Noteworthy, CI, MITK
kislinsk closed T27076: [CTK] QT designer plugins are not built anymore and cause problems in command line module as Resolved.
Fri, Feb 14, 9:58 AM · MITK
kislinsk committed rMITK80dbfaa2f89b: Merge remote-tracking branch 'origin/T27076-ChangeDesignerBuildFlagToDefault' (authored by kislinsk).
Merge remote-tracking branch 'origin/T27076-ChangeDesignerBuildFlagToDefault'
Fri, Feb 14, 9:57 AM
kislinsk moved T27016: Use OpenStack for our CI system from Restricted Project Column to Restricted Project Column on the Restricted Project board.

Then let's wait until we talked to the Openstack admins regarding Windows instances. If we can have them in the same Openstack project, resource requirements change anyway. If we cannot have them in the same project, we may just want to increase RAM to 160 GB to have 10 Linux build clients.

Fri, Feb 14, 6:41 AM · Restricted Project, CI
kislinsk updated the task description for T27033: Clean up stale remote branches.
Fri, Feb 14, 6:29 AM · MITK

Thu, Feb 13

kislinsk added a comment to T27016: Use OpenStack for our CI system.

Was able to (probably) completely provision Ubuntu 18.04 instances for MITK builds with a cloud-config file.

Thu, Feb 13, 6:50 PM · Restricted Project, CI

Wed, Feb 12

kislinsk renamed T27122: PlanarFigureMaskGenerator::GetPrincipalAxis() is too pedantic from PlanarFigureMaskGenerator::GetPrincipalAxis() is to pedantic to PlanarFigureMaskGenerator::GetPrincipalAxis() is too pedantic.
Wed, Feb 12, 6:40 PM · MITK
kislinsk moved T27016: Use OpenStack for our CI system from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Feb 12, 3:50 PM · Restricted Project, CI
kislinsk moved T27016: Use OpenStack for our CI system from Backlog to In Progress on the CI board.
Wed, Feb 12, 3:49 PM · Restricted Project, CI
kislinsk claimed T27016: Use OpenStack for our CI system.
Wed, Feb 12, 3:49 PM · Restricted Project, CI
kislinsk added a comment to T27016: Use OpenStack for our CI system.

Was able to successfully connect an OpenStack Ubuntu 18.04 to Jenkins via SSH. Currently writing a cloud-config file to provision the instances for MITK.

Wed, Feb 12, 3:49 PM · Restricted Project, CI
kislinsk added a comment to T27120: Remove old deprecated property names of DICOM information.

FYI: When changing/removing properties there's always the chance that old mitk scene files are suddenly incompatible as properties are stored in them. If that's an issue, property aliases may be a solution for a legacy mapping between property names.

Wed, Feb 12, 1:29 PM · Request for Discussion, MITK

Tue, Feb 11

kislinsk archived MITK (2018-04-4).
Tue, Feb 11, 4:39 PM
kislinsk triaged T27087: Remove Autoload-Modul-Workarround in the FixMacOS script as Normal priority.
Tue, Feb 11, 7:18 AM · MITK

Mon, Feb 10

kislinsk added a comment to T27084: Clean up, improve and test PluginGenerator, ProjectTemplate and MITK_EXTENSION_DIRS mechanism.
  • I would like to see the plugin generator loosing complexity by removing its project template capabilities
  • The current approach is https://github.com/MITK/MITK-ProjectTemplate
  • The project template is based on the last release, resp. releases/2018-04
  • The project template is an MITK extension
  • MITK extensions can be easily set in a recent version of our CDash script
  • To test the project template, we need separate build clients based on the last release instead of master, no specific test has to be executed (see bullet point above)
  • A few tests are currently not executed because I removed CTest subproject labels for testing purposes and I forgot to reintroduce them
  • Instead of simply adding them again, I vote for a better label than "MITK" or "MITK-Plugins" like "MITK-Packaging"
Mon, Feb 10, 1:15 PM · Request for Discussion, MITK
kislinsk closed T27082: Merge RectifyImage app as Resolved.
Mon, Feb 10, 10:57 AM · MITK
kislinsk committed rMITKe953353b75e1: Merge branch 'T27082-RectifyImageApp' (authored by kislinsk).
Merge branch 'T27082-RectifyImageApp'
Mon, Feb 10, 10:57 AM
kislinsk committed rMITK52b13dde4b88: Move RectifyImage app to BasicImageProcessing (authored by kislinsk).
Move RectifyImage app to BasicImageProcessing
Mon, Feb 10, 10:57 AM
kislinsk committed rMITKbedf7d7a68a3: Merge remote-tracking branch 'origin/personal/kislinsk/RectifyImage' into… (authored by kislinsk).
Merge remote-tracking branch 'origin/personal/kislinsk/RectifyImage' into…
Mon, Feb 10, 10:57 AM
kislinsk added a comment to T27082: Merge RectifyImage app.

Pushed new branch T27082-RectifyImageApp.

Mon, Feb 10, 10:57 AM · MITK
kislinsk added a comment to T27082: Merge RectifyImage app.

It's an experimental app that already helped us to load some images that otherwise were flipped or oriented the wrong way. Probably does not work with oblique images. I'll move the app to the BasicImageProcessing module.

Mon, Feb 10, 9:46 AM · MITK
kislinsk triaged T27082: Merge RectifyImage app as Wishlist priority.
Mon, Feb 10, 7:27 AM · MITK
kislinsk closed T22289: Optionally allow to clone as many external dependencies as possible instead of downloading their tarballs as Wontfix.
Mon, Feb 10, 6:48 AM · MITK
kislinsk closed T24080: Write visual debugging utilitiy for inspecting geometries as Wontfix.
Mon, Feb 10, 6:42 AM · MITK
kislinsk closed T24080: Write visual debugging utilitiy for inspecting geometries, a subtask of T24071: Revisit 2-d image rendering, as Wontfix.
Mon, Feb 10, 6:42 AM · MITK

Fri, Feb 7

kislinsk lowered the priority of T27077: Planar figure reader not available anymore before opening a Quantification view from High to Normal.
Fri, Feb 7, 2:59 PM · MITK
kislinsk triaged T27078: Workbench crashes if statistics are computed with a double ellipse with equal diameter as High priority.
Fri, Feb 7, 2:46 PM · MITK
kislinsk triaged T27077: Planar figure reader not available anymore before opening a Quantification view as High priority.
Fri, Feb 7, 2:41 PM · MITK
kislinsk accepted rMITKf72f4d871b1e: Correct path.

Oops, meant to comment on the Differential, not on this commit. See D240 instead.

Fri, Feb 7, 10:05 AM
kislinsk awarded T27038: Allow CTest subprojects definition in MITK extensions a Hungry Hippo token.
Fri, Feb 7, 10:02 AM · Noteworthy, MITK
kislinsk raised a concern with rMITKf72f4d871b1e: Correct path.
Fri, Feb 7, 10:01 AM
kislinsk added a comment to T27061: Planar figures crash if drawn with empty data storage.

Here's a screenshot from the last release. All the tools are deactivated as long as there isn't any visible object.

Fri, Feb 7, 9:05 AM · MITK
kislinsk triaged T27061: Planar figures crash if drawn with empty data storage as Normal priority.

While there should be a nullptr check I guess, this is another regression in the first place as it wasn't possible with the Measurement view to draw with an empty storage until recently. Is this possibly related to your work on selections?

Fri, Feb 7, 9:03 AM · MITK
kislinsk triaged T27050: Crash with planar figures and stastics/measurement as High priority.
Fri, Feb 7, 8:52 AM · Restricted Project, MITK
kislinsk triaged T27003: Extend representation object handling in NavigationDataObjectVisualizationFilter as Wishlist priority.
Fri, Feb 7, 8:44 AM · MITK, Restricted Project

Mon, Feb 3

kislinsk added a comment to T27022: CTest returns error code if subproject does not have tests.

Merged! 🎉 Will be available in CMake 3.17.

Mon, Feb 3, 9:14 PM · CI, MITK

Sat, Feb 1

kislinsk renamed T27024: Fix PhotoacousticsLib mitkSpectralUnmixingTest and mitkPhotoacousticVolumeTest from Fix PhotoacousticsLib mitkSpectralUnmixingTest to Fix PhotoacousticsLib mitkSpectralUnmixingTest and mitkPhotoacousticVolumeTest.
Sat, Feb 1, 3:08 PM · MITK
kislinsk committed rMITK88ba8587edc7: Merge branch 'T27024-FixVolumeTest' (authored by kislinsk).
Merge branch 'T27024-FixVolumeTest'
Sat, Feb 1, 3:06 PM
kislinsk committed rMITK5c734ceabe81: Disable randomly failing test (authored by kislinsk).
Disable randomly failing test
Sat, Feb 1, 3:06 PM
kislinsk added a comment to T27024: Fix PhotoacousticsLib mitkSpectralUnmixingTest and mitkPhotoacousticVolumeTest.

Pushed new branch T27024-FixVolumeTest.

Sat, Feb 1, 3:05 PM · MITK

Fri, Jan 31

kislinsk closed T27042: Short-range plan to prevent Differentials from unnecessarily building the superbuild as Resolved.
Fri, Jan 31, 3:15 PM · Noteworthy, Restricted Project, CI, MITK
kislinsk committed rMITK96923a079f6f: Merge branch 'T27042-AutocleanExternalProjects' (authored by kislinsk).
Merge branch 'T27042-AutocleanExternalProjects'
Fri, Jan 31, 1:59 PM
kislinsk committed rMITKca3c891e09b4: Glob Unix binaries with lib prefix (authored by kislinsk).
Glob Unix binaries with lib prefix
Fri, Jan 31, 1:59 PM
kislinsk added a project to T27042: Short-range plan to prevent Differentials from unnecessarily building the superbuild: Noteworthy.
Fri, Jan 31, 1:33 PM · Noteworthy, Restricted Project, CI, MITK
kislinsk added a comment to T27042: Short-range plan to prevent Differentials from unnecessarily building the superbuild.

I activated MITK_AUTOCLEAN_EXTERNAL_PROJECTS on Differential and Continuous jobs. Fingers crossed.

Fri, Jan 31, 1:27 PM · Noteworthy, Restricted Project, CI, MITK
kislinsk committed rMITK08c4886e4d4d: Merge branch 'T27042-AutocleanExternalProjects' (authored by kislinsk).
Merge branch 'T27042-AutocleanExternalProjects'
Fri, Jan 31, 12:50 PM
kislinsk committed rMITKea003216477e: Create install manifest for Boost (authored by kislinsk).
Create install manifest for Boost
Fri, Jan 31, 12:44 PM
kislinsk committed rMITK253abe403cee: Introduce experimental auto-cleaning of updated external projects (authored by kislinsk).
Introduce experimental auto-cleaning of updated external projects
Fri, Jan 31, 8:12 AM
kislinsk added a comment to T27042: Short-range plan to prevent Differentials from unnecessarily building the superbuild.

Pushed new branch T27042-AutocleanExternalProjects.

Fri, Jan 31, 8:11 AM · Noteworthy, Restricted Project, CI, MITK

Thu, Jan 30

kislinsk added a comment to T27042: Short-range plan to prevent Differentials from unnecessarily building the superbuild.

I just thought about it could be a good idea to actually do this in our CMake script right in MITK. We can check all sorts of things there before and after external project processing.

Thu, Jan 30, 9:30 AM · Noteworthy, Restricted Project, CI, MITK
kislinsk added a comment to T26980: MITK_CREATE_MACRO should prohibit dependencies against autoload modules.

@kislinsk You mentioned that we should do something as soon as the (wrong) autload dependencies are gone. I cannot remember what, do you? May be some work arround in our packaging code due to the autoload modules?

Thu, Jan 30, 9:26 AM · MITK, Noteworthy

Wed, Jan 29

kislinsk added a comment to T27042: Short-range plan to prevent Differentials from unnecessarily building the superbuild.

Possibly useful Jenkins plugins:

Wed, Jan 29, 5:38 PM · Noteworthy, Restricted Project, CI, MITK
kislinsk added a comment to T27042: Short-range plan to prevent Differentials from unnecessarily building the superbuild.

We also have the possibility to modify the Herald rule that triggers the jobs. For example, if the revision summary contains a certain keyword, trigger a complete rebuild instead of an incremental build. Two disadventages are: Revision creators have to be aware of this possibility, and this is not enough as there may be also some other changes on the master branch since the last build on the build client that affect critical files.

Wed, Jan 29, 5:28 PM · Noteworthy, Restricted Project, CI, MITK
kislinsk added a comment to T27042: Short-range plan to prevent Differentials from unnecessarily building the superbuild.

Possible entry points in Jenkions job configuration:

Wed, Jan 29, 4:48 PM · Noteworthy, Restricted Project, CI, MITK
kislinsk updated the task description for T27042: Short-range plan to prevent Differentials from unnecessarily building the superbuild.
Wed, Jan 29, 4:05 PM · Noteworthy, Restricted Project, CI, MITK
kislinsk updated the task description for T27042: Short-range plan to prevent Differentials from unnecessarily building the superbuild.
Wed, Jan 29, 4:05 PM · Noteworthy, Restricted Project, CI, MITK
kislinsk triaged T27042: Short-range plan to prevent Differentials from unnecessarily building the superbuild as High priority.
Wed, Jan 29, 4:04 PM · Noteworthy, Restricted Project, CI, MITK
kislinsk closed T27041: Allow to override MITK_REVISION_DESC as Resolved.
Wed, Jan 29, 3:53 PM · Noteworthy, MITK
kislinsk committed rMITK9ae73cc0c121: Merge branch 'T27041-MITK_CUSTOM_REVISION_DESC' (authored by kislinsk).
Merge branch 'T27041-MITK_CUSTOM_REVISION_DESC'
Wed, Jan 29, 3:47 PM
kislinsk committed rMITKde615c842e0c: Add MITK_CUSTOM_REVISION_DESC cache variable (authored by kislinsk).
Add MITK_CUSTOM_REVISION_DESC cache variable
Wed, Jan 29, 3:47 PM
kislinsk added a comment to T27041: Allow to override MITK_REVISION_DESC.

Pushed new branch T27041-MITK_CUSTOM_REVISION_DESC.

Wed, Jan 29, 3:46 PM · Noteworthy, MITK
kislinsk added a project to T27038: Allow CTest subprojects definition in MITK extensions: Noteworthy.
Wed, Jan 29, 3:39 PM · Noteworthy, MITK
kislinsk added a project to T27041: Allow to override MITK_REVISION_DESC: Noteworthy.
Wed, Jan 29, 3:39 PM · Noteworthy, MITK
kislinsk triaged T27041: Allow to override MITK_REVISION_DESC as Normal priority.
Wed, Jan 29, 3:39 PM · Noteworthy, MITK
kislinsk added a comment to T27033: Clean up stale remote branches.

I'm creating a more detailed list of unmerged remote branches in CSV format with the following script:

Wed, Jan 29, 2:43 PM · MITK

Tue, Jan 28

kislinsk committed rMITKf3e457a7114e: Merge branch 'T27038-CTestSubprojectsInExtensions' (authored by kislinsk).
Merge branch 'T27038-CTestSubprojectsInExtensions'
Tue, Jan 28, 3:41 PM
kislinsk closed T27038: Allow CTest subprojects definition in MITK extensions as Resolved.
Tue, Jan 28, 3:41 PM · Noteworthy, MITK
kislinsk committed rMITK2f3c95e35fc6: Enable MITK extensions to add CTest subprojects (authored by kislinsk).
Enable MITK extensions to add CTest subprojects
Tue, Jan 28, 3:41 PM
kislinsk added a comment to T27038: Allow CTest subprojects definition in MITK extensions.

Pushed new branch T27038-CTestSubprojectsInExtensions.

Tue, Jan 28, 3:40 PM · Noteworthy, MITK
kislinsk triaged T27038: Allow CTest subprojects definition in MITK extensions as Low priority.
Tue, Jan 28, 3:36 PM · Noteworthy, MITK
kislinsk closed T27037: Clean up unused components as Resolved.
Tue, Jan 28, 1:51 PM · MITK
kislinsk closed T27025: Fix documentation warnings as Resolved.
Tue, Jan 28, 10:07 AM · MITK
kislinsk committed rMITK8d4413858655: Merge branch 'T27025-FixDocumentationWarnings' (authored by kislinsk).
Merge branch 'T27025-FixDocumentationWarnings'
Tue, Jan 28, 10:06 AM
kislinsk committed rMITKa3856f4ac9f0: Fix various links (authored by kislinsk).
Fix various links
Tue, Jan 28, 9:10 AM
kislinsk committed rMITKc79ca3162c0f: Merge branch 'T27037-CleanUpUnusedComponents' (authored by kislinsk).
Merge branch 'T27037-CleanUpUnusedComponents'
Tue, Jan 28, 8:05 AM
kislinsk committed rMITK993ae654dc68: Update repository URL (authored by kislinsk).
Update repository URL
Tue, Jan 28, 8:04 AM
kislinsk committed rMITK89f617963a8d: Remove disabled Solstice application (authored by kislinsk).
Remove disabled Solstice application
Tue, Jan 28, 8:04 AM
kislinsk committed rMITKbcdbf62ed302: Remove unused MitkCoreApp (authored by kislinsk).
Remove unused MitkCoreApp
Tue, Jan 28, 8:04 AM
kislinsk committed rMITKc4259970fab3: Remove disabled TumorInvasionAnalysis module (authored by kislinsk).
Remove disabled TumorInvasionAnalysis module
Tue, Jan 28, 8:04 AM