Page MenuHomePhabricator

kislinsk (Stefan Dinkelacker)
UserAdministrator

Projects (15)

User Details

User Since
Aug 1 2016, 11:50 AM (167 w, 6 d)
Roles
Administrator

Recent Activity

Thu, Oct 17

kislinsk placed T26721: Prepare Qt 5.13 compatibility up for grabs.
Thu, Oct 17, 11:13 AM · MITK
kislinsk added a comment to T26721: Prepare Qt 5.13 compatibility.

Status as of now:

Thu, Oct 17, 11:13 AM · MITK
kislinsk committed rMITKc556e27481e6: Merge branch 'T26721-Qt-5.12' (authored by kislinsk).
Merge branch 'T26721-Qt-5.12'
Thu, Oct 17, 11:09 AM
kislinsk committed rMITK813e0bf26539: Merge branch 'releases/2018-04' (authored by kislinsk).
Merge branch 'releases/2018-04'
Thu, Oct 17, 11:08 AM
kislinsk committed rMITKe24e19794d8c: Set Qt 5.12 as minimum required version (authored by kislinsk).
Set Qt 5.12 as minimum required version
Thu, Oct 17, 11:05 AM
kislinsk committed rMITK964b9d8b0578: Merge branch 'releases/2018-04' (authored by kislinsk).
Merge branch 'releases/2018-04'
Thu, Oct 17, 11:05 AM
kislinsk added a comment to T26721: Prepare Qt 5.13 compatibility.

Pushed new branch T26721-Qt-5.12.

Thu, Oct 17, 11:05 AM · MITK
kislinsk committed rMITKc74351aa4e91: Set Qt 5.12 as maximum supported version (authored by kislinsk).
Set Qt 5.12 as maximum supported version
Thu, Oct 17, 10:58 AM
kislinsk added a comment to T26721: Prepare Qt 5.13 compatibility.

For now we should stick with the Qt 5.12 LTS, as long as 5.13 does not work reliably (see Windows issue above). We can add a CMake warning/error for now that does not allow to proceed configuring MITK with Qt > 5.12.

Thu, Oct 17, 10:34 AM · MITK
kislinsk reassigned T26756: Adapt to mitkFunctionCreateBlueBerryApplication changes from kislinsk to neher.
Thu, Oct 17, 10:30 AM · MITK Diffusion
kislinsk triaged T26745: MITK's interaction not the first to handle events anymore -- QVTKOpenGLWidget::event() changed since VTK 7.0.0 (MITK 2016.11) as High priority.
Thu, Oct 17, 9:27 AM · MITK (2018-04-4), Pull Request
kislinsk edited projects for T26745: MITK's interaction not the first to handle events anymore -- QVTKOpenGLWidget::event() changed since VTK 7.0.0 (MITK 2016.11), added: MITK (2018-04-4); removed MITK.
Thu, Oct 17, 9:27 AM · MITK (2018-04-4), Pull Request
kislinsk claimed T26745: MITK's interaction not the first to handle events anymore -- QVTKOpenGLWidget::event() changed since VTK 7.0.0 (MITK 2016.11).
Thu, Oct 17, 9:27 AM · MITK (2018-04-4), Pull Request
kislinsk added a project to T26745: MITK's interaction not the first to handle events anymore -- QVTKOpenGLWidget::event() changed since VTK 7.0.0 (MITK 2016.11): Pull Request.
Thu, Oct 17, 9:18 AM · MITK (2018-04-4), Pull Request
kislinsk added a comment to T26756: Adapt to mitkFunctionCreateBlueBerryApplication changes.

Look at your nightlies. This is the fix. You're the only one allowed to merge into the master branch of MITK-Diffusion.

Thu, Oct 17, 9:17 AM · MITK Diffusion

Wed, Oct 16

kislinsk closed T23293: Apply C++ 11 modernizations as Resolved.
Wed, Oct 16, 2:03 PM · MITK
kislinsk committed rMITK029a4ba313e1: Modernize usage of auto keyword with clang-tidy (authored by kislinsk).
Modernize usage of auto keyword with clang-tidy
Wed, Oct 16, 1:54 PM
kislinsk added a comment to T23293: Apply C++ 11 modernizations.
Wed, Oct 16, 1:53 PM · MITK
kislinsk committed rMITK43319a16964c: Merge branch 'T23293-nullptr' (authored by kislinsk).
Merge branch 'T23293-nullptr'
Wed, Oct 16, 1:30 PM
kislinsk committed rMITKe9e22e6f0239: Fix wrong return value types (authored by kislinsk).
Fix wrong return value types
Wed, Oct 16, 1:24 PM
kislinsk committed rMITK0979df62b0ba: Modernize nullptr usage (authored by kislinsk).
Modernize nullptr usage
Wed, Oct 16, 1:24 PM
kislinsk added a comment to T23293: Apply C++ 11 modernizations.

Pushed new branch T23293-nullptr.

Wed, Oct 16, 1:24 PM · MITK
kislinsk committed rMITK3db51a382ace: Merge branch 'T23293-override-Oct2019' (authored by kislinsk).
Merge branch 'T23293-override-Oct2019'
Wed, Oct 16, 1:03 PM
kislinsk committed rMITKe18c70938711: Fix clang-tidy errors regarding multiple override specifiers (authored by kislinsk).
Fix clang-tidy errors regarding multiple override specifiers
Wed, Oct 16, 1:02 PM
kislinsk committed rMITK5d99ddc4d7ed: Merge branch 'T23293-override-Oct2019' (authored by kislinsk).
Merge branch 'T23293-override-Oct2019'
Wed, Oct 16, 12:35 PM
kislinsk committed rMITK4b7a4af81338: Add more override keywords with clang-tidy 9 (authored by kislinsk).
Add more override keywords with clang-tidy 9
Wed, Oct 16, 12:34 PM
kislinsk added a comment to T26756: Adapt to mitkFunctionCreateBlueBerryApplication changes.

@neher, you probably want to merge this. :-)

Wed, Oct 16, 12:31 PM · MITK Diffusion
kislinsk committed rMITKDIFF1f1ae6cd1401: Migrate to latest changes of mitkFunctionCreateBlueBerryApplication (authored by kislinsk).
Migrate to latest changes of mitkFunctionCreateBlueBerryApplication
Wed, Oct 16, 12:29 PM
kislinsk added a comment to T26756: Adapt to mitkFunctionCreateBlueBerryApplication changes.

Pushed new branch T26756-mitkFunctionCreateBlueBerryApplication.

Wed, Oct 16, 12:29 PM · MITK Diffusion
kislinsk created T26756: Adapt to mitkFunctionCreateBlueBerryApplication changes.
Wed, Oct 16, 12:27 PM · MITK Diffusion
kislinsk placed T26702: Support mosaic images up for grabs.
Wed, Oct 16, 12:10 PM · MITK
kislinsk closed T26654: Github pull request 239 (Check filename for invalid characters before saving e.g. "a:b.obj") as Resolved.
Wed, Oct 16, 12:07 PM · MITK (2018-04-4), Pull Request
kislinsk committed rMITK24e0741964b4: Merge branch 'releases/2018-04' (authored by kislinsk).
Merge branch 'releases/2018-04'
Wed, Oct 16, 12:06 PM
kislinsk committed rMITK6d55c6c4600c: Merge remote-tracking branch 'maleike/check-save-filenames' into releases/2018… (authored by kislinsk).
Merge remote-tracking branch 'maleike/check-save-filenames' into releases/2018…
Wed, Oct 16, 12:02 PM

Tue, Oct 15

kislinsk committed rMITK1fdbd9088049: Merge branch 'T23293-override-Oct2019' (authored by kislinsk).
Merge branch 'T23293-override-Oct2019'
Tue, Oct 15, 4:55 PM
kislinsk committed rMITK7bc10f124dfd: Fix wrong class name (authored by kislinsk).
Fix wrong class name
Tue, Oct 15, 4:54 PM
kislinsk committed rMITK9646099b086a: Unleash clang-tidy on MITK (override) (authored by kislinsk).
Unleash clang-tidy on MITK (override)
Tue, Oct 15, 4:41 PM
kislinsk added a comment to T23293: Apply C++ 11 modernizations.

Pushed new branch T23293-override-Oct2019.

Tue, Oct 15, 4:41 PM · MITK
kislinsk claimed T23293: Apply C++ 11 modernizations.

Revive task.

Tue, Oct 15, 3:59 PM · MITK
kislinsk closed T26752: [macOS] Make Boost libraries use RPATH as Resolved.
Tue, Oct 15, 3:48 PM · MITK
kislinsk committed rMITKf5e3a038d853: Merge branch 'T26752-Boost-RPATH' (authored by kislinsk).
Merge branch 'T26752-Boost-RPATH'
Tue, Oct 15, 3:28 PM
kislinsk committed rMITK6a53c08eddca: Make Boost libraries use RPATH (authored by kislinsk).
Make Boost libraries use RPATH
Tue, Oct 15, 3:27 PM
kislinsk added a comment to T26752: [macOS] Make Boost libraries use RPATH.

Pushed new branch T26752-Boost-RPATH.

Tue, Oct 15, 3:27 PM · MITK
kislinsk triaged T26752: [macOS] Make Boost libraries use RPATH as Normal priority.
Tue, Oct 15, 3:26 PM · MITK
kislinsk closed T26747: Fix AppleClang compile errors as Resolved.
Tue, Oct 15, 3:25 PM · MITK
kislinsk committed rMITKbab67ba4fb38: Merge branch 'T26747-AppleClang-Errors' (authored by kislinsk).
Merge branch 'T26747-AppleClang-Errors'
Tue, Oct 15, 1:51 PM
kislinsk committed rMITKfab06a4b7d5e: Fix AppleClang compile errors (authored by kislinsk).
Fix AppleClang compile errors
Tue, Oct 15, 1:50 PM
kislinsk added a comment to T26747: Fix AppleClang compile errors.

Pushed new branch T26747-AppleClang-Errors.

Tue, Oct 15, 1:50 PM · MITK
kislinsk triaged T26747: Fix AppleClang compile errors as Normal priority.
Tue, Oct 15, 1:41 PM · MITK
kislinsk committed rMITK31c6eb29967b: Merge branch 'releases/2018-04' (authored by kislinsk).
Merge branch 'releases/2018-04'
Tue, Oct 15, 1:17 PM
kislinsk committed rMITKb7f0edc76daf: Add QCoreApplication class declaration (authored by kislinsk).
Add QCoreApplication class declaration
Tue, Oct 15, 1:17 PM
kislinsk committed rMITKd24e97f0b901: Merge branch 'releases/2018-04' (authored by kislinsk).
Merge branch 'releases/2018-04'
Tue, Oct 15, 11:13 AM

Mon, Oct 14

kislinsk updated subscribers of T26745: MITK's interaction not the first to handle events anymore -- QVTKOpenGLWidget::event() changed since VTK 7.0.0 (MITK 2016.11).

@hempe @kalali Maybe related to the flickering render window menu issues?

Mon, Oct 14, 10:54 PM · MITK (2018-04-4), Pull Request
kislinsk added a comment to T26736: Starting second MITK instance fails under GNU/Linux.

That's a strong indicator that your graphics H/W causes trouble with the "modern" OpenGL version that VTK 8.x requires. I'm open for new ideas but I think this is something that is not fixable other than trying newer drivers or more recent H/W. In theory, everything not older than 6-7years should work with OpenGL 3.2, but as it turned out, there's a lot of fake-compatibility in older drivers.

Mon, Oct 14, 1:31 PM · MITK
kislinsk added a comment to T26736: Starting second MITK instance fails under GNU/Linux.

I tested with Ubuntu 16.04 in VM and also on a Ubuntu 18.04 host. Nvidia graphics.

Mon, Oct 14, 12:33 PM · MITK
kislinsk added a comment to T26736: Starting second MITK instance fails under GNU/Linux.

Works for me on various Ubuntu machines and Windows.

Mon, Oct 14, 11:55 AM · MITK
kislinsk added a comment to T26736: Starting second MITK instance fails under GNU/Linux.

Firstly, thank you very much for the detailed and complete bug report. It really is a pleasure to have all information without asking for every detail.

Mon, Oct 14, 11:39 AM · MITK
kislinsk committed rMITK69a8c137cf43: Merge branch 'releases/2018-04' (authored by kislinsk).
Merge branch 'releases/2018-04'
Mon, Oct 14, 8:57 AM

Fri, Oct 11

kislinsk removed a project from T23742: Implement proof of concept for new segmentation data type: Request for Discussion.

The current status of this task is documented by the Bachelor's thesis of @jungsi.

Fri, Oct 11, 11:34 AM · MITK
kislinsk added a comment to T26712: DICOM StructuredReport export for planar figures - right place for the contribution.

Can you give us more information about what's actually contained in the report?

Fri, Oct 11, 11:32 AM · Request for Discussion, d:cipher, MITK
kislinsk removed a member for MITK: steint.
Fri, Oct 11, 11:28 AM
kislinsk added a member for Mint Medical GmbH: steint.
Fri, Oct 11, 11:28 AM
kislinsk added a member for Mint Medical GmbH: hentsch.
Fri, Oct 11, 11:27 AM
kislinsk removed a member for MITK: hentsch.
Fri, Oct 11, 11:23 AM

Thu, Oct 10

kislinsk added a comment to T26721: Prepare Qt 5.13 compatibility.

We still need a pull request for CTK:

  • Replace QString::null with QString()
Thu, Oct 10, 4:31 PM · MITK
kislinsk added a comment to T26721: Prepare Qt 5.13 compatibility.

Pushed new branch T26721-Qt-5.13.

Thu, Oct 10, 4:30 PM · MITK
kislinsk claimed T26721: Prepare Qt 5.13 compatibility.

At least on Windows the Qt 5.13.1 CMake scripts do not work when trying to find Qt5UiTools as the script isn't able to find the release and debug library paths of Qt5Core. I had to manually set the corresponding CMake variables in the MITK-superbuild, the CTK-superbuild, the CTK-build, and the MITK-build.

Thu, Oct 10, 11:17 AM · MITK
kislinsk merged task T26720: Fix build problems with Qt 5.13 into T26721: Prepare Qt 5.13 compatibility.
Thu, Oct 10, 11:14 AM
kislinsk merged T26720: Fix build problems with Qt 5.13 into T26721: Prepare Qt 5.13 compatibility.
Thu, Oct 10, 11:14 AM · MITK
kislinsk closed T26728: Fix macOS 10.15 compiler errors as Resolved.
Thu, Oct 10, 11:13 AM · MITK (2018-04-4)

Tue, Oct 8

kislinsk added a comment to T26728: Fix macOS 10.15 compiler errors.

Pushed new branch T26728-macOS-10.15.

Tue, Oct 8, 5:16 PM · MITK (2018-04-4)
kislinsk triaged T26728: Fix macOS 10.15 compiler errors as Normal priority.
Tue, Oct 8, 5:08 PM · MITK (2018-04-4)

Thu, Sep 26

kislinsk removed a watcher for MITK: thkim.
Thu, Sep 26, 2:11 PM
kislinsk removed a watcher for MITK: azias.
Thu, Sep 26, 2:11 PM

Wed, Sep 25

kislinsk changed the edit policy for CI.
Wed, Sep 25, 3:16 PM
kislinsk updated the task description for T26702: Support mosaic images.
Wed, Sep 25, 9:31 AM · MITK
kislinsk updated subscribers of T26702: Support mosaic images.
Wed, Sep 25, 9:30 AM · MITK

Tue, Sep 24

kislinsk added a comment to T26702: Support mosaic images.

More information on Siemens Mosaic Images, see: https://nipy.org/nibabel/dicom/spm_dicom.html

Tue, Sep 24, 4:08 PM · MITK
kislinsk updated subscribers of T26702: Support mosaic images.

Example data is located in E230-Daten/MITK.

Tue, Sep 24, 10:49 AM · MITK
kislinsk updated subscribers of T26702: Support mosaic images.
Tue, Sep 24, 10:47 AM · MITK
kislinsk claimed T26702: Support mosaic images.
Tue, Sep 24, 10:45 AM · MITK
kislinsk triaged T26702: Support mosaic images as Wishlist priority.
Tue, Sep 24, 10:44 AM · MITK

Mon, Sep 23

kislinsk updated kislinsk.
Mon, Sep 23, 9:02 AM
kislinsk updated kislinsk.
Mon, Sep 23, 9:02 AM
kislinsk updated kislinsk.
Mon, Sep 23, 9:01 AM

Sep 20 2019

kislinsk added a parent task for T26276: Segmentation created for multiple timepoints on 3D+t images: T24766: Last time step of 3D+t data with arbitrary time geometry not selectable by image navigator spinbox.
Sep 20 2019, 4:21 AM · MITK (2018-04-4)
kislinsk added a subtask for T24766: Last time step of 3D+t data with arbitrary time geometry not selectable by image navigator spinbox: T26276: Segmentation created for multiple timepoints on 3D+t images.
Sep 20 2019, 4:21 AM · MITK
kislinsk added a comment to T24766: Last time step of 3D+t data with arbitrary time geometry not selectable by image navigator spinbox.

@kalali Resolved?

Sep 20 2019, 4:20 AM · MITK
kislinsk created CI.
Sep 20 2019, 4:09 AM

Sep 12 2019

kislinsk added a comment to T26427: Support software rendering.

Side note: https://fdossena.com does provide 64-bit builds now.

Sep 12 2019, 1:00 PM · MITK (2018-04-4)
kislinsk changed the visibility for F1437698: bitmap.png.
Sep 12 2019, 11:26 AM

Sep 9 2019

kislinsk added a comment to T26653: Github pull request 263 (Forward vtkInformation objects to MITK mappers - allow for VTK depth peeling).

Cool! 👍🏻
Will look into this on Community Day.

Sep 9 2019, 12:03 PM · MITK (2018-04-4), Noteworthy, Pull Request
kislinsk triaged T26653: Github pull request 263 (Forward vtkInformation objects to MITK mappers - allow for VTK depth peeling) as Normal priority.
Sep 9 2019, 11:58 AM · MITK (2018-04-4), Noteworthy, Pull Request
kislinsk triaged T26654: Github pull request 239 (Check filename for invalid characters before saving e.g. "a:b.obj") as Normal priority.

Requested code changes in pull request.

Sep 9 2019, 11:56 AM · MITK (2018-04-4), Pull Request
kislinsk placed T26427: Support software rendering up for grabs.
Sep 9 2019, 11:39 AM · MITK (2018-04-4)
kislinsk closed T26655: Github pull request 237 (Gizmo fix: avoid double emission of Modified() signal) as Resolved.

Merged into releases/2018-04.

Sep 9 2019, 11:38 AM · MITK (2018-04-4), Pull Request
kislinsk added a comment to T26655: Github pull request 237 (Gizmo fix: avoid double emission of Modified() signal).

Pushed new branch T26655-GizmoFix.

Sep 9 2019, 11:37 AM · MITK (2018-04-4), Pull Request
kislinsk triaged T26655: Github pull request 237 (Gizmo fix: avoid double emission of Modified() signal) as Low priority.
Sep 9 2019, 11:37 AM · MITK (2018-04-4), Pull Request
kislinsk triaged T26656: Gitlab pull request 238 (Avoid collapsing 'Properties' view when editing child-properties (e.g. "material.something")) as Low priority.

Not yet working. Tree doesn't collapse only the first time.

Sep 9 2019, 11:34 AM · MITK (2018-04-4), Pull Request

Sep 2 2019

kislinsk changed the Default Edit Policy policy for application Diffusion from Administrators to Custom Policy.
Sep 2 2019, 11:02 AM