Page MenuHomePhabricator

kislinsk (Stefan Dinkelacker)
UserAdministrator

Projects (14)

User Details

User Since
Aug 1 2016, 11:50 AM (268 w, 6 d)
Roles
Administrator

Recent Activity

Fri, Sep 24

kislinsk updated subscribers of T28706: Cannot build module DataTypesExt becasue lz4 is not linked by CMake.
Fri, Sep 24, 9:31 AM · MITK (v2021.10)
kislinsk added a comment to T28706: Cannot build module DataTypesExt becasue lz4 is not linked by CMake.

Oh, I think I might have found the issue. Ignore the comment above and in CMake/Findlz4.cmake please add lib64 to the PATH_SUFFIXES of the two calls to find_library() in lines 11 and 18 like PATH_SUFFIXES lib lib64. Does it work?

Fri, Sep 24, 9:30 AM · MITK (v2021.10)
kislinsk claimed T28706: Cannot build module DataTypesExt becasue lz4 is not linked by CMake.
Fri, Sep 24, 9:25 AM · MITK (v2021.10)
kislinsk triaged T28706: Cannot build module DataTypesExt becasue lz4 is not linked by CMake as High priority.

Thanks for the comprehensive report. Can you do me a favor and add message(FATAL_ERROR "include dirs: ${lz4_INCLUDE_DIR} libraries: ${lz4_LIBRARIES}") as last line to CMake/PackageDepends/MITK_lz4_Config.cmake and configure MITK (not superbuild) to get the output?

Fri, Sep 24, 9:25 AM · MITK (v2021.10)

Fri, Sep 17

kislinsk merged T28489: int64 not supported into T28557: Cannot load segmentations from KITS challenge due to unknown pixel type.
Fri, Sep 17, 11:13 AM · Request for Discussion, MITK (v2021.10)
kislinsk merged task T28489: int64 not supported into T28557: Cannot load segmentations from KITS challenge due to unknown pixel type.
Fri, Sep 17, 11:13 AM · MITK

Wed, Sep 15

kislinsk added a member for MIC: y033f.
Wed, Sep 15, 4:46 PM
kislinsk triaged T28691: AutoSegmentationWithPreviewTool tool manager won't support multi threading as Normal priority.
Wed, Sep 15, 4:55 AM · MITK (v2021.10), Request for Discussion
kislinsk moved T28675: Boolean Operations in Segmentation utilities are slow from Backlog to Segmentation on the MITK (v2021.10) board.
Wed, Sep 15, 4:54 AM · MITK (v2021.10)
kislinsk triaged T28675: Boolean Operations in Segmentation utilities are slow as Normal priority.

This could be connected to the undo/redo implementation of MITK and the creation of difference images for the undo stack. I do not know your version of MITK but the use of LZ4 compression for difference images in the latest versions could already be the or part of the solution. I agree that the operations should be much faster but they might be already as fast as the python implementation so whoever is working on this task should clock the different parts of the operation first to see what is actually taking so long and as said, if it is still the case in the latest version of MITK.

Wed, Sep 15, 4:54 AM · MITK (v2021.10)
kislinsk added a subtask for T28521: multilabel segmentation add switch to disable contour: T28522: Segmentations are drawn differently depending on whether the segmentation tool is open or not.
Wed, Sep 15, 4:49 AM · MITK (v2021.10)
kislinsk added a parent task for T28522: Segmentations are drawn differently depending on whether the segmentation tool is open or not: T28521: multilabel segmentation add switch to disable contour.
Wed, Sep 15, 4:49 AM · MITK
kislinsk triaged T28522: Segmentations are drawn differently depending on whether the segmentation tool is open or not as Low priority.

If it only affects the legacy segmentation type (not displayed as multilabel segmentation), it should be soon resolved with the segmentation refactoring anyway. I think a workaround for now could be to convert the legacy segmentation to a multilabel segmentation in MITK (Data Manager context menu?). This task is also potentially connected to T28521: multilabel segmentation add switch to disable contour.

Wed, Sep 15, 4:49 AM · MITK
kislinsk moved T28521: multilabel segmentation add switch to disable contour from Backlog to Segmentation on the MITK (v2021.10) board.
Wed, Sep 15, 4:45 AM · MITK (v2021.10)
kislinsk triaged T28521: multilabel segmentation add switch to disable contour as Normal priority.

This is already possible in the Properties view but I guess it is a good candidate to be more accessible from within the segmentation view or preference page.

Wed, Sep 15, 4:45 AM · MITK (v2021.10)
kislinsk triaged T28493: Multilabel color map colors are not very nice as Low priority.

I think I once looked into this specific issue and it turned out that your label values had quite some gaps between there values resulting in similar neighboring colors "by accident". Consecutive label values would be quite distinguishable. I am not sure if at least the first x colors follow a certain standard or not. This should be checked first before changing the colors.

Wed, Sep 15, 4:43 AM · MITK
kislinsk triaged T28489: int64 not supported as Wishlist priority.

@kleina already tried to add int64 as supported image type but it didn't work out of the box AFAIK. In theory it should be enough to add the type to the MITK_ACCESSBYITK_INTEGRAL_PIXEL_TYPES CMake variable. If we would be able to make this work, compilation time and binary size would increase noticeably, though, because of the templated nature of ITK.

Wed, Sep 15, 4:39 AM · MITK

Mon, Sep 6

kislinsk assigned T28680: Build fails on Ubuntu 20.04. -Wold-style-cast error while compiling CppMicroServices to s349i.
Mon, Sep 6, 3:25 PM · MITK (v2021.10)
kislinsk triaged T28680: Build fails on Ubuntu 20.04. -Wold-style-cast error while compiling CppMicroServices as High priority.
Mon, Sep 6, 3:24 PM · MITK (v2021.10)

Wed, Sep 1

kislinsk added a member for MITK: s349i.
Wed, Sep 1, 1:51 PM
kislinsk added a member for MIC: s349i.
Wed, Sep 1, 1:50 PM

Aug 11 2021

kislinsk removed a project from T27149: [Segmentation] Interpolation nodes / position nodes are not correctly hidden: Request for Discussion.
Aug 11 2021, 11:51 AM · MITK (v2021.10)

Aug 4 2021

kislinsk added a member for MIC: kochch.
Aug 4 2021, 9:46 AM
kislinsk closed T28657: Fix Visual Studio 2019 v16.11 warnings as errors as Resolved.
Aug 4 2021, 6:31 AM · MITK (v2021.10)
kislinsk added a comment to T28657: Fix Visual Studio 2019 v16.11 warnings as errors.

Deleted branch from rMITK MITK: bugfix/T28657-FixMSVCv16.11WarningsAsErrors.

Aug 4 2021, 6:30 AM · MITK (v2021.10)
kislinsk committed rMITKa393ebd03511: Fix unused return type (authored by kislinsk).
Fix unused return type
Aug 4 2021, 6:29 AM
kislinsk committed rMITKdc72fd711279: Merge branch 'bugfix/T28657-FixMSVCv16.11WarningsAsErrors' into develop (authored by kislinsk).
Merge branch 'bugfix/T28657-FixMSVCv16.11WarningsAsErrors' into develop
Aug 4 2021, 6:29 AM
kislinsk added a comment to T28657: Fix Visual Studio 2019 v16.11 warnings as errors.

Pushed new branch to rMITK MITK: bugfix/T28657-FixMSVCv16.11WarningsAsErrors.

Aug 4 2021, 6:28 AM · MITK (v2021.10)
kislinsk triaged T28657: Fix Visual Studio 2019 v16.11 warnings as errors as High priority.
Aug 4 2021, 6:24 AM · MITK (v2021.10)

Jul 26 2021

kislinsk claimed T27701: Overhaul or remove PluginGenerator.
Jul 26 2021, 9:36 AM · MITK (v2021.10)
kislinsk triaged T28585: The MITK-Tutorial Step 9 missing inheritence as Normal priority.
Jul 26 2021, 9:35 AM · MITK (v2021.10)
kislinsk added a subtask for T27701: Overhaul or remove PluginGenerator: T28585: The MITK-Tutorial Step 9 missing inheritence.
Jul 26 2021, 9:35 AM · MITK (v2021.10)
kislinsk added a parent task for T28585: The MITK-Tutorial Step 9 missing inheritence: T27701: Overhaul or remove PluginGenerator.
Jul 26 2021, 9:35 AM · MITK (v2021.10)
kislinsk added a project to T28585: The MITK-Tutorial Step 9 missing inheritence: MITK (v2021.10).
Jul 26 2021, 9:34 AM · MITK (v2021.10)

Jul 21 2021

kislinsk added a comment to T28635: [Segmentation] Remove deprecated classes.

When deprecated classes are still around for a long time it is a valid base assumption that the reason is just that they were either forgotten since they weren't used or seen for a long time, or that it is surprisingly difficult to actually get rid of them since there's no real replacement for example but they are still in heavy use. The latter reason is something seen rather often in the core unfortunately.

Jul 21 2021, 11:51 PM · Cleared, MITK (v2021.10)
kislinsk updated the task description for T28635: [Segmentation] Remove deprecated classes.
Jul 21 2021, 11:47 PM · Cleared, MITK (v2021.10)

Jul 20 2021

kislinsk added a comment to T28616: Allow fixed-size point set markers in VTK mapper.

Deleted branch from rMITK MITK: feature/T28616-FixedSizeVisualizationForPointSets.

Jul 20 2021, 9:43 AM · Pull Request, MITK (v2021.10)
kislinsk committed rMITK51054fb39226: Merge remote-tracking branch 'slafebre/feature/T28616-fixed-size-markers-for… (authored by kislinsk).
Merge remote-tracking branch 'slafebre/feature/T28616-fixed-size-markers-for…
Jul 20 2021, 9:42 AM
kislinsk committed rMITK5788efe2d52a: Fix glyph scaling when switching back to non-fixed point sizes (authored by kislinsk).
Fix glyph scaling when switching back to non-fixed point sizes
Jul 20 2021, 9:42 AM
kislinsk committed rMITK461a2db73b4e: Fix glyph scaling of selected glyphs (authored by kislinsk).
Fix glyph scaling of selected glyphs
Jul 20 2021, 9:42 AM
kislinsk committed rMITKfe35a091a085: Add option to visualize point sets as fixed-size markers (authored by kislinsk).
Add option to visualize point sets as fixed-size markers
Jul 20 2021, 9:42 AM
kislinsk closed T28616: Allow fixed-size point set markers in VTK mapper as Resolved by committing rMITKfe35a091a085: Add option to visualize point sets as fixed-size markers.
Jul 20 2021, 9:42 AM · Pull Request, MITK (v2021.10)

Jul 14 2021

kislinsk lowered the priority of T16153: [Segmentation] Jump to center of mass of segmentation on click from Normal to Wishlist.
Jul 14 2021, 11:31 AM · MITK (v2021.10), Bugzilla
kislinsk lowered the priority of T28262: TimeGeometry inconsistent documentation and implementation of time bounds and checks from Unbreak Now! to High.
Jul 14 2021, 11:09 AM · MITK (v2021.10), Request for Discussion

Jul 13 2021

kislinsk updated the task description for T27437: Migrate MITK to use ITK 5.x .
Jul 13 2021, 2:22 PM · MITK (v2021.10)
kislinsk added a comment to T27437: Migrate MITK to use ITK 5.x .

I continued migrating MITK. Without explicitly switching on any plugins, the Workbench already compiles and run. Switching on the WorkbenchRelease configuration (without MatchPoint, since I cannot currently compile it because of a compiler bug) compiles as well except for the following two classes which need a rewrite of their multi-threaded implementation, since the ITK base class changed its implementation in that regard:

Jul 13 2021, 4:10 AM · MITK (v2021.10)

Jul 10 2021

kislinsk changed the status of T28614: [Segmentation] Replace ITK filter pipeline for 2-d interpolation with single filter that does the same job from Resolved to Wontfix.
Jul 10 2021, 1:42 AM · MITK (v2021.10)
kislinsk added a comment to T28614: [Segmentation] Replace ITK filter pipeline for 2-d interpolation with single filter that does the same job.

Deleted branch from rMITK MITK: bugfix/T28614-Revert.

Jul 10 2021, 1:41 AM · MITK (v2021.10)
kislinsk added a reverting change for rMITK4aa264835117: Replace 2-d interpolation filter pipeline with equivalent ITK filter: rMITK4ab8a5898b8d: Revert "Replace 2-d interpolation filter pipeline with equivalent ITK filter".
Jul 10 2021, 1:41 AM
kislinsk committed rMITK4ab8a5898b8d: Revert "Replace 2-d interpolation filter pipeline with equivalent ITK filter" (authored by kislinsk).
Revert "Replace 2-d interpolation filter pipeline with equivalent ITK filter"
Jul 10 2021, 1:41 AM
kislinsk committed rMITK648a34ce6f0e: Merge branch 'bugfix/T28614-Revert' into develop (authored by kislinsk).
Merge branch 'bugfix/T28614-Revert' into develop
Jul 10 2021, 1:41 AM
kislinsk added a comment to T28614: [Segmentation] Replace ITK filter pipeline for 2-d interpolation with single filter that does the same job.

Pushed new branch to rMITK MITK: bugfix/T28614-Revert.

Jul 10 2021, 1:40 AM · MITK (v2021.10)

Jul 9 2021

kislinsk added a comment to T28614: [Segmentation] Replace ITK filter pipeline for 2-d interpolation with single filter that does the same job.

Deleted branch from rMITK MITK: bugfix/T28614-Simplify2DInterpolationFilterPipeline.

Jul 9 2021, 2:49 PM · MITK (v2021.10)
kislinsk committed rMITK4aa264835117: Replace 2-d interpolation filter pipeline with equivalent ITK filter (authored by kislinsk).
Replace 2-d interpolation filter pipeline with equivalent ITK filter
Jul 9 2021, 2:48 PM
kislinsk committed rMITK3e08285283ef: Replace 2-d interpolation filter pipeline with equivalent ITK filter (authored by kislinsk).
Replace 2-d interpolation filter pipeline with equivalent ITK filter
Jul 9 2021, 2:48 PM
kislinsk closed T28614: [Segmentation] Replace ITK filter pipeline for 2-d interpolation with single filter that does the same job as Resolved by committing rMITK3e08285283ef: Replace 2-d interpolation filter pipeline with equivalent ITK filter.
Jul 9 2021, 2:48 PM · MITK (v2021.10)
kislinsk moved T28616: Allow fixed-size point set markers in VTK mapper from Backlog to Cycle on the MITK (v2021.10) board.
Jul 9 2021, 11:31 AM · Pull Request, MITK (v2021.10)
kislinsk added a revision to T28616: Allow fixed-size point set markers in VTK mapper: Unknown Object (Differential Revision).
Jul 9 2021, 11:26 AM · Pull Request, MITK (v2021.10)
kislinsk added a comment to T28616: Allow fixed-size point set markers in VTK mapper.

Pushed new branch to rMITK MITK: feature/T28616-FixedSizeVisualizationForPointSets.

Jul 9 2021, 10:28 AM · Pull Request, MITK (v2021.10)
kislinsk claimed T28616: Allow fixed-size point set markers in VTK mapper.
Jul 9 2021, 10:23 AM · Pull Request, MITK (v2021.10)
kislinsk added a project to T28616: Allow fixed-size point set markers in VTK mapper: Pull Request.

Thanks!

Jul 9 2021, 10:22 AM · Pull Request, MITK (v2021.10)
kislinsk added a comment to T28385: [Segmentation] Erosion crashes the MITK Workbench after interpolation.

Deleted branch from rMITK MITK: bugfix/T28385-AddNullptrCheck.

Jul 9 2021, 9:56 AM · Cleared, MITK (v2021.10)
kislinsk committed rMITK5071cbec8de1: Add nullptr check (authored by kislinsk).
Add nullptr check
Jul 9 2021, 9:56 AM
kislinsk committed rMITKcbf0c82a8caa: Merge branch 'bugfix/T28385-AddNullptrCheck' into develop (authored by kislinsk).
Merge branch 'bugfix/T28385-AddNullptrCheck' into develop
Jul 9 2021, 9:55 AM
kislinsk added a comment to T28385: [Segmentation] Erosion crashes the MITK Workbench after interpolation.

Pushed new branch to rMITK MITK: bugfix/T28385-AddNullptrCheck.

Jul 9 2021, 9:55 AM · Cleared, MITK (v2021.10)
kislinsk added a comment to T28606: [Segmentation] Accelerate do/undo mechanism for segmentations.

Deleted branch from rMITK MITK: bugfix/T28606-StoreImageDimension.

Jul 9 2021, 9:39 AM · MITK (v2021.10)
kislinsk committed rMITK40adb64e9980: Explicitly store and restore image dimension (authored by kislinsk).
Explicitly store and restore image dimension
Jul 9 2021, 9:38 AM
kislinsk committed rMITK454aee539fff: Merge branch 'bugfix/T28606-StoreImageDimension' into develop (authored by kislinsk).
Merge branch 'bugfix/T28606-StoreImageDimension' into develop
Jul 9 2021, 9:38 AM
kislinsk added a comment to T28606: [Segmentation] Accelerate do/undo mechanism for segmentations.

Pushed new branch to rMITK MITK: bugfix/T28606-StoreImageDimension.

Jul 9 2021, 9:38 AM · MITK (v2021.10)
kislinsk triaged T28616: Allow fixed-size point set markers in VTK mapper as Wishlist priority.

Thanks for the suggestion and patch! 👍

Jul 9 2021, 8:25 AM · Pull Request, MITK (v2021.10)
kislinsk closed T28606: [Segmentation] Accelerate do/undo mechanism for segmentations as Resolved.
Jul 9 2021, 8:01 AM · MITK (v2021.10)
kislinsk added a comment to T28606: [Segmentation] Accelerate do/undo mechanism for segmentations.

Deleted branch from rMITK MITK: bugfix/T28606-UseLZ4InCompressedImageContainerClass.

Jul 9 2021, 7:59 AM · MITK (v2021.10)
kislinsk committed rMITK25d18deac4a7: Add lz4 as third-party dependency (authored by kislinsk).
Add lz4 as third-party dependency
Jul 9 2021, 7:58 AM
kislinsk committed rMITK31a4130fcacc: Rewrite CompressedImageContainer to use LZ4 compression (authored by kislinsk).
Rewrite CompressedImageContainer to use LZ4 compression
Jul 9 2021, 7:58 AM
kislinsk committed rMITK14632b174db4: Merge branch 'bugfix/T28606-UseLZ4InCompressedImageContainerClass' into develop (authored by kislinsk).
Merge branch 'bugfix/T28606-UseLZ4InCompressedImageContainerClass' into develop
Jul 9 2021, 7:58 AM
kislinsk committed rMITK83eab9c57a25: Migrate unit test to changed API (authored by kislinsk).
Migrate unit test to changed API
Jul 9 2021, 7:58 AM
kislinsk committed rMITKafe3b0b3c036: Merge branch 'develop' into bugfix/T28606-UseLZ4InCompressedImageContainerClass (authored by kislinsk).
Merge branch 'develop' into bugfix/T28606-UseLZ4InCompressedImageContainerClass
Jul 9 2021, 7:58 AM
kislinsk added a comment to T28385: [Segmentation] Erosion crashes the MITK Workbench after interpolation.

Deleted branch from rMITK MITK: bugfix/T28385-InterpolationCrashOnMorphologicalOperations.

Jul 9 2021, 7:49 AM · Cleared, MITK (v2021.10)
kislinsk committed rMITK6d56f81401b8: Handle uninitialized segmentations (authored by kislinsk).
Handle uninitialized segmentations
Jul 9 2021, 7:49 AM
kislinsk committed rMITKe2a033fa4497: Disable interpolation if interpolator aborted (authored by kislinsk).
Disable interpolation if interpolator aborted
Jul 9 2021, 7:49 AM
kislinsk committed rMITKb1020c733309: Reset feedback node when interpolation was aborted (authored by kislinsk).
Reset feedback node when interpolation was aborted
Jul 9 2021, 7:49 AM
kislinsk committed rMITKbb5598e1083a: Release own reference to segmentation if it is invalid (authored by kislinsk).
Release own reference to segmentation if it is invalid
Jul 9 2021, 7:49 AM
kislinsk closed T28385: [Segmentation] Erosion crashes the MITK Workbench after interpolation as Resolved by committing rMITKb7299f54c209: Handle uninitialized segmentations in interpolator.
Jul 9 2021, 7:49 AM · Cleared, MITK (v2021.10)
kislinsk committed rMITKb7299f54c209: Handle uninitialized segmentations in interpolator (authored by kislinsk).
Handle uninitialized segmentations in interpolator
Jul 9 2021, 7:49 AM

Jul 8 2021

kislinsk closed T28615: [Segmentation] First 2-d interpolation is only performed after the current slice was changed as Wontfix.
Jul 8 2021, 2:34 PM · MITK (v2021.10)
kislinsk moved T28615: [Segmentation] First 2-d interpolation is only performed after the current slice was changed from Backlog to Cycle on the MITK (v2021.10) board.
Jul 8 2021, 12:33 PM · MITK (v2021.10)
kislinsk triaged T28615: [Segmentation] First 2-d interpolation is only performed after the current slice was changed as Normal priority.
Jul 8 2021, 12:33 PM · MITK (v2021.10)
kislinsk merged T28516: 2D slice interpolation should use multiprocessing into T28491: Slice interpolation 'confirm for all slices' not working for large images.
Jul 8 2021, 12:29 PM · MITK (v2021.10)
kislinsk merged task T28516: 2D slice interpolation should use multiprocessing into T28491: Slice interpolation 'confirm for all slices' not working for large images.
Jul 8 2021, 12:29 PM · MITK (v2021.10)
kislinsk renamed T28385: [Segmentation] Erosion crashes the MITK Workbench after interpolation from [Segmentation Utilities] Erosion crashes the MITK Workbench after interpolation to [Segmentation] Erosion crashes the MITK Workbench after interpolation.
Jul 8 2021, 12:23 PM · Cleared, MITK (v2021.10)
kislinsk added a revision to T28606: [Segmentation] Accelerate do/undo mechanism for segmentations: Unknown Object (Differential Revision).
Jul 8 2021, 12:22 PM · MITK (v2021.10)
kislinsk renamed T28606: [Segmentation] Accelerate do/undo mechanism for segmentations from Accelerate do/undo mechanism for segmentations to [Segmentation] Accelerate do/undo mechanism for segmentations.
Jul 8 2021, 12:21 PM · MITK (v2021.10)
kislinsk placed T28480: [Checklist] [Test data] Define publicly available location to store user test data up for grabs.
Jul 8 2021, 12:21 PM · MITK (v2021.10)
kislinsk moved T28614: [Segmentation] Replace ITK filter pipeline for 2-d interpolation with single filter that does the same job from Backlog to Cycle on the MITK (v2021.10) board.
Jul 8 2021, 12:19 PM · MITK (v2021.10)
kislinsk added a revision to T28614: [Segmentation] Replace ITK filter pipeline for 2-d interpolation with single filter that does the same job: Restricted Differential Revision.
Jul 8 2021, 12:17 PM · MITK (v2021.10)
kislinsk added a comment to T28614: [Segmentation] Replace ITK filter pipeline for 2-d interpolation with single filter that does the same job.

Pushed new branch to rMITK MITK: bugfix/T28614-Simplify2DInterpolationFilterPipeline.

Jul 8 2021, 12:16 PM · MITK (v2021.10)
kislinsk triaged T28614: [Segmentation] Replace ITK filter pipeline for 2-d interpolation with single filter that does the same job as Normal priority.
Jul 8 2021, 12:14 PM · MITK (v2021.10)
kislinsk added a revision to T28385: [Segmentation] Erosion crashes the MITK Workbench after interpolation: Unknown Object (Differential Revision).
Jul 8 2021, 7:57 AM · Cleared, MITK (v2021.10)

Jul 7 2021

kislinsk added a comment to T28385: [Segmentation] Erosion crashes the MITK Workbench after interpolation.

Pushed new branch to rMITK MITK: bugfix/T28385-InterpolationCrashOnMorphologicalOperations.

Jul 7 2021, 10:55 PM · Cleared, MITK (v2021.10)
kislinsk added a comment to T28385: [Segmentation] Erosion crashes the MITK Workbench after interpolation.

We can fix it in the SegmentationInterpolationController by explicitly handling the situation that the modified image is not initialized (IsInitialized() == false).

Jul 7 2021, 5:23 PM · Cleared, MITK (v2021.10)