Page MenuHomePhabricator

kislinsk (Stefan Dinkelacker)
UserAdministrator

Projects (15)

User Details

User Since
Aug 1 2016, 11:50 AM (339 w, 5 d)
Roles
Administrator

Recent Activity

Wed, Feb 1

kislinsk placed T29347: Measurement Checklist - Possible inconsistent recentering behavior when clicking on geometry node in Data Manager. up for grabs.
Wed, Feb 1, 10:43 AM · MITK (v2023.04), Cleared, Checklist

Wed, Jan 25

kislinsk moved T29444: Ability to add "tags" to annotated regions from Backlog to MITK Meeting on the Request for Discussion board.
Wed, Jan 25, 12:07 PM · Request for Discussion, MITK (v2023.04)
kislinsk moved T29445: Make Segmentation Tasks Lists fully available in the MITK Workbench from Backlog to MITK Meeting on the Request for Discussion board.
Wed, Jan 25, 12:07 PM · Request for Discussion, MITK (v2023.04)
kislinsk moved T29437: [SEG] Add TotalSegmentator from MITK Meeting to Backlog on the Request for Discussion board.
Wed, Jan 25, 11:48 AM · MITK (v2023.04)

Tue, Jan 24

kislinsk added a comment to T29444: Ability to add "tags" to annotated regions.

@ahmadqasim We cannot see the images as their View Policies are too strict (it is an issue with Phabricator). You can change the View Policy afterwards by clicking on the file and you find according settings in the menu.

Tue, Jan 24, 9:52 AM · Request for Discussion, MITK (v2023.04)

Mon, Jan 23

kislinsk triaged T29445: Make Segmentation Tasks Lists fully available in the MITK Workbench as Normal priority.
Mon, Jan 23, 1:31 PM · Request for Discussion, MITK (v2023.04)
kislinsk placed T29225: Rule Checker for FlowBench up for grabs.
Mon, Jan 23, 1:27 PM · MITK (v2023.04)
kislinsk added a comment to T29412: List of MITK publications on web page is not up to date.

Status: Added quite a few papers up until 2020 thanks to a currated list of papers from @floca. For the past two years we now need to look out for papers first.

Mon, Jan 23, 1:19 PM · MITK

Thu, Jan 19

kislinsk updated the task description for T29444: Ability to add "tags" to annotated regions.
Thu, Jan 19, 10:17 PM · Request for Discussion, MITK (v2023.04)
kislinsk added a project to T29444: Ability to add "tags" to annotated regions: Request for Discussion.
Thu, Jan 19, 10:17 PM · Request for Discussion, MITK (v2023.04)
kislinsk added a comment to T29431: [worklist] mitk-flow: save changed dicom segmentation not possible.

@gaoh I triggered the build of a new Flowbench installer in our CI. Will be ready later today and automatically uploaded. Commit hash: 122321bb.

Thu, Jan 19, 3:36 PM · MITK
kislinsk closed T29431: [worklist] mitk-flow: save changed dicom segmentation not possible as Resolved by committing rMITK122321bb10af: Add DICOM SEG workaround as specified in T29431.
Thu, Jan 19, 3:32 PM · MITK
kislinsk committed rMITK122321bb10af: Add DICOM SEG workaround as specified in T29431 (authored by kislinsk).
Add DICOM SEG workaround as specified in T29431
Thu, Jan 19, 3:32 PM
kislinsk committed rMITK09f2d8ae9272: Add DICOM SEG workaround as specified in T29432 (authored by kislinsk).
Add DICOM SEG workaround as specified in T29432
Thu, Jan 19, 3:32 PM
kislinsk added a revision to T29431: [worklist] mitk-flow: save changed dicom segmentation not possible: Unknown Object (Differential Revision).
Thu, Jan 19, 10:28 AM · MITK
kislinsk committed rMITK9105e0ca9c7d: Deactivate preloading (authored by kislinsk).
Deactivate preloading
Thu, Jan 19, 9:32 AM
kislinsk committed rMITK9f91bb7ad618: Merge branch 'feature/T29432-PreloadFirstTask2' into develop (authored by kislinsk).
Merge branch 'feature/T29432-PreloadFirstTask2' into develop
Thu, Jan 19, 9:32 AM
kislinsk added a comment to T29432: [worklist] mitk-flow preload first task.

Pushed new branch to rMITK MITK: feature/T29432-PreloadFirstTask2.

Thu, Jan 19, 9:32 AM · Request for Discussion, MITK
kislinsk raised the priority of T29432: [worklist] mitk-flow preload first task from Wishlist to High.

Original issue resolved, raising priority and leaving open to discuss consequences in the next MITK meeting.

Thu, Jan 19, 9:13 AM · Request for Discussion, MITK
kislinsk added a comment to T29432: [worklist] mitk-flow preload first task.

Deleted branch from rMITK MITK: feature/T29432-PreloadFirstTask.

Thu, Jan 19, 9:11 AM · Request for Discussion, MITK
kislinsk committed rMITK7aa58d50cea4: Automatically load first unfinished task of task list (authored by kislinsk).
Automatically load first unfinished task of task list
Thu, Jan 19, 9:11 AM
kislinsk committed rMITKcfe4eee32d37: Prevent unnecessary data modification (authored by kislinsk).
Prevent unnecessary data modification
Thu, Jan 19, 9:11 AM
kislinsk committed rMITKfa49a75ea36d: Migrate to microservice-based preferences (authored by kislinsk).
Migrate to microservice-based preferences
Thu, Jan 19, 9:11 AM
kislinsk committed rMITKd1fa87498876: Merge branch 'feature/T29432-PreloadFirstTask' into develop (authored by kislinsk).
Merge branch 'feature/T29432-PreloadFirstTask' into develop
Thu, Jan 19, 9:11 AM
kislinsk added a comment to T29432: [worklist] mitk-flow preload first task.

Pushed new branch to rMITK MITK: feature/T29432-PreloadFirstTask.

Thu, Jan 19, 9:11 AM · Request for Discussion, MITK
kislinsk added a comment to T29432: [worklist] mitk-flow preload first task.

While the original issue is rather easy to resolve by exchanging the class to data->Modified() with a RequestRenderWindowAll() (which is the actual intent anyway according to the comments), more hurdles start to appear that are not as easy to resolve.

Thu, Jan 19, 9:05 AM · Request for Discussion, MITK
kislinsk removed a project from T29412: List of MITK publications on web page is not up to date: Request for Discussion.
Thu, Jan 19, 7:20 AM · MITK
kislinsk added a comment to T29412: List of MITK publications on web page is not up to date.

Status: Currently I add 10 MITK-related papers per day to our publications page. Ongoing...

Thu, Jan 19, 7:19 AM · MITK

Tue, Jan 17

kislinsk removed a member for MITK: petersej.
Tue, Jan 17, 7:26 AM
kislinsk removed a member for MITK: groehl.
Tue, Jan 17, 7:26 AM
kislinsk removed a member for MITK: rosst.
Tue, Jan 17, 7:26 AM
kislinsk removed a member for MITK: thomass.
Tue, Jan 17, 7:26 AM
kislinsk removed a member for MITK: kleina.
Tue, Jan 17, 7:25 AM
kislinsk removed a member for MITK: onogur.
Tue, Jan 17, 7:25 AM
kislinsk removed a member for MITK: mindrocf.
Tue, Jan 17, 7:25 AM
kislinsk removed a member for MITK: e249r.
Tue, Jan 17, 7:25 AM
kislinsk removed a member for MITK: s349i.
Tue, Jan 17, 7:25 AM
kislinsk archived MITK (v2022.10).
Tue, Jan 17, 7:25 AM
kislinsk removed a member for MIC: petersej.
Tue, Jan 17, 7:25 AM
kislinsk removed a member for MIC: kleina.
Tue, Jan 17, 7:25 AM
kislinsk removed a member for MIC: kamphenk.
Tue, Jan 17, 7:24 AM
kislinsk removed a member for MIC: zhangs.
Tue, Jan 17, 7:24 AM
kislinsk removed a member for MIC: k921n.
Tue, Jan 17, 7:24 AM
kislinsk removed a member for MIC: f818k.
Tue, Jan 17, 7:24 AM
kislinsk removed a member for MIC: m564f.
Tue, Jan 17, 7:24 AM
kislinsk removed a member for MIC: s429r.
Tue, Jan 17, 7:24 AM
kislinsk removed a member for MIC: thomass.
Tue, Jan 17, 7:24 AM
kislinsk removed a member for MIC: d485r.
Tue, Jan 17, 7:24 AM
kislinsk removed a member for MIC: rasheed.
Tue, Jan 17, 7:24 AM
kislinsk removed a member for MIC: graf.
Tue, Jan 17, 7:24 AM
kislinsk removed a member for MIC: c082x.
Tue, Jan 17, 7:24 AM
kislinsk removed a member for MIC: e249r.
Tue, Jan 17, 7:24 AM
kislinsk removed a member for MIC: m139l.
Tue, Jan 17, 7:24 AM
kislinsk removed a member for MIC: o776l.
Tue, Jan 17, 7:24 AM
kislinsk removed a member for MIC: forche.
Tue, Jan 17, 7:24 AM
kislinsk removed a member for MIC: s349i.
Tue, Jan 17, 7:23 AM
kislinsk removed a member for MIC: o280o.
Tue, Jan 17, 7:23 AM

Fri, Jan 13

kislinsk added a member for MITK-MBI: a564y.
Fri, Jan 13, 4:13 PM
kislinsk claimed T29431: [worklist] mitk-flow: save changed dicom segmentation not possible.

Thanks Ralf!

Fri, Jan 13, 12:42 AM · MITK

Wed, Jan 11

kislinsk closed T29292: Unsupported pixel types as Wontfix.

We see and feel you. Considering the circumstances that Ralf mentioned (it's basically an ITK issue/contribution) I would anyway go for a Won't Fix here on our MITK side for now, until ITK provides the functionalities for such data types. Okay? :)

Wed, Jan 11, 1:01 PM · Request for Discussion, MITK
kislinsk moved T29294: Extend &/or Test nnUnet(v2) on Windows from MITK Meeting to Backlog on the Request for Discussion board.
Wed, Jan 11, 12:18 PM · MITK (v2023.04), Request for Discussion
kislinsk claimed T29412: List of MITK publications on web page is not up to date.
Wed, Jan 11, 12:12 PM · MITK
kislinsk triaged T29437: [SEG] Add TotalSegmentator as High priority.

As it is a really nice user-friendly feature, we have a high interest in getting TotalSegmenter integrated soon into MITK.

Wed, Jan 11, 11:49 AM · MITK (v2023.04)
kislinsk added a comment to T29130: [WorkBench] Segmentation fault when "Close Project" is invoked and QmitkDataStorageComboBox widget is in UI.

We talked about this task in our meeting today and concluded that we will migrate the DataStorageComboBox in our code to the SingleSelectionWidget and even deprecate the DataStorageComboBox.

Wed, Jan 11, 10:15 AM · MITK (v2023.04)

Dec 22 2022

kislinsk added a comment to T24398: Dicom plugin: Retrieve does not work.

Have you pushed your clean ups? Not that your efforts get lost. 😉

Dec 22 2022, 12:17 PM · Next Milestone, MITK, Request for Discussion, Missing Info

Dec 16 2022

kislinsk added a comment to T29433: MITK Workbench Persistent Crash.

Without a data sample we are not able to reproduce this issue. Can you upload one of these nrrd files? Please make sure that the data does not contain any personal information. You can also restrict access to uploaded files to certain users like me.

Dec 16 2022, 11:05 AM · Missing Info, MITK

Dec 13 2022

kislinsk moved T29432: [worklist] mitk-flow preload first task from Backlog to MITK Meeting on the Request for Discussion board.
Dec 13 2022, 8:55 PM · Request for Discussion, MITK
kislinsk added a project to T29432: [worklist] mitk-flow preload first task: Request for Discussion.
Dec 13 2022, 8:54 PM · Request for Discussion, MITK
kislinsk added a comment to T29432: [worklist] mitk-flow preload first task.

Without any extra preferences, it's as easy as adding the line this->LoadNextUnfinishedTask(); at the end of the OnTaskListChanged() method.

Dec 13 2022, 8:54 PM · Request for Discussion, MITK
kislinsk closed T29434: Clean up preference pointer anti pattern as Resolved.
Dec 13 2022, 2:46 PM · MITK
kislinsk added a comment to T29434: Clean up preference pointer anti pattern.

Deleted branch from rMITK MITK: bugfix/T29434-CleanUpPrefPtrAntiPattern.

Dec 13 2022, 2:46 PM · MITK
kislinsk committed rMITKcbf2e888a72c: Clean up preferences pointer anti pattern (authored by kislinsk).
Clean up preferences pointer anti pattern
Dec 13 2022, 2:45 PM
kislinsk committed rMITKe3f615b43c0b: Remove old preferences pointer from ctor init list (authored by kislinsk).
Remove old preferences pointer from ctor init list
Dec 13 2022, 2:45 PM
kislinsk committed rMITKc2904532ff3f: Merge branch 'bugfix/T29434-CleanUpPrefPtrAntiPattern' into develop (authored by kislinsk).
Merge branch 'bugfix/T29434-CleanUpPrefPtrAntiPattern' into develop
Dec 13 2022, 2:45 PM
kislinsk triaged T29433: MITK Workbench Persistent Crash as Normal priority.

Thanks for reporting. We are not aware of any crash like this with valid nrrd files. Since ITK snap crashes as well it could be a strong indicator that the crash is happening in the ITK reader that we use as well. It could be probably related to a corrupt nrrd file, or, in case it is a huge file, it could be simply related to running out of memory. Anyway, without the data we are not able to reproduce this issue.

Dec 13 2022, 1:19 PM · Missing Info, MITK
kislinsk added a revision to T29434: Clean up preference pointer anti pattern: Unknown Object (Differential Revision).
Dec 13 2022, 12:30 PM · MITK
kislinsk added a comment to T29434: Clean up preference pointer anti pattern.

Pushed new branch to rMITK MITK: bugfix/T29434-CleanUpPrefPtrAntiPattern.

Dec 13 2022, 12:23 PM · MITK
kislinsk added a comment to T29025: Preference service (access) based on cpp microservices.

Deleted branch from rMITK MITK: feature/T29025-PreferencesCoreService.

Dec 13 2022, 10:32 AM · MITK (v2023.04), Breaking Change
kislinsk triaged T29434: Clean up preference pointer anti pattern as Normal priority.
Dec 13 2022, 10:31 AM · MITK
kislinsk committed rMITK207ecdb75531: Move BlueBerry preferences to MITK Core services (authored by kislinsk).
Move BlueBerry preferences to MITK Core services
Dec 13 2022, 10:22 AM
kislinsk committed rMITK952b9648480a: Move BlueBerry preferences to MITK Core services (authored by kislinsk).
Move BlueBerry preferences to MITK Core services
Dec 13 2022, 10:22 AM
kislinsk closed T29025: Preference service (access) based on cpp microservices as Resolved by committing rMITK952b9648480a: Move BlueBerry preferences to MITK Core services.
Dec 13 2022, 10:22 AM · MITK (v2023.04), Breaking Change
kislinsk closed T29025: Preference service (access) based on cpp microservices, a subtask of T29027: Move NodeSelectionWidgets to QtWidgets module, as Resolved.
Dec 13 2022, 10:22 AM · MITK (v2023.04)

Dec 12 2022

kislinsk triaged T29381: Move Multilabel classes to Core module as Low priority.

The hash above doesn't seem to be auto-linked. So here it is: rMITKa73e482c0387: moved labelset-related classes out from core

Dec 12 2022, 11:27 AM · MITK, Request for Discussion
kislinsk triaged T29389: Python utility module as Normal priority.

I big leap into the Python direction would be to finally resolve T27923: Integrate possibility to execute Python Code in MITK , which is complete for a while now but we weren't able to figure out why it fails on Ubuntu build clients. Since the ITK v5 upgrade, we also need to adjust a little more I guess.

Dec 12 2022, 11:25 AM · Next Milestone, Request for Discussion, MITK
kislinsk updated subscribers of T29431: [worklist] mitk-flow: save changed dicom segmentation not possible.

Task lists don't do anything special regarding saving/loading data. So in theory, this bug should be reproducible by regular loading and saving via the menu in the Workbench?
However, task lists are prone to expose existing bugs related to repeated saving/loading of data. We indeed noticed another bug in this direction with .nrrd files, which were erroneous when loaded a second time in certain situations. The reason was faulty handling of properties: T29274: Label Loss on repeatedly loaded and saved segmentations.

Dec 12 2022, 11:21 AM · MITK

Dec 7 2022

kislinsk added a comment to T29428: Creating scene file with image properties can result in missing LevelWindowbar.

Reading your other task regarding mitkscene files I wonder if it has something to to with attaching the level window property to the BaseData property list instead of the DataNode property list. In principle, the level window should be attached to the latter one as it is an "appearance" property and not something instrinsic to the data. A few years ago we changed the way properties are queried and when a property is not present in a DataNode property list, the Base Data property list is queried as fallback. Maybe it is not fully functional for level windows as it could be that the code somehow relies on / assumes that the properties are located in the DataNode property list.

Dec 7 2022, 10:00 AM · MITK
kislinsk added a comment to T29427: FlowBench mitkscene structure has changed..

Not sure if I fully understand what is going on here but the difference is that in your first example you have DataNode properties and in your second example you have BaseData properties, right? Let's talk about it in our group 5 meeting today. :)

Dec 7 2022, 9:56 AM · MITK

Dec 1 2022

kislinsk updated subscribers of T29421: Finding CppRestSDK library alternative.

@a178n I added cpp-httplib as dependency to MITK in the branch mentioned above so you can easily experiment with it. For details, see rMITKf88e3d05aeb0: Add cpp-httplib as optional dependency.

Dec 1 2022, 1:51 PM · MITK
kislinsk added a comment to T29421: Finding CppRestSDK library alternative.

Pushed new branch to rMITK MITK: feature/T29421-httplib.

Dec 1 2022, 1:49 PM · MITK

Nov 30 2022

kislinsk moved T29337: Global Reinit HotKey functionality not there in Mac OSX from Others to Backlog on the MITK (v2023.04) board.
Nov 30 2022, 12:23 PM · MITK (v2023.04), Cleared, Checklist
kislinsk moved T28262: TimeGeometry inconsistent documentation and implementation of time bounds and checks from Others to Backlog on the MITK (v2023.04) board.
Nov 30 2022, 12:23 PM · MITK (v2023.04)
kislinsk moved T27189: REST API for data storage from In candidates to Backlog on the MITK (v2023.04) board.
Nov 30 2022, 12:23 PM · MITK (v2023.04), Restricted Project, Request for Discussion
kislinsk moved T27718: Miniapp for basic DICOM testing from In candidates to Backlog on the MITK (v2023.04) board.
Nov 30 2022, 12:23 PM · MITK (v2023.04), Kaapana (internal)
kislinsk moved T29027: Move NodeSelectionWidgets to QtWidgets module from In candidates to Backlog on the MITK (v2023.04) board.
Nov 30 2022, 12:23 PM · MITK (v2023.04)
kislinsk moved T29140: [Selection widget] Optional selection can not be removed if a fitting node is always found from In candidates to Backlog on the MITK (v2023.04) board.
Nov 30 2022, 12:23 PM · MITK (v2023.04), Request for Discussion
kislinsk moved T26988: [Checklist] LevelWindow checklist does not provide explicit expected results for sufficient verification from In candidates to Backlog on the MITK (v2023.04) board.
Nov 30 2022, 12:23 PM · MITK (v2023.04)
kislinsk moved T27613: Improve reinit behavior from In candidates to Backlog on the MITK (v2023.04) board.
Nov 30 2022, 12:23 PM · Request for Discussion, MITK (v2023.04)
kislinsk moved T27090: Provide standard NodePredicates from In candidates to Backlog on the MITK (v2023.04) board.
Nov 30 2022, 12:23 PM · MITK (v2023.04), Request for Discussion
kislinsk moved T29163: [XNAT] Opening XNAT session fails from In candidates to Backlog on the MITK (v2023.04) board.
Nov 30 2022, 12:23 PM · MITK (v2023.04)