Page MenuHomePhabricator

kislinsk (Stefan Dinkelacker)
UserAdministrator

Projects (13)

User Details

User Since
Aug 1 2016, 11:50 AM (233 w, 3 d)
Roles
Administrator

Recent Activity

Today

kislinsk closed T28189: [MITKDoc] Fix documentation warnings as Resolved.
Thu, Jan 21, 1:15 PM · MITK (2020)
kislinsk added a comment to T28189: [MITKDoc] Fix documentation warnings.

Deleted branch from rMITK MITK: bugfix/T28189-FixDoxygenWarnings.

Thu, Jan 21, 1:14 PM · MITK (2020)
kislinsk committed rMITK71a34b8570cf: Fix doxygen warnings (authored by kislinsk).
Fix doxygen warnings
Thu, Jan 21, 1:14 PM
kislinsk committed rMITK56edf255d20b: Merge branch 'bugfix/T28189-FixDoxygenWarnings' into develop (authored by kislinsk).
Merge branch 'bugfix/T28189-FixDoxygenWarnings' into develop
Thu, Jan 21, 1:14 PM
kislinsk committed rMITKf1758c202dba: Fix doxygen warnings (authored by kislinsk).
Fix doxygen warnings
Thu, Jan 21, 12:43 PM
kislinsk committed rMITK91703725ae84: Merge branch 'bugfix/T28189-FixDoxygenWarnings' into develop (authored by kislinsk).
Merge branch 'bugfix/T28189-FixDoxygenWarnings' into develop
Thu, Jan 21, 12:43 PM
kislinsk added a comment to T28189: [MITKDoc] Fix documentation warnings.

Pushed new branch to rMITK MITK: bugfix/T28189-FixDoxygenWarnings.

Thu, Jan 21, 12:42 PM · MITK (2020)
kislinsk triaged T28189: [MITKDoc] Fix documentation warnings as Normal priority.
Thu, Jan 21, 12:41 PM · MITK (2020)
kislinsk closed T28187: Automatically build and deploy MITK releases as Resolved.

I used the snapshot client configurations as baseline and created Jenkins jobs in MITK/Release. I also extended the Git hook to trigger these jobs. Hard to test, though, as I do not want to temporarily push test tags. Fingers crossed.

Thu, Jan 21, 11:59 AM · CI, MITK (2020)
kislinsk triaged T28187: Automatically build and deploy MITK releases as High priority.
Thu, Jan 21, 11:32 AM · CI, MITK (2020)

Tue, Jan 19

kislinsk added a revision to T28174: Fix minor C++ style issues: Unknown Object (Differential Revision).
Tue, Jan 19, 12:39 PM · MITK
kislinsk renamed T27701: Overhaul or remove PluginGenerator from Plugin Generator tests fail to Overhaul or remove PluginGenerator.
Tue, Jan 19, 4:54 AM · MITK, Next Milestone
kislinsk edited projects for T27701: Overhaul or remove PluginGenerator, added: Next Milestone, MITK; removed MITK (2020).
Tue, Jan 19, 4:54 AM · MITK, Next Milestone
kislinsk closed T28173: Get rid of CMake warnings with CMake v3.19 as Resolved.
Tue, Jan 19, 4:41 AM · MITK (2020)
kislinsk added a comment to T28173: Get rid of CMake warnings with CMake v3.19.

Deleted branch from rMITK MITK: bugfix/T28173-CMakeWarnings.

Tue, Jan 19, 4:40 AM · MITK (2020)
kislinsk committed rMITK409a16c91932: Use CMake's FindDCMTK module (authored by kislinsk).
Use CMake's FindDCMTK module
Tue, Jan 19, 4:40 AM
kislinsk committed rMITK6b1b7c6dafcd: Search for DCMTK only if necessary (authored by kislinsk).
Search for DCMTK only if necessary
Tue, Jan 19, 4:40 AM
kislinsk committed rMITKbd82e0170b8c: Reduce CMake config noise (authored by kislinsk).
Reduce CMake config noise
Tue, Jan 19, 4:40 AM
kislinsk committed rMITK9eff0bbb30ed: Get rid of CMake deprecation warning (authored by kislinsk).
Get rid of CMake deprecation warning
Tue, Jan 19, 4:40 AM
kislinsk committed rMITK020d23f2ed29: Merge branch 'bugfix/T28173-CMakeWarnings' into develop (authored by kislinsk).
Merge branch 'bugfix/T28173-CMakeWarnings' into develop
Tue, Jan 19, 4:40 AM
kislinsk added a comment to T28173: Get rid of CMake warnings with CMake v3.19.

Pushed new branch to rMITK MITK: bugfix/T28173-CMakeWarnings.

Tue, Jan 19, 4:40 AM · MITK (2020)
kislinsk triaged T28173: Get rid of CMake warnings with CMake v3.19 as Low priority.
Tue, Jan 19, 4:36 AM · MITK (2020)

Mon, Jan 18

kislinsk triaged T28172: Include MITK-ProjectTemplate in MITK Differential builds as Normal priority.
Mon, Jan 18, 3:07 PM · CI, MITK (2020)
kislinsk closed T28171: Migrate MITK-ProjectTemplate to current MITK develop branch as Resolved.
Mon, Jan 18, 2:45 PM · MITK (2020), MITK-ProjectTemplate
kislinsk added a comment to T28171: Migrate MITK-ProjectTemplate to current MITK develop branch.

Deleted branch from rMPT MITK-ProjectTemplate: bugfix/T28171-MigrateToCurrentMITKDevelopBranch.

Mon, Jan 18, 2:45 PM · MITK (2020), MITK-ProjectTemplate
kislinsk committed rMPT9551835199a1: Merge branch 'bugfix/T28171-MigrateToCurrentMITKDevelopBranch' into develop (authored by kislinsk).
Merge branch 'bugfix/T28171-MigrateToCurrentMITKDevelopBranch' into develop
Mon, Jan 18, 2:44 PM
kislinsk committed rMPTd5f24705e385: Fix enum value names (authored by kislinsk).
Fix enum value names
Mon, Jan 18, 2:44 PM
kislinsk added a comment to T28171: Migrate MITK-ProjectTemplate to current MITK develop branch.

Pushed new branch to rMPT MITK-ProjectTemplate: bugfix/T28171-MigrateToCurrentMITKDevelopBranch.

Mon, Jan 18, 2:43 PM · MITK (2020), MITK-ProjectTemplate
kislinsk triaged T28171: Migrate MITK-ProjectTemplate to current MITK develop branch as Normal priority.
Mon, Jan 18, 2:36 PM · MITK (2020), MITK-ProjectTemplate
kislinsk closed T28170: Test new hooks for MITK-ProjectTemplate as Resolved.
Mon, Jan 18, 2:17 PM · MITK-ProjectTemplate, MITK
kislinsk added a comment to T28170: Test new hooks for MITK-ProjectTemplate.

Deleted branch from rMPT MITK-ProjectTemplate: bugfix/T28170-TestHooks.

Mon, Jan 18, 2:09 PM · MITK-ProjectTemplate, MITK
kislinsk added a comment to T28170: Test new hooks for MITK-ProjectTemplate.

Pushed new branch to rMPT MITK-ProjectTemplate: bugfix/T28170-TestHooks.

Mon, Jan 18, 2:09 PM · MITK-ProjectTemplate, MITK
kislinsk added a comment to T28170: Test new hooks for MITK-ProjectTemplate.

Deleted branch from rMPT MITK-ProjectTemplate: bugfix/T28170-TestHooks.

Mon, Jan 18, 2:08 PM · MITK-ProjectTemplate, MITK
kislinsk added a comment to T28170: Test new hooks for MITK-ProjectTemplate.

Pushed new branch to rMPT MITK-ProjectTemplate: bugfix/T28170-TestHooks.

Mon, Jan 18, 2:08 PM · MITK-ProjectTemplate, MITK
kislinsk added a comment to T28170: Test new hooks for MITK-ProjectTemplate.

Deleted branch from rMPT MITK-ProjectTemplate: bugfix/T28170-TestHooks.

Mon, Jan 18, 2:07 PM · MITK-ProjectTemplate, MITK
kislinsk triaged T28170: Test new hooks for MITK-ProjectTemplate as Normal priority.
Mon, Jan 18, 1:55 PM · MITK-ProjectTemplate, MITK
kislinsk committed rMPTa3cdbda12c8c: Adapt branching model to MITK repository (authored by kislinsk).
Adapt branching model to MITK repository
Mon, Jan 18, 12:51 PM
kislinsk added a comment to T28127: Reopen segmentation in MITK.

It depends. NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION is only for checking in predicates; not for constant use throughout MITK while are there calculations after calculations after calculations and so the values may drift away from the actual truth, right? So for a temporary fix, I'm okay. But we should definitely check what is going on in DCMQI and fix on that side preferably.

Mon, Jan 18, 12:32 PM · Request for Discussion, MITK (2020), Restricted Project, Kaapana (internal)
kislinsk closed T28164: Update date in copyright as Resolved.
Mon, Jan 18, 6:39 AM · MITK (2020)
kislinsk added a comment to T28164: Update date in copyright.

Deleted branch bugfix/T28164-CopyrightDate.

Mon, Jan 18, 6:39 AM · MITK (2020)
kislinsk committed rMITK7609ba5f5be8: Merge branch 'bugfix/T28164-CopyrightDate' into develop (authored by kislinsk).
Merge branch 'bugfix/T28164-CopyrightDate' into develop
Mon, Jan 18, 6:38 AM
kislinsk committed rMITKe1f7ba295014: Adjust date range (authored by kislinsk).
Adjust date range
Mon, Jan 18, 6:38 AM
kislinsk added a comment to T28164: Update date in copyright.

Pushed new branch bugfix/T28164-CopyrightDate.

Mon, Jan 18, 6:38 AM · MITK (2020)
kislinsk triaged T28164: Update date in copyright as Low priority.
Mon, Jan 18, 6:33 AM · MITK (2020)
kislinsk added a comment to T28127: Reopen segmentation in MITK.

Thanks for looking into this issue as well. :-) I think 1e-5 is okay. We/you already introduced NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION not long ago since we had similar issues and 1e-5 should still be conservative enough the purpose of geometries.

Mon, Jan 18, 5:01 AM · Request for Discussion, MITK (2020), Restricted Project, Kaapana (internal)

Fri, Jan 15

kislinsk added a comment to T28159: Officially support MITK using system Qt.

I understand. :-) Just wanted to give you more options to think about as it is probably only a temporal solution. Sooner or later (currently read "later"), our minimum version requirements won't match again with the OS-provided Qt version. So we cannot run away from it forever I guess. :D

Fri, Jan 15, 12:40 PM · CI, Kaapana (internal), Request for Discussion, MITK
kislinsk renamed T27693: Packaging Python does not work/is not implemented from Cannot start nightly workbench on a clean Ubuntu 18/20 to Packaging Python does not work/is not implemented.
Fri, Jan 15, 12:09 PM · MITK
kislinsk merged T27894: Linux nightly installer doesn't start on Fedora into T27693: Packaging Python does not work/is not implemented.
Fri, Jan 15, 12:09 PM · MITK
kislinsk merged task T27894: Linux nightly installer doesn't start on Fedora into T27693: Packaging Python does not work/is not implemented.
Fri, Jan 15, 12:09 PM · MITK (2020)
kislinsk edited projects for T27196: Rewrite packaging of MITK, added: Next Milestone, MITK; removed MITK (2020).
Fri, Jan 15, 12:07 PM · MITK, Next Milestone, Cleared

Thu, Jan 14

kislinsk triaged T28159: Officially support MITK using system Qt as Normal priority.

As it already works (?) and we will stay at least another year with Qt 5 we can do this. But in general, do you know of the new Qt Installer Framework with command-line interface? It's much easier now to install Qt with a single command and there a a few possibilities to provide credentials if that's an issue. See here for examples: https://phabricator.mitk.org/T27960#214043

Thu, Jan 14, 5:22 PM · CI, Kaapana (internal), Request for Discussion, MITK
kislinsk closed T28155: Make Qt log messages optional as Resolved.
Thu, Jan 14, 11:09 AM · MITK (2020)
kislinsk added a comment to T28155: Make Qt log messages optional.

Deleted branch feature/T28155-MakeQtLogMessagesOptional.

Thu, Jan 14, 11:08 AM · MITK (2020)
kislinsk committed rMITK8aeabe996f16: Make Qt log messages optional (authored by kislinsk).
Make Qt log messages optional
Thu, Jan 14, 11:08 AM
kislinsk committed rMITK46eee069a4bf: Merge branch 'feature/T28155-MakeQtLogMessagesOptional' into develop (authored by kislinsk).
Merge branch 'feature/T28155-MakeQtLogMessagesOptional' into develop
Thu, Jan 14, 11:08 AM
kislinsk added a comment to T28155: Make Qt log messages optional.

Pushed new branch feature/T28155-MakeQtLogMessagesOptional.

Thu, Jan 14, 11:07 AM · MITK (2020)

Wed, Jan 13

kislinsk added a revision to T28155: Make Qt log messages optional: Unknown Object (Differential Revision).
Wed, Jan 13, 3:33 PM · MITK (2020)
kislinsk triaged T28155: Make Qt log messages optional as Normal priority.
Wed, Jan 13, 3:26 PM · MITK (2020)
kislinsk updated subscribers of T28151: [macOS] MITK (resp. VTK) doesn't compile with XCode 12.
Wed, Jan 13, 2:53 PM · Noteworthy, MITK (2020)
kislinsk closed T28151: [macOS] MITK (resp. VTK) doesn't compile with XCode 12 as Resolved.

Since we need to patch VTK anyway, I took the opportunity to upgrade from VTK 9.0.0 to 9.0.1.

Wed, Jan 13, 2:52 PM · Noteworthy, MITK (2020)
kislinsk added a comment to T28151: [macOS] MITK (resp. VTK) doesn't compile with XCode 12.

Deleted branch bugfix/T28151-FixVTKOnMacOSXCode12.

Wed, Jan 13, 2:51 PM · Noteworthy, MITK (2020)
kislinsk committed rMITKc0ad4f1441a1: Exclude unistd.h from Windows builds (authored by kislinsk).
Exclude unistd.h from Windows builds
Wed, Jan 13, 2:47 PM
kislinsk committed rMITKda3e2af67311: Merge branch 'bugfix/T28151-FixVTKOnMacOSXCode12' into develop (authored by kislinsk).
Merge branch 'bugfix/T28151-FixVTKOnMacOSXCode12' into develop
Wed, Jan 13, 2:47 PM
kislinsk committed rMITK6617af527acd: Patch (and upgrade) VTK (authored by kislinsk).
Patch (and upgrade) VTK
Wed, Jan 13, 2:16 PM
kislinsk committed rMITKca75fe9867c2: Fix compiler errors with XCode 12 (authored by kislinsk).
Fix compiler errors with XCode 12
Wed, Jan 13, 2:16 PM
kislinsk committed rMITKbce1eaddb837: Merge branch 'bugfix/T28151-FixVTKOnMacOSXCode12' into develop (authored by kislinsk).
Merge branch 'bugfix/T28151-FixVTKOnMacOSXCode12' into develop
Wed, Jan 13, 2:16 PM
kislinsk added a comment to T28151: [macOS] MITK (resp. VTK) doesn't compile with XCode 12.

Pushed new branch bugfix/T28151-FixVTKOnMacOSXCode12.

Wed, Jan 13, 9:45 AM · Noteworthy, MITK (2020)

Mon, Jan 11

kislinsk triaged T28151: [macOS] MITK (resp. VTK) doesn't compile with XCode 12 as Unbreak Now! priority.
Mon, Jan 11, 11:18 PM · Noteworthy, MITK (2020)
kislinsk closed T27717: Mac OS: MITK Workbench&Flowbench crashes immediately after start , a subtask of T27196: Rewrite packaging of MITK, as Resolved.
Mon, Jan 11, 11:12 PM · MITK, Next Milestone, Cleared
kislinsk closed T27717: Mac OS: MITK Workbench&Flowbench crashes immediately after start as Resolved.
Mon, Jan 11, 11:12 PM · MITK (2020)
kislinsk added a comment to T27717: Mac OS: MITK Workbench&Flowbench crashes immediately after start .

Deleted branch bugfix/T27717-FixMacOSInstallerOpenApp.

Mon, Jan 11, 11:12 PM · MITK (2020)
kislinsk committed rMITKff9ca2f439c0: Fix num of chars in strncmp() (authored by kislinsk).
Fix num of chars in strncmp()
Mon, Jan 11, 11:12 PM
kislinsk committed rMITK35cc4be67bda: Merge branch 'bugfix/T27717-FixMacOSInstallerOpenApp' into develop (authored by kislinsk).
Merge branch 'bugfix/T27717-FixMacOSInstallerOpenApp' into develop
Mon, Jan 11, 11:12 PM
kislinsk added a comment to T27717: Mac OS: MITK Workbench&Flowbench crashes immediately after start .

Pushed new branch bugfix/T27717-FixMacOSInstallerOpenApp.

Mon, Jan 11, 11:11 PM · MITK (2020)
kislinsk added a comment to T27717: Mac OS: MITK Workbench&Flowbench crashes immediately after start .

rMITKf54a83e25846: Fix memory leak and refactor parts of BaseApplication

Mon, Jan 11, 9:25 PM · MITK (2020)
kislinsk claimed T27717: Mac OS: MITK Workbench&Flowbench crashes immediately after start .
Mon, Jan 11, 8:56 PM · MITK (2020)
kislinsk added a comment to T28039: DICOM Seg loading error.

I set the GIT_TAG of DCMQI locally to v1.2.3 and I can confirm that the data from above can be loaded.

Mon, Jan 11, 5:01 PM · MITK (2020), Missing Info, Request for Discussion
kislinsk closed T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore as Resolved.

Was removed in rMITK66bb0d67 and forgotten to get restored in rMITK02a46548.

Mon, Jan 11, 3:58 PM · MITK (2020)
kislinsk added a comment to T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore.

Deleted branch bugfix/T28137-FixMissingContextMenuEntries.

Mon, Jan 11, 3:57 PM · MITK (2020)
kislinsk committed rMITK1aa2efd2c474: Add missing context menu extension point line (authored by kislinsk).
Add missing context menu extension point line
Mon, Jan 11, 3:57 PM
kislinsk committed rMITK2e864760744f: Merge branch 'bugfix/T28137-FixMissingContextMenuEntries' into develop (authored by kislinsk).
Merge branch 'bugfix/T28137-FixMissingContextMenuEntries' into develop
Mon, Jan 11, 3:57 PM
kislinsk added a comment to T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore.

Pushed new branch bugfix/T28137-FixMissingContextMenuEntries.

Mon, Jan 11, 3:55 PM · MITK (2020)
kislinsk added a comment to T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore.

Thanks @kalali, nice find and hint. A sneaky line is missing in DataManager's plugin.xml: <extension-point id="contextMenuActions" name="Context menu actions"/>.

Mon, Jan 11, 3:51 PM · MITK (2020)
kislinsk claimed T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore.
Mon, Jan 11, 3:39 PM · MITK (2020)
kislinsk raised the priority of T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore from High to Unbreak Now!.
Mon, Jan 11, 12:08 PM · MITK (2020)

Dec 21 2020

kislinsk closed T28126: 2020 Week 52 (Late December) as Resolved.
Dec 21 2020, 6:52 AM · MITK
kislinsk edited the content of Changelog.
Dec 21 2020, 6:52 AM · MITK
kislinsk added a comment to T28126: 2020 Week 52 (Late December).

Deleted branch release/T28126-2020-Week-52.

Dec 21 2020, 6:51 AM · MITK
kislinsk committed rMITK5dc9bf8b39f9: Merge branch 'master' into develop (authored by kislinsk).
Merge branch 'master' into develop
Dec 21 2020, 6:51 AM
kislinsk committed rMITKbd9ce02f928c: 2020 Week 52 (Late December) (authored by kislinsk).
2020 Week 52 (Late December)
Dec 21 2020, 6:50 AM
kislinsk edited the content of 2020 Week 52 (Late December).
Dec 21 2020, 6:44 AM
kislinsk added a comment to T28126: 2020 Week 52 (Late December).

Pushed new branch release/T28126-2020-Week-52.

Dec 21 2020, 5:16 AM · MITK
kislinsk triaged T28126: 2020 Week 52 (Late December) as Normal priority.
Dec 21 2020, 5:14 AM · MITK
kislinsk created an object: 2020 Week 52 (Late December).
Dec 21 2020, 5:13 AM

Dec 18 2020

kislinsk closed T26237: Improve performance for interactions in 2d widgets as Resolved.
Dec 18 2020, 4:03 AM · MITK
kislinsk added a comment to T26237: Improve performance for interactions in 2d widgets.

Deleted branch bugfix/T26237-ImprovePerformance.

Dec 18 2020, 4:02 AM · MITK
kislinsk committed rMITKbf264ce891b8: Improve performance (authored by kislinsk).
Improve performance
Dec 18 2020, 4:02 AM
kislinsk committed rMITKd05bd6a2660b: Merge remote-tracking branch 'origin/develop' into bugfix/T26237… (authored by kislinsk).
Merge remote-tracking branch 'origin/develop' into bugfix/T26237…
Dec 18 2020, 4:02 AM
kislinsk committed rMITKdbbf947882f4: Improve ITK patch (authored by kislinsk).
Improve ITK patch
Dec 18 2020, 4:02 AM
kislinsk committed rMITKdc76958e5051: Merge branch 'bugfix/T26237-ImprovePerformance' into develop (authored by kislinsk).
Merge branch 'bugfix/T26237-ImprovePerformance' into develop
Dec 18 2020, 4:02 AM