Page MenuHomePhabricator

kislinsk (Stefan Dinkelacker)
UserAdministrator

Projects (15)

User Details

User Since
Aug 1 2016, 11:50 AM (416 w, 4 d)
Roles
Administrator

Recent Activity

Thu, Jul 18

kislinsk added a comment to T30301: Move Totalsegmentator installation into Preferences.

This is still an issue also in combination with general UX improvement of AI tools. I suggest to have a closer look on that together in September so we have enough time for a nice design and implementation until v2024.12.

Thu, Jul 18, 5:26 PM · MITK (v2024.12)
kislinsk moved T30301: Move Totalsegmentator installation into Preferences from Backlog to Segmentation on the MITK (v2024.12) board.
Thu, Jul 18, 5:23 PM · MITK (v2024.12)

Wed, Jul 17

kislinsk added a comment to T30491: Switch off MITK_USE_httplib in Minimal.cmake build configuration.

Deleted branch from rMITK MITK: bugfix/T30491-SwitchOffHttplibInMinimalConfig.

Wed, Jul 17, 11:45 PM · MITK
kislinsk committed rMITKb769330c46bb: Switch off httplib in minimal configuration (authored by kislinsk).
Switch off httplib in minimal configuration
Wed, Jul 17, 11:45 PM
kislinsk closed T30491: Switch off MITK_USE_httplib in Minimal.cmake build configuration as Resolved by committing rMITK5f7b36e760a2: Switch off httplib in minimal configuration.
Wed, Jul 17, 11:45 PM · MITK
kislinsk committed rMITK5f7b36e760a2: Switch off httplib in minimal configuration (authored by kislinsk).
Switch off httplib in minimal configuration
Wed, Jul 17, 11:45 PM
kislinsk moved T30492: Ask for saving on exit of MITK Workbench from Backlog to MITK Meeting on the Request for Discussion board.
Wed, Jul 17, 2:58 PM · Request for Discussion, MITK
kislinsk triaged T30492: Ask for saving on exit of MITK Workbench as Wishlist priority.
Wed, Jul 17, 2:57 PM · Request for Discussion, MITK
kislinsk added a revision to T30491: Switch off MITK_USE_httplib in Minimal.cmake build configuration: Unknown Object (Differential Revision).
Wed, Jul 17, 2:45 PM · MITK
kislinsk added a comment to T30491: Switch off MITK_USE_httplib in Minimal.cmake build configuration.

Pushed new branch to rMITK MITK: bugfix/T30491-SwitchOffHttplibInMinimalConfig.

Wed, Jul 17, 2:44 PM · MITK
kislinsk triaged T30491: Switch off MITK_USE_httplib in Minimal.cmake build configuration as Normal priority.
Wed, Jul 17, 1:28 PM · MITK

Tue, Jul 9

kislinsk added a comment to T30485: MITK Workbench freezes on 4-d images with empty time steps.

Deleted branch from rMITK MITK: bugfix/T30485-HandleNaNImages.

Tue, Jul 9, 9:14 PM · MITK
kislinsk committed rMITKf77bc512c1f3: Check if an image contains any valid pixel value at all (authored by kislinsk).
Check if an image contains any valid pixel value at all
Tue, Jul 9, 9:13 PM
kislinsk committed rMITK1de260a7c1a9: Remove unused typedef (authored by kislinsk).
Remove unused typedef
Tue, Jul 9, 9:13 PM
kislinsk committed rMITK00ef843ff8d9: Extend the search for appropriate level window values to other time steps (authored by kislinsk).
Extend the search for appropriate level window values to other time steps
Tue, Jul 9, 9:13 PM
kislinsk committed rMITK570c0df8de3a: Improve variable name (authored by kislinsk).
Improve variable name
Tue, Jul 9, 9:13 PM
kislinsk committed rMITKb226db94d9e8: Improve readability (authored by kislinsk).
Improve readability
Tue, Jul 9, 9:13 PM
kislinsk closed T30485: MITK Workbench freezes on 4-d images with empty time steps as Resolved by committing rMITK31d3c0df98b6: Fix handling of images with NaN pixel values.
Tue, Jul 9, 9:13 PM · MITK
kislinsk committed rMITK31d3c0df98b6: Fix handling of images with NaN pixel values (authored by kislinsk).
Fix handling of images with NaN pixel values
Tue, Jul 9, 9:13 PM

Mon, Jul 8

kislinsk added a comment to T30454: IO Support for Blosc2.

If I would be them, I also wouldn't like to have another metalayer under my belt. I think we can directly go with our own publishing. We may consider to suggest something like a registry, though, for third-party metalayers. :)

Mon, Jul 8, 10:23 PM · MITK (v2024.12)
kislinsk closed T30484: MITK fails to start workbench as Resolved.

A few people reported trouble starting any MITK application with v2024.06.2. The culprit turned out to be Qt v6.7.1. I refreshed all Windows installers and packages with Qt v6.7.2.

Mon, Jul 8, 3:40 PM · MITK
kislinsk added a comment to T30454: IO Support for Blosc2.

Is there a defined anatomic coordinate system for blosc or the code that wrote the blosc images? Like LPS or RSA (https://www.slicer.org/wiki/Coordinate_systems) may be it differs form the assumption we have in MITK and therefore the memory layout of the pixels is different.

Mon, Jul 8, 8:56 AM · MITK (v2024.12)

Fri, Jul 5

kislinsk changed the visibility for F5241891: Screenshot 2024-07-05 224840.png.
Fri, Jul 5, 11:17 PM
kislinsk added a comment to T30454: IO Support for Blosc2.

First breakthrough: I was able to load and display the n2nd example image from @isensee. The orientation is unexpected, though. Probably rotated 180° (not mirrored?) around the axial axis. Trying to figure out the culprit. I use a the b2nd_to_cbuffer() function to copy the pixel data into the MITK image memory. If this orientation mismatch is systematic, we may be able to solve it by creating a geometry accordingly. At the moment the MITK image is just initialized via pixel type and image dimensions. As far as I am aware, the Blosc2 image does not contain any orientation meta data, right?

Fri, Jul 5, 11:17 PM · MITK (v2024.12)
kislinsk updated subscribers of T30454: IO Support for Blosc2.

c-blosc2 basically has 3 dependencies. We already fulfill an can/should use 2 of them: zlib (resp. zlib-ng) and lz4. The third one is zstd which is no issue, since c-blosc2 comes with an internal version of it if not provided externally.

Fri, Jul 5, 11:50 AM · MITK (v2024.12)
kislinsk added a comment to T30454: IO Support for Blosc2.

Pushed new branch to rMITK MITK: feature/T30454-Blosc2.

Fri, Jul 5, 11:41 AM · MITK (v2024.12)
kislinsk claimed T30454: IO Support for Blosc2.
Fri, Jul 5, 10:14 AM · MITK (v2024.12)

Thu, Jul 4

kislinsk added a revision to T30485: MITK Workbench freezes on 4-d images with empty time steps: Unknown Object (Differential Revision).
Thu, Jul 4, 10:40 AM · MITK
kislinsk added a comment to T30485: MITK Workbench freezes on 4-d images with empty time steps.

Pushed new branch to rMITK MITK: bugfix/T30485-HandleNaNImages.

Thu, Jul 4, 10:36 AM · MITK
kislinsk added a comment to T30485: MITK Workbench freezes on 4-d images with empty time steps.

I think I found a adequate solution:

Thu, Jul 4, 10:32 AM · MITK
kislinsk added a comment to T30485: MITK Workbench freezes on 4-d images with empty time steps.

The origin of the huge level window range is the calculation of the image statistics in mitkImageStatisticsHolder.cpp:100. The function template mitk::_ComputeExtremaInItkImage() is supposed to calculate the extrema and 2nd largest/smallest extrema as well as their counts. However, it does not check for NaN and compares it against the default values (itk::NumericTraits<>::max() resp. NonpositiveMin()). Hence, these extrema stay at their initial default values.

Thu, Jul 4, 9:40 AM · MITK

Wed, Jul 3

kislinsk changed the visibility for F5235634: NoNaN.nrrd.
Wed, Jul 3, 1:35 PM
kislinsk added a comment to T30485: MITK Workbench freezes on 4-d images with empty time steps.

"Empty time steps" turn out be be represented by frames filled with NaN (double). And I think this is the issue. Here's the file were I replaced all NaNs with 0s:

Wed, Jul 3, 1:35 PM · MITK
kislinsk added a comment to T30485: MITK Workbench freezes on 4-d images with empty time steps.

Sounds like a default value initialized with max possible value and the assumption that it would always be set to the actual value later on? How did you step into QmitkSliderLevelWindowWidget::paintEvent()? I always get stuck right before in Qt6Widgets.

Wed, Jul 3, 1:01 PM · MITK
kislinsk added a comment to T30485: MITK Workbench freezes on 4-d images with empty time steps.

The freeze happens at the end of QmitkSliderLevelWindowWidget::resizeEvent() but we need to install the debug files of Qt (Qt6Widgetsd.pdb) for further investigation.

Wed, Jul 3, 11:36 AM · MITK
kislinsk changed the visibility for F5235069: Scan_33.PA.bf.frame.0000047.nrrd.
Wed, Jul 3, 9:42 AM
kislinsk triaged T30485: MITK Workbench freezes on 4-d images with empty time steps as High priority.
Wed, Jul 3, 9:42 AM · MITK

Tue, Jul 2

kislinsk added a comment to T30484: MITK fails to start workbench.

Okay, maybe it is really simple and obvious: I noticed the path in video implies that the Workbench was installed in a OneDrive directory that is synced between multiple PCs. What if it really is just the DLLs missing locally since they are not synced? For example, does C:\Users\adiazpinto\OneDrive - NVIDIA Corporation\Documents\MITK v2024.06.2\bin\MitkCore\MitkModelFitIOServices.dll really exist locally?

Tue, Jul 2, 11:13 AM · MITK
kislinsk added a comment to T30484: MITK fails to start workbench.

I was finally able to play the video from the link above. This looks more like a common system DLL or something similar is missing since basically every DLL is unable to load. We can't really figure out anything without access to an affected system. In that case I would run Dependencies on the Workbench executable after making sure to set the same path as in the start batch file.

Tue, Jul 2, 11:05 AM · MITK
kislinsk added a comment to T30484: MITK fails to start workbench.

Here's the other report: T30448: MITK snapshots/2024-05-02 Workbench not restarting

Tue, Jul 2, 9:54 AM · MITK

Mon, Jul 1

kislinsk added a comment to T30484: MITK fails to start workbench.

I use it on Windows 11 just fine. We recently had a similar report from someone using Windows 10. I throw anti-virus / defender as culprint into the ring.

Mon, Jul 1, 6:50 PM · MITK

Fri, Jun 28

kislinsk closed T29421: Finding CppRestSDK library alternative as Resolved.
Fri, Jun 28, 8:51 AM · MITK (v2024.12)
kislinsk added a comment to T29421: Finding CppRestSDK library alternative.

Deleted branch from rMITK MITK: bugfix/T29421-RemoveCPPRestSDK.

Fri, Jun 28, 8:51 AM · MITK (v2024.12)
kislinsk committed rMITKf3f41401d040: Remove C++ REST SDK dependency (authored by kislinsk).
Remove C++ REST SDK dependency
Fri, Jun 28, 8:50 AM
kislinsk committed rMITK846e41531a9c: Merge branch 'bugfix/T29421-RemoveCPPRestSDK' into develop (authored by kislinsk).
Merge branch 'bugfix/T29421-RemoveCPPRestSDK' into develop
Fri, Jun 28, 8:50 AM

Thu, Jun 27

kislinsk closed T30482: MITK v2024.06.2 as Resolved.
Thu, Jun 27, 8:22 AM · MITK
kislinsk edited the content of Changelog.
Thu, Jun 27, 8:22 AM · MITK
kislinsk edited the content of MITK v2024.06.2.
Thu, Jun 27, 8:21 AM
kislinsk edited the content of MITK v2024.06.
Thu, Jun 27, 8:20 AM
kislinsk edited the content of MITK v2024.06.
Thu, Jun 27, 8:19 AM
kislinsk closed T30483: Fix typos in Segmentation Utilities as Resolved.
Thu, Jun 27, 8:17 AM · MITK
kislinsk added a comment to T30482: MITK v2024.06.2.

Pushed new branch to rMITK MITK: hotfix/T30482-v2024.06.2.

Thu, Jun 27, 8:08 AM · MITK
kislinsk added a comment to T30483: Fix typos in Segmentation Utilities.

Deleted branch from rMITK MITK: bugfix/T30483-FixTyposInSegmentationUtilities.

Thu, Jun 27, 8:07 AM · MITK
kislinsk committed rMITKb1cb1e823bde: Fix typos (authored by kislinsk).
Fix typos
Thu, Jun 27, 8:06 AM
kislinsk committed rMITKdfee4f84afad: Merge branch 'bugfix/T30483-FixTyposInSegmentationUtilities' into develop (authored by kislinsk).
Merge branch 'bugfix/T30483-FixTyposInSegmentationUtilities' into develop
Thu, Jun 27, 8:06 AM
kislinsk added a comment to T30483: Fix typos in Segmentation Utilities.

Pushed new branch to rMITK MITK: bugfix/T30483-FixTyposInSegmentationUtilities.

Thu, Jun 27, 8:06 AM · MITK
kislinsk triaged T30483: Fix typos in Segmentation Utilities as Normal priority.
Thu, Jun 27, 8:03 AM · MITK
kislinsk triaged T30482: MITK v2024.06.2 as Normal priority.
Thu, Jun 27, 7:58 AM · MITK
kislinsk edited the content of MITK v2024.06.2.
Thu, Jun 27, 7:57 AM
kislinsk created an object: MITK v2024.06.2.
Thu, Jun 27, 7:56 AM
kislinsk deleted MITK v2024.04.2.
Thu, Jun 27, 7:56 AM
kislinsk created an object: MITK v2024.04.2.
Thu, Jun 27, 7:55 AM

Jun 26 2024

kislinsk added a revision to T30481: [DICOM] Handle multiple images with no position information correctly: Unknown Object (Differential Revision).
Jun 26 2024, 11:53 PM · MITK (v2024.12), Request for Discussion

Jun 25 2024

kislinsk added a comment to T30478: MITKFileConverter multiple output index before last extension.

Wouldn't that break support of compressed files like foo.nii.gz for example?

Jun 25 2024, 9:57 AM · MITK (v2024.12), Request for Discussion, Breaking Change
kislinsk added a revision to T29421: Finding CppRestSDK library alternative: Unknown Object (Differential Revision).
Jun 25 2024, 4:31 AM · MITK (v2024.12)
kislinsk added a comment to T29421: Finding CppRestSDK library alternative.

Pushed new branch to rMITK MITK: bugfix/T29421-RemoveCPPRestSDK.

Jun 25 2024, 4:30 AM · MITK (v2024.12)
kislinsk edited projects for T29421: Finding CppRestSDK library alternative, added: MITK (v2024.12); removed MITK.
Jun 25 2024, 4:26 AM · MITK (v2024.12)
kislinsk edited projects for T30430: [TotalSeg] Add check if python venv exists before installation, added: MITK (v2024.06); removed MITK (v2024.12).
Jun 25 2024, 4:03 AM · MITK (v2024.06)
kislinsk closed T30430: [TotalSeg] Add check if python venv exists before installation as Resolved.
Jun 25 2024, 4:03 AM · MITK (v2024.06)

Jun 19 2024

kislinsk added a comment to T29390: How to ease the handling of external generated segmentations.

Deleted branch from rMITK MITK: feature/T29390-Improve_conversion_for_multilabel.

Jun 19 2024, 11:39 AM · MITK (v2024.06)
kislinsk added a comment to T30469: Build MITK CoreCmdApps on CentOS 7.

Deleted branch from rMITK MITK: feature/T30469-SupportExperimentalFilesystem.

Jun 19 2024, 11:38 AM · MITK (v2024.06)
kislinsk added a comment to T30387: [SEG] More visual feedback by supporting highlighted labels in render window..

Deleted branch from rMITK MITK: feature/T30387-highlight_labels.

Jun 19 2024, 11:38 AM · MITK (v2024.06)
kislinsk added a comment to T29317: Clean up DICOM Browser plugin.

Deleted branch from rMITK MITK: bugfix/T29317-CleanUpDICOMBrowser.

Jun 19 2024, 11:36 AM · MITK (v2024.12)
kislinsk closed T29317: Clean up DICOM Browser plugin, a subtask of T24398: Dicom plugin: Retrieve does not work, as Wontfix.
Jun 19 2024, 11:36 AM · MITK (v2024.12)
kislinsk closed T29317: Clean up DICOM Browser plugin as Wontfix.

Meanwhile a lot of code in CTK regarding the DICOM browser changed and the branch her is outdated so much that it makes sense to start from scratch again, if really necessary at all.

Jun 19 2024, 11:36 AM · MITK (v2024.12)
kislinsk added a comment to T30222: [Registration] Enable use of parameters for command line MiniApp.

Deleted branch from rMITK MITK: feature/T30222-MatchImageMiniApp_add_parameter_support.

Jun 19 2024, 11:33 AM · MITK (v2023.12)
kislinsk added a comment to T30294: {SEG] Remove label set structure.

Deleted branch from rMITK MITK: feature/T30294-Remove_LabelSet_class.

Jun 19 2024, 11:33 AM · Breaking Change, MITK (v2024.06)
kislinsk added a comment to T28487: MitkMRSignal2Concentration MiniApp does not correctly handles exceptions in app configuration step.

Deleted branch from rMITK MITK: bugfix/T28487-MitkMRSignal2Concentration_handle_exceptions.

Jun 19 2024, 11:33 AM · MITK
kislinsk added a comment to T27196: Rewrite packaging of MITK.

Deleted branch from rMITK MITK: bugfix/T27196-RewritePackaging.

Jun 19 2024, 11:31 AM · MITK, Cleared
kislinsk edited projects for T27196: Rewrite packaging of MITK, added: MITK; removed MITK (v2024.12).
Jun 19 2024, 11:30 AM · MITK, Cleared
kislinsk added a comment to T29371: [Registration] Improve view icons.

Deleted branch from rMITK MITK: bugfix/T29371-ImproveRegistrationIcons.

Jun 19 2024, 11:30 AM · MITK
kislinsk closed T29371: [Registration] Improve view icons as Wontfix.
Jun 19 2024, 11:30 AM · MITK
kislinsk added a comment to T29603: Warn (as error) in Visual Studio for unreferenced parameters and variables to match our GCC/Clang settings.

Deleted branch from rMITK MITK: bugfix/T29603-MatchVisualStudioCompilerErrorsBetterToGCCAndClang.

Jun 19 2024, 11:28 AM · MITK
kislinsk added a comment to T30321: Upgrade dependencies to be compatible with Ubuntu 23.10+.

Deleted branch from rMITK MITK: bugfix/T30321-Ubuntu_23.10_Compatibility.

Jun 19 2024, 11:26 AM · MITK
kislinsk added a comment to T30334: Images are not rendered anymore in 3-d window.

Deleted branch from rMITK MITK: bugfix/T30334-FixPlaneGeometryDataToSurfaceFilter.

Jun 19 2024, 11:26 AM · MITK
kislinsk closed T30255: Allow render window utility widgets on all sides as Wontfix.

We weren't able to get the PR working.

Jun 19 2024, 11:26 AM · MITK (v2024.12), Pull Request
kislinsk added a comment to T30255: Allow render window utility widgets on all sides .

Deleted branch from rMITK MITK: feature/T30255-RenderWindowUtilityWidgets.

Jun 19 2024, 11:25 AM · MITK (v2024.12), Pull Request

Jun 17 2024

kislinsk closed T30448: MITK snapshots/2024-05-02 Workbench not restarting as Invalid.

I close this task as invalid. We were not able to reproduce this issue at all and we never heard of if by anyone else. Feel free to reopen the task if there's a reliable recipe for reproduction.

Jun 17 2024, 2:42 PM · MITK (v2024.12), Missing Info
kislinsk triaged T30359: MITK MiniApps in Kaapana as Normal priority.
Jun 17 2024, 2:40 PM · MITK
kislinsk triaged T30310: Add new views, e.g. for Seg Task List or Perfusion as Wishlist priority.
Jun 17 2024, 2:39 PM · Missing Info, MITK
kislinsk triaged T18489: Help perspective cannot be closed as Low priority.
Jun 17 2024, 2:38 PM · MITK (v2024.12), Request for Discussion
kislinsk closed T23748: Image should have a valid DICOM.0008.0018 proprety, a subtask of T23774: Implement helper to correctly (DICOM conformal) parameterize images (or other BaseData derived classes), as Wontfix.
Jun 17 2024, 2:36 PM · MITK
kislinsk closed T28780: Levelwindow widgets - add labels to the edit field as Wontfix.

Hi there! 🙂

Jun 17 2024, 2:36 PM · Auto-closed, MITK
kislinsk closed T27140: Fusion of two 5DoF tools to a 6DoF tool as Wontfix.

Hi there! 🙂

Jun 17 2024, 2:36 PM · Auto-closed, IGT, MITK
kislinsk closed T23748: Image should have a valid DICOM.0008.0018 proprety as Wontfix.

Hi there! 🙂

Jun 17 2024, 2:36 PM · Auto-closed, MITK
kislinsk closed T23748: Image should have a valid DICOM.0008.0018 proprety, a subtask of T23746: MITK and DICOM (realization), as Wontfix.
Jun 17 2024, 2:36 PM · MITK
kislinsk closed T24402: Improve clang-format support as Wontfix.

Hi there! 🙂

Jun 17 2024, 2:36 PM · Auto-closed, MITK
kislinsk closed T24295: mitk::LocaleSwitch promotes illpossed pattern and excessive use reduces thread savety as Wontfix.

Hi there! 🙂

Jun 17 2024, 2:36 PM · Restricted Project, MITK
kislinsk closed T24692: Scene serialization is corrupted due to images stored with wrong locale as Wontfix.

Hi there! 🙂

Jun 17 2024, 2:36 PM · Auto-closed, Restricted Project, MITK
kislinsk closed T27231: In Matchpoint Algorithm Control: It is necessary to select the algorithm twice as Wontfix.

Hi there! 🙂

Jun 17 2024, 2:36 PM · Auto-closed, MITK