Page MenuHomePhabricator | MITK

kislinsk (Stefan Dinkelacker)Administrator
User

Projects (12)

User Details

User Since
Aug 1 2016, 11:50 AM (115 w, 3 d)
Roles
Administrator

Recent Activity

Wed, Oct 17

kislinsk closed T24563: Superbuild: Boost build fails in RelWithDebInfo as Resolved.

Thanks for noticing. The new Boost.cmake script will support all four CMake build configurations.

Wed, Oct 17, 1:42 PM · MITK
kislinsk closed T24563: Superbuild: Boost build fails in RelWithDebInfo, a subtask of T24615: Make Boost build robust, as Resolved.
Wed, Oct 17, 1:42 PM · MITK (2018-04)
kislinsk closed T24222: FindBoost does not work with superbuild boost as Resolved.

Boost stopped to support newer toolset versions than 14.1 for the time being as they are binary compatible in the 14.x range. The new Boost.cmake script will be based on major versions to be at least minimum future-proof for 15.0 and upwards.

Wed, Oct 17, 1:41 PM · MITK
kislinsk closed T24222: FindBoost does not work with superbuild boost, a subtask of T24615: Make Boost build robust, as Resolved.
Wed, Oct 17, 1:41 PM · MITK (2018-04)
kislinsk added a comment to T24333: Noteworthy new features since MITK 2016.11.

MITK_PP_ macros were replaced with their original BOOST_PP_ counterparts. Only mitkPPArgCount.h is left as it doesn't originate from Boost.

Wed, Oct 17, 9:41 AM · MITK (2018-04)
kislinsk committed rMITK807c60ad7ec5: Use Boost.Preprocessor (authored by kislinsk).
Use Boost.Preprocessor
Wed, Oct 17, 9:27 AM
kislinsk committed rMITK21990e1e7aff: Use Boost imported targets (authored by kislinsk).
Use Boost imported targets
Wed, Oct 17, 9:27 AM
kislinsk added a comment to T24615: Make Boost build robust.

Pushed new branch T24615-FixBoostRelatedIssues.

Wed, Oct 17, 9:27 AM · MITK (2018-04)
kislinsk closed T20093: Remove mangled boost headers as Resolved.
Wed, Oct 17, 9:26 AM · Restricted Project, MITK
kislinsk closed T20093: Remove mangled boost headers, a subtask of T24615: Make Boost build robust, as Resolved.
Wed, Oct 17, 9:26 AM · MITK (2018-04)
kislinsk closed T19550: [CMake 3.5] Use Boost imported targets as Resolved.
Wed, Oct 17, 8:57 AM · Restricted Project, Bugzilla, MITK
kislinsk closed T19550: [CMake 3.5] Use Boost imported targets, a subtask of T24615: Make Boost build robust, as Resolved.
Wed, Oct 17, 8:57 AM · MITK (2018-04)

Tue, Oct 16

kislinsk closed T24993: DICOM Plugin doesn't build as Resolved.

Fixed in beta branch. Turned out it wasn't found on Linux and macOS at least since 2013. I just double-checked the 2016.11 installers and storescp was set manually back then.

Tue, Oct 16, 2:55 PM · MITK (2018-04)
kislinsk committed rMITK934a093e44a9: Fix warnings (authored by kislinsk).
Fix warnings
Tue, Oct 16, 2:43 PM
kislinsk committed rMITKf34045570dfa: Find DCMTK storescp also on Linux and macOS (authored by kislinsk).
Find DCMTK storescp also on Linux and macOS
Tue, Oct 16, 2:43 PM
kislinsk committed rMITK160394d48ee0: Remove background fill color (authored by kislinsk).
Remove background fill color
Tue, Oct 16, 1:55 PM
kislinsk committed rMITK638b55e5424d: Fix toolbar ext button width on macOS (authored by kislinsk).
Fix toolbar ext button width on macOS
Tue, Oct 16, 1:55 PM
kislinsk committed rMITK6c1096a287a8: Style label set widget items (authored by kislinsk).
Style label set widget items
Tue, Oct 16, 12:54 PM
kislinsk committed rMITKd10961def932: Style selected abstract view items (authored by kislinsk).
Style selected abstract view items
Tue, Oct 16, 11:20 AM
kislinsk closed T25526: Workbench crashes when double-clicking on multilabel-segmentation label using 3D+t images as Resolved.
Tue, Oct 16, 10:39 AM · MITK (2018-04)
kislinsk committed rMITK9663bdc87fac: Merge branch 'T25526-DoubleClickOnLabelItemCrash' into T25191-v2018.04-beta (authored by kislinsk).
Merge branch 'T25526-DoubleClickOnLabelItemCrash' into T25191-v2018.04-beta
Tue, Oct 16, 10:39 AM
kislinsk committed rMITK8899f8328902: Update center of mass also in 4-d labels (authored by kislinsk).
Update center of mass also in 4-d labels
Tue, Oct 16, 10:38 AM
kislinsk added a comment to T25526: Workbench crashes when double-clicking on multilabel-segmentation label using 3D+t images .

Pushed new branch T25526-DoubleClickOnLabelItemCrash.

Tue, Oct 16, 10:38 AM · MITK (2018-04)
kislinsk added a comment to T25526: Workbench crashes when double-clicking on multilabel-segmentation label using 3D+t images .

This error occurs when double-clicking on a label (no need for a second label to be present), or when searching for a label. Both code paths end in a request to update the label's center of the mass which is currently not compiled for four-dimensional images.

Tue, Oct 16, 10:36 AM · MITK (2018-04)
kislinsk edited projects for T25435: time function for segmentation tasks of 2d/3d+t data, added: MITK (2018-04); removed MITK.
Tue, Oct 16, 8:59 AM · MITK (2018-04)
kislinsk removed a project from T25435: time function for segmentation tasks of 2d/3d+t data: Request for Discussion.
Tue, Oct 16, 8:59 AM · MITK (2018-04)
kislinsk triaged T25527: Auto-cycle feature for stepping through 3d+t data as Wishlist priority.
Tue, Oct 16, 8:59 AM · MITK
kislinsk triaged T25525: Make keys for timestep increase/decrease configurable through preferences as Wishlist priority.
Tue, Oct 16, 8:49 AM · MITK
kislinsk added a comment to T25435: time function for segmentation tasks of 2d/3d+t data.

The single-step increase/decrease feature is in the beta branch now. I'll create subtasks for remaining TODOs.

Tue, Oct 16, 8:47 AM · MITK (2018-04)
kislinsk closed T25465: Workbench doesn't close because of using futures as Wontfix.
Tue, Oct 16, 8:44 AM · MITK
kislinsk closed T25465: Workbench doesn't close because of using futures, a subtask of T25435: time function for segmentation tasks of 2d/3d+t data, as Wontfix.
Tue, Oct 16, 8:44 AM · MITK (2018-04)
kislinsk committed rMITK50cc26030ed7: Merge branch 'T25435-TimeFunctionForSegmentationBasedOnBetaBranch' into T25191… (authored by kislinsk).
Merge branch 'T25435-TimeFunctionForSegmentationBasedOnBetaBranch' into T25191…
Tue, Oct 16, 8:34 AM

Fri, Oct 12

kislinsk edited projects for T24615: Make Boost build robust, added: MITK (2018-04); removed Request for Discussion, MITK.
Fri, Oct 12, 5:25 PM · MITK (2018-04)
kislinsk added a comment to T24615: Make Boost build robust.

Probably found the origin of issue. We're calling booststrap.bat on Windows and bootstrap.sh on other platforms. The latter script has lots of parameters like --with-toolset=..., while the former script just knows a single parameter like vc141. However, we currently assume that the former script would also understand --with-toolset=v141. The script doesn't know how to handle this and falls back to something else.

Fri, Oct 12, 4:22 PM · MITK (2018-04)
kislinsk renamed T24615: Make Boost build robust from Boost Build fails for current Superbuild using Visual Studio 2017 to Make Boost build robust.
Fri, Oct 12, 2:05 PM · MITK (2018-04)
kislinsk added subtasks for T24615: Make Boost build robust: T19550: [CMake 3.5] Use Boost imported targets, T20093: Remove mangled boost headers, T24222: FindBoost does not work with superbuild boost, T22656: Boost binaries provoke a compile error in superbuild when built for multiple configurations, T24563: Superbuild: Boost build fails in RelWithDebInfo.
Fri, Oct 12, 2:02 PM · MITK (2018-04)
kislinsk added a parent task for T19550: [CMake 3.5] Use Boost imported targets: T24615: Make Boost build robust.
Fri, Oct 12, 2:02 PM · Restricted Project, Bugzilla, MITK
kislinsk added a parent task for T20093: Remove mangled boost headers: T24615: Make Boost build robust.
Fri, Oct 12, 2:02 PM · Restricted Project, MITK
kislinsk added a parent task for T22656: Boost binaries provoke a compile error in superbuild when built for multiple configurations: T24615: Make Boost build robust.
Fri, Oct 12, 2:02 PM · Restricted Project
kislinsk added a parent task for T24222: FindBoost does not work with superbuild boost: T24615: Make Boost build robust.
Fri, Oct 12, 2:02 PM · MITK
kislinsk added a parent task for T24563: Superbuild: Boost build fails in RelWithDebInfo: T24615: Make Boost build robust.
Fri, Oct 12, 2:02 PM · MITK
kislinsk committed rMITK520af5b2de0d: Add time function for segmentation (authored by tsvetkov).
Add time function for segmentation
Fri, Oct 12, 10:22 AM
kislinsk added a comment to T25435: time function for segmentation tasks of 2d/3d+t data.

Pushed new branch T25435-TimeFunctionForSegmentationBasedOnBetaBranch.

Fri, Oct 12, 10:22 AM · MITK (2018-04)
kislinsk closed T22608: IOUtils::LoadSurface and similar methods do not try hard enough as Resolved.

Please re-open if I made wrong assumptions:

Fri, Oct 12, 8:58 AM · MITK

Thu, Oct 11

kislinsk added a member for MITK: tsvetkov.
Thu, Oct 11, 11:11 AM

Wed, Oct 10

kislinsk added a comment to T25510: Revolutionize Superbuild.

It would also be much more convenient if our build script would detect a thirdparty toolkit upgrade and remove the old version first before installing the new version. This is something that has to be done manually at the moment and it sucks big time to do this for all the remote continuous dart clients for example.

Wed, Oct 10, 3:45 AM · Request for Discussion, MITK

Tue, Oct 9

kislinsk created Medical Detection Toolkit.
Tue, Oct 9, 11:01 AM

Sun, Oct 7

kislinsk updated the image for mitk.org from F1187555: profile to F1187559: fa-briefcase-orange.png.
Sun, Oct 7, 10:03 AM
kislinsk renamed mitk.org from mitk.org Homepage to mitk.org.
Sun, Oct 7, 10:03 AM
kislinsk set the image for mitk.org to F1187555: profile.
Sun, Oct 7, 9:58 AM
kislinsk added a hashtag to mitk.org: #mitk.org.
Sun, Oct 7, 9:57 AM
kislinsk created mitk.org.
Sun, Oct 7, 9:56 AM

Fri, Oct 5

kislinsk committed rMITKb7f15b92cf4e: Fix memory leaks (authored by kislinsk).
Fix memory leaks
Fri, Oct 5, 11:25 AM
kislinsk closed T25495: Memory Leak in QmitkSegmentationOrganNamesHandling as Resolved.
Fri, Oct 5, 11:20 AM · MITK (2018-04)
kislinsk committed rMITK085bb97bea59: Merge branch 'T25495-MemoryLeak' (authored by kislinsk).
Merge branch 'T25495-MemoryLeak'
Fri, Oct 5, 10:51 AM
kislinsk committed rMITKf6cdd8d3a95b: Fix memory leaks (authored by kislinsk).
Fix memory leaks
Fri, Oct 5, 10:48 AM
kislinsk added a project to T24540: DICOMReader module does not support Philips US 3D files on its "own": Restricted Project.
Fri, Oct 5, 10:14 AM · Restricted Project, MITK
kislinsk committed rMITKbe94d49ab4a0: Merge branch 'T25495-MemoryLeak' (authored by kislinsk).
Merge branch 'T25495-MemoryLeak'
Fri, Oct 5, 10:10 AM
kislinsk committed rMITKd872362ebacc: Fix memory leaks (authored by kislinsk).
Fix memory leaks
Fri, Oct 5, 10:09 AM
kislinsk reopened T25495: Memory Leak in QmitkSegmentationOrganNamesHandling as "Open".
Fri, Oct 5, 10:02 AM · MITK (2018-04)
kislinsk triaged T25498: Stopping of MitkPharmacokineticModelsServices outputs warning in tests as High priority.
Fri, Oct 5, 9:38 AM · MITK
kislinsk triaged T25497: Auto-loading of module MitkDICOMQIIO fails in tests as High priority.
Fri, Oct 5, 9:35 AM · MITK
kislinsk reassigned T25435: time function for segmentation tasks of 2d/3d+t data from menjivar to tsvetkov.

@tsvetkov is currently working on this task. Did you guys coordinate? :-)

Fri, Oct 5, 9:19 AM · MITK (2018-04)
kislinsk closed T24790: Build fails on Fedora 28 as Resolved.
Fri, Oct 5, 9:18 AM · MITK (2018-04)
kislinsk triaged T24615: Make Boost build robust as Normal priority.
Fri, Oct 5, 9:17 AM · MITK (2018-04)
kislinsk triaged T24540: DICOMReader module does not support Philips US 3D files on its "own" as Wishlist priority.

What's the status on this one?

Fri, Oct 5, 9:16 AM · Restricted Project, MITK
kislinsk triaged T24447: CommonWL profiles for our MiniApps/Container as Wishlist priority.
Fri, Oct 5, 9:16 AM · Request for Discussion, d:cipher, MITK
kislinsk triaged T24342: Make ToFProcessing memory safe as Low priority.
Fri, Oct 5, 9:15 AM · MITK
kislinsk triaged T24311: MITK crashes on closing the application if GetDataManagerSelection() is called in views Visible() method as Low priority.

Lower priority as nothing happened so far.

Fri, Oct 5, 9:14 AM · MITK
kislinsk triaged T24303: A segmentation should generate all DICOM relevant IDs as soon as it can be referenced. as Wishlist priority.
Fri, Oct 5, 9:14 AM · Request for Discussion, MITK
kislinsk triaged T24295: mitk::LocaleSwitch promotes illpossed pattern and excessive use reduces thread savety as Low priority.
Fri, Oct 5, 9:13 AM · Restricted Project, MITK
kislinsk triaged T24692: Scene serialization is corrupted due to images stored with wrong locale as Low priority.

Currently fixed with workaround, hence no pressing issue. Set priority to low but add #community_day tag.

Fri, Oct 5, 9:12 AM · Restricted Project, MITK
kislinsk closed T24399: MITK v2016.11: Build issue on Mac OS X 10.13.3 as Resolved.

Should work in 2018.04 (beta). Minimum recommended version for macOS in now High Sierra. Mojave works as well.

Fri, Oct 5, 9:07 AM · MITK
kislinsk triaged T25491: OpenGL warning in Cmake as Low priority.
Fri, Oct 5, 9:05 AM · MITK
kislinsk closed T25495: Memory Leak in QmitkSegmentationOrganNamesHandling as Resolved.
Fri, Oct 5, 8:57 AM · MITK (2018-04)
kislinsk added a comment to T25495: Memory Leak in QmitkSegmentationOrganNamesHandling.

Found same leak also in mitk::DICOMSegmentationPropertyHelper.

Fri, Oct 5, 8:57 AM · MITK (2018-04)
kislinsk committed rMITKe961c415a7e9: Merge branch 'T25495-MemoryLeak' (authored by kislinsk).
Merge branch 'T25495-MemoryLeak'
Fri, Oct 5, 8:56 AM
kislinsk committed rMITK700cd45cc388: Fix memory leaks (authored by kislinsk).
Fix memory leaks
Fri, Oct 5, 8:54 AM
kislinsk added a comment to T25495: Memory Leak in QmitkSegmentationOrganNamesHandling.

Pushed new branch T25495-MemoryLeak.

Fri, Oct 5, 8:54 AM · MITK (2018-04)
kislinsk triaged T25495: Memory Leak in QmitkSegmentationOrganNamesHandling as Normal priority.
Fri, Oct 5, 8:51 AM · MITK (2018-04)

Tue, Oct 2

kislinsk added a task to rMITKd93b1bde8192: First fix: T25441: Name DataNodes with DICOM data appropriately by using dicom tags.
Tue, Oct 2, 10:17 AM
kislinsk committed rMITKb42dbe0dd8b9: Merge remote-tracking branch 'origin/T25191-v2018.04-beta' (authored by kislinsk).
Merge remote-tracking branch 'origin/T25191-v2018.04-beta'
Tue, Oct 2, 10:17 AM
kislinsk added a commit to T25441: Name DataNodes with DICOM data appropriately by using dicom tags: rMITKd93b1bde8192: First fix.
Tue, Oct 2, 10:17 AM · MITK
kislinsk committed rMITK6020e3ba6ef1: Hint at default install locations of Qt (authored by kislinsk).
Hint at default install locations of Qt
Tue, Oct 2, 9:22 AM

Mon, Oct 1

kislinsk added a comment to T25469: Improve MITK build experience.

I (hopefully) improved our CMake script by hint find_package(Qt5) at Qt default install locations (C:/Qt). Only MSVC for now, Linux and macOS are following tomorrow with /opt/Qt and ~/Qt.

Mon, Oct 1, 9:40 PM · MITK (2018-04)
kislinsk committed rMITKe67f98585e89: Hint at default install locations of Qt (authored by kislinsk).
Hint at default install locations of Qt
Mon, Oct 1, 9:34 PM
kislinsk added a comment to T25441: Name DataNodes with DICOM data appropriately by using dicom tags.

I cherry-picked the two revisions into the beta branch.

Mon, Oct 1, 3:10 PM · MITK
kislinsk committed rMITK21965156e0d2: Fixed gcc compile errors of T25441 (authored by floca).
Fixed gcc compile errors of T25441
Mon, Oct 1, 3:09 PM
kislinsk committed rMITKd93b1bde8192: First fix (authored by floca).
First fix
Mon, Oct 1, 3:09 PM
kislinsk moved T25186: Set version information from Backlog to Blocking v2018.04 on the MITK (2018-04) board.
Mon, Oct 1, 12:25 PM · MITK (2018-04)
kislinsk moved T25469: Improve MITK build experience from Blocking v2018.04 to Backlog on the MITK (2018-04) board.
Mon, Oct 1, 12:25 PM · MITK (2018-04)
kislinsk moved T25469: Improve MITK build experience from Backlog to Blocking v2018.04 on the MITK (2018-04) board.
Mon, Oct 1, 12:25 PM · MITK (2018-04)
kislinsk triaged T25469: Improve MITK build experience as Normal priority.
Mon, Oct 1, 12:25 PM · MITK (2018-04)
kislinsk added a comment to T25469: Improve MITK build experience.

I made the minimum required versions of compilers and Qt more consistent in our CMake scripts as well as the documentation.

Mon, Oct 1, 12:24 PM · MITK (2018-04)
kislinsk committed rMITKbb16886d6cbe: Improve minimum required version consistency (authored by kislinsk).
Improve minimum required version consistency
Mon, Oct 1, 11:45 AM
kislinsk committed rMITK0896968b27a3: Suppress OpenGL deprecation warnings on macOS 10.14 (authored by kislinsk).
Suppress OpenGL deprecation warnings on macOS 10.14
Mon, Oct 1, 11:18 AM
kislinsk committed rMITKc614f933e1e8: Increase minimum supported macOS version to 10.13 (authored by kislinsk).
Increase minimum supported macOS version to 10.13
Mon, Oct 1, 10:47 AM

Fri, Sep 28

kislinsk added a comment to T25469: Improve MITK build experience.

I enhanced our CMake script to pre-set the Visual Studio redistributable, which already comes along with Visual Studio 2017.

Fri, Sep 28, 4:32 PM · MITK (2018-04)
kislinsk committed rMITK5b398d60b952: Try at least a little to pre-set MSVC redistributable (authored by kislinsk).
Try at least a little to pre-set MSVC redistributable
Fri, Sep 28, 3:49 PM
kislinsk removed a project from T23104: Deprecate QmitkPlotWidget: Request for Discussion.
Fri, Sep 28, 11:12 AM · Restricted Project, MITK