Page MenuHomePhabricator

"Rename Label" window improvements
Closed, ResolvedPublic

Assigned To
Authored By
j562r
Oct 8 2022, 1:42 PM
Referenced Files
F2577315: diffs.txt
Oct 8 2022, 1:42 PM
F2577313: Screenshot 2022-10-08 133122.png
Oct 8 2022, 1:42 PM
F2577311: image.png
Oct 8 2022, 1:42 PM

Description

I would like to propose some improvements to the Rename Label window:

  1. Currently the window is a bit small so that we can't see all labels at once:
    image.png (405×508 px, 31 KB)
    For a reasonable number of labels it would be cool if the window scales so that all labels are visible. This avoids unnecessary scrolling.
  2. (minor) The list of labels is always sorted and does not respect the order defined in dataset_labels.json. Our clinical partners have their own organ ordering which they also would like to see when annotating the data. My current workaround for this issue is to prepend the labels with numbers, 01_, 02, etc. This does the job so if you don't want this feature, it is also fine with us.
  3. For faster access of the Rename Label window, I trigger it also via double click on the label name. Not sure if this works for every case but at least from a user perspective double click on a label did nothing before, so maybe it is a sensible default?

My current solution for (1)

Screenshot 2022-10-08 133122.png (812×332 px, 22 KB)

is a bit hacky and I can already tell that it does not work for every DPI scaling (but I think DPI is also an issue at other places). It makes also sense if the window does not get larger then the screen size.

Attached also my changes, just for reference.

Revisions and Commits

rMITK MITK
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision

Event Timeline

kislinsk triaged this task as Wishlist priority.

Regarding point 3: Currently the doule click (should) allow to jump to the centroid of the label. So it has a purpose. Don't know what makes more sense UX wise. May be a keyboard short cut for renaming may also be sufficient?

There is already a shortcut for renaming: Ctrl+L, R but I found this too inconvenient and always ended up doing right click -> Rename instead.

Maybe CTRL + double click would be an option to have both functionalities (label centroid and renaming dialog)?

One question. The current implementation has always standard suggestions and the custom suggestions are added. I am wondering it wouldn't be better if in case of custom suggestions are given, only the custom suggestions appear.
E.g. with the current logic we would be able to allow people define a study that only contain special custom suggestions and not the standard ones, would we?

One question. The current implementation has always standard suggestions and the custom suggestions are added. I am wondering it wouldn't be better if in case of custom suggestions are given, only the custom suggestions appear.
E.g. with the current logic we would be able to allow people define a study that only contain special custom suggestions and not the standard ones, would we?

It's already an optional feature. You can choose if you want to add your suggestion to the standard suggestions or if you only want your custom suggestions in the preferences. When specified via command-line, the custom suggestions will be the only ones by default.

It's already an optional feature. You can choose if you want to add your suggestion to the standard suggestions or if you only want your custom suggestions in the preferences. When specified via command-line, the custom suggestions will be the only ones by default.

👀 Uhh. Great work. 😄

kislinsk added a revision: Restricted Differential Revision.Oct 12 2022, 10:41 AM

Deleted branch from rMITK MITK: bugfix/T29338-RenameLabelWindowImprovements.