T30269-Avoid_phantom_drawing_in_editable_contour_tool
8920b845f478
Actions

Description

T30269-Avoid_phantom_drawing_in_editable_contour_tool

Summary:
Improve constness

fixed T30269

added a condiction to check for enough distance
(at least diagonal norm of a voxel) to the last
point before drawing starts.

Test Plan: code review; ui test

Reviewers: O1 MITK Reviewer Group I, O3 MITK Reviewer Group II, kislinsk

Reviewed By: O1 MITK Reviewer Group I, O3 MITK Reviewer Group II, kislinsk

Subscribers: kislinsk

Maniphest Tasks: T30269, T30405

Differential Revision: https://phabricator.mitk.org/D938

Details

Provenance

floca	Authored on Thu, May 2, 7:38 AM
floca	Pushed on Thu, May 2, 7:40 AM

Reviewer

O1: MITK Reviewer Group I

Differential Revision

Restricted Differential Revision

Parents

rMITKc758c4e5774e: Removwd obsolete/unused class
rMITKf298153c27b2: Update data selection concept in perfusion/modelfit-related views.

Branches

Unknown

Tags

Unknown

Tasks

Restricted Maniphest Task
T30405: Placed vertices with LiveWire tool 1-2 pixels off

Event Timeline

floca committed rMITK8920b845f478: T30269-Avoid_phantom_drawing_in_editable_contour_tool (authored by floca).Thu, May 2, 7:40 AM

floca added tasks: T30405: Placed vertices with LiveWire tool 1-2 pixels off, Restricted Maniphest Task.

floca added an edge: Restricted Differential Revision.

kislinsk mentioned this in T30407: 2024 Week 18 (Very Early May).Thu, May 2, 7:56 AM

Merged Changes

c758c4e5774e Removwd obsolete/unused class
Author
floca
Browse Repository
No Builds
No Audits
df27356f3946 If a preview contour exists the closure contour will always point to the
Author
floca
Browse Repository
No Builds
No Audits
981dad00a2cc Only using the relevant spacings of the plane to compute the dead zone
Author
floca
Browse Repository
No Builds
No Audits
eae73522b73b fixed T30405
Author
floca
Browse Repository
No Builds
No Audits
f2cd0aca8405 fixed T30269
Author
floca
Browse Repository
No Builds
No Audits
fa4519736184 Improve constness
Author
floca
Browse Repository
No Builds
No Audits

Changes (10)

Path

Size

Packages

Modules/

ContourModel/

DataManagement/

mitkContourModel.cpp

O3: MITK Reviewer Group II

mitkContourModel.h

O3: MITK Reviewer Group II

Segmentation/

Algorithms/

mitkImageLiveWireContourModelFilter.cpp

O1: MITK Reviewer Group I

mitkImageToLiveWireContourFilter.cpp

O1: MITK Reviewer Group I

mitkImageToLiveWireContourFilter.h

O1: MITK Reviewer Group I

Interactions/

mitkEditableContourTool.cpp

O1: MITK Reviewer Group I

mitkEditableContourTool.h

O1: MITK Reviewer Group I

mitkLiveWireTool2D.cpp

O1: MITK Reviewer Group I

Resources/

Interactions/

EditableContourTool.xml

O1: MITK Reviewer Group I

files.cmake

O1: MITK Reviewer Group I

rMITK8920b845f478

View Options

Modules/ContourModel/DataManagement/mitkContourModel.cpp

View Options

Modules/ContourModel/DataManagement/mitkContourModel.h

View Options

Modules/Segmentation/Algorithms/mitkImageLiveWireContourModelFilter.cpp

View Options

Modules/Segmentation/Algorithms/mitkImageToLiveWireContourFilter.cpp

View Options

Modules/Segmentation/Algorithms/mitkImageToLiveWireContourFilter.h

View Options

Modules/Segmentation/Interactions/mitkEditableContourTool.cpp

View Options

Modules/Segmentation/Interactions/mitkEditableContourTool.h

View Options

Modules/Segmentation/Interactions/mitkLiveWireTool2D.cpp

View Options

Modules/Segmentation/Resources/Interactions/EditableContourTool.xml

View Options

Modules/Segmentation/files.cmake

T30269-Avoid_phantom_drawing_in_editable_contour_tool8920b845f478Actions

Description

Details

Event Timeline

Merged Changes

Changes (10)

rMITK8920b845f478

Modules/ContourModel/DataManagement/mitkContourModel.cpp

Modules/ContourModel/DataManagement/mitkContourModel.h

Modules/Segmentation/Algorithms/mitkImageLiveWireContourModelFilter.cpp

Modules/Segmentation/Algorithms/mitkImageToLiveWireContourFilter.cpp

Modules/Segmentation/Algorithms/mitkImageToLiveWireContourFilter.h

Modules/Segmentation/Interactions/mitkEditableContourTool.cpp

Modules/Segmentation/Interactions/mitkEditableContourTool.h

Modules/Segmentation/Interactions/mitkLiveWireTool2D.cpp

Modules/Segmentation/Resources/Interactions/EditableContourTool.xml

Modules/Segmentation/files.cmake

T30269-Avoid_phantom_drawing_in_editable_contour_tool
8920b845f478
Actions