Page MenuHomePhabricator
Create Task
Maniphest T2428

OpMOVEPOINTUP and OpMOVEPOINTDOWN operations are broken in mitk::PointSet
Closed, ResolvedPublic
Actions

Assigned To
None
Authored By
neuhaus
Aug 26 2009, 6:28 PM
Tags
Referenced Files
F301: ChangeRequest bug 2428.txt
Aug 27 2009, 3:01 PM
Unknown Object (File)
Aug 26 2009, 6:29 PM
F3: fa-flask-violet.png
Aug 26 2009, 6:29 PM
Subscribers
neuhaus

Description

OpMOVEPOINTUP and OpMOVEPOINTDOWN operations are broken in mitk::PointSet. They
use the point ID as index, which will lead to a crash if the point IDs are not
consecutive (e.g. after deleting a point in the middle of the pointset).

Event Timeline

neuhaus added projects: MITK, Bugzilla.Aug 26 2009, 6:28 PM
neuhaus added a subscriber: neuhaus.

These operations are used by the PointListWidget (F2/F3 keys)

neuhaus added a comment.Aug 27 2009, 3:01 PM

change request to fix the broken operations.

ChangeRequest bug 2428.txt1 KBDownload

neuhaus added a comment.Aug 27 2009, 3:05 PM

core modification granted.

neuhaus added a comment.Aug 28 2009, 10:09 AM

fixed in revision #18738. Unit test is extended to test the previously buggy behavior. Manual testing showed no problems.

MITK · MIC · IMSY · DKFZ