Page MenuHomePhabricator
Create Task
Maniphest T25466

Enhance TemporoSpatialStringProperty to represent and store information more compact
Closed, ResolvedPublic
Actions

Description

Currently the TemporoSpatialStringProperty always generates a large "matrix" (by slice and timpoint) to represent all values. This is even the case if the value is the same for all slices (and timepoints).

It would be great to offer the possibility to store/load TemporoSpatialStringProperties in such a way that the can express that all values in a timepoint are the same or that all timepoints have the same values. Aim is to achive a serialized representation (e.g. in a NRRD file) that is as compact as possible.

The choosen solution should be backwards compatible to still allow the loading of old data correctly.

Revisions and Commits

Restricted Differential Revision
rMITK MITK
Restricted Differential RevisionrMITKd691d2eeaec1 Fixed T25466
Restricted Differential RevisionrMITKbbba9f774b3e Improved readablity of the mitk::PropertyPersistenceSerialization…
Restricted Differential RevisionrMITK34a9351c5a13 Fixed task extended tests.
Restricted Differential RevisionrMITK47dff70a5d61 Added more possibilities to query available timestepes and slices
Restricted Differential RevisionrMITK48a478756029 Removed obsolete workarround.

Related Objects

Event Timeline

floca triaged this task as Normal priority.Sep 21 2018, 2:55 PM
floca created this task.
floca mentioned this in T26142: Property persistence for property relation instance identifing (RII) properties.Nov 23 2019, 10:35 PM
floca edited projects, added MITK (v2021.02); removed MITK.Apr 12 2020, 6:50 PM
floca claimed this task.Apr 26 2020, 4:09 PM
floca added a project: Noteworthy.

This task will focuse on the ability to condense the TemperoSpatialStringProperty, if possible when it is serialzed by serializeTemporoSpatialStringPropertyToJSON().
As this is the most important aspect of the task to ensure compact storing of properties into files.

For that we introduce the additional keys "tmax" and "zmax" which together with "t" and "z" can encode if a value spans over several "cells" of the time-x-zslice-matrix.
It will be implemented in a backwords compatible manner.

The memory representation is kept untouched. We can optimize it if we identify the need. I want to avoid premature optimization.

floca added a revision: Restricted Differential Revision.Apr 27 2020, 9:11 PM
floca added a revision: Restricted Differential Revision.Apr 27 2020, 9:21 PM
floca added a comment.Apr 27 2020, 9:37 PM

Pushed new branch T25466-Compact_TemporoSpatialStringProperty_serialization.

floca added a commit: rMITK48a478756029: Removed obsolete workarround..Apr 27 2020, 9:37 PM
floca added a commit: rMITK47dff70a5d61: Added more possibilities to query available timestepes and slices.
floca added a commit: rMITK34a9351c5a13: Fixed task extended tests..
floca moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Apr 29 2020, 10:37 AM
floca added a commit: rMITKbbba9f774b3e: Improved readablity of the mitk::PropertyPersistenceSerialization….Apr 29 2020, 4:22 PM
floca closed this task as Resolved by committing rMITKd691d2eeaec1: Fixed T25466.Apr 29 2020, 8:23 PM
floca added a commit: rMITKd691d2eeaec1: Fixed T25466.
floca mentioned this in T27486: Prepare changelog and migration guide for upcoming master merge.Jun 22 2020, 9:57 PM
MITK · MIC · IMSY · DKFZ