Page MenuHomePhabricator

floca (Ralf Omar Floca)
User

Projects (13)

User Details

User Since
Aug 1 2016, 12:10 PM (269 w, 14 h)

Recent Activity

Aug 6 2021

floca committed rMITK52ebf19b564a: T28658 and T28659 (authored by floca).
T28658 and T28659
Aug 6 2021, 7:30 PM
floca committed rMITK5347a24176fb: Fixed review remarks (authored by floca).
Fixed review remarks
Aug 6 2021, 7:30 PM
floca closed T28658: Workbench crashes when try to load an empty directory as Resolved by committing rMITK06c5a8f5f975: - Prevent front() on empty directories; fixed T28658.
Aug 6 2021, 7:30 PM · MITK (v2021.10)
floca committed rMITK06c5a8f5f975: - Prevent front() on empty directories; fixed T28658 (authored by floca).
- Prevent front() on empty directories; fixed T28658
Aug 6 2021, 7:30 PM
floca closed T28659: DICOM Directory loading mighting fails if other files are in the directory as Resolved by committing rMITK06c5a8f5f975: - Prevent front() on empty directories; fixed T28658.
Aug 6 2021, 7:30 PM · MITK (v2021.10)

Aug 4 2021

floca added a revision to T28659: DICOM Directory loading mighting fails if other files are in the directory: Unknown Object (Differential Revision).
Aug 4 2021, 10:24 AM · MITK (v2021.10)
floca added a revision to T28658: Workbench crashes when try to load an empty directory : Unknown Object (Differential Revision).
Aug 4 2021, 10:24 AM · MITK (v2021.10)
floca added a revision to T28658: Workbench crashes when try to load an empty directory : Restricted Differential Revision.
Aug 4 2021, 10:21 AM · MITK (v2021.10)
floca added a revision to T28659: DICOM Directory loading mighting fails if other files are in the directory: Restricted Differential Revision.
Aug 4 2021, 10:21 AM · MITK (v2021.10)
floca triaged T28659: DICOM Directory loading mighting fails if other files are in the directory as Normal priority.
Aug 4 2021, 10:11 AM · MITK (v2021.10)
floca triaged T28658: Workbench crashes when try to load an empty directory as Unbreak Now! priority.
Aug 4 2021, 10:05 AM · MITK (v2021.10)

Aug 3 2021

floca added a comment to T26172: 2D interpolation in MultiLabelSegmentation Editor only works for 1. label .

that is at least one of the two code locations I assume to make problems. (The other one is when the interpolation results are written back to the segmentation)
For now, I wouldn't try to patch in multi-label support into the interpolation class. Instead I would ensure that only a label image (so an image that just contains the active label) is passed to the interpolation class.
I think that that is the most pragmatic approach to it, procure the current implementation will never work properly when multiple labels are present, due to the assumptions already stated by @kalali.

Aug 3 2021, 5:16 PM · Request for Discussion, MITK (v2021.10)

Jul 30 2021

floca added a comment to T28142: [Segmentation] Remove plugin redundancy with MultiLabelSegmentation.

oops, sorry. than I have mixed something up.

Jul 30 2021, 5:02 PM · MITK (v2021.10)

Jul 28 2021

floca removed a project from T28244: [Segmentation] Fast Marching Tool not really responsive for large images: Missing Info.
Jul 28 2021, 1:35 PM · MITK (v2021.10)
floca lowered the priority of T28244: [Segmentation] Fast Marching Tool not really responsive for large images from High to Low.

Down prioritized it, because survey indicated currently low relevance.

Jul 28 2021, 1:34 PM · MITK (v2021.10)
floca added a parent task for T28525: Design refactoring of LabelSetImage and associated classes: T28145: SetRegionTool does not work as expected (flood fill like) with concentric structures..
Jul 28 2021, 12:50 PM · MITK (v2021.10)
floca added a subtask for T28145: SetRegionTool does not work as expected (flood fill like) with concentric structures.: T28525: Design refactoring of LabelSetImage and associated classes.
Jul 28 2021, 12:50 PM · MITK (v2021.10)
floca removed a project from T28145: SetRegionTool does not work as expected (flood fill like) with concentric structures.: Missing Info.
Jul 28 2021, 12:49 PM · MITK (v2021.10)
floca triaged T28641: [Segmentation] Improve Watershed tool documentation as Normal priority.
Jul 28 2021, 12:47 PM · Cleared, MITK (v2021.10)
floca moved T28641: [Segmentation] Improve Watershed tool documentation from Backlog to Segmentation on the MITK (v2021.10) board.
Jul 28 2021, 12:47 PM · Cleared, MITK (v2021.10)
floca created T28641: [Segmentation] Improve Watershed tool documentation.
Jul 28 2021, 12:47 PM · Cleared, MITK (v2021.10)
floca lowered the priority of T28247: [Segmentation] Watershed tool freezes when slider and threshold are set to a low value from Normal to Low.

Down prioritized it, because survey indicated currently low relevance.

Jul 28 2021, 12:45 PM · Missing Info, MITK (v2021.10), Request for Discussion

Jul 27 2021

floca closed T27571: Multilabel segmentation does not work with US DICOM images as Invalid.
Jul 27 2021, 9:59 AM · MITK (v2021.10), Missing Info, Restricted Project
floca closed T27571: Multilabel segmentation does not work with US DICOM images, a subtask of T27554: Handling of 2D and 2D+t sonographic (US) images, as Invalid.
Jul 27 2021, 9:59 AM · Restricted Project, MITK
floca closed T27571: Multilabel segmentation does not work with US DICOM images, a subtask of T27807: [MultiLabel Segmentation] Inspection of module and plugin, as Invalid.
Jul 27 2021, 9:59 AM · MITK (v2021.10)
floca added a parent task for T28139: [LabelSetImage] Ambigious meaning of "layer" in LabelSetImage: T28525: Design refactoring of LabelSetImage and associated classes.
Jul 27 2021, 9:57 AM · Request for Discussion, MITK (v2021.10)
floca added a subtask for T28525: Design refactoring of LabelSetImage and associated classes: T28139: [LabelSetImage] Ambigious meaning of "layer" in LabelSetImage.
Jul 27 2021, 9:57 AM · MITK (v2021.10)
floca added a parent task for T28140: [MultiLabel Segmentation] Default parameter (unsigned int layer = 0) is unnecessary and causes problems: T28525: Design refactoring of LabelSetImage and associated classes.
Jul 27 2021, 9:57 AM · Request for Discussion, MITK (v2021.10)
floca added a subtask for T28525: Design refactoring of LabelSetImage and associated classes: T28140: [MultiLabel Segmentation] Default parameter (unsigned int layer = 0) is unnecessary and causes problems.
Jul 27 2021, 9:57 AM · MITK (v2021.10)
floca added projects to T28134: [Multilabel Segmentation] No warning triggered when using different mask geometries in Utilities View: Cleared, Restricted Project.
Jul 27 2021, 9:54 AM · Restricted Project, Cleared, MITK (v2021.10)
floca added a project to T27810: [Multilabel Segmentation] Inconsistencies and unclear functionality in operations of Utilities view: Cleared.
Jul 27 2021, 9:50 AM · Cleared, MITK (v2021.10), Restricted Project
floca added a project to T27637: [Segmentation] Multilabel label name dialoge on label creation is a UX problem: Cleared.
Jul 27 2021, 9:48 AM · Cleared, MITK (v2021.10)
floca raised the priority of T28464: [Segmentation] New Add/Remove tool from Normal to High.
Jul 27 2021, 9:46 AM · Cleared, MITK (v2021.10)
floca added a project to T28635: [Segmentation] Remove deprecated classes: Cleared.
Jul 27 2021, 9:45 AM · Cleared, MITK (v2021.10)
floca added a project to T28264: [Segmentation Utilities] Various issues: Cleared.

Comment: One should seperate the open todos into sub tasks, I think.

Jul 27 2021, 9:43 AM · Cleared, MITK (v2021.10)
floca added a comment to T28142: [Segmentation] Remove plugin redundancy with MultiLabelSegmentation.

@kalali Aren't you already working on that topic? I thought, i just reviewed something in that direction?!?

Jul 27 2021, 9:39 AM · MITK (v2021.10)

Jul 9 2021

floca added a revision to T28607: [Segmentation] LiveWire tool issues and improvements: Unknown Object (Differential Revision).
Jul 9 2021, 4:30 PM · MITK (v2021.10)
floca updated the image for Kaapana (internal) from F1910040: profile to F2368403: profile.
Jul 9 2021, 8:37 AM

Jul 7 2021

floca updated subscribers of T28385: [Segmentation] Erosion crashes the MITK Workbench after interpolation.

@kleina Just as a remark. I would postpone this task a bit, as we have enough other things to do and @kislinsk is currently working on interpolation and this might have also impact on this tasks.

Jul 7 2021, 11:34 AM · Cleared, MITK (v2021.10)
floca moved T28385: [Segmentation] Erosion crashes the MITK Workbench after interpolation from Segmentation to Cycle on the MITK (v2021.10) board.
Jul 7 2021, 11:31 AM · Cleared, MITK (v2021.10)
floca added a comment to T28607: [Segmentation] LiveWire tool issues and improvements.

I think that are good ideas.

Jul 7 2021, 11:30 AM · MITK (v2021.10)
floca moved T28606: [Segmentation] Accelerate do/undo mechanism for segmentations from Segmentation to Cycle on the MITK (v2021.10) board.
Jul 7 2021, 10:25 AM · MITK (v2021.10)
floca moved T26485: [Segmentation] PACS mode is active while segmentation is drawn from Segmentation to Cycle on the MITK (v2021.10) board.
Jul 7 2021, 10:24 AM · MITK (v2021.10)

Jul 6 2021

floca edited the content of 2021 Week 26 (Very Early July).
Jul 6 2021, 10:25 AM

Jul 2 2021

floca added a project to T28603: Cannot start MITK on a Windows remote desktop: Missing Info.
  • Does the problem also occure with the current release?
  • It is a known problem that Windows (OpenGL problem) does not work (well) remote with MITK. The best way is installing the right drivers (see https://phabricator.mitk.org/T26427#224676)
Jul 2 2021, 3:48 PM · Missing Info, MITK
floca updated subscribers of T26496: [mxn multi widget] Re-initializations reset all render windows.

I cannot answer that question directly. As I do not know the history of this class and documentation does not help. Maybe @nolden does.

Jul 2 2021, 3:02 PM · Restricted Project, MITK

Jun 29 2021

floca added a comment to T28491: Slice interpolation 'confirm for all slices' not working for large images.

Sounds like it goes in the write direction. :) thanks.

Jun 29 2021, 7:51 PM · MITK (v2021.10)

Jun 28 2021

floca closed T28549: Remove deprecated functions from classes involved in the LabelSetImage refactoring, a subtask of T28524: Refactor LabelSetImage and associated classes., as Resolved.
Jun 28 2021, 10:08 AM · MITK (v2021.10)
floca closed T28549: Remove deprecated functions from classes involved in the LabelSetImage refactoring as Resolved.
Jun 28 2021, 10:08 AM · MITK (v2021.10)
floca committed rMITK22ffff3fe76c: T28549 Clean_up_for_segmentation_refactoring (authored by floca).
T28549 Clean_up_for_segmentation_refactoring
Jun 28 2021, 10:07 AM
floca committed rMITKce406798a0c4: Merge remote-tracking branch 'origin/develop' into feature/T28549… (authored by floca).
Merge remote-tracking branch 'origin/develop' into feature/T28549…
Jun 28 2021, 10:07 AM
floca committed rMITK27d32c8e84f5: BREAKING Moved the deprecated ImageDataItem::GetData to protected visiblity (authored by floca).
BREAKING Moved the deprecated ImageDataItem::GetData to protected visiblity
Jun 28 2021, 10:07 AM
floca committed rMITK93b12789c6e5: BREAKING Removed the deprecated and obsolete TimeSlicedGeometry (authored by floca).
BREAKING Removed the deprecated and obsolete TimeSlicedGeometry
Jun 28 2021, 10:07 AM
floca committed rMITK86bfb4f18df2: BREAKING: Removed deprecated functions from mitk::BaseData and mitk::Image (authored by floca).
BREAKING: Removed deprecated functions from mitk::BaseData and mitk::Image
Jun 28 2021, 10:07 AM

Jun 22 2021

floca added a comment to T26394: [Render window manager] Provide tree view / model.

This is then based on the QmitkDataStorageTreeInspector? Would make sense, wouldn't it?

Jun 22 2021, 2:03 PM · Restricted Project, Restricted Project, MITK
floca added a comment to T28541: Roadmap and TODO using Kata Container.

It seems to me that most of this points are at least 1-2 work days worth of time. If this right it would make sense to turn them into subtasks. Then we also have a clearer burn up, because one can explicitly marke sub tasks as done...

Jun 22 2021, 10:39 AM · Restricted Project

Jun 21 2021

floca added a comment to T28204: Refactor LevelWindowManagerTest.

Just as a side note. As far as I know, the data storage interace gives no guarantees regarding the order (aplied sorting criteria) of returned node sets. So any implementation that relies on such an order is likely to fail.

Jun 21 2021, 3:43 PM · MITK (v2021.10)

Jun 18 2021

floca triaged T28561: Refactor/Fix mitk::SegmentationInteractor::ChangeActiveLabel as High priority.
Jun 18 2021, 8:51 AM · MITK (v2021.10)

Jun 17 2021

floca assigned T28523: Evaluate MITK segmentation survey to a178n.

What is the status here? This is on "unbreak now", but no assignee. Is there something to evaluate yet?

Good point. @a178n I put you as asignee for now as you started the survey. How many answers do we have already. If it is a low number, then could you send a reminder. So that we can compile the result for internal read through next Wednesday?

Jun 17 2021, 2:11 PM · MITK (v2021.10)

Jun 16 2021

floca removed a project from T27637: [Segmentation] Multilabel label name dialoge on label creation is a UX problem: Request for Discussion.
Jun 16 2021, 12:39 PM · Cleared, MITK (v2021.10)
floca added a comment to T28135: [MultiLabel Segmentation] Utilities view can not handle non-binary multilabel segmentations.

@floca Is this something worth looking into before the refactoring is done?

I would say: no.

Jun 16 2021, 9:12 AM · MITK (v2021.10)
floca added a project to T28315: [Selection concept] Provide preference page option to show / hide helper nodes: Request for Discussion.

I understand the reasoning behind that feature request, but I think it should be discussed. At least it contradicts one of the key assumptions of the new selection concept: relevance criteria is defined localy in the view.

Jun 16 2021, 9:02 AM · Request for Discussion, MITK (v2021.10)

Jun 15 2021

floca renamed T28549: Remove deprecated functions from classes involved in the LabelSetImage refactoring from Remove deprecated functions from classes involved in the LabelSetImge refactoring to Remove deprecated functions from classes involved in the LabelSetImage refactoring.
Jun 15 2021, 8:50 AM · MITK (v2021.10)
floca triaged T28549: Remove deprecated functions from classes involved in the LabelSetImage refactoring as Normal priority.
Jun 15 2021, 8:50 AM · MITK (v2021.10)

Jun 13 2021

floca updated subscribers of T28525: Design refactoring of LabelSetImage and associated classes.
Jun 13 2021, 2:25 PM · MITK (v2021.10)

Jun 10 2021

floca added a comment to T27665: PlanarFigure tests show error with DICOMTagsOfInterestAddHelper.

@floca I can't reproduce this anymore. However, I'm not sure where some changes were done. Do you have an idea?

Jun 10 2021, 2:41 PM · Restricted Project, MITK
floca added a comment to T27133: [Segmentation] Is QmitkDataSelectionWidget needed anymore?.

The QmitkDataSelectionWidget uses the new selection concept widget SingleNodeSelectionWidget. So it is not redundant per se.
But it is right that it makes no sense to dublicate the widget in the plugins. It should be in MitkSegmentationUI and only one time.

Jun 10 2021, 2:35 PM · MITK (v2021.10)

Jun 9 2021

floca added a comment to T28525: Design refactoring of LabelSetImage and associated classes.

Pushed new branch to rMITK MITK: feature/T28525-Design_refactoring_labelset.

Jun 9 2021, 8:41 AM · MITK (v2021.10)

Jun 8 2021

floca removed a project from T26427: Support software rendering: Next Milestone.

Update regarding the problem of @tpenzkofer (Software Rendering with VMWare VMs):
After the update to the newest VMWare version, the software rendering works correctly also with newer MITK versions. It seems like the new VMWare version has its own Mesa driver with OpenGL 3.3 support wich does the trick.

Jun 8 2021, 8:21 AM · MITK

Jun 7 2021

floca added a project to T26427: Support software rendering: Next Milestone.
Jun 7 2021, 6:53 PM · MITK
floca added a comment to T26427: Support software rendering.

I think Stefan is refering to that https://developer.nvidia.com/designworks, arn't you @kislinsk ?

Jun 7 2021, 10:35 AM · MITK
floca raised the priority of T27319: [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View from High to Unbreak Now!.
Jun 7 2021, 9:16 AM · MITK (v2021.10), Restricted Project, Cleared
floca added a subtask for T28142: [Segmentation] Remove plugin redundancy with MultiLabelSegmentation: T27319: [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View.
Jun 7 2021, 9:14 AM · MITK (v2021.10)
floca added a parent task for T27319: [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View: T28142: [Segmentation] Remove plugin redundancy with MultiLabelSegmentation.
Jun 7 2021, 9:14 AM · MITK (v2021.10), Restricted Project, Cleared
floca moved T28516: 2D slice interpolation should use multiprocessing from Backlog to Segmentation on the MITK (v2021.10) board.
Jun 7 2021, 9:13 AM · MITK (v2021.10)
floca triaged T28516: 2D slice interpolation should use multiprocessing as Normal priority.
Jun 7 2021, 9:13 AM · MITK (v2021.10)
floca lowered the priority of T28385: [Segmentation] Erosion crashes the MITK Workbench after interpolation from High to Normal.

Does it only crash with erosion or also with other utilities?

Jun 7 2021, 9:11 AM · Cleared, MITK (v2021.10)
floca edited projects for T28385: [Segmentation] Erosion crashes the MITK Workbench after interpolation, added: MITK (v2021.10); removed MITK.
Jun 7 2021, 9:10 AM · Cleared, MITK (v2021.10)
floca moved T26172: 2D interpolation in MultiLabelSegmentation Editor only works for 1. label from Backlog to Segmentation on the MITK (v2021.10) board.
Jun 7 2021, 9:08 AM · Request for Discussion, MITK (v2021.10)
floca edited projects for T26172: 2D interpolation in MultiLabelSegmentation Editor only works for 1. label , added: MITK (v2021.10); removed MITK.
Jun 7 2021, 9:08 AM · Request for Discussion, MITK (v2021.10)
floca moved T27319: [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View from Backlog to Segmentation on the MITK (v2021.10) board.
Jun 7 2021, 9:08 AM · MITK (v2021.10), Restricted Project, Cleared
floca added a parent task for T26172: 2D interpolation in MultiLabelSegmentation Editor only works for 1. label : T27319: [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View.
Jun 7 2021, 9:07 AM · Request for Discussion, MITK (v2021.10)
floca added a subtask for T27319: [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View: T26172: 2D interpolation in MultiLabelSegmentation Editor only works for 1. label .
Jun 7 2021, 9:07 AM · MITK (v2021.10), Restricted Project, Cleared
floca edited projects for T27319: [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View, added: MITK (v2021.10); removed MITK.
Jun 7 2021, 9:07 AM · MITK (v2021.10), Restricted Project, Cleared

Jun 6 2021

floca claimed T28525: Design refactoring of LabelSetImage and associated classes.
Jun 6 2021, 8:27 PM · MITK (v2021.10)
floca moved T28275: [Segmentation] AdaptiveRegionGrowingTool must be refactored / 4D Segmentation returns error message when point is not on the correct timestep from Segmentation to Cycle on the MITK (v2021.10) board.
Jun 6 2021, 8:27 PM · MITK (v2021.10)
floca moved T28499: Refactor/rewrite RegionGrowing3D tool from Segmentation to Cycle on the MITK (v2021.10) board.
Jun 6 2021, 8:27 PM · Request for Discussion, MITK (v2021.10)
floca moved T27872: [Segmentation] Region Growing 3D GUI does not provide a "Overwrite" checkbox from Segmentation to Cycle on the MITK (v2021.10) board.
Jun 6 2021, 8:27 PM · MITK (v2021.10), Restricted Project, Cleared
floca moved T27684: [Segmentation] Improve Region Growing 2D algorithm and interaction from Segmentation to Cycle on the MITK (v2021.10) board.
Jun 6 2021, 8:27 PM · MITK (v2021.10)
floca moved T27872: [Segmentation] Region Growing 3D GUI does not provide a "Overwrite" checkbox from Cycle to Segmentation on the MITK (v2021.10) board.
Jun 6 2021, 8:27 PM · MITK (v2021.10), Restricted Project, Cleared
floca moved T27684: [Segmentation] Improve Region Growing 2D algorithm and interaction from Cycle to Segmentation on the MITK (v2021.10) board.
Jun 6 2021, 8:27 PM · MITK (v2021.10)
floca moved T28275: [Segmentation] AdaptiveRegionGrowingTool must be refactored / 4D Segmentation returns error message when point is not on the correct timestep from Cycle to Segmentation on the MITK (v2021.10) board.
Jun 6 2021, 8:27 PM · MITK (v2021.10)
floca moved T28499: Refactor/rewrite RegionGrowing3D tool from Cycle to Segmentation on the MITK (v2021.10) board.
Jun 6 2021, 8:27 PM · Request for Discussion, MITK (v2021.10)

Jun 4 2021

floca added a subtask for T28131: [MultiLabel Segmentation] 3D Threshold tool does not work with multiple labels / layers: T28526: [Segmentation] Check tools (especially 3D tools) to correctly handle updating of LabelSetImage.
Jun 4 2021, 7:38 PM · MITK (v2021.10)
floca added a parent task for T28526: [Segmentation] Check tools (especially 3D tools) to correctly handle updating of LabelSetImage: T28131: [MultiLabel Segmentation] 3D Threshold tool does not work with multiple labels / layers.
Jun 4 2021, 7:38 PM · MITK (v2021.10)
floca added a subtask for T28176: [Segmentation] Inspection of module and plugin: T28526: [Segmentation] Check tools (especially 3D tools) to correctly handle updating of LabelSetImage.
Jun 4 2021, 7:37 PM · MITK (v2021.10)
floca added a parent task for T28526: [Segmentation] Check tools (especially 3D tools) to correctly handle updating of LabelSetImage: T28176: [Segmentation] Inspection of module and plugin.
Jun 4 2021, 7:37 PM · MITK (v2021.10)
floca added a subtask for T28526: [Segmentation] Check tools (especially 3D tools) to correctly handle updating of LabelSetImage: T28524: Refactor LabelSetImage and associated classes..
Jun 4 2021, 7:36 PM · MITK (v2021.10)
floca added a parent task for T28524: Refactor LabelSetImage and associated classes.: T28526: [Segmentation] Check tools (especially 3D tools) to correctly handle updating of LabelSetImage.
Jun 4 2021, 7:36 PM · MITK (v2021.10)
floca triaged T28526: [Segmentation] Check tools (especially 3D tools) to correctly handle updating of LabelSetImage as High priority.
Jun 4 2021, 7:36 PM · MITK (v2021.10)