Page MenuHomePhabricator | MITK

floca (Ralf Omar Floca)
User

Projects (8)

User Details

User Since
Aug 1 2016, 12:10 PM (119 w, 1 d)

Recent Activity

Yesterday

floca added a comment to T24553: Write and communicate release strategy (alpha, beta, ...).

Is this really already resolved?

Tue, Nov 13, 11:52 AM · MITK (2018-04)

Mon, Nov 12

floca committed rMITK5f214014b7cd: Fixed T25590 (authored by floca).
Fixed T25590
Mon, Nov 12, 6:19 PM
floca committed rMITK52681c45b3f9: Merge remote-tracking branch 'origin/T25191-v2018.04-beta' into… (authored by floca).
Merge remote-tracking branch 'origin/T25191-v2018.04-beta' into…
Mon, Nov 12, 6:18 PM
floca added a task to rMITK0b4c5f65ed9d: Fixed T25590: T25590: Correct doxygen docu for ModelFit and co....
Mon, Nov 12, 6:05 PM
floca committed rMITKe04b978614a0: Merge branch 'T25590-ModelFit_docs' (authored by floca).
Merge branch 'T25590-ModelFit_docs'
Mon, Nov 12, 6:05 PM
floca closed T25590: Correct doxygen docu for ModelFit and co... as Resolved by committing rMITK0b4c5f65ed9d: Fixed T25590.
Mon, Nov 12, 6:05 PM · MITK
floca committed rMITK0b4c5f65ed9d: Fixed T25590 (authored by floca).
Fixed T25590
Mon, Nov 12, 6:04 PM
floca added a comment to T25590: Correct doxygen docu for ModelFit and co....

Pushed new branch T25590-ModelFit_docs.

Mon, Nov 12, 6:03 PM · MITK

Fri, Nov 9

floca added a comment to T25437: Evaluate to switch from C3.js to Plotly.js.

Nice!
That's cool. Thanks for the effort! Will be very usefull also for our model fit and CEST work!

Fri, Nov 9, 10:17 PM · Restricted Project, MITK
floca added a comment to T25437: Evaluate to switch from C3.js to Plotly.js.

@steint : Cool thanks for following up on this! Very valuable.

Fri, Nov 9, 6:45 PM · Restricted Project, MITK
floca committed rMITK50ab7b117ae3: Cherry picked T25589 (authored by floca).
Cherry picked T25589
Fri, Nov 9, 10:20 AM
floca committed rMITK6197e12c4525: Checked docs (authored by floca).
Checked docs
Fri, Nov 9, 10:20 AM
floca committed rMITK0d4d926a4b00: Fixed T25589-MatchPoint_docs (authored by floca).
Fixed T25589-MatchPoint_docs
Fri, Nov 9, 10:11 AM
floca closed T25589: Correct doxygen docu for MatchPoint as Resolved by committing rMITK0d4d926a4b00: Fixed T25589-MatchPoint_docs.
Fri, Nov 9, 10:11 AM · MITK

Wed, Nov 7

floca committed rMITK9f78a0158caa: Correct view size of svg (authored by floca).
Correct view size of svg
Wed, Nov 7, 4:33 PM

Tue, Oct 30

floca committed rMITK624133f06d52: Checked docs (authored by floca).
Checked docs
Tue, Oct 30, 5:54 PM
floca added a comment to T25589: Correct doxygen docu for MatchPoint.

Pushed new branch T25589-MatchPoint_docs.

Tue, Oct 30, 5:53 PM · MITK

Mon, Oct 29

floca updated the task description for T25590: Correct doxygen docu for ModelFit and co....
Mon, Oct 29, 2:04 PM · MITK
floca claimed T25590: Correct doxygen docu for ModelFit and co....
Mon, Oct 29, 2:03 PM · MITK
floca created T25590: Correct doxygen docu for ModelFit and co....
Mon, Oct 29, 2:03 PM · MITK
floca claimed T25589: Correct doxygen docu for MatchPoint.
Mon, Oct 29, 2:03 PM · MITK
floca created T25589: Correct doxygen docu for MatchPoint.
Mon, Oct 29, 2:02 PM · MITK
floca added a parent task for T22616: Store exact software version in properties when reading DICOM: Unknown Object (Maniphest Task).
Mon, Oct 29, 12:46 PM · Restricted Project, Restricted Project, MITK
floca added a parent task for T24303: A segmentation should generate all DICOM relevant IDs as soon as it can be referenced.: Unknown Object (Maniphest Task).
Mon, Oct 29, 12:43 PM · Request for Discussion, MITK
floca added a parent task for T23746: MITK and DICOM (realization): Unknown Object (Maniphest Task).
Mon, Oct 29, 12:42 PM · MITK
floca added a parent task for T23748: Image should have a valid DICOM.0008.0018 proprety: Unknown Object (Maniphest Task).
Mon, Oct 29, 12:42 PM · MITK
floca added a parent task for T23774: Implement helper to correctly (DICOM conformal) parameterize images (or other BaseData derived classes): Unknown Object (Maniphest Task).
Mon, Oct 29, 12:42 PM · MITK
floca added a parent task for T24302: Should we persiste the ID of Identifiable when loading/saving BaseDatas?: Unknown Object (Maniphest Task).
Mon, Oct 29, 12:42 PM · MITK

Fri, Oct 26

floca added a comment to T25105: UpdateStatusBar duplicates business logic.

We do not need to move the whole functionality to the data storage, just the geometry processing part.

What do you exactly mean with geometry processing part? Does "to the storage" mean, into the class or into the file?

Fri, Oct 26, 11:06 PM · MITK
floca committed rMP137e66ef8981: Check to prevent currently wrong cmake configurations that lead to seg faults. (authored by floca).
Check to prevent currently wrong cmake configurations that lead to seg faults.
Fri, Oct 26, 5:54 PM
floca committed rMPe7ff67e31c7a: fixed gcc compile issues. (authored by floca).
fixed gcc compile issues.
Fri, Oct 26, 5:28 PM

Tue, Oct 23

floca added a comment to T25105: UpdateStatusBar duplicates business logic.

Would it be reasonable to move the UpdateStatusBar functionality to the data storage as well

No, I don't think so. It is not job of the DataStorage to update the status bar.

Tue, Oct 23, 4:26 PM · MITK
floca committed rMITKa1979086882c: Added new line at EOF (authored by floca).
Added new line at EOF
Tue, Oct 23, 12:49 PM
floca committed rMITK9174c6f2c194: Fixed T24987 (authored by floca).
Fixed T24987
Tue, Oct 23, 12:49 PM
floca added a subtask for T25042: How to handle update informations in heterogeneous time geometries and out of bound situations : T25098: Mapper (partially?) do not handle images correctly if they are out of time bound.
Tue, Oct 23, 12:41 PM · MITK
floca added a parent task for T25098: Mapper (partially?) do not handle images correctly if they are out of time bound: T25042: How to handle update informations in heterogeneous time geometries and out of bound situations .
Tue, Oct 23, 12:40 PM · MITK
floca added a comment to T25042: How to handle update informations in heterogeneous time geometries and out of bound situations .

Yes, partially. We have no crashes, but

Tue, Oct 23, 12:40 PM · MITK
floca updated the task description for T25042: How to handle update informations in heterogeneous time geometries and out of bound situations .
Tue, Oct 23, 12:30 PM · MITK
floca updated the task description for T25042: How to handle update informations in heterogeneous time geometries and out of bound situations .
Tue, Oct 23, 12:28 PM · MITK

Mon, Oct 22

floca added a comment to rMPb391c8f57e95: Merge branch 'T25506-portRAP'.

@hentsch I get build errors with the current master (in ubuntu), without your commit everything is fine.
Do I have to change something with cmake flags?
The last lines before failure:
/home/hanno/myDocker/Matchpoint/src/Code/Algorithms/ITK/boxed/mapITKRigid3DMattesMIHeadNeckRegistrationAlgorithmTemplate.tpp:128:25: error: ‘zSize’ was not declared in this scope

region.SetIndex(2, zSize / 3);
Mon, Oct 22, 2:30 PM

Fri, Oct 19

floca added a comment to T22656: Boost binaries provoke a compile error in superbuild when built for multiple configurations.

that would be great.

Fri, Oct 19, 2:09 PM · Restricted Project

Thu, Oct 18

floca committed rMITK0ef5644f7ce7: Added new line at EOF (authored by floca).
Added new line at EOF
Thu, Oct 18, 5:27 PM
floca committed rMITK9eaa2f5119bb: Fixed T24987 (authored by floca).
Fixed T24987
Thu, Oct 18, 5:25 PM
floca added a comment to T24987: mitkFunctionGetLibrarySearchPaths is not aware of extensions.

Pushed new branch T24987-mitkFunctionAddLibrarySearchPaths.

Thu, Oct 18, 5:25 PM · Restricted Project, MITK
floca added a revision to T24987: mitkFunctionGetLibrarySearchPaths is not aware of extensions: Unknown Object (Differential Revision).
Thu, Oct 18, 5:23 PM · Restricted Project, MITK
floca claimed T24987: mitkFunctionGetLibrarySearchPaths is not aware of extensions.
Thu, Oct 18, 5:10 PM · Restricted Project, MITK
floca removed a project from T24987: mitkFunctionGetLibrarySearchPaths is not aware of extensions: Request for Discussion.

Discussed it. For now we will implement an simple solution (simelar to the legacy modulconf pattern) to add additional path from the eps cmakeexternals script.

Thu, Oct 18, 5:10 PM · Restricted Project, MITK

Oct 13 2018

floca added a comment to rMITK1dbcb6d9ec91: First fix.

@nolden Could you please "unraise" your concern now. It is spoiling my statistics/dashboard. Thanks ;)

Oct 13 2018, 3:06 PM
floca accepted rMITK1dbcb6d9ec91: First fix.

GCC error was fixes. Thanks for the hint.

Oct 13 2018, 3:05 PM
floca updated subscribers of T23306: Reactivation of org.blueberry.test plugin.

@kislinsk : Do you know the/a reason why this task wasn't merged and closed after positiv review? Seems like it was forgotten some how.

Oct 13 2018, 3:01 PM
floca updated subscribers of T24271: Port tests from old mitk test macros to CPPUNIT.

@kislinsk , @kahl: Is there a reason this is not merged into the master and closed? The review was already done and positive.

Oct 13 2018, 2:55 PM · MITK

Oct 10 2018

floca added a comment to T25498: Stopping of MitkPharmacokineticModelsServices outputs warning in tests.

I think the reason is that this Service has now a new (correct) autoload rule and the continuus clients are not cleaned. This combiniation leads to the service being load twice.

Oct 10 2018, 5:09 PM · MITK
floca committed rMITKf3ad28e9c695: Fixed T25390 (authored by floca).
Fixed T25390
Oct 10 2018, 4:48 PM
floca closed T25390: Refactor CEST StatisticView and ModelFitInspector to be more synergistic as Resolved by committing rMITKf3ad28e9c695: Fixed T25390.
Oct 10 2018, 4:48 PM · Restricted Project, Restricted Project, MITK
floca committed rMITKe79522b0d998: Removed redundant generic models from pharmacokinetics models service. (authored by floca).
Removed redundant generic models from pharmacokinetics models service.
Oct 10 2018, 4:12 PM
floca committed rMITK9141ea630abc: fixed gcc compile errors (authored by floca).
fixed gcc compile errors
Oct 10 2018, 4:11 PM
floca committed rMITK475f074a7562: Removed redundant generic models from pharmacokinetics models service. (authored by floca).
Removed redundant generic models from pharmacokinetics models service.
Oct 10 2018, 4:11 PM
floca committed rMITK9a9235982e53: fixed gcc compile errors (authored by floca).
fixed gcc compile errors
Oct 10 2018, 4:02 PM
floca added a comment to T24333: Noteworthy new features since MITK 2016.11.

Propertylist has more strict behavior. Only none empty strings are allows as property key. Property list now also implements the PropertyOwner interface.
Introduced with T25441: Name DataNodes with DICOM data appropriately by using dicom tags

Oct 10 2018, 9:28 AM · MITK (2018-04)
floca committed rMITKedc20723131e: Corrected SceneIO test to regard preconditions of mitk::PropertyList… (authored by floca).
Corrected SceneIO test to regard preconditions of mitk::PropertyList…
Oct 10 2018, 9:25 AM
floca committed rMITK4ad74a8e1d82: Corrected SceneIO test to regard preconditions of mitk::PropertyList… (authored by floca).
Corrected SceneIO test to regard preconditions of mitk::PropertyList…
Oct 10 2018, 9:23 AM
floca committed rMITK96b95c4dd935: Corrected SceneIO test to regard preconditions of mitk::PropertyList… (authored by floca).
Corrected SceneIO test to regard preconditions of mitk::PropertyList…
Oct 10 2018, 9:11 AM
floca committed rMITKe1206775c0fe: fixed gcc error (unused variable) (authored by floca).
fixed gcc error (unused variable)
Oct 10 2018, 9:01 AM

Oct 9 2018

floca added a revision to T25441: Name DataNodes with DICOM data appropriately by using dicom tags: Unknown Object (Differential Revision).
Oct 9 2018, 2:54 PM · MITK
floca added a comment to T25441: Name DataNodes with DICOM data appropriately by using dicom tags.

Pushed new branch T25441-fix_tests.

Oct 9 2018, 2:23 PM · MITK
floca committed rMITKb2a7c5fe8885: Corrected SceneIO test to regard preconditions of mitk::PropertyList… (authored by floca).
Corrected SceneIO test to regard preconditions of mitk::PropertyList…
Oct 9 2018, 2:21 PM
floca added a comment to T25442: [MITK Diffusion] Add copy to and from python for diffusion-weighted images.

Pushed new branch T25442-fix_tests.

Oct 9 2018, 2:21 PM · MITK

Oct 8 2018

floca committed rMITKa064b49f914e: Fixed unnecessary offsets determination for T1 datasets. (authored by floca).
Fixed unnecessary offsets determination for T1 datasets.
Oct 8 2018, 4:19 PM
floca committed rMITK5a76db242603: Fixed unnecessary offsets determination for T1 datasets. (authored by floca).
Fixed unnecessary offsets determination for T1 datasets.
Oct 8 2018, 4:18 PM

Oct 5 2018

floca added a comment to T24540: DICOMReader module does not support Philips US 3D files on its "own".

Still open, as nobody was assigned so far and had time ;)

Oct 5 2018, 9:43 AM · Restricted Project, MITK

Oct 4 2018

floca committed rMITK8162e4833265: Fixed test errors (authored by floca).
Fixed test errors
Oct 4 2018, 4:43 PM
floca committed rMITK3d7ad4bf93b4: Fixed test errors (authored by floca).
Fixed test errors
Oct 4 2018, 4:41 PM
floca added a project to T24615: Make Boost build robust: Request for Discussion.
Oct 4 2018, 10:53 AM · MITK (2018-04)

Oct 2 2018

floca committed rMITKabe6324fafca: Extracted time grid supersampling (authored by floca).
Extracted time grid supersampling
Oct 2 2018, 6:17 PM
floca committed rMITKe3e9817b2fd6: Extracted time grid supersampling (authored by floca).
Extracted time grid supersampling
Oct 2 2018, 6:16 PM

Sep 28 2018

floca committed rMITKe40e6c1cb275: gcc compile issues (authored by floca).
gcc compile issues
Sep 28 2018, 5:59 PM
floca committed rMITK19a58b7f8722: gcc compile issues (authored by floca).
gcc compile issues
Sep 28 2018, 4:51 PM
floca raised a concern with rMITK0dd5b03404fb: update.
Sep 28 2018, 12:22 PM
floca removed a project from T22322: Changing a renderer-specific property list of a data node does not modify the data node: Request for Discussion.

We discussed it today with the following results:

Sep 28 2018, 10:57 AM · MITK
floca committed rMITKeb48eca8fbd3: Fixed gcc compile errors of T25441 (authored by floca).
Fixed gcc compile errors of T25441
Sep 28 2018, 10:07 AM
floca committed rMITK56d1937cafb7: Fixed gcc compile errors of T25441 (authored by floca).
Fixed gcc compile errors of T25441
Sep 28 2018, 9:44 AM

Sep 26 2018

floca added a revision to T25441: Name DataNodes with DICOM data appropriately by using dicom tags: Unknown Object (Differential Revision).
Sep 26 2018, 6:20 PM · MITK
floca committed rMITKcd8fb62c2be8: Fixed gcc compile errors of T25441 (authored by floca).
Fixed gcc compile errors of T25441
Sep 26 2018, 6:14 PM
floca added a comment to T25441: Name DataNodes with DICOM data appropriately by using dicom tags.

Pushed new branch T25441-fix_gcc.

Sep 26 2018, 6:14 PM · MITK
floca added a comment to T25469: Improve MITK build experience.

Good idea that would really help.

Sep 26 2018, 6:06 PM · MITK (2018-04)

Sep 25 2018

floca added a comment to T25245: Add MITK_EXTENSION_DIRS to mitkConfig.

@hentsch Is there a reason this is still open. Seems to be mergeable to the master, isn't it?

Sep 25 2018, 8:52 PM · MITK
floca added a project to T24987: mitkFunctionGetLibrarySearchPaths is not aware of extensions: Request for Discussion.
Sep 25 2018, 8:48 PM · Restricted Project, MITK
floca moved T25463: QmitkSelectionServiceConnector wrongly emits empty node lists if workbench part changes from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Sep 25 2018, 8:42 PM · Restricted Project, Restricted Project, MITK

Sep 21 2018

floca added a comment to T25435: time function for segmentation tasks of 2d/3d+t data.

@kahl : If you work on a task (e.g. this one; thank you!) please claim it, that everyone sees that you are assigned. If you have stopped working on the task, its fine in its unassigned state.

Sep 21 2018, 2:57 PM · MITK (2018-04)
floca triaged T25466: Enhance TemporoSpatialStringProperty to represent and store information more compact as Normal priority.
Sep 21 2018, 2:55 PM · Restricted Project, MITK
floca added a comment to T25152: Cannot compare TemporoSpatialStringProperty.

You pointed in the right direction. The operator == currently checks complete equality. So also the number of time points and frames must be the same; and must have the same value. This is not the case in your on-the-fly-generated operand. Tempering with the == is not trival, because there are use cases where it realy matters if there is the same geometry and not only the same value. There are thoughts to implement posibilities to express TemporoSpatialStringProperties more compact, but thats no quick solution.

Sep 21 2018, 2:49 PM · MITK
floca committed rMITK1dbcb6d9ec91: First fix (authored by floca).
First fix
Sep 21 2018, 2:40 PM
floca closed T25441: Name DataNodes with DICOM data appropriately by using dicom tags as Resolved by committing rMITK1dbcb6d9ec91: First fix.
Sep 21 2018, 2:40 PM · MITK
floca added a comment to T23343: Dicom editor can not load dicom segmentation objects.

As far as I can see (had to dig through the commits) All changes of this branch, have already been cherry picked to the master at some point. (Don't know if they are also already in the current beta brunch).

Sep 21 2018, 2:40 PM · MICO (Demo MICCAI 2018), MITK (2018-04)

Sep 20 2018

floca committed rMITK45b84b51945d: Fixed T25441 / Refactored node naming (authored by floca).
Fixed T25441 / Refactored node naming
Sep 20 2018, 3:38 PM
floca committed rMITK323d1e27ba4d: Added IPropertOwner/IPropertyProvider interfaces to PropertyList and… (authored by floca).
Added IPropertOwner/IPropertyProvider interfaces to PropertyList and…
Sep 20 2018, 3:38 PM
floca committed rMITK63b1f32f4eb2: Fixed missing series info (authored by floca).
Fixed missing series info
Sep 20 2018, 3:38 PM
floca committed rMITKf3b1a5948b49: First fix (authored by floca).
First fix
Sep 20 2018, 3:38 PM
floca committed rMITK4a81310d755f: Improvments in UI and business logic. (authored by floca).
Improvments in UI and business logic.
Sep 20 2018, 3:38 PM
floca committed rMITK10e13fef0c2c: Refactored ModelFit inspector (authored by floca).
Refactored ModelFit inspector
Sep 20 2018, 3:38 PM