Page MenuHomePhabricator

floca (Ralf Omar Floca)
User

Projects (12)

User Details

User Since
Aug 1 2016, 12:10 PM (181 w, 3 d)

Recent Activity

Yesterday

floca closed T22888: ImageStatistics Plugin: Model/View instead of TableWidget as Resolved.

I think both is right

  1. It is already resolved by work of HackingWeek 2019/2
  2. If docu writes something about TabelModel it is wrong/outdates/implementation detail...
Thu, Jan 23, 4:50 PM · MITK
floca added a comment to T24776: Refactor MatchPoint plugins to use the new node selection widgets.

Batch is deprecated. Frame Correction is the last opened view.

Thu, Jan 23, 4:36 PM · MITK
floca triaged T27029: SingleNodeSelection skips user selection on predicate change as Normal priority.
Thu, Jan 23, 2:42 PM · MITK
floca added a revision to T24776: Refactor MatchPoint plugins to use the new node selection widgets: Unknown Object (Differential Revision).
Thu, Jan 23, 10:43 AM · MITK
floca updated the task description for T27027: Optimize selection widget disabled state vizualization.
Thu, Jan 23, 9:43 AM · MITK
floca triaged T27027: Optimize selection widget disabled state vizualization as Normal priority.
Thu, Jan 23, 9:42 AM · MITK
floca triaged T27026: Deprecate MatchPoint Batch Registration View as Normal priority.
Thu, Jan 23, 9:38 AM · MITK

Wed, Jan 22

floca added a comment to T19124: When selecting more than one measurement, statistics aren't calculated.

Clemenst meant Option 2. This is what we have planned.
Cannot tell what @zhangyan meant. I would fix this with option 2.

Wed, Jan 22, 9:18 PM · Bugzilla, MITK
floca committed rMITK9eb9830a1a13: Fixed T24660 (authored by floca).
Fixed T24660
Wed, Jan 22, 1:38 PM
floca committed rMITKfacc3e630dc0: Merge remote-tracking branch 'origin/master' into T24660… (authored by floca).
Merge remote-tracking branch 'origin/master' into T24660…
Wed, Jan 22, 1:38 PM

Tue, Jan 21

floca committed rMITK93827c374c6b: Fixed review remarks. (authored by floca).
Fixed review remarks.
Tue, Jan 21, 2:50 PM
floca committed rMITK48cfba96c089: Fixed T24660 (authored by floca).
Fixed T24660
Tue, Jan 21, 2:50 PM
floca closed T24660: Add a "selection history" inspector as Resolved by committing rMITK48cfba96c089: Fixed T24660.
Tue, Jan 21, 2:49 PM · MITK
floca closed T24660: Add a "selection history" inspector, a subtask of T23751: Introduction of new selection concept, as Resolved.
Tue, Jan 21, 2:49 PM · MITK
floca added a comment to T24660: Add a "selection history" inspector.

Pushed new branch T24660-selection_history_inspector.

Tue, Jan 21, 2:49 PM · MITK

Mon, Jan 20

floca added a comment to T27006: [Perfusion] - Problems selecting T1 map.
In T27006#191923, @Sara wrote:

Hi Ralf,
We changed the properties of the data node regarding the T1 map but unsuccessfully.
We always get "Dimension 2 is not in (ItkOutputImageType::ImageDimension)" error.

Just to be sure. The work-arround with the "binary" property (see above) is only for the problem that you weren't able to select the T1 map in the view.
It is not a solution for the Dimension 2 is not in (ItkOutputImageType::ImageDimension) error!

Mon, Jan 20, 11:59 AM · MITK
floca added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

@jsolislemus : Could you provide me your email adresse? Then I will send you the instructions how to transfer data.
Thanks

Mon, Jan 20, 10:04 AM · MITK (2018-04-4)

Sun, Jan 19

floca closed T27006: [Perfusion] - Problems selecting T1 map as Invalid.

The problem was caused by the fact that the T1 map has just 2 different pixel values. Therfore it was automatically classified as binary image /mask on loading.

Sun, Jan 19, 8:36 AM · MITK
floca triaged T27006: [Perfusion] - Problems selecting T1 map as Normal priority.
Sun, Jan 19, 8:30 AM · MITK

Sat, Jan 18

floca added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

That would be great. Thanks!

Sat, Jan 18, 1:25 PM · MITK (2018-04-4)

Fri, Jan 17

floca claimed T24776: Refactor MatchPoint plugins to use the new node selection widgets.
Fri, Jan 17, 5:47 PM · MITK
floca added a revision to T24660: Add a "selection history" inspector: Unknown Object (Differential Revision).
Fri, Jan 17, 5:44 PM · MITK

Thu, Jan 16

floca triaged T26239: BlackboxFunction custom parameters in own "bucket" and not in "params" as Normal priority.
Thu, Jan 16, 3:18 PM · Hyppopy
floca added a comment to T26998: Refactor Properties plugin to use the new node selection widgets.

@floca: This task does not fix T26475 since the QmitkSingleSlotSelectionWidget does not react to node changes itself (see T27000).

Yes you are right. I was inprecise. I already had T26851 in mind because it is on out to do list.

Thu, Jan 16, 1:28 PM · MITK

Wed, Jan 15

floca added a comment to T26475: QmitkPropertyTreeView does not react on DICOM node changes.

@kalali: If this task is fixed T26475 should be fixed as well, after you introduced the new SelectionWidget to QmitkPropertyTreeView, shouldn't it? Or is it already fixed due to T26381?

Wed, Jan 15, 7:53 PM · Restricted Project, MITK
floca accepted rMITKfdfabc089f2d: Enalbe NodeChanged event trigger and pre-check if update is necessary.

Logic is correct. But I would condense it to remove redundancy (see inline comment).

Wed, Jan 15, 7:48 PM
floca accepted rMITK13e7f96912aa: Add new inspector for favorite nodes.

Discussed it offline.

Wed, Jan 15, 1:45 PM

Tue, Jan 14

floca added inline comments to rMITK13e7f96912aa: Add new inspector for favorite nodes.
Tue, Jan 14, 9:44 PM
floca raised a concern with rMITK13e7f96912aa: Add new inspector for favorite nodes.
Tue, Jan 14, 9:40 PM
floca claimed T24660: Add a "selection history" inspector.
Tue, Jan 14, 9:05 AM · MITK

Fri, Jan 10

floca updated the task description for T25043: Remove pixel informations from the statusbar and put it into views.
Fri, Jan 10, 12:25 PM · MITK
floca added a revision to T26980: MITK_CREATE_MACRO should prohibit dependencies against autoload modules: Unknown Object (Differential Revision).
Fri, Jan 10, 12:09 PM · MITK (2018-04-4)

Thu, Jan 9

floca committed rMITK4b0ae72571dc: Removed autoload dependencies. (authored by floca).
Removed autoload dependencies.
Thu, Jan 9, 6:37 PM
floca added a project to T25930: [Segmentation] Fill/Erase crashes at non-zero timestep / Issue with ArbitraryTimeGeometry: Request for Discussion.
Thu, Jan 9, 6:33 PM · Request for Discussion, Restricted Project, MITK (2018-04-4)
floca committed rMITK3f52569e770a: First draft for fix of T26980 (authored by floca).
First draft for fix of T26980
Thu, Jan 9, 12:22 PM
floca added a comment to T26980: MITK_CREATE_MACRO should prohibit dependencies against autoload modules.

Pushed new branch T26980-Prohibit_dependency_on_autoload_module.

Thu, Jan 9, 12:22 PM · MITK (2018-04-4)
floca claimed T26980: MITK_CREATE_MACRO should prohibit dependencies against autoload modules.
Thu, Jan 9, 12:19 PM · MITK (2018-04-4)
floca triaged T26980: MITK_CREATE_MACRO should prohibit dependencies against autoload modules as Normal priority.
Thu, Jan 9, 10:20 AM · MITK (2018-04-4)

Dec 20 2019

floca added a parent task for T26951: DICOM SEG - DicomSegIO should just use properties of the passed segmentation object: T25192: Enable DICOM SEG conversion for nrrd segmentations.
Dec 20 2019, 11:03 PM · MITK
floca added a parent task for T26952: Implement helper to correct (DICOM conformal) set the properties of a segmentation (DICOM SEG): T25192: Enable DICOM SEG conversion for nrrd segmentations.
Dec 20 2019, 11:03 PM · MITK
floca added subtasks for T25192: Enable DICOM SEG conversion for nrrd segmentations: T26952: Implement helper to correct (DICOM conformal) set the properties of a segmentation (DICOM SEG), T26951: DICOM SEG - DicomSegIO should just use properties of the passed segmentation object.
Dec 20 2019, 11:03 PM · MICO (Demo MICCAI 2018), MITK
floca added a comment to T25192: Enable DICOM SEG conversion for nrrd segmentations.

I don't know the status of the branch above as it is dangeling arround for quite some time.

Dec 20 2019, 11:00 PM · MICO (Demo MICCAI 2018), MITK
floca added a parent task for T25988: LabelSetImageIO should support time geometries and property serialization: T25192: Enable DICOM SEG conversion for nrrd segmentations.
Dec 20 2019, 10:55 PM · MITK (2018-04-4)
floca added a subtask for T25192: Enable DICOM SEG conversion for nrrd segmentations: T25988: LabelSetImageIO should support time geometries and property serialization.
Dec 20 2019, 10:55 PM · MICO (Demo MICCAI 2018), MITK
floca updated the task description for T26953: DICOM SEG - Cannot rewrite segmentations as DICOM SEG.
Dec 20 2019, 10:51 PM · MITK
floca added a parent task for T26951: DICOM SEG - DicomSegIO should just use properties of the passed segmentation object: T26953: DICOM SEG - Cannot rewrite segmentations as DICOM SEG.
Dec 20 2019, 10:51 PM · MITK
floca added a subtask for T26953: DICOM SEG - Cannot rewrite segmentations as DICOM SEG: T26951: DICOM SEG - DicomSegIO should just use properties of the passed segmentation object.
Dec 20 2019, 10:51 PM · MITK
floca created T26953: DICOM SEG - Cannot rewrite segmentations as DICOM SEG.
Dec 20 2019, 10:50 PM · MITK
floca renamed T26952: Implement helper to correct (DICOM conformal) set the properties of a segmentation (DICOM SEG) from Implement helper to correct (DICOM conforma) set the properties of a segmentation (DICOM SEG) to Implement helper to correct (DICOM conformal) set the properties of a segmentation (DICOM SEG).
Dec 20 2019, 10:48 PM · MITK
floca added a subtask for T26952: Implement helper to correct (DICOM conformal) set the properties of a segmentation (DICOM SEG): T26950: Add rule class for DICOM Seg relations to source image.
Dec 20 2019, 10:48 PM · MITK
floca added a parent task for T26950: Add rule class for DICOM Seg relations to source image: T26952: Implement helper to correct (DICOM conformal) set the properties of a segmentation (DICOM SEG).
Dec 20 2019, 10:48 PM · MITK
floca edited parent tasks for T26952: Implement helper to correct (DICOM conformal) set the properties of a segmentation (DICOM SEG), added: T26951: DICOM SEG - DicomSegIO should just use properties of the passed segmentation object; removed: T23774: Implement helper to correctly (DICOM conformal) parameterize images (or other BaseData derived classes).
Dec 20 2019, 10:48 PM · MITK
floca added a subtask for T26951: DICOM SEG - DicomSegIO should just use properties of the passed segmentation object: T26952: Implement helper to correct (DICOM conformal) set the properties of a segmentation (DICOM SEG).
Dec 20 2019, 10:48 PM · MITK
floca removed a subtask for T23774: Implement helper to correctly (DICOM conformal) parameterize images (or other BaseData derived classes): T26952: Implement helper to correct (DICOM conformal) set the properties of a segmentation (DICOM SEG).
Dec 20 2019, 10:48 PM · MITK
floca triaged T26952: Implement helper to correct (DICOM conformal) set the properties of a segmentation (DICOM SEG) as Normal priority.
Dec 20 2019, 10:48 PM · MITK
floca added a subtask for T26951: DICOM SEG - DicomSegIO should just use properties of the passed segmentation object: T26950: Add rule class for DICOM Seg relations to source image.
Dec 20 2019, 10:42 PM · MITK
floca added a parent task for T26950: Add rule class for DICOM Seg relations to source image: T26951: DICOM SEG - DicomSegIO should just use properties of the passed segmentation object.
Dec 20 2019, 10:42 PM · MITK
floca created T26951: DICOM SEG - DicomSegIO should just use properties of the passed segmentation object.
Dec 20 2019, 10:39 PM · MITK
floca triaged T26950: Add rule class for DICOM Seg relations to source image as Normal priority.
Dec 20 2019, 10:19 PM · MITK
floca updated the task description for T26843: Rethink/CleanUp PropertyRelation connection levels and RII properties used in SourceImageRelationRule.
Dec 20 2019, 10:14 PM · MITK
floca updated the task description for T26843: Rethink/CleanUp PropertyRelation connection levels and RII properties used in SourceImageRelationRule.
Dec 20 2019, 10:13 PM · MITK
floca created T26949: DICOM SEG - 3D segmentations with only one slice cannot be reloaded as DICOM SEG .
Dec 20 2019, 9:34 PM · MITK
floca updated the task description for T26903: DICOM Seg writing is broken due to changes in DICOMSEGIOMimeType.
Dec 20 2019, 9:18 PM · MITK (2018-04-4), Request for Discussion

Dec 6 2019

floca added a comment to T25192: Enable DICOM SEG conversion for nrrd segmentations.

NOT READY FOR MASTER!
Already add serialization of properties marked as persistent to the multilabel nrrd writer. Also copied the code from image nrrd file reader to get all properties while reading a nrrd image (not nice but works). But testing was only for one use case. So looking for side effects before merging this commit (6f1b022e7b8d) into master.

Dec 6 2019, 6:28 PM · MICO (Demo MICCAI 2018), MITK
floca added a comment to T26903: DICOM Seg writing is broken due to changes in DICOMSEGIOMimeType.

rMITK060c74e0e13601d6ccd7653122ce65e2e7fae181 is a proposed fix for the problem.
@neher Do you see any problems?

Dec 6 2019, 6:18 PM · MITK (2018-04-4), Request for Discussion
floca committed rMITK060c74e0e136: Patched problem due to T26903 in order to allow storing of DICOM seg again. (authored by floca).
Patched problem due to T26903 in order to allow storing of DICOM seg again.
Dec 6 2019, 6:17 PM
floca committed rMITK427d7f56e989: Corrected command line argument name (authored by floca).
Corrected command line argument name
Dec 6 2019, 6:17 PM
floca triaged T26903: DICOM Seg writing is broken due to changes in DICOMSEGIOMimeType as Unbreak Now! priority.
Dec 6 2019, 6:07 PM · MITK (2018-04-4), Request for Discussion
floca updated subscribers of T26897: Build error: Could not find git for clone of qRestAPI.

I have managed to compile now just using cmake cli, when doing the following:

Dec 6 2019, 4:38 PM · MITK
floca committed rMITK31d1c60d7158: Fixes broken ExtractSliceFilter (authored by floca).
Fixes broken ExtractSliceFilter
Dec 6 2019, 4:26 PM
floca added a comment to T26167: ExtractSliceFilter handles 3D+t images inefficiently and inconsequently.

Pushed new branch T26167-Fix_broken_test.

Dec 6 2019, 4:26 PM · MITK
floca updated subscribers of T26167: ExtractSliceFilter handles 3D+t images inefficiently and inconsequently.

@kompan It is now in the master. ;)

Dec 6 2019, 3:00 PM · MITK
floca added a reverting change for rMITK1f815a9b6d98: Test of performance impact of simplified (unsafer) ArbitraryTimeGeometry: rMITK1f6747197e81: Fixed T26167. ExtractSliceFilter does not clone unnecessarily the input….
Dec 6 2019, 2:55 PM
floca committed rMITK1f6747197e81: Fixed T26167. ExtractSliceFilter does not clone unnecessarily the input… (authored by floca).
Fixed T26167. ExtractSliceFilter does not clone unnecessarily the input…
Dec 6 2019, 2:55 PM
floca committed rMITK0c068a29b4af: Fixed review remarks (authored by floca).
Fixed review remarks
Dec 6 2019, 2:55 PM
floca closed T26167: ExtractSliceFilter handles 3D+t images inefficiently and inconsequently as Resolved by committing rMITK1f6747197e81: Fixed T26167. ExtractSliceFilter does not clone unnecessarily the input….
Dec 6 2019, 2:54 PM · MITK

Dec 5 2019

floca added a comment to T26897: Build error: Could not find git for clone of qRestAPI.

I have the same error on my local Ubuntu VM. But only if configure via CMake command line. If I use the CMake gui and set the same values, then everything works fine.
Generator does not matter I have the problem with make and ninja; with one and multiple jobs.

Dec 5 2019, 9:39 PM · MITK

Dec 3 2019

floca committed rMITKfcb0a4eb1c8a: Added system independent output path generation. (authored by floca).
Added system independent output path generation.
Dec 3 2019, 9:04 PM
floca committed rMITK29e20f6291dd: Quickfix / hack to avoid parsing errors for flow arguments under linux. (authored by floca).
Quickfix / hack to avoid parsing errors for flow arguments under linux.
Dec 3 2019, 5:43 PM
floca committed rMITK05ccf5cfbbcf: Removed unnecessary out commented code (authored by floca).
Removed unnecessary out commented code
Dec 3 2019, 5:43 PM

Nov 28 2019

floca moved T26451: DICOM plugin cannot parse DICOM directories in macOS installer from Backlog to MITK Meeting on the Request for Discussion board.
Nov 28 2019, 9:46 PM · MITK (2018-04-4)
floca edited projects for T26451: DICOM plugin cannot parse DICOM directories in macOS installer, added: Request for Discussion, MITK; removed MITK (2018-04-4).

Sorry for the long delay. Localisers should not be a problem per se. We also have such images in our protocols.

Nov 28 2019, 9:45 PM · MITK (2018-04-4)
floca placed T26158: Perfomance loss due to intense (time)geometry clonig up for grabs.

Fixing T26167 was enough for now.

Nov 28 2019, 3:13 PM · MITK

Nov 27 2019

floca added a comment to T26777: Refactoring QmitkChartExample.

Ok, thanks!

Nov 27 2019, 9:03 PM · MITK
floca added a reverting change for rMITK1f815a9b6d98: Test of performance impact of simplified (unsafer) ArbitraryTimeGeometry: Unknown Object (Differential Revision).
Nov 27 2019, 5:55 PM
floca added a revision to T26167: ExtractSliceFilter handles 3D+t images inefficiently and inconsequently: Unknown Object (Differential Revision).
Nov 27 2019, 5:55 PM · MITK
floca added a comment to T26777: Refactoring QmitkChartExample.

Sooner then later I have to restart on reworking the ChartWidget due to performance problems when transfering data to the java script side. Currently each line is communicated on its own and this communication has an overhead. Paied for every graph line on an update it is a serious performance bump that impacts usability e.g. in the perfusion context.

Nov 27 2019, 5:27 PM · MITK
floca added a reverting change for rMITK1f815a9b6d98: Test of performance impact of simplified (unsafer) ArbitraryTimeGeometry: rMITKc3d79c9093d2: Revert "Test of performance impact of simplified (unsafer)….
Nov 27 2019, 5:18 PM
floca committed rMITKc3d79c9093d2: Revert "Test of performance impact of simplified (unsafer)… (authored by floca).
Revert "Test of performance impact of simplified (unsafer)…
Nov 27 2019, 5:18 PM
floca committed rMITK33ada1271b45: Reworked ExtractSliceFilter::GenerateOutput() to remove redundant code for… (authored by floca).
Reworked ExtractSliceFilter::GenerateOutput() to remove redundant code for…
Nov 27 2019, 5:18 PM
floca committed rMITK1f815a9b6d98: Test of performance impact of simplified (unsafer) ArbitraryTimeGeometry (authored by floca).
Test of performance impact of simplified (unsafer) ArbitraryTimeGeometry
Nov 27 2019, 5:18 PM

Nov 26 2019

floca added a member for HAF: kleina.
Nov 26 2019, 8:50 PM
floca updated the image for HiGHmed from F1453041: profile to F1453043: profile.
Nov 26 2019, 8:48 PM
floca set the image for HiGHmed to F1453041: profile.
Nov 26 2019, 8:47 PM
floca added a member for HiGHmed: c082x.
Nov 26 2019, 8:46 PM
floca committed rMITK62782a545308: Fixed gcc compiler errors (authored by floca).
Fixed gcc compiler errors
Nov 26 2019, 5:13 PM

Nov 25 2019

floca added a comment to T26851: QmitkNodeSelectionButton does not refresh if node information changes.

Oh, great. Thanks for the hint.

Nov 25 2019, 6:03 PM · MITK
floca triaged T26851: QmitkNodeSelectionButton does not refresh if node information changes as Low priority.
Nov 25 2019, 4:46 PM · MITK
floca updated the task description for T26843: Rethink/CleanUp PropertyRelation connection levels and RII properties used in SourceImageRelationRule.
Nov 25 2019, 1:53 PM · MITK
floca committed rMITKf80a628814fa: Renamed flowbench plugins into flow plugins. Finished dependency inversion… (authored by floca).
Renamed flowbench plugins into flow plugins. Finished dependency inversion…
Nov 25 2019, 1:26 PM