Page MenuHomePhabricator

floca (Ralf Omar Floca)
User

Projects (14)

User Details

User Since
Aug 1 2016, 12:10 PM (406 w, 6 d)

Recent Activity

Wed, May 15

floca moved T30447: [TotalSeg] Levelwindow effect from Backlog to MITK Meeting on the Request for Discussion board.
Wed, May 15, 9:52 AM · MITK
floca added a project to T30447: [TotalSeg] Levelwindow effect: Request for Discussion.
Wed, May 15, 9:52 AM · MITK

Tue, May 14

floca placed T30412: [Statistics] Planar figure cannot be set as ROI for askew images up for grabs.
Tue, May 14, 9:34 AM · MITK, Next Milestone
floca closed T30421: [SEG] Undo/Redo problems with Fill/Erase tool reported as Wontfix.

Undo/redo is a known problem, covered by other tickets.
The crash propblem I was not able to reproduce.

Tue, May 14, 9:31 AM · Missing Info, Checklist, MITK (v2024.06)
floca committed rMITK1b29c1cf757a: T30444-Crash_when_working_with_labels (authored by floca).
T30444-Crash_when_working_with_labels
Tue, May 14, 9:28 AM
floca committed rMITKd50db49303c6: fixed typos (authored by floca).
fixed typos
Tue, May 14, 9:28 AM
floca committed rMITKb6bb9b40d428: Secured usage of GetLabel results to ensure that not nullptr access is (authored by floca).
Secured usage of GetLabel results to ensure that not nullptr access is
Tue, May 14, 9:28 AM
floca committed rMITK18037d1366b5: Changed return of GetLabel() to ensure secure usage of method with auto. (authored by floca).
Changed return of GetLabel() to ensure secure usage of method with auto.
Tue, May 14, 9:28 AM

Mon, May 13

floca committed rMITKaf12ad9b29fe: T30442-fix_clear_label_content_refresh (authored by floca).
T30442-fix_clear_label_content_refresh
Mon, May 13, 1:39 PM
floca closed T30442: [SEG] Clear content on one label does not directly refresh the render windows as Resolved by committing rMITK9345a199763e: Fixed T30442.
Mon, May 13, 1:39 PM · MITK (v2024.06)
floca committed rMITK9345a199763e: Fixed T30442 (authored by floca).
Fixed T30442
Mon, May 13, 1:39 PM
floca added a revision to T30442: [SEG] Clear content on one label does not directly refresh the render windows: Unknown Object (Differential Revision).
Mon, May 13, 11:55 AM · MITK (v2024.06)
floca moved T30444: [SEG] Crash when working a lot with labels on label delete from Backlog to Cycle on the MITK (v2024.06) board.
Mon, May 13, 11:29 AM · MITK (v2024.06)

Sat, May 11

floca added a comment to T30444: [SEG] Crash when working a lot with labels on label delete .

After monkey testing in RelWDebugInfo, I think I found a lead. It can happen due to different processing of the Qt event queue that GetLabel is queried in a widget on a label that does not exist anymore. But it is not checked if GetLabel returns nullptr. Which in this case can happen. I hope this will fix the problem..,

Sat, May 11, 12:24 PM · MITK (v2024.06)
floca triaged T30444: [SEG] Crash when working a lot with labels on label delete as Unbreak Now! priority.
Sat, May 11, 12:21 PM · MITK (v2024.06)
floca changed the visibility for F3651393: bug_tab.PNG.
Sat, May 11, 12:19 PM
floca changed the visibility for F3651396: bug_tab2.PNG.
Sat, May 11, 12:18 PM
floca created T30443: Tab button of 2nd view is not correctly rendered.
Sat, May 11, 12:17 PM · MITK (v2024.06)

Fri, May 10

floca triaged T30442: [SEG] Clear content on one label does not directly refresh the render windows as Low priority.
Fri, May 10, 3:04 PM · MITK (v2024.06)
floca closed T30422: [SEG] Erase tool double click is irritating as Resolved.
Fri, May 10, 2:20 PM · Checklist, MITK (v2024.06)
floca committed rMITK196b8d8a4948: BREAKING: Removed background click feature from EraseRegionTool (authored by floca).
BREAKING: Removed background click feature from EraseRegionTool
Fri, May 10, 2:20 PM
floca committed rMITK4b9a5e0625e1: T30422-Remove_erase_tool_background_click (authored by floca).
T30422-Remove_erase_tool_background_click
Fri, May 10, 2:20 PM
floca committed rMITK6a2778e74939: T30417-Fix_confusing_highlighting_invisible_labels (authored by floca).
T30417-Fix_confusing_highlighting_invisible_labels
Fri, May 10, 2:19 PM
floca committed rMITK87c91fb3dedf: Fixed gcc error (authored by floca).
Fixed gcc error
Fri, May 10, 2:19 PM
floca closed T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX as Resolved by committing rMITK27cad36203c2: Refactored QmitkMultiLabelInspector to use the highlight guard.
Fri, May 10, 2:19 PM · Request for Discussion, Checklist, MITK (v2024.06)
floca committed rMITK27cad36203c2: Refactored QmitkMultiLabelInspector to use the highlight guard (authored by floca).
Refactored QmitkMultiLabelInspector to use the highlight guard
Fri, May 10, 2:19 PM
floca committed rMITK692addbcd6fe: Rework mapper to support highlight invisible (authored by floca).
Rework mapper to support highlight invisible
Fri, May 10, 2:19 PM
floca committed rMITK57fedf2e5d5d: Introduced the LabelHighlightGuard (authored by floca).
Introduced the LabelHighlightGuard
Fri, May 10, 2:19 PM
floca edited projects for T30412: [Statistics] Planar figure cannot be set as ROI for askew images, added: Next Milestone, MITK, Request for Discussion; removed Missing Info, Checklist, MITK (v2024.06).

We should clarify how we handle the reinit or reinit warning in the Measurement view. Should be very simelar to the Segmentation view.

Fri, May 10, 10:39 AM · MITK, Next Milestone

Thu, May 9

floca moved T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX from Backlog to Cycle on the MITK (v2024.06) board.
Thu, May 9, 10:53 AM · Request for Discussion, Checklist, MITK (v2024.06)
floca moved T30422: [SEG] Erase tool double click is irritating from Backlog to Cycle on the MITK (v2024.06) board.
Thu, May 9, 10:53 AM · Checklist, MITK (v2024.06)
floca moved T30432: [Perfusion] Possible to write text into info box from Backlog to Cycle on the MITK (v2024.06) board.
Thu, May 9, 10:53 AM · Next Milestone, MITK (v2024.06)
floca moved T30421: [SEG] Undo/Redo problems with Fill/Erase tool reported from Backlog to Cycle on the MITK (v2024.06) board.
Thu, May 9, 10:53 AM · Missing Info, Checklist, MITK (v2024.06)
floca added a comment to T30422: [SEG] Erase tool double click is irritating.

How to adapt: Use the "clear label" option in the context menue of the label inspector.

Thu, May 9, 10:52 AM · Checklist, MITK (v2024.06)
floca claimed T30422: [SEG] Erase tool double click is irritating.
Thu, May 9, 10:48 AM · Checklist, MITK (v2024.06)
floca added a revision to T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX: Unknown Object (Differential Revision).
Thu, May 9, 10:47 AM · Request for Discussion, Checklist, MITK (v2024.06)
floca claimed T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX.
Thu, May 9, 10:45 AM · Request for Discussion, Checklist, MITK (v2024.06)

Tue, May 7

floca committed rMITK303cdff5e506: Fixed T29526 (authored by floca).
Fixed T29526
Tue, May 7, 6:28 PM
floca committed rMITK88164071fbca: Fixed T29526 (authored by floca).
Fixed T29526
Tue, May 7, 6:28 PM
floca closed T29526: [Segmentation] Workbench crashes when closing render window part with active tool as Resolved by committing rMITK88164071fbca: Fixed T29526.
Tue, May 7, 6:28 PM · MITK (v2024.06)
floca added a comment to T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX.

hm. I see.
May be:
B + if you press shift while hovering, then always highlight?

Tue, May 7, 4:08 PM · Request for Discussion, Checklist, MITK (v2024.06)
floca added a comment to T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX.

but the disadvantages proved to outweigh.

That you cannot tell. You don't know how testers would react to option A. May be it is equaly irritating to them. And may be they would missing the highlighting of invisible labels if the realy would work with it... 🤔
If we want to base it on user feedback in such an unclear situation, one would need to offer/explain all options and let them choose/poll.

Tue, May 7, 3:51 PM · Request for Discussion, Checklist, MITK (v2024.06)
floca added a comment to T30412: [Statistics] Planar figure cannot be set as ROI for askew images.

Hm, yes, As we also define a reference image like in the segmentation view. I think it is the most pragmatic and consistent approach to introduce the same/simelar behavior:
warn users if the rendering is not alligned with the reference image and only allow making planar figures if the geometry was reinit.
I am not sure if reinit as soon as the click on a planar figure button wouldn't be irritating.

Tue, May 7, 3:45 PM · MITK, Next Milestone
floca committed rMITK02992e94b8ae: T30411-Fix_wrong_label_color_display_after_instance_addition (authored by floca).
T30411-Fix_wrong_label_color_display_after_instance_addition
Tue, May 7, 3:20 PM
floca closed T30411: [SEG] Label color is off unitl first refresh when instances are used as Resolved by committing rMITK36f6b8c0d855: Fixed T30411.
Tue, May 7, 3:20 PM · Checklist, MITK (v2024.06)
floca committed rMITK36f6b8c0d855: Fixed T30411 (authored by floca).
Fixed T30411
Tue, May 7, 3:20 PM
floca committed rMITK109886894aa4: Fixed T30420 (authored by floca).
Fixed T30420
Tue, May 7, 3:19 PM
floca closed T30420: [SEG] Fill/Erase tool does not work due to geometry error, a subtask of T30421: [SEG] Undo/Redo problems with Fill/Erase tool reported, as Resolved.
Tue, May 7, 3:19 PM · Missing Info, Checklist, MITK (v2024.06)
floca closed T30420: [SEG] Fill/Erase tool does not work due to geometry error as Resolved by committing rMITKd52112aa4083: Fixed T30420.
Tue, May 7, 3:19 PM · Checklist, MITK (v2024.06)
floca committed rMITKd52112aa4083: Fixed T30420 (authored by floca).
Fixed T30420
Tue, May 7, 3:19 PM
floca committed rMITKd97f4d532271: T30419-Fix_growcut_confirm_btn (authored by floca).
T30419-Fix_growcut_confirm_btn
Tue, May 7, 3:18 PM
floca closed T30419: [Segmentation] "Preview" button of GrowCut tools needs to be clicked twice before "Confirm segmentation" button gets active as Resolved by committing rMITK551e8c93dbfc: Fixed T30419.
Tue, May 7, 3:18 PM · Checklist, MITK (v2024.06)
floca committed rMITK551e8c93dbfc: Fixed T30419 (authored by floca).
Fixed T30419
Tue, May 7, 3:18 PM
floca claimed T29526: [Segmentation] Workbench crashes when closing render window part with active tool.
Tue, May 7, 2:59 PM · MITK (v2024.06)
floca moved T30412: [Statistics] Planar figure cannot be set as ROI for askew images from Backlog to Cycle on the MITK (v2024.06) board.
Tue, May 7, 2:50 PM · MITK, Next Milestone
floca added a project to T30412: [Statistics] Planar figure cannot be set as ROI for askew images: Missing Info.

I cannot reproduce the "bug".
But it is not realy a bug but correct. If you do not reinit on brain.nrrd before making the planar figure, it is tilted. Therefore no statistics can be computed.

Tue, May 7, 2:49 PM · MITK, Next Milestone
floca claimed T30412: [Statistics] Planar figure cannot be set as ROI for askew images.
Tue, May 7, 2:37 PM · MITK, Next Milestone
floca merged T30418: [Segmentation / Pixel Value] Pixel values only shown for active group into T29525: Pixel Value View should be aware of label set images.
Tue, May 7, 2:36 PM · MITK
floca merged task T30418: [Segmentation / Pixel Value] Pixel values only shown for active group into T29525: Pixel Value View should be aware of label set images.
Tue, May 7, 2:36 PM · Checklist, MITK (v2024.06)
floca added a revision to T30419: [Segmentation] "Preview" button of GrowCut tools needs to be clicked twice before "Confirm segmentation" button gets active: Unknown Object (Differential Revision).
Tue, May 7, 2:30 PM · Checklist, MITK (v2024.06)

Mon, May 6

floca moved T30419: [Segmentation] "Preview" button of GrowCut tools needs to be clicked twice before "Confirm segmentation" button gets active from Backlog to Cycle on the MITK (v2024.06) board.
Mon, May 6, 12:11 PM · Checklist, MITK (v2024.06)
floca moved T30411: [SEG] Label color is off unitl first refresh when instances are used from Backlog to Cycle on the MITK (v2024.06) board.
Mon, May 6, 12:11 PM · Checklist, MITK (v2024.06)
floca moved T30420: [SEG] Fill/Erase tool does not work due to geometry error from Backlog to Cycle on the MITK (v2024.06) board.
Mon, May 6, 12:11 PM · Checklist, MITK (v2024.06)
floca claimed T30419: [Segmentation] "Preview" button of GrowCut tools needs to be clicked twice before "Confirm segmentation" button gets active.
Mon, May 6, 12:10 PM · Checklist, MITK (v2024.06)
floca added a project to T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX: Request for Discussion.

The first version had option B.
I changed it because I thought that UX is better if you have still the posibility to peek/see also the highlight of invisible labels. E.g. in order to pick the right one to make visible again.

Mon, May 6, 10:26 AM · Request for Discussion, Checklist, MITK (v2024.06)
floca claimed T30420: [SEG] Fill/Erase tool does not work due to geometry error.
Mon, May 6, 10:10 AM · Checklist, MITK (v2024.06)
floca triaged T30422: [SEG] Erase tool double click is irritating as Normal priority.
Mon, May 6, 9:31 AM · Checklist, MITK (v2024.06)
floca added a comment to T30421: [SEG] Undo/Redo problems with Fill/Erase tool reported.

Have to check if T30420 is fixed.

Mon, May 6, 9:08 AM · Missing Info, Checklist, MITK (v2024.06)
floca added a subtask for T30421: [SEG] Undo/Redo problems with Fill/Erase tool reported: T30420: [SEG] Fill/Erase tool does not work due to geometry error.
Mon, May 6, 9:08 AM · Missing Info, Checklist, MITK (v2024.06)
floca added a parent task for T30420: [SEG] Fill/Erase tool does not work due to geometry error: T30421: [SEG] Undo/Redo problems with Fill/Erase tool reported.
Mon, May 6, 9:08 AM · Checklist, MITK (v2024.06)
floca created T30421: [SEG] Undo/Redo problems with Fill/Erase tool reported.
Mon, May 6, 9:08 AM · Missing Info, Checklist, MITK (v2024.06)
floca updated the task description for T30420: [SEG] Fill/Erase tool does not work due to geometry error.
Mon, May 6, 9:05 AM · Checklist, MITK (v2024.06)
floca triaged T30420: [SEG] Fill/Erase tool does not work due to geometry error as Unbreak Now! priority.
Mon, May 6, 9:05 AM · Checklist, MITK (v2024.06)
floca claimed T30411: [SEG] Label color is off unitl first refresh when instances are used.
Mon, May 6, 8:59 AM · Checklist, MITK (v2024.06)

Sat, May 4

floca added a comment to T30410: [Segmentation] 2-d interpolation does not interpolate between multiple slices.

I also peeked into the code base. And as also 2D is a mess 🙈.
It would make sense to completle rework and align it with the chaching mechanism of the surface interpolation controler (may be refactor it to use the same interpolation base class or just cover both use cases in the same controller class, because the only difference is the interpolation strategy (generate surface or slice interpolations along a plane normal, and over a method for doing 2D interpolations).
Therfore I am inclined to opt for the following:

Sat, May 4, 12:55 PM · MITK, Next Milestone
floca added a revision to T30411: [SEG] Label color is off unitl first refresh when instances are used: Restricted Differential Revision.
Sat, May 4, 12:04 PM · Checklist, MITK (v2024.06)
floca added a comment to T30398: 3D interpolation using SAM tool.

@a178n isn't that resolved?

Sat, May 4, 11:59 AM · MITK
floca closed T29437: [SEG] Add TotalSegmentator, a subtask of T29191: [SEG] New segmentation tool candidates, as Resolved.
Sat, May 4, 11:57 AM · MITK (v2024.06)
floca closed T29437: [SEG] Add TotalSegmentator as Resolved.

The open sub tasks are still valid. But as TotalSegmentator itself is added, I would close this very task.

Sat, May 4, 11:57 AM · MITK
floca closed T29465: How to display available statistics of segmentation, a subtask of T29458: Include Advanced settings support for TotalSegmentator tool in MITK, as Wontfix.
Sat, May 4, 11:55 AM · MITK (v2023.04)
floca closed T29465: How to display available statistics of segmentation as Wontfix.
Sat, May 4, 11:55 AM · MITK
floca committed rMITKac60245b872e: T30408_fix_create_label_dialoge_canceling (authored by floca).
T30408_fix_create_label_dialoge_canceling
Sat, May 4, 11:52 AM
floca committed rMITK6e6d7553a3b8: Fixed T30409 (authored by floca).
Fixed T30409
Sat, May 4, 11:52 AM
floca closed T30409: [Segmentation] Clear content in label context menu does not update render windows as Resolved by committing rMITK6e6d7553a3b8: Fixed T30409.
Sat, May 4, 11:52 AM · Checklist, MITK (v2024.06)
floca committed rMITK4ca154eb4f74: Fixed incorrect info string. (authored by floca).
Fixed incorrect info string.
Sat, May 4, 11:52 AM
floca closed T30408: [Segmentation] Cancelling the "Create label" dialog creates a label/segmentation anyway as Resolved by committing rMITK3670b3a0a123: Fixed T30408.
Sat, May 4, 11:52 AM · MITK (v2024.06), Checklist
floca committed rMITK3670b3a0a123: Fixed T30408 (authored by floca).
Fixed T30408
Sat, May 4, 11:52 AM
floca added a comment to T30410: [Segmentation] 2-d interpolation does not interpolate between multiple slices.

thanks for the research. Are you already working on that ticket?

Sat, May 4, 11:51 AM · MITK, Next Milestone

Fri, May 3

floca updated the task description for T30411: [SEG] Label color is off unitl first refresh when instances are used.
Fri, May 3, 9:21 AM · Checklist, MITK (v2024.06)
floca created T30411: [SEG] Label color is off unitl first refresh when instances are used.
Fri, May 3, 9:21 AM · Checklist, MITK (v2024.06)

Thu, May 2

floca added a revision to T30409: [Segmentation] Clear content in label context menu does not update render windows: Unknown Object (Differential Revision).
Thu, May 2, 9:12 PM · Checklist, MITK (v2024.06)
floca added a revision to T30408: [Segmentation] Cancelling the "Create label" dialog creates a label/segmentation anyway: Unknown Object (Differential Revision).
Thu, May 2, 9:12 PM · MITK (v2024.06), Checklist
floca added a comment to T30410: [Segmentation] 2-d interpolation does not interpolate between multiple slices.

Was this also a problem in the last release?

Thu, May 2, 7:00 PM · MITK, Next Milestone
floca claimed T30409: [Segmentation] Clear content in label context menu does not update render windows.
Thu, May 2, 6:59 PM · Checklist, MITK (v2024.06)
floca claimed T30408: [Segmentation] Cancelling the "Create label" dialog creates a label/segmentation anyway.
Thu, May 2, 6:59 PM · MITK (v2024.06), Checklist
floca edited the content of 2024 Week 18 (Very Early May).
Thu, May 2, 6:38 PM
floca edited the content of 2024 Week 18 (Very Early May).
Thu, May 2, 10:12 AM
floca edited the content of 2024 Week 18 (Very Early May).
Thu, May 2, 10:06 AM
floca edited the content of 2024 Week 18 (Very Early May).
Thu, May 2, 10:05 AM
floca committed rMITK8920b845f478: T30269-Avoid_phantom_drawing_in_editable_contour_tool (authored by floca).
T30269-Avoid_phantom_drawing_in_editable_contour_tool
Thu, May 2, 7:41 AM