Page MenuHomePhabricator

floca (Ralf Omar Floca)
User

Projects (10)

User Details

User Since
Aug 1 2016, 12:10 PM (171 w, 19 h)

Recent Activity

Sat, Nov 9

floca committed rOBSHYPPOPYadb51dafb1a2: Feedback on first draft (authored by floca).
Feedback on first draft
Sat, Nov 9, 11:17 PM

Fri, Oct 25

floca triaged T26712: DICOM StructuredReport export for planar figures - right place for the contribution as Normal priority.
Fri, Oct 25, 11:11 AM · Request for Discussion, d:cipher, MITK

Wed, Oct 23

floca removed a member for d:cipher: greinerm.
Wed, Oct 23, 5:05 PM
floca removed a member for d:cipher: steint.
Wed, Oct 23, 5:05 PM
floca removed a member for d:cipher: hentsch.
Wed, Oct 23, 5:05 PM

Oct 11 2019

floca added a comment to T26712: DICOM StructuredReport export for planar figures - right place for the contribution.

@hentsch : Du kannst es erstmal direkt in PlanaFigure reinpacken, auch wenn es eine DCMTK dependency bedeutet. Wir schauen es uns erstmal an und wollen bis dahin den Aufwand gering halten.

Oct 11 2019, 3:47 PM · Request for Discussion, d:cipher, MITK

Oct 10 2019

floca moved T23742: Implement proof of concept for new segmentation data type from Backlog to MITK Meeting on the Request for Discussion board.
Oct 10 2019, 9:52 PM · MITK
floca moved T26712: DICOM StructuredReport export for planar figures - right place for the contribution from Backlog to MITK Meeting on the Request for Discussion board.
Oct 10 2019, 9:49 PM · Request for Discussion, d:cipher, MITK

Oct 4 2019

floca added a comment to T26463: MatchPoint Registration Manipulator Segmentation Fault.

@isensee

  1. Does it work if you select two normal images (not segmentations)?
  2. Does the seg fault also happens if you use the Registration Evaluator plugin with the image and the segmentation?
  3. Could you provied example data, please?
Oct 4 2019, 3:34 PM · MITK (2018-04-4)

Oct 2 2019

floca closed T26698: Perfusion Curve Description Parameters View- no time series selectable as Resolved.
Oct 2 2019, 5:34 PM · MITK
floca committed rMITKc41303acbd40: Merge branch 'T26698-PerfusionCurveDescription_data_not_selectable' (authored by floca).
Merge branch 'T26698-PerfusionCurveDescription_data_not_selectable'
Oct 2 2019, 5:33 PM
floca added a comment to T26698: Perfusion Curve Description Parameters View- no time series selectable.

Pushed new branch T26698-PerfusionCurveDescription_data_not_selectable.

Oct 2 2019, 5:32 PM · MITK
floca claimed T26698: Perfusion Curve Description Parameters View- no time series selectable.
Oct 2 2019, 5:30 PM · MITK

Sep 27 2019

floca removed a project from T26636: Repo for sourcecode of upload infrastructure for DICOM and non-DICOM files: Request for Discussion.

Discussion result:

  1. Currently we can put into the methods subsection
  2. Next step would be to retrofit the code to be a usefull service. This we have to discuss further
Sep 27 2019, 1:45 PM · d:cipher
floca removed a project from T24710: Check failing dicom data in MITK-Data: Request for Discussion.

We have discussed, how to proceed with corrupted images (see above).

Sep 27 2019, 11:39 AM · MITK

Sep 26 2019

floca created T26712: DICOM StructuredReport export for planar figures - right place for the contribution.
Sep 26 2019, 5:35 PM · Request for Discussion, d:cipher, MITK

Sep 25 2019

floca added a project to T24710: Check failing dicom data in MITK-Data: Request for Discussion.

I looked into all DICOM images that make this problems and are located in the DICOMReader/ directory.

Sep 25 2019, 2:21 PM · MITK

Sep 19 2019

floca added a comment to T26269: [image statistics plugin] refactor to use new node selection widget.

The widget still can't tell if the selected mask fits the selected image, which can cause errors.

May be I missed the point. But it is de facto possible.
You can already define a filter predicate and you can specify a filter/check lambda. Both ways would allow to control if the geometries fit or not. These techiques should be used. If you have any questions, please ask.

Sep 19 2019, 3:46 PM · MITK
floca added a comment to T26694: [image statistics plugin] Add multithreading .

I wouldn't value the node name of statistic nodes that high, as it has questionable importance/value.

  1. It is an open discussion if the statistic nodes should be visible at all in the data managers/storage inspectors. I currently tend to declare them as helpernodes that are not visible any ways.
  2. The name is not needed for the statistics view. For relations we use the relation rules.
  3. Name properties of nodes must not be "stable"; e.g. the name of an image node could change and then it would not feed any more to the image name encoded in the statistic node name.
Sep 19 2019, 3:28 PM · MITK

Sep 17 2019

floca updated subscribers of T26158: Perfomance loss due to intense (time)geometry clonig.
Sep 17 2019, 2:51 PM · MITK

Sep 6 2019

floca added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

Apologies, but I am not sure I understand your first questions, but given your last statement:

No problem. A now fixed typo made it hard to understand.

Sep 6 2019, 9:26 PM · MITK (2018-04-4)

Aug 21 2019

floca added a comment to T25804: Set 'selected' property when using the new selection concept.

OK. But we definetly should talk about it before it is approached.

Aug 21 2019, 7:10 PM · MITK

Aug 20 2019

floca added a project to T26636: Repo for sourcecode of upload infrastructure for DICOM and non-DICOM files: Request for Discussion.
Aug 20 2019, 4:26 PM · d:cipher

Aug 19 2019

floca added a comment to T24766: Last time step of 3D+t data with arbitrary time geometry not selectable by image navigator spinbox.

@kalali: Sharp eyes and good work. As far as I can see this is a proper solution to fix a state I had not covered in my implementation. The handling of invalid timepoints is still okay. As the documentation only guaranties that negative invalids will be 0. For all others there are no garanties and developers should use GetTimeBounds() to check wether they request legal time points or not.

Aug 19 2019, 2:07 PM · MITK

Aug 12 2019

floca added a comment to T25804: Set 'selected' property when using the new selection concept.

This would be necessary if we want to use the render window manager with the mxnmultiwidget and the mentioned task (T25483).

Aug 12 2019, 3:22 PM · MITK

Aug 7 2019

floca added a member for d:cipher: kalali.
Aug 7 2019, 5:38 PM

Aug 2 2019

floca added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

Hm, ok. Then the log output is somehow inconsistent, with what is loaded into the workbench.
@kislinsk How do one enforces the more detailed log? The logging console is capable to show more information then given in the attached log.

Aug 2 2019, 4:40 PM · MITK (2018-04-4)

Aug 1 2019

floca added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

(1) Using the Open File button -> Selected the (autoselect) -> NOT clicking on "apply the same to the remaining files" (file MitkWorkbench_MRIreadeAutoselect.log and looking as in the screenshot attached). The images were loaded individually, and not as a single dicom.

Regarding this workflow: I have another question. How many files did you select in the dialoge? One file of the stack as selection would be sufficient.

Aug 1 2019, 11:40 AM · MITK (2018-04-4)

Jul 31 2019

floca added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

@jsolislemus Thanks for the info. If I understood it correctly also the official installer shows this problem. Could you please do me a favor and check with the official installer if you have the same loading problem, if you do not use the DICOM browser, but instead the normal file open dialog or dragNdrop. With this information we can narrow it down a bit more.
Thanks.

Jul 31 2019, 3:27 PM · MITK (2018-04-4)
floca added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

It would be helpfull to see the log output in order to see if a different reader configuration was choosen and which. Please activate the log window and check the out put of the read process.

Jul 31 2019, 9:55 AM · MITK (2018-04-4)

Jul 30 2019

floca added a comment to T26033: Update ModelFit manual.

@kompan : Thanks! I think we should remove the arxiv version, as the final paper is open access to. Thanks.

Jul 30 2019, 9:21 AM · Restricted Project, MITK

Jul 22 2019

floca added a comment to T26473: Optimize QmitkChartWidget interface.

@steint I think I would have made it slightly different, but this is more a case of tast than hard facts (at least I have no good arguments against it right now ;).
So bottom line: We should go with the changes. Thanks. If we learn that something is missing, nothing stops us to revisit and refactor.

Jul 22 2019, 4:02 PM · MITK

Jul 19 2019

floca updated subscribers of T26033: Update ModelFit manual.

@kompan: Could you be so kind and take care when you have some time left? Thanks!

Jul 19 2019, 12:15 PM · Restricted Project, MITK
floca updated subscribers of T25981: ModelFit: actualize/fix wiki page.

@kompan: Could you be so kind and take care when you have some time left?

Jul 19 2019, 12:14 PM · Restricted Project, Restricted Project, MITK

Jul 11 2019

floca added a comment to T23948: Provide source code of Qt.

@kislinsk Shouldn't we raise priority, if we run otherwise in a licesnsing gray zone?

Jul 11 2019, 5:14 PM · MITK

Jul 9 2019

floca triaged T26473: Optimize QmitkChartWidget interface as Normal priority.
Jul 9 2019, 4:11 PM · MITK
floca created T26472: CMAKE_INSTALL_PREFIX is not set for external projects of extenstions.
Jul 9 2019, 1:14 PM · MITK (2018-04-4)

Jun 17 2019

floca added a project to T26399: Workbench crash on simple tree model update: Request for Discussion.
Jun 17 2019, 12:38 PM · Request for Discussion, MITK

May 29 2019

floca added a comment to T26029: [image statistics plugin] 4D image + 4D segmentation as mask does not work.

I merged it, we only pushed the branch

May 29 2019, 9:31 PM · Restricted Project, MITK

May 24 2019

floca added a comment to T26347: Compile error in ModelFit with Visual Studio 2017 15.9.11 .

It affects every branch that containes the ModelFit module and tries to build it with VS 2017 >=15.9.11

May 24 2019, 5:11 PM · MITK

May 23 2019

floca created T26347: Compile error in ModelFit with Visual Studio 2017 15.9.11 .
May 23 2019, 5:42 PM · MITK

May 22 2019

floca triaged T26345: Number Shift in the resulting Dataframe as Normal priority.
May 22 2019, 9:15 PM · Hyppopy

May 20 2019

floca added a watcher for DICOM: floca.
May 20 2019, 2:40 PM
floca committed rRTTBddc35d1195b4: Also removed "thread" from the BoostBinaries_Config. (authored by floca).
Also removed "thread" from the BoostBinaries_Config.
May 20 2019, 12:08 PM

May 17 2019

floca committed rRTTB1e9344957739: boost::thread & co is removed. (authored by floca).
boost::thread & co is removed.
May 17 2019, 5:16 PM
floca removed a project from T26294: Should we move DICOMPropertyPath helper to Core: Request for Discussion.

Result of the discussion:
At the current state we voted against moving to core.

May 17 2019, 11:24 AM · MITK
floca added a project to T25805: Standardize/Rework DICOM module naming: DICOM.
May 17 2019, 11:18 AM · DICOM, MITK
floca removed a project from T25496: Visualize RTDOSE correctly: Request for Discussion.

Result of the discussion:

May 17 2019, 11:16 AM · MITK

May 11 2019

floca triaged T26326: CI for hyppopy as Normal priority.
May 11 2019, 6:09 PM · Hyppopy
floca committed rOBSHYPPOPY28b51f16932d: Fixed T26325 (authored by floca).
Fixed T26325
May 11 2019, 6:05 PM
floca closed T26325: Add code coverage for hyppopy as Resolved by committing rOBSHYPPOPY28b51f16932d: Fixed T26325.
May 11 2019, 6:05 PM · Hyppopy
floca added a comment to T26325: Add code coverage for hyppopy.

Code coverage can be checked now.
And everything is setup up to use it with codecov.io

May 11 2019, 6:02 PM · Hyppopy
floca renamed T26325: Add code coverage for hyppopy from Add codecov for hyppopy to Add code coverage for hyppopy.
May 11 2019, 5:56 PM · Hyppopy
floca created T26325: Add code coverage for hyppopy.
May 11 2019, 12:16 PM · Hyppopy

May 10 2019

floca added a comment to T26323: [MitkChart] add feature to highlight/colorize point.

I think it would be nice but is no show stopper, because we could, as a work arround, use a chartline that only contains the highlited point(s).

May 10 2019, 1:25 PM · MITK

May 9 2019

floca added a comment to T23159: Make building a module automatically build all dependencies.

Without a fundamental rework of the rttb build mechanics the only way to sooth the problem is to explicitly check if all prerequisits are fullfilled and if not give a meaningfull cmake error message.

May 9 2019, 2:13 PM · Mantis, Restricted Project
floca moved T25967: RegEx cant read special characters from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 9 2019, 1:37 PM · Restricted Project, Restricted Project

May 2 2019

floca committed rMITK105369df51ca: Fixed layout stretch to ensure that the chart always covers the blank space. (authored by floca).
Fixed layout stretch to ensure that the chart always covers the blank space.
May 2 2019, 3:27 PM
floca committed rMPf2a64255250e: Closed T26313 (authored by floca).
Closed T26313
May 2 2019, 2:32 PM
floca committed rMP1ddd054712c2: Changed problematic clang tidy change. (authored by floca).
Changed problematic clang tidy change.
May 2 2019, 2:06 PM
floca added a comment to T23104: Deprecate QmitkPlotWidget.

@hentsch / @kislinsk : Shouldn't we already set QmitkPlotDialog/QmitkPlotWidget/QtHistogram to deprecated then. To give us sooner then later the posibilite to realy remove the code from the codebase. If I see it correctly, that would also gives us the possibility to reomive Qwt as a third party package from MITK. What do you think?

May 2 2019, 1:28 PM · Restricted Project, MITK

Apr 29 2019

floca committed rMITKa0ba9d263118: Merge branch 'T25941-Improve_mapper_view_user_manuel' (authored by floca).
Merge branch 'T25941-Improve_mapper_view_user_manuel'
Apr 29 2019, 10:26 AM
floca committed rMITK4edc1ed9e966: Improved the user manuel of the mapper view (authored by floca).
Improved the user manuel of the mapper view
Apr 29 2019, 10:25 AM
floca added a comment to T25941: Saving Registered Data in new Coordinate frame.

Pushed new branch T25941-Improve_mapper_view_user_manuel.

Apr 29 2019, 10:25 AM · MITK
floca triaged T25941: Saving Registered Data in new Coordinate frame as Normal priority.

@kislinsk Thanks for the hint.

Apr 29 2019, 10:22 AM · MITK
floca updated the task description for T25988: LabelSetImageIO should support time geometries and property serialization.
Apr 29 2019, 9:42 AM · MITK (2018-04-4)

Apr 26 2019

floca added inline comments to rMITK750daa0b6d2b: Fixed crash for single time step segmentations.
Apr 26 2019, 10:31 PM
floca added a comment to T26029: [image statistics plugin] 4D image + 4D segmentation as mask does not work.

I have concerns with the latest commit. See comments there. You can come by and ask if you have any questions.

Apr 26 2019, 1:18 PM · Restricted Project, MITK
floca raised a concern with rMITK750daa0b6d2b: Fixed crash for single time step segmentations.

The fix is not good and has several problems. See comment above. If it is not clear how to handle it properly, just drop by an I can explaine.

Apr 26 2019, 1:18 PM
floca moved T26294: Should we move DICOMPropertyPath helper to Core from Backlog to MITK Meeting on the Request for Discussion board.
Apr 26 2019, 10:29 AM · MITK
floca created T26294: Should we move DICOMPropertyPath helper to Core.
Apr 26 2019, 10:28 AM · MITK
floca moved T25496: Visualize RTDOSE correctly from Backlog to MITK Meeting on the Request for Discussion board.
Apr 26 2019, 9:54 AM · MITK

Apr 24 2019

floca committed rMITK7ef1b6556231: Fixed T26287 (authored by floca).
Fixed T26287
Apr 24 2019, 3:47 PM
floca closed T26287: MRI Perfusion crashes (sometimes) when using signal to concentration conversion as Resolved by committing rMITK7ef1b6556231: Fixed T26287.
Apr 24 2019, 3:47 PM · MITK
floca updated subscribers of T26289: MatchPoint causes warnings during SuperBuild.

@kislinsk Stefan, you said you reworked this pragma for MITK? Does it implie any changes for 3rd party projects?

Apr 24 2019, 1:31 PM · MITK, MatchPoint
floca closed T23808: Add Rule base class for DICOM source imagereferences, a subtask of T23754: DataStorage/Relationship clean up/refactoring, as Resolved.
Apr 24 2019, 1:29 PM · MITK
floca closed T23808: Add Rule base class for DICOM source imagereferences as Resolved.
Apr 24 2019, 1:29 PM · MITK
floca committed rMITKa36581e59950: First implementation of ImageToImageRelationRule (authored by floca).
First implementation of ImageToImageRelationRule
Apr 24 2019, 12:59 PM
floca committed rMITKb7c916ea357f: Fixed review issues D195 (authored by floca).
Fixed review issues D195
Apr 24 2019, 10:31 AM

Apr 18 2019

floca renamed T26288: MRI Perfusion view should only generate concentration images once from MRI Perfusion view should only generate concentration once to MRI Perfusion view should only generate concentration images once.
Apr 18 2019, 7:09 PM · MITK
floca renamed T26288: MRI Perfusion view should only generate concentration images once from MRI Perfusion view should only generare concentration once to MRI Perfusion view should only generate concentration once.
Apr 18 2019, 7:09 PM · MITK
floca triaged T26288: MRI Perfusion view should only generate concentration images once as Normal priority.
Apr 18 2019, 7:09 PM · MITK
floca committed rMITKda7a438dda21: Fixed T26287 (authored by floca).
Fixed T26287
Apr 18 2019, 7:05 PM
floca committed rMITK892967f97029: Starting fix (authored by floca).
Starting fix
Apr 18 2019, 6:51 PM
floca added a comment to T26287: MRI Perfusion crashes (sometimes) when using signal to concentration conversion.

Pushed new branch T26287-Perfusion_crash_when_converting_signal.

Apr 18 2019, 6:50 PM · MITK
floca added a comment to T26287: MRI Perfusion crashes (sometimes) when using signal to concentration conversion.

It seems to beeing correlated with the addition of the generated concentration node to the data storage. If the nodes are not added to the datastorage, I cannot provoke a crash. This is at least concistent to the finding that there is also no proplem if we calculate the concentration beforehand.

Apr 18 2019, 4:56 PM · MITK
floca added a comment to T26287: MRI Perfusion crashes (sometimes) when using signal to concentration conversion.

Narrowed down the point where it crashes.

Apr 18 2019, 4:49 PM · MITK
floca triaged T26287: MRI Perfusion crashes (sometimes) when using signal to concentration conversion as High priority.
Apr 18 2019, 4:40 PM · MITK
floca committed rMITK3367c0e0bbce: Merge branch 'T26265-Connect_error_multinodeselectionwidget' (authored by floca).
Merge branch 'T26265-Connect_error_multinodeselectionwidget'
Apr 18 2019, 4:26 PM
floca closed T26265: Warning in QmitkMultiNodeSelectionWidget as Resolved by committing rMITKbf7b24f189d4: Fixed T26265.
Apr 18 2019, 4:26 PM · MITK
floca committed rMITKbf7b24f189d4: Fixed T26265 (authored by floca).
Fixed T26265
Apr 18 2019, 10:36 AM
floca added a comment to T26265: Warning in QmitkMultiNodeSelectionWidget.

Pushed new branch T26265-Connect_error_multinodeselectionwidget.

Apr 18 2019, 10:35 AM · MITK

Apr 17 2019

floca committed rMP471e4259e51f: Fixed T26284 (authored by floca).
Fixed T26284
Apr 17 2019, 9:07 AM
floca changed the visibility for MatchPoint.
Apr 17 2019, 8:59 AM

Apr 15 2019

floca added a revision to T23808: Add Rule base class for DICOM source imagereferences: Unknown Object (Differential Revision).
Apr 15 2019, 5:45 PM · MITK

Apr 12 2019

floca committed rMITK77159b59c2ac: Added unit tests for SourceImageRelationRule. (authored by floca).
Added unit tests for SourceImageRelationRule.
Apr 12 2019, 6:23 PM
floca committed rMITK43747213b8ec: First implementation of ImageToImageRelationRule (authored by floca).
First implementation of ImageToImageRelationRule
Apr 12 2019, 6:23 PM
floca added a comment to T23808: Add Rule base class for DICOM source imagereferences.

Pushed new branch T23808-Image2ImagePropertyRelation.

Apr 12 2019, 6:23 PM · MITK

Apr 5 2019

floca added a comment to T26219: Crash in rendering mappers when pressing "Close Project" after using a selection widget.

😄

Apr 5 2019, 5:05 PM · MITK
floca added a comment to T26219: Crash in rendering mappers when pressing "Close Project" after using a selection widget.

Can you reproduce your problem now with the fix, that helped me out?

Apr 5 2019, 2:43 PM · MITK