Page MenuHomePhabricator

floca (Ralf Omar Floca)
User

Projects (14)

User Details

User Since
Aug 1 2016, 12:10 PM (205 w, 9 h)

Recent Activity

Today

floca added a comment to T27525: Problems while opening MITK scenes created with 2018.04 release with the current master.

Which configuration did you used to build it? Was it a clean build?

Mon, Jul 6, 4:45 PM · Missing Info, MITK (2020)
floca closed T27483: DICOM import of multi-channel data not working as Resolved.
Mon, Jul 6, 2:44 PM · MITK (2020), Restricted Project, DICOM
floca added a comment to T27525: Problems while opening MITK scenes created with 2018.04 release with the current master.

What about the Segmentations? I was wrong, I tried with the current develop as well (sorry, was used to having the master branch on clone :-D).
I had Hanno also try it and the segmentations are missing for him as well.
I put an installer into the same folder, you can just start it from the bin folder to reproduce.

Mon, Jul 6, 12:02 PM · Missing Info, MITK (2020)
floca committed rMITK9a29ffc60b2e: T27483-DICOM_import_mulit_phase_data (authored by floca).
T27483-DICOM_import_mulit_phase_data
Mon, Jul 6, 10:49 AM
floca committed rMITK6307b8d92e46: Fixed reveiw remarks (authored by floca).
Fixed reveiw remarks
Mon, Jul 6, 10:49 AM
floca committed rMITK2628fb5822b4: Added option feature to PreferenceListReaderOptionsFunctor (authored by floca).
Added option feature to PreferenceListReaderOptionsFunctor
Mon, Jul 6, 10:49 AM
floca committed rMITK0697e83d9b42: Added DICOM reader that allows to manually select which configuration should be… (authored by floca).
Added DICOM reader that allows to manually select which configuration should be…
Mon, Jul 6, 10:49 AM
floca moved T27510: [MITKDoc] Add/revise developers documentation for new statistics back-/frontend from Backlog to Documentation on the MITK (2020) board.
Mon, Jul 6, 9:45 AM · MITK (2020)
floca added a project to T24775: Refactor plugins to use the new node selection widgets: Restricted Project.
Mon, Jul 6, 9:36 AM · Restricted Project, Cleared, MITK (2020)

Fri, Jul 3

floca added a comment to T27525: Problems while opening MITK scenes created with 2018.04 release with the current master.

Cannot reproduce the problem with the current develop. Just checked with all example projects. All worked fine T1 and T2 was visible?!?

Fri, Jul 3, 5:40 PM · Missing Info, MITK (2020)
floca added a project to T27525: Problems while opening MITK scenes created with 2018.04 release with the current master: Missing Info.
Fri, Jul 3, 5:40 PM · Missing Info, MITK (2020)
floca committed rMITKbd7b41ba163a: T27492 Make BooleanOperation time point aware (authored by floca).
T27492 Make BooleanOperation time point aware
Fri, Jul 3, 2:26 PM
floca committed rMITK9be590035c77: Add geometry check for segmentations to have more meaningfull error messages. (authored by floca).
Add geometry check for segmentations to have more meaningfull error messages.
Fri, Jul 3, 2:26 PM
floca committed rMITK4c37bb3ec974: Fixed error in ContourModelSetToImageFilter::GenerateOutputInformation() that… (authored by floca).
Fixed error in ContourModelSetToImageFilter::GenerateOutputInformation() that…
Fri, Jul 3, 2:26 PM
floca committed rMITK90dacf16c124: Make QmitkContourModelToImageWidget time point aware (authored by floca).
Make QmitkContourModelToImageWidget time point aware
Fri, Jul 3, 2:26 PM
floca closed T27492: Rework QmitkBooleanOperationsWidget to be time point aware as Resolved by committing rMITK90dacf16c124: Make QmitkContourModelToImageWidget time point aware.
Fri, Jul 3, 2:26 PM · MITK (2020)
floca committed rMITKaf1a11693d7d: Make BooleanOperation time point aware (authored by floca).
Make BooleanOperation time point aware
Fri, Jul 3, 2:26 PM
floca committed rMITK0cee80b3b4a5: T27347 MatchPoint_evaluator_and_manipulator_auto_select (authored by floca).
T27347 MatchPoint_evaluator_and_manipulator_auto_select
Fri, Jul 3, 12:37 PM
floca committed rMITK39c72527a228: Fixed T27347 (authored by floca).
Fixed T27347
Fri, Jul 3, 12:37 PM
floca closed T27347: [Registration] Evaluator/Mainpulator new autoselect behavior wanted? as Resolved by committing rMITK39c72527a228: Fixed T27347.
Fri, Jul 3, 12:37 PM · Cleared, MITK (2020)
floca committed rMITKbd6eeb2d651f: T27517 Seg_crash_on_minimal_time_bounds_greater_0 (authored by floca).
T27517 Seg_crash_on_minimal_time_bounds_greater_0
Fri, Jul 3, 12:30 PM
floca committed rMITK3b1040c88c33: Fixed T27517 (authored by floca).
Fixed T27517
Fri, Jul 3, 12:30 PM
floca closed T27517: [Segmentation] Seg tools crashes when segmentation starts for images with minimal time bounds > 0 as Resolved by committing rMITK3b1040c88c33: Fixed T27517.
Fri, Jul 3, 12:30 PM · MITK (2020)
floca triaged T27489: Deprecate and correct QmitkSliceWidget? as Low priority.
Fri, Jul 3, 11:12 AM · Request for Discussion
floca removed a project from T27489: Deprecate and correct QmitkSliceWidget?: MITK (2020).

@nolden: Do you have a clue?

Fri, Jul 3, 11:10 AM · Request for Discussion

Thu, Jul 2

floca moved T27489: Deprecate and correct QmitkSliceWidget? from Backlog to MITK Meeting on the Request for Discussion board.
Thu, Jul 2, 8:59 PM · Request for Discussion
floca removed a project from T27483: DICOM import of multi-channel data not working: Request for Discussion.
Thu, Jul 2, 8:59 PM · MITK (2020), Restricted Project, DICOM
floca updated the task description for T27506: Extend checklists for segmentation view.
Thu, Jul 2, 8:53 PM · Restricted Project, Cleared, MITK (2020)
floca added a revision to T27517: [Segmentation] Seg tools crashes when segmentation starts for images with minimal time bounds > 0: Unknown Object (Differential Revision).
Thu, Jul 2, 8:33 PM · MITK (2020)
floca triaged T27517: [Segmentation] Seg tools crashes when segmentation starts for images with minimal time bounds > 0 as High priority.
Thu, Jul 2, 8:30 PM · MITK (2020)
floca triaged T27516: [Segmentation] ContourModelSetToImageFilter always use first time step of contour model as Normal priority.
Thu, Jul 2, 8:16 PM · MITK
floca added a comment to T27493: Rework QmitkContourModelToImageWidget to be time point aware.

see comment in D338

Thu, Jul 2, 2:28 PM · MITK (2020)
floca committed rMITK6ca565676bec: T27477 Improved_node_selection_preference_page_default_settings (authored by floca).
T27477 Improved_node_selection_preference_page_default_settings
Thu, Jul 2, 2:17 PM
floca committed rMITKf85b24c88ee3: Fixed review remark. (authored by floca).
Fixed review remark.
Thu, Jul 2, 2:17 PM
floca committed rMITKb13220899013: Fixed review remark (authored by floca).
Fixed review remark
Thu, Jul 2, 2:17 PM
floca committed rMITKc5502abe64fc: Added better default behavior if no preferences are set so far. (authored by floca).
Added better default behavior if no preferences are set so far.
Thu, Jul 2, 2:17 PM
floca closed T27477: [Segmentation] Selection concept displays 'Favorite node list' by default leading to user confusion as Resolved by committing rMITKc5502abe64fc: Added better default behavior if no preferences are set so far..
Thu, Jul 2, 2:17 PM · Cleared, MITK (2020)

Wed, Jul 1

floca added a project to T27476: [Segmentation] Crash if new segmentation is created with timestep different than 0: Restricted Project.

As D329 is now landed. I think this is an low hanging fruit to check if the problem still exists ;)

Wed, Jul 1, 4:33 PM · MITK (2020)
floca claimed T27483: DICOM import of multi-channel data not working.
Wed, Jul 1, 10:36 AM · MITK (2020), Restricted Project, DICOM

Tue, Jun 30

floca closed T27464: [CEST] Generic CEST data reader as Resolved.
Tue, Jun 30, 4:47 PM · Restricted Project, MITK (2020)
floca committed rMITK064ad45c08bf: T27464 CEST generic readers. (authored by floca).
T27464 CEST generic readers.
Tue, Jun 30, 4:42 PM
floca committed rMITKd70a70ab66bb: Fixed review remarks (authored by floca).
Fixed review remarks
Tue, Jun 30, 4:42 PM
floca committed rMITKef9a2fd894de: Fixed review remarks (authored by floca).
Fixed review remarks
Tue, Jun 30, 4:42 PM
floca committed rMITKbe619309efad: Fixed gcc/clang compile errors (authored by floca).
Fixed gcc/clang compile errors
Tue, Jun 30, 4:42 PM
floca committed rMITK30061d78b31e: Fixed review remarks for CEST Generic Reader from user (authored by floca).
Fixed review remarks for CEST Generic Reader from user
Tue, Jun 30, 4:42 PM
floca committed rMITKb7604476cb5e: Fixed crash in CESTIOMimeType if a directory is selected. (authored by floca).
Fixed crash in CESTIOMimeType if a directory is selected.
Tue, Jun 30, 4:42 PM
floca committed rMITKf97d6ae11c99: Removed the usage of TOTALSCANTIME as it was not really needed (authored by floca).
Removed the usage of TOTALSCANTIME as it was not really needed
Tue, Jun 30, 4:42 PM
floca committed rMITK11bcbe87a492: Added consitency check (time steps count must equal offset/trec count) to… (authored by floca).
Added consitency check (time steps count must equal offset/trec count) to…
Tue, Jun 30, 4:42 PM
floca committed rMITK64129c827290: Introduced public methods to extract CEST offsets and CESt T1 times. (authored by floca).
Introduced public methods to extract CEST offsets and CESt T1 times.
Tue, Jun 30, 4:42 PM
floca committed rMITKaa02f2bf04cb: Introduce BaseDicomMimeType and CEST DICOM manual mime types (authored by floca).
Introduce BaseDicomMimeType and CEST DICOM manual mime types
Tue, Jun 30, 4:42 PM
floca committed rMITKf766f6333b3b: Improved QmitkFileReaderOptionsDialog to only (authored by floca).
Improved QmitkFileReaderOptionsDialog to only
Tue, Jun 30, 4:42 PM
floca committed rMITK6fc5cddf9c71: First draft of the generic readers. (authored by floca).
First draft of the generic readers.
Tue, Jun 30, 4:42 PM
floca added a revision to T27347: [Registration] Evaluator/Mainpulator new autoselect behavior wanted? : Unknown Object (Differential Revision).
Tue, Jun 30, 4:39 PM · Cleared, MITK (2020)
floca claimed T27347: [Registration] Evaluator/Mainpulator new autoselect behavior wanted? .
Tue, Jun 30, 4:38 PM · Cleared, MITK (2020)
floca closed T27201: [Registration] Executor layout in mask box is broken as Resolved.

Seems to be fixed already in the current develop branch

Tue, Jun 30, 12:05 PM · Restricted Project, Cleared, MITK (2020)
floca claimed T27493: Rework QmitkContourModelToImageWidget to be time point aware.

Covered by T27492 by accident ;)

Tue, Jun 30, 11:54 AM · MITK (2020)
floca added a revision to T27492: Rework QmitkBooleanOperationsWidget to be time point aware: Unknown Object (Differential Revision).
Tue, Jun 30, 11:50 AM · MITK (2020)
floca committed rMITKf7333b92e781: T27497-Statistics_view_intensity_profile_slider_does_not_work (authored by floca).
T27497-Statistics_view_intensity_profile_slider_does_not_work
Tue, Jun 30, 10:09 AM
floca committed rMITKf61fcb23bc3c: Fixed T27497 (authored by floca).
Fixed T27497
Tue, Jun 30, 10:09 AM
floca closed T27497: Intensity profile of dynamic image only works for first timestep as Resolved by committing rMITKf61fcb23bc3c: Fixed T27497.
Tue, Jun 30, 10:09 AM · MITK (2020)
floca committed rMITKd68e055ff3bd: T27491 Corrected time point awareness of MatchPoint views (authored by floca).
T27491 Corrected time point awareness of MatchPoint views
Tue, Jun 30, 10:08 AM
floca committed rMITKa4796ab1632c: Corrected time point awareness of MatchPoint views (authored by floca).
Corrected time point awareness of MatchPoint views
Tue, Jun 30, 10:08 AM
floca closed T27491: Rework MatchPointRegistrationManipulator & MatchPointRegistrationEvaluator to be time point aware as Resolved by committing rMITKa4796ab1632c: Corrected time point awareness of MatchPoint views.
Tue, Jun 30, 10:08 AM · MITK (2020)

Mon, Jun 29

floca claimed T27492: Rework QmitkBooleanOperationsWidget to be time point aware.
Mon, Jun 29, 7:03 PM · MITK (2020)
floca added a revision to T27491: Rework MatchPointRegistrationManipulator & MatchPointRegistrationEvaluator to be time point aware: Restricted Differential Revision.
Mon, Jun 29, 7:02 PM · MITK (2020)
floca claimed T27491: Rework MatchPointRegistrationManipulator & MatchPointRegistrationEvaluator to be time point aware.
Mon, Jun 29, 6:55 PM · MITK (2020)
floca added a comment to T27486: Prepare changelog and migration guide for upcoming master merge.

New Image Statistics (preview)

The image statistics (modules ImageStatistics and ImageStatisticsUI as well as the QmitkImageStatisticsView provided by the plugin org.mitk.gui.qt.measurementtoolbox) have been heavily refactored on the backend and the frontend side. The rework is not yet finished as the current state just ensures that we have no regression but does only to a little extend tap into the potential of the new infrastructure.
The following paragraphs briefly summarize what’s new.

Mon, Jun 29, 5:28 PM · MITK (2020)
floca triaged T27510: [MITKDoc] Add/revise developers documentation for new statistics back-/frontend as Normal priority.
Mon, Jun 29, 4:50 PM · MITK (2020)
floca edited projects for T24771: [MITKDoc] Add a concept documentation for the data storage inspectors and the overhaul of the selection concept, added: MITK (2020); removed MITK.
Mon, Jun 29, 4:47 PM · MITK (2020)
floca committed rMITKdb7545f1ff98: Fixed broking unit test (authored by floca).
Fixed broking unit test
Mon, Jun 29, 3:28 PM
floca committed rMITKaa6caa16db68: Fixed broking unit test (authored by floca).
Fixed broking unit test
Mon, Jun 29, 3:28 PM
floca closed T27490: Correct handling of time points selected by SliceNavigator, a subtask of T27476: [Segmentation] Crash if new segmentation is created with timestep different than 0, as Resolved.
Mon, Jun 29, 2:08 PM · MITK (2020)
floca closed T27490: Correct handling of time points selected by SliceNavigator as Resolved.
Mon, Jun 29, 2:08 PM · Noteworthy, MITK (2020)
floca closed T27490: Correct handling of time points selected by SliceNavigator, a subtask of T27492: Rework QmitkBooleanOperationsWidget to be time point aware, as Resolved.
Mon, Jun 29, 2:08 PM · MITK (2020)
floca closed T27490: Correct handling of time points selected by SliceNavigator, a subtask of T27491: Rework MatchPointRegistrationManipulator & MatchPointRegistrationEvaluator to be time point aware, as Resolved.
Mon, Jun 29, 2:08 PM · MITK (2020)
floca closed T27490: Correct handling of time points selected by SliceNavigator, a subtask of T26974: [Segmentation] Region Growing 3D with 4D dataset not working, as Resolved.
Mon, Jun 29, 2:08 PM · MITK (2020)
floca committed rMITK9827e87b0805: T27490 - Correct handling of timepoints selected by SliceNavigator (authored by floca).
T27490 - Correct handling of timepoints selected by SliceNavigator
Mon, Jun 29, 2:04 PM
floca committed rMITK795547ab54bc: Fixed review remarks (authored by floca).
Fixed review remarks
Mon, Jun 29, 2:04 PM
floca committed rMITKaa706123b8cd: (ML)Segmentation views no reinit views according to the reference image (authored by floca).
(ML)Segmentation views no reinit views according to the reference image
Mon, Jun 29, 2:04 PM
floca committed rMITKd8b575f7d1e9: Refactored QmitkImageCropperView to be time point aware. (authored by floca).
Refactored QmitkImageCropperView to be time point aware.
Mon, Jun 29, 2:04 PM
floca committed rMITK70d71578a30c: Fixed review remarks. (authored by floca).
Fixed review remarks.
Mon, Jun 29, 2:04 PM
floca committed rMITKae14494f50df: Reworked QmitkDicomInspectorView for time point awareness (authored by floca).
Reworked QmitkDicomInspectorView for time point awareness
Mon, Jun 29, 2:04 PM
floca committed rMITK0e300ecea187: Refactored CESTStatisticView to be time point aware. (authored by floca).
Refactored CESTStatisticView to be time point aware.
Mon, Jun 29, 2:04 PM
floca committed rMITK09e4ea88b587: Refactored AutoSegmentationTools to be time point aware (authored by floca).
Refactored AutoSegmentationTools to be time point aware
Mon, Jun 29, 2:04 PM
floca committed rMITKa5f414eb66e6: Refactored QmitkSlicesInterpolater to be time point aware. (authored by floca).
Refactored QmitkSlicesInterpolater to be time point aware.
Mon, Jun 29, 2:04 PM
floca committed rMITKe7dd2b342ea1: Add time point awareness to QmitkSliceBasedInterpolatorWidget (authored by floca).
Add time point awareness to QmitkSliceBasedInterpolatorWidget
Mon, Jun 29, 2:04 PM
floca committed rMITK735b36be69b3: Removed unused/incorrect ui file. (authored by floca).
Removed unused/incorrect ui file.
Mon, Jun 29, 2:04 PM
floca committed rMITK6b246a24bc55: Removed dead code (authored by floca).
Removed dead code
Mon, Jun 29, 2:03 PM
floca committed rMITK8f6380912e9d: Added convinience method GetSelectedTimePoint to IRenderWindowPart (authored by floca).
Added convinience method GetSelectedTimePoint to IRenderWindowPart
Mon, Jun 29, 2:03 PM
floca committed rMITK75e424bf5121: Added convienience methods to SliceNavigationController (authored by floca).
Added convienience methods to SliceNavigationController
Mon, Jun 29, 2:03 PM
floca added a comment to T27509: [Segmentation] How to handle 3D and 4D Segmentations on 4D images.

I would propose the following policy:

  1. All tools per default work only on the respective time step of the reference data and the segmentation, that are indicated by the currently selected time point (SliceNavigator). So this is general and independent from the fact if it is a 3D or a 4D segmentation. This is the same behavior like the interactive tools and does not break user expectations.
  2. It is up to the specific tool (must be discussed there) if for 4D reference images others then the current time step of the reference data step should be used. Per se, I would say no.
  3. It is up to the specific (3D) tool to allow the altering of more then the current segmentation time step (if the segmentation is 4D). If one wants such a feature I would add e.g. a check box to the tool like "confirm for all time steps".
Mon, Jun 29, 1:48 PM · Request for Discussion, MITK
floca added a comment to T27486: Prepare changelog and migration guide for upcoming master merge.

I think I moved and aligned everything into a draft of the official changelog (click on View Draft Version): 2020 Week 25 (Late June).

@floca The only thing missing is statistics as it seems that the text above is not yet complete.

Mon, Jun 29, 12:47 PM · MITK (2020)

Sat, Jun 27

floca added a comment to T27497: Intensity profile of dynamic image only works for first timestep.

Histogram has a simelar problem, but to fix that the Histogramwidget also needs a rework). Such a rework should be done in conjunction with the rework of T27284

Sat, Jun 27, 2:49 PM · MITK (2020)
floca updated the task description for T27284: ImageStatisticView Histogram is only supported with one image and <=1 ROI.
Sat, Jun 27, 2:45 PM · MITK (2020)
floca claimed T27497: Intensity profile of dynamic image only works for first timestep.
Sat, Jun 27, 2:41 PM · MITK (2020)
floca added a revision to T27497: Intensity profile of dynamic image only works for first timestep: Unknown Object (Differential Revision).
Sat, Jun 27, 2:41 PM · MITK (2020)
floca triaged T27506: Extend checklists for segmentation view as High priority.
Sat, Jun 27, 1:31 PM · Restricted Project, Cleared, MITK (2020)
floca moved T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation from Backlog to Segmentation on the MITK (2020) board.
Sat, Jun 27, 1:30 PM · Restricted Project, Cleared, MITK (2020)
floca triaged T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation as High priority.
Sat, Jun 27, 1:30 PM · Restricted Project, Cleared, MITK (2020)
floca moved T27506: Extend checklists for segmentation view from Backlog to Segmentation on the MITK (2020) board.
Sat, Jun 27, 1:25 PM · Restricted Project, Cleared, MITK (2020)