Page MenuHomePhabricator

floca (Ralf Omar Floca)
User

Projects (13)

User Details

User Since
Aug 1 2016, 12:10 PM (191 w, 5 d)

Recent Activity

Thu, Apr 2

floca placed T19477: Select which dicom tags are used to create a nodes name up for grabs.
Thu, Apr 2, 9:26 PM · Request for Discussion, Bugzilla, MITK
floca closed T27268: [Image Statistics] Moving/modifying a planar figure that is shown in statistics keeps adding graphs as Resolved.
Thu, Apr 2, 9:24 PM · MITK (2020)
floca committed rMITK3e3f1a6e8437: T27268 fixed (authored by floca).
T27268 fixed
Thu, Apr 2, 9:23 PM
floca committed rMITK6913eee12e6f: fixed review remarks (authored by floca).
fixed review remarks
Thu, Apr 2, 9:23 PM
floca closed T27229: [ImageStatistic] Copy to clipboard from statistic table should be directly usabel in Excel as Resolved.
Thu, Apr 2, 5:17 PM · MITK (2020), Unknown Object (Project)
floca committed rMITK5728c2c3af66: Added locale awareness for string conversion (authored by floca).
Added locale awareness for string conversion
Thu, Apr 2, 5:15 PM
floca committed rMITKa388260014ac: Merge branch 'master' into T27229-Add_locale_awareness (authored by floca).
Merge branch 'master' into T27229-Add_locale_awareness
Thu, Apr 2, 5:15 PM
floca closed T25988: LabelSetImageIO should support time geometries and property serialization, a subtask of T25192: Enable DICOM SEG conversion for nrrd segmentations, as Resolved.
Thu, Apr 2, 4:54 PM · MITK (2020), MICO (Demo MICCAI 2018)
floca closed T25988: LabelSetImageIO should support time geometries and property serialization as Resolved.

@nolden @gaoh @thomass First step to the long road to DICOM Seg. Now at least multi lable images stored as nrrd contain all (dicom) properties needed to write DICOM Seg. Till now only projects files have everything to allow the reconstrution of a state to write DICOM Seg.

Thu, Apr 2, 4:54 PM · MITK (2020)
floca committed rMITK0a429f8768fb: Added time geometry and property support for multi label (authored by floca).
Added time geometry and property support for multi label
Thu, Apr 2, 4:50 PM
floca committed rMITK36ce10a5c6c0: Fixed review remarks (authored by floca).
Fixed review remarks
Thu, Apr 2, 4:50 PM

Wed, Apr 1

floca committed rMITK07c45cb1fb6b: Fixed broken test due to T27205 (authored by floca).
Fixed broken test due to T27205
Wed, Apr 1, 11:18 PM
floca closed T27272: Double-clicking an entry in the new selection widget should select it and close the selection dialog as Resolved.
Wed, Apr 1, 11:16 PM · Noteworthy, MITK (2020)
floca committed rMITK1557198d13fc: Added double click feature to directly accept a selection. (authored by floca).
Added double click feature to directly accept a selection.
Wed, Apr 1, 11:15 PM
floca committed rMITK6e31f6067456: fixed gcc error (authored by floca).
fixed gcc error
Wed, Apr 1, 11:11 PM
floca committed rMITKc697a0ca91cd: Added double click feature to directly accept a selection. (authored by floca).
Added double click feature to directly accept a selection.
Wed, Apr 1, 11:07 PM
floca added a comment to T27272: Double-clicking an entry in the new selection widget should select it and close the selection dialog.

Pushed new branch T27272-NodeSelectionDialoge_with_double_click.

Wed, Apr 1, 11:07 PM · Noteworthy, MITK (2020)
floca added a revision to T27272: Double-clicking an entry in the new selection widget should select it and close the selection dialog: Unknown Object (Differential Revision).
Wed, Apr 1, 11:06 PM · Noteworthy, MITK (2020)
floca claimed T27272: Double-clicking an entry in the new selection widget should select it and close the selection dialog.
Wed, Apr 1, 11:02 PM · Noteworthy, MITK (2020)
floca committed rMITK1060d842b708: Removed annoying flickering of histogram chart when statistics are updated. (authored by floca).
Removed annoying flickering of histogram chart when statistics are updated.
Wed, Apr 1, 10:45 PM
floca committed rMITKa0711dd51940: T27268 fixed (authored by floca).
T27268 fixed
Wed, Apr 1, 10:14 PM
floca added a comment to T27268: [Image Statistics] Moving/modifying a planar figure that is shown in statistics keeps adding graphs.

Pushed new branch T27268-Statistic_view_adds_graphs_instead_of_refreshing.

Wed, Apr 1, 10:13 PM · MITK (2020)
floca added a revision to T27268: [Image Statistics] Moving/modifying a planar figure that is shown in statistics keeps adding graphs: Unknown Object (Differential Revision).
Wed, Apr 1, 10:13 PM · MITK (2020)
floca triaged T27285: QmitkChart widget should support ID or allow control over labels as Normal priority.
Wed, Apr 1, 10:04 PM · MITK (2020)
floca triaged T27284: ImageStatisticView Histogram is only supported with one image and <=1 ROI as Normal priority.
Wed, Apr 1, 9:52 PM · MITK (2020)
floca committed rMITKea0a7545e212: Fixed broken test due to T27205 (authored by floca).
Fixed broken test due to T27205
Wed, Apr 1, 9:11 PM
floca added a comment to T27205: Refactor statistic generation by introduce generators drafted for RT statistics.

Pushed new branch T27205-TestFix.

Wed, Apr 1, 9:11 PM · Unknown Object (Project), MITK
floca added a revision to T27205: Refactor statistic generation by introduce generators drafted for RT statistics: Unknown Object (Differential Revision).
Wed, Apr 1, 9:10 PM · Unknown Object (Project), MITK
floca committed rMITKae189248e49f: Added time geometry and property support for multi label (authored by floca).
Added time geometry and property support for multi label
Wed, Apr 1, 6:00 PM
floca added a comment to T25988: LabelSetImageIO should support time geometries and property serialization.

Pushed new branch T25988-LabelSetImageIO_support_time_geometries_and_property_serialization.

Wed, Apr 1, 6:00 PM · MITK (2020)
floca added a revision to T25988: LabelSetImageIO should support time geometries and property serialization: Unknown Object (Differential Revision).
Wed, Apr 1, 5:59 PM · MITK (2020)

Tue, Mar 31

floca added a parent task for T27271: [Image Statistics] Double clicking to isolate one graph only works on already enabled graphs: Unknown Object (Maniphest Task).
Tue, Mar 31, 9:44 PM · MITK (2020)
floca added a parent task for T27268: [Image Statistics] Moving/modifying a planar figure that is shown in statistics keeps adding graphs: Unknown Object (Maniphest Task).
Tue, Mar 31, 9:11 PM · MITK (2020)
floca added a parent task for T27267: [Image Statistics] Removal of image and planar figure from data storage does not affect statistics widget: Unknown Object (Maniphest Task).
Tue, Mar 31, 9:11 PM · MITK (2020)
floca added a parent task for T27229: [ImageStatistic] Copy to clipboard from statistic table should be directly usabel in Excel: Unknown Object (Maniphest Task).
Tue, Mar 31, 9:10 PM · MITK (2020), Unknown Object (Project)
floca closed T27205: Refactor statistic generation by introduce generators drafted for RT statistics as Resolved.
Tue, Mar 31, 9:08 PM · Unknown Object (Project), MITK
floca committed rMITKb7f3afaa22c5: Refactoring if Qmitk statistics classes (authored by floca).
Refactoring if Qmitk statistics classes
Tue, Mar 31, 9:06 PM
floca committed rMITKac639fc20cae: Fixed review remarks. (authored by floca).
Fixed review remarks.
Tue, Mar 31, 9:06 PM
floca updated subscribers of T25832: Migrate ModelFit inspector plugin to MitkChart.
Tue, Mar 31, 12:09 PM · Unknown Object (Project), Restricted Project, MITK

Mon, Mar 30

floca committed rMITKcdddd7f1427d: Fixed review remarks (authored by floca).
Fixed review remarks
Mon, Mar 30, 6:01 PM
floca committed rMITK89a3b29e75c4: Fixed review remarks (authored by floca).
Fixed review remarks
Mon, Mar 30, 4:21 PM

Sat, Mar 28

floca committed rMITK84f89f14d47c: Fixed mac os compile error (authored by floca).
Fixed mac os compile error
Sat, Mar 28, 5:35 PM
floca committed rMITKe93eabbe0dcf: fixed gcc compile errors (authored by floca).
fixed gcc compile errors
Sat, Mar 28, 5:14 PM
floca edited projects for T27229: [ImageStatistic] Copy to clipboard from statistic table should be directly usabel in Excel, added: MITK (2020); removed MITK.
Sat, Mar 28, 11:23 AM · MITK (2020), Unknown Object (Project)
floca reopened T27229: [ImageStatistic] Copy to clipboard from statistic table should be directly usabel in Excel as "Open".

Mixed things up my commits if this branch are not yet in the master. Must still be reviewed and merged.

Sat, Mar 28, 11:23 AM · MITK (2020), Unknown Object (Project)
floca committed rMITKa48eba105e97: Fixed gcc compile errors. (authored by floca).
Fixed gcc compile errors.
Sat, Mar 28, 11:08 AM
floca committed rMITK252232af307e: Improved documentation (authored by floca).
Improved documentation
Sat, Mar 28, 11:08 AM
floca added a comment to T27266: [Image Statistics] Planar figures cannot be read or written until one of the quantification views is open.

So we have to make an auto load module for the planar figure IO. Right?

Sat, Mar 28, 10:57 AM · MITK (2020)
floca claimed T27267: [Image Statistics] Removal of image and planar figure from data storage does not affect statistics widget.

In context of my work for T27205 I have already addressed it. I have it stashed becaus I didn't want to get the review for T27205 even bigger. If T27205 is reviewed and merged, I will pop the fixes from stash and add them.

Sat, Mar 28, 10:56 AM · MITK (2020)
floca claimed T27268: [Image Statistics] Moving/modifying a planar figure that is shown in statistics keeps adding graphs.

I have allready the fix stashed while working on the T27205.

Sat, Mar 28, 10:50 AM · MITK (2020)
floca raised the priority of T27272: Double-clicking an entry in the new selection widget should select it and close the selection dialog from Wishlist to High.

Great point! I would even bump up priority as UX is important. It is not to hard to realize and it is realy faster then Click+OK-Btn or Click+Return.

Sat, Mar 28, 10:42 AM · Noteworthy, MITK (2020)

Fri, Mar 27

floca added a revision to T27205: Refactor statistic generation by introduce generators drafted for RT statistics: Unknown Object (Differential Revision).
Fri, Mar 27, 8:45 PM · Unknown Object (Project), MITK
floca committed rMITKb1098f7f7b24: Optimized QmitkDataGeneratorBase logic to reduce unnecessary checking (authored by floca).
Optimized QmitkDataGeneratorBase logic to reduce unnecessary checking
Fri, Mar 27, 2:02 PM
floca committed rMITK2b36f93b1a98: Fixed wrong usage of mitk::WeakPointer in QmitkDataStarageTreeModel (authored by floca).
Fixed wrong usage of mitk::WeakPointer in QmitkDataStarageTreeModel
Fri, Mar 27, 2:02 PM
floca added a subtask for T27258: [statistics] Deprecate QmitkImageStatisticsGeneratorJob: T27134: [Image statistics] Refactor Calculation Job and Calculation Runnable.
Fri, Mar 27, 11:50 AM · MITK (2020)
floca added a parent task for T27134: [Image statistics] Refactor Calculation Job and Calculation Runnable: T27258: [statistics] Deprecate QmitkImageStatisticsGeneratorJob.
Fri, Mar 27, 11:50 AM · MITK
floca removed a project from T27258: [statistics] Deprecate QmitkImageStatisticsGeneratorJob: Request for Discussion.

OK. And we remove it directly :)

Fri, Mar 27, 11:48 AM · MITK (2020)
floca moved T27258: [statistics] Deprecate QmitkImageStatisticsGeneratorJob from Backlog to MITK Meeting on the Request for Discussion board.
Fri, Mar 27, 11:37 AM · MITK (2020)
floca edited projects for T26953: DICOM SEG - Cannot rewrite segmentations as DICOM SEG, added: MITK (2020); removed MITK.
Fri, Mar 27, 11:34 AM · MITK (2020)
floca added a subtask for T24402: Improve clang-format support: T27190: Clang format style for * and & at variables.
Fri, Mar 27, 11:09 AM · MITK
floca added a parent task for T27190: Clang format style for * and & at variables: T24402: Improve clang-format support.
Fri, Mar 27, 11:09 AM · Request for Discussion, MITK

Thu, Mar 26

floca triaged T27258: [statistics] Deprecate QmitkImageStatisticsGeneratorJob as Normal priority.
Thu, Mar 26, 10:42 PM · MITK (2020)
floca edited projects for T26098: Histogram Statistics need to be tested, added: MITK (2020); removed MITK.
Thu, Mar 26, 10:38 PM · MITK (2020), Restricted Project
floca closed T26102: Display only available statistics in QmitkImageStatisticsWidget as Wontfix.

The refactoring T27205 solves it in different ways. Pending calculations are indicated and will be updated automatically.

Thu, Mar 26, 10:32 PM · MITK
floca closed T23972: Image statistics view does not work as Resolved.

Should not be a problem any mor in the new plugin.

Thu, Mar 26, 10:31 PM · Restricted Project, MITK
floca closed T27229: [ImageStatistic] Copy to clipboard from statistic table should be directly usabel in Excel as Resolved.
Thu, Mar 26, 10:17 PM · MITK (2020), Restricted Project
floca committed rMITK646b9affea58: Introduced "IgnoreZero" and "HistogramNBin" awarness to… (authored by floca).
Introduced "IgnoreZero" and "HistogramNBin" awarness to…
Thu, Mar 26, 9:35 PM
floca committed rMITK3be7302bc554: Integrate new generator and model features into QmitkImageStatisticsView (authored by floca).
Integrate new generator and model features into QmitkImageStatisticsView
Thu, Mar 26, 9:35 PM
floca committed rMITKcaeb257cafa0: Added unit test for QmitkImageStatisticsDataGenerator (authored by floca).
Added unit test for QmitkImageStatisticsDataGenerator
Thu, Mar 26, 9:35 PM
floca committed rMITKdf09f051113b: Started unit test for QmitkImageStatisticsDataGenerator (authored by floca).
Started unit test for QmitkImageStatisticsDataGenerator
Thu, Mar 26, 9:35 PM
floca committed rMITKf2ebd2b07dae: First complete refactoring draft for statistics data generator (authored by floca).
First complete refactoring draft for statistics data generator
Thu, Mar 26, 9:35 PM

Wed, Mar 18

floca moved T26843: Rethink/CleanUp PropertyRelation connection levels and RII properties used in SourceImageRelationRule from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Mar 18, 10:39 AM · MITK (2020), Restricted Project
floca edited projects for T26843: Rethink/CleanUp PropertyRelation connection levels and RII properties used in SourceImageRelationRule, added: MITK (2020); removed MITK.
Wed, Mar 18, 10:39 AM · MITK (2020), Restricted Project
floca placed T26843: Rethink/CleanUp PropertyRelation connection levels and RII properties used in SourceImageRelationRule up for grabs.
Wed, Mar 18, 10:38 AM · MITK (2020), Restricted Project
floca moved T27205: Refactor statistic generation by introduce generators drafted for RT statistics from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Mar 18, 10:37 AM · Restricted Project, MITK
floca added a project to T27205: Refactor statistic generation by introduce generators drafted for RT statistics: Restricted Project.
Wed, Mar 18, 10:37 AM · Restricted Project, MITK
floca moved T27229: [ImageStatistic] Copy to clipboard from statistic table should be directly usabel in Excel from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Mar 18, 10:36 AM · MITK (2020), Restricted Project
floca added a project to T27229: [ImageStatistic] Copy to clipboard from statistic table should be directly usabel in Excel: Restricted Project.

Das war von mir, weil ich es ja dann übernehmen wollte ;)

Wed, Mar 18, 10:36 AM · MITK (2020), Restricted Project

Tue, Mar 17

floca committed rMITKf7c2d0761ab1: Interim commit (home office transfer) (authored by floca).
Interim commit (home office transfer)
Tue, Mar 17, 6:09 PM
floca committed rMITK8c28b91b05ce: WIP transfer for home office (authored by floca).
WIP transfer for home office
Tue, Mar 17, 3:18 PM
floca added a comment to T27205: Refactor statistic generation by introduce generators drafted for RT statistics.

Pushed new branch T27205-Refactor_statistic_generation.

Tue, Mar 17, 3:18 PM · Restricted Project, MITK

Mon, Mar 16

floca committed rMITK5683b5cfa036: fixed gcc errors (authored by floca).
fixed gcc errors
Mon, Mar 16, 5:25 PM
floca committed rMITKb5b4fabf24ad: Added locale awareness for string conversion (authored by floca).
Added locale awareness for string conversion
Mon, Mar 16, 4:57 PM
floca added a comment to T27229: [ImageStatistic] Copy to clipboard from statistic table should be directly usabel in Excel.

Pushed new branch T27229-Add_locale_awareness.

Mon, Mar 16, 4:56 PM · MITK (2020), Restricted Project
floca added a revision to T27229: [ImageStatistic] Copy to clipboard from statistic table should be directly usabel in Excel: Unknown Object (Differential Revision).
Mon, Mar 16, 4:55 PM · MITK (2020), Restricted Project
floca edited projects for T25192: Enable DICOM SEG conversion for nrrd segmentations, added: MITK (2020); removed MITK.
Mon, Mar 16, 4:14 PM · MITK (2020), MICO (Demo MICCAI 2018)
floca edited projects for T26951: DICOM SEG - DicomSegIO should just use properties of the passed segmentation object, added: MITK (2020); removed MITK.
Mon, Mar 16, 4:13 PM · MITK (2020)
floca edited projects for T26950: Add rule class for DICOM Seg relations to source image, added: MITK (2020); removed MITK.
Mon, Mar 16, 4:13 PM · MITK (2020)
floca edited projects for T26952: Implement helper to correct (DICOM conformal) set the properties of a segmentation (DICOM SEG), added: MITK (2020); removed MITK.
Mon, Mar 16, 4:13 PM · MITK (2020)

Fri, Mar 13

floca triaged T27231: In Matchpoint Algorithm Control: It is necessary to select the algorithm twice as Low priority.

This explicit locking of an algorithm is necessary as long the algorithm selections are propagated globally by the browser view to all registration plugins.

Fri, Mar 13, 3:00 PM · MITK
floca claimed T27229: [ImageStatistic] Copy to clipboard from statistic table should be directly usabel in Excel.

How did you encounter the different decimal separator?

By copying the content of stats table and histogram to excel. Reason ist that histogram uses QString::arg to convert doubles locale sensitive. The stats widget does not. But this problem roots alread in a stats helper class, because it always converts the values into strings befor passing them to the model. This implies a deeper rework I already have started. I will base it on your work as soon as D264 is merged.

Fri, Mar 13, 2:56 PM · MITK (2020), Restricted Project

Thu, Mar 12

floca triaged T27229: [ImageStatistic] Copy to clipboard from statistic table should be directly usabel in Excel as Normal priority.
Thu, Mar 12, 4:38 PM · MITK (2020), Restricted Project

Mon, Mar 9

floca claimed T27205: Refactor statistic generation by introduce generators drafted for RT statistics.
Mon, Mar 9, 11:56 AM · Restricted Project, MITK
floca closed T27202: Support Planarfigures with fixed size as Resolved.
Mon, Mar 9, 11:56 AM · MITK, Restricted Project
floca committed rMITKa9ed8eb6f77f: Added feature of fixed sized PlanarCircle and PlanarDoubleEllipse. (authored by floca).
Added feature of fixed sized PlanarCircle and PlanarDoubleEllipse.
Mon, Mar 9, 11:55 AM
floca triaged T27210: Stitching tool for images as Normal priority.
Mon, Mar 9, 11:53 AM · Restricted Project, Restricted Project
floca triaged T27209: [Registration] Mapper does not allow to select ML segmentation as input as Normal priority.
Mon, Mar 9, 9:23 AM · MITK (2020)

Sun, Mar 8

floca triaged T27208: [Registration] Potential crash in manipulator as Normal priority.
Sun, Mar 8, 9:09 PM · MITK (2020)
floca closed T27207: [Registration] Manipulator does not update start button when inputs are selected as Invalid.

Was caused by the already fixed connection error.

Sun, Mar 8, 9:07 PM · MITK (2020)
floca triaged T27207: [Registration] Manipulator does not update start button when inputs are selected as Normal priority.
Sun, Mar 8, 8:58 PM · MITK (2020)