Page MenuHomePhabricator

floca (Ralf Omar Floca)
User

Projects (13)

User Details

User Since
Aug 1 2016, 12:10 PM (233 w, 3 d)

Recent Activity

Yesterday

floca added a comment to T28127: Reopen segmentation in MITK.
In T28127#217604, @gaoh wrote:

@floca I might have found a dataset, where even the new number is not enough:
P:\Gao\mitk-testdata\

Wed, Jan 20, 9:46 PM · Request for Discussion, MITK (2020), Restricted Project, Kaapana (internal)
floca added a comment to T27498: [Selection widgets] Define default for auto selection / listening mechanism.

Hm, interesting... I say we but it under the category experience and close that chapter. If it reoccures we see how to handle it. Thanks for investigating it.

Wed, Jan 20, 8:27 PM · Restricted Project, MITK (2020)
floca committed rMITK52adb58300dd: T27689 RTDose_image_cannot_be_serialized_and_workbench_crashes_upon_loading (authored by floca).
T27689 RTDose_image_cannot_be_serialized_and_workbench_crashes_upon_loading
Wed, Jan 20, 5:27 PM
floca committed rMITKadb6d06ec088: Fixed T27689 (authored by floca).
Fixed T27689
Wed, Jan 20, 5:27 PM
floca closed T27689: RTDose image can not be serialized and workbench crashes upon loading as Resolved by committing rMITKadb6d06ec088: Fixed T27689.
Wed, Jan 20, 5:27 PM · Request for Discussion, MITK
floca committed rMITKbac2bebfaee6: Prevent that serialization errors of single properties lead to a failed write… (authored by floca).
Prevent that serialization errors of single properties lead to a failed write…
Wed, Jan 20, 5:27 PM
floca committed rMITKb0a993ea0c4b: Code clean up (dead code) (authored by floca).
Code clean up (dead code)
Wed, Jan 20, 5:27 PM
floca committed rMITK9919ca949962: Changed to Point3dProperty to use existing serializer. (authored by floca).
Changed to Point3dProperty to use existing serializer.
Wed, Jan 20, 5:27 PM
floca committed rMITKbb5f99527044: Changed to DoubleProperty to support existing serializers (authored by floca).
Changed to DoubleProperty to support existing serializers
Wed, Jan 20, 5:27 PM

Tue, Jan 19

floca added a comment to T27498: [Selection widgets] Define default for auto selection / listening mechanism.

I just came across this again:
For me the following happens:

  1. I open the MITK workbench
  2. open the Segementation View
  3. below the image selectors a warning Please select an image is shown
  4. both image selectors show a red warning
  5. I open an image e.g. US4DCyl.nrrd
  6. the warning below the image selectors changes to Select or create a segmentation
  7. both image selectors still show a red warning
  8. the image is not automatically selected
Tue, Jan 19, 2:44 PM · Restricted Project, MITK (2020)
floca closed T27703: [Segmentation] Watershed segmentation crashes on images when high threshold is chosen as Resolved.

Is this solved?

As far as I have described above, yes.

Tue, Jan 19, 2:38 PM · MITK
floca added a comment to T28039: DICOM Seg loading error.

I set the GIT_TAG of DCMQI locally to v1.2.3 and I can confirm that the data from above can be loaded.

OK, then increasing the DCMQI version to 1.2.3 before our next release seems to be the most sensible fix, doen't it?

Tue, Jan 19, 9:38 AM · MITK (2020), Missing Info, Request for Discussion
floca moved T28118: Refactoring of SegTool2D from Backlog to Segmentation on the MITK (2020) board.
Tue, Jan 19, 9:36 AM · MITK (2020)

Mon, Jan 18

floca committed rMITK0440a5b618a8: T28127 Reopen_segmentation_in_MITK (authored by floca).
T28127 Reopen_segmentation_in_MITK
Mon, Jan 18, 11:14 PM
floca closed T28127: Reopen segmentation in MITK as Resolved by committing rMITK5f64c29977dd: Made NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION less strict.
Mon, Jan 18, 11:14 PM · Request for Discussion, MITK (2020), Restricted Project, Kaapana (internal)
floca committed rMITK5f64c29977dd: Made NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION less strict (authored by floca).
Made NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION less strict
Mon, Jan 18, 11:14 PM
floca added a revision to T28127: Reopen segmentation in MITK: Unknown Object (Differential Revision).
Mon, Jan 18, 9:42 PM · Request for Discussion, MITK (2020), Restricted Project, Kaapana (internal)
floca added a comment to T28127: Reopen segmentation in MITK.

It depends. NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION is only for checking in predicates;

As long as nobody has missused it so far, it is just used for that. ;) At least I have introduced it with this purpose and only used it there.

Mon, Jan 18, 4:01 PM · Request for Discussion, MITK (2020), Restricted Project, Kaapana (internal)
floca added a comment to T28127: Reopen segmentation in MITK.

1e-5 should still be conservative enough for the purpose of geometries.

Is your statement also valid for 5e-5? Beause 1e-5 would not be enough in that case.

Mon, Jan 18, 11:31 AM · Request for Discussion, MITK (2020), Restricted Project, Kaapana (internal)

Sun, Jan 17

floca claimed T28127: Reopen segmentation in MITK.

The problem seems to be that DCMQI rounds the the orientation matrix values at the 5th decimal place when storing to DCM Seg.

Sun, Jan 17, 8:41 PM · Request for Discussion, MITK (2020), Restricted Project, Kaapana (internal)
floca added a revision to T28148: Fix/Refactor ContourElement: Unknown Object (Differential Revision).
Sun, Jan 17, 1:50 PM · MITK (2020)
floca added a comment to T28118: Refactoring of SegTool2D.

Pushed new branch feature/T28118-Refactor_SegTool2D_and_derived_classes.

Sun, Jan 17, 1:45 PM · MITK (2020)

Sat, Jan 16

floca added a revision to T28148: Fix/Refactor ContourElement: Unknown Object (Differential Revision).
Sat, Jan 16, 8:48 PM · MITK (2020)

Mon, Jan 11

floca triaged T28150: [RT] Refactor RT Dose reader as Normal priority.
Mon, Jan 11, 7:19 PM · MITK
floca added a comment to T27689: RTDose image can not be serialized and workbench crashes upon loading.

Ok. Found the problem. Should now be fixed with the new diff. At least it works on my PC now with the test files.

Mon, Jan 11, 7:12 PM · Request for Discussion, MITK
floca edited projects for T28039: DICOM Seg loading error, added: Request for Discussion, Missing Info, MITK (2020); removed MITK.

@fedorov Happy new year and thanks for keeping us up to date!

Mon, Jan 11, 11:29 AM · MITK (2020), Missing Info, Request for Discussion

Sat, Jan 9

floca triaged T28148: Fix/Refactor ContourElement as Unbreak Now! priority.
Sat, Jan 9, 4:52 PM · MITK (2020)
floca added a revision to T26975: 2D Fast Marching for 4D data intermediate state displays segmentation in other timesteps: Unknown Object (Differential Revision).
Sat, Jan 9, 1:27 PM · Missing Info, MITK (2020)

Tue, Jan 5

floca triaged T28146: Rework how SegTool2D should add contour markers as Low priority.
Tue, Jan 5, 5:06 PM · MITK
floca triaged T28145: SetRegionTool does not work as expected (flood fill like) with concentric structures. as Normal priority.
Tue, Jan 5, 4:56 PM · MITK
floca created T28145: SetRegionTool does not work as expected (flood fill like) with concentric structures..
Tue, Jan 5, 4:55 PM · MITK
floca triaged T28144: CorrectorTool does not properly handle unlocked lables of LabelSet Images as Normal priority.
Tue, Jan 5, 4:41 PM · MITK
floca added a comment to T26975: 2D Fast Marching for 4D data intermediate state displays segmentation in other timesteps.

Will be fixed (is fixed already) by the rework done in T28118.

Tue, Jan 5, 4:30 PM · Missing Info, MITK (2020)
floca added a revision to T27800: [Segmentation] Live Wire crashes with 4D image and static segmentation: Unknown Object (Differential Revision).
Tue, Jan 5, 11:01 AM · MITK (2020)
floca added a revision to T28128: ContourModels are not correctly rendered on time steps > 0: Unknown Object (Differential Revision).
Tue, Jan 5, 11:01 AM · MITK
floca added a revision to T28129: Contour interactor do not handle time steps > 0 correctly and do not support time geometries correctly: Unknown Object (Differential Revision).
Tue, Jan 5, 11:01 AM · MITK

Mon, Jan 4

floca added a comment to T28118: Refactoring of SegTool2D.

Looking through the checklists I found that the 2D tools of the segmentation view are different than the 2D tools of the Multilabel segmentation (one more: Fast Marching is missing).

What do you mean with different. Different in there behavior or a different selection of tools.

Mon, Jan 4, 11:45 AM · MITK (2020)

Dec 22 2020

floca added a comment to T28113: [Segmentation] LiveWire tool confirms segmentation upon tool or label change.

I haven't made up my mind about the best way to go, I'm open for suggestions. I just wanted to state that even the checklists state something different. So to align the tests with what the workbench actually does, we should clarify, how the tools actually behave or should behave.

  • If the tool is deactivated (explicitly, by selecting another tool, by closing the view) all unconfirmed contours will be removed.

And this is not the case right now. Currently, a mask will be generated and drawn into the image.

Dec 22 2020, 11:21 AM · MITK
floca added a comment to T28113: [Segmentation] LiveWire tool confirms segmentation upon tool or label change.

Regarding the issue itself: I think it is a fundamental question of the capability of the tool. Auto confirm when closing the contour would
Pro: be a faster UX
Contra: won't allow to alter live wires before confirmation.

Dec 22 2020, 10:47 AM · MITK
floca added a comment to T28113: [Segmentation] LiveWire tool confirms segmentation upon tool or label change.

I just found out that the Checklists also states the following:

Deaktiveren des Live Wire Tools
  Tool Icon verschwindet vom Mouse Cursor
  Die gelben Konturen werden weiterhin angezeigt, können aber nicht mehr bearbeitet werden

So even the experienced behavior does not fit the checklist test. We should clarify which workflow we want to provide.

Dec 22 2020, 10:44 AM · MITK
floca triaged T28129: Contour interactor do not handle time steps > 0 correctly and do not support time geometries correctly as Normal priority.
Dec 22 2020, 10:13 AM · MITK
floca triaged T28128: ContourModels are not correctly rendered on time steps > 0 as Normal priority.
Dec 22 2020, 10:09 AM · MITK
floca claimed T27800: [Segmentation] Live Wire crashes with 4D image and static segmentation.

Will be fixed (is fixed already) by the rework done in T28118.

Dec 22 2020, 9:35 AM · MITK (2020)

Dec 17 2020

floca added a subtask for T28118: Refactoring of SegTool2D: T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation.
Dec 17 2020, 11:50 AM · MITK (2020)
floca added a parent task for T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation: T28118: Refactoring of SegTool2D.
Dec 17 2020, 11:50 AM · Missing Info, Restricted Project, MITK (2020)
floca added a parent task for T26975: 2D Fast Marching for 4D data intermediate state displays segmentation in other timesteps: T28118: Refactoring of SegTool2D.
Dec 17 2020, 11:50 AM · Missing Info, MITK (2020)
floca added a subtask for T28118: Refactoring of SegTool2D: T26975: 2D Fast Marching for 4D data intermediate state displays segmentation in other timesteps.
Dec 17 2020, 11:50 AM · MITK (2020)
floca triaged T28118: Refactoring of SegTool2D as High priority.
Dec 17 2020, 11:49 AM · MITK (2020)

Dec 16 2020

floca added a comment to T27689: RTDose image can not be serialized and workbench crashes upon loading.

Which node is it? you can look up the name if you look into caaaaa.xml

Dec 16 2020, 8:45 AM · Request for Discussion, MITK

Dec 15 2020

floca added a comment to T27689: RTDose image can not be serialized and workbench crashes upon loading.

could you provied (e.g. via nextcloud) such an invalid scene file?

Dec 15 2020, 4:20 PM · Request for Discussion, MITK
floca committed rRTTBf16003785168: Fixed T27214 also for RTTB as it will have the same problems. (authored by floca).
Fixed T27214 also for RTTB as it will have the same problems.
Dec 15 2020, 9:32 AM
floca committed rMPa47d55585495: Fixed T27214 (authored by floca).
Fixed T27214
Dec 15 2020, 9:21 AM

Dec 14 2020

floca added a comment to T27689: RTDose image can not be serialized and workbench crashes upon loading.

Do you have still problems with crashes? If yes, this is almost certainly not due to the GenericProperty thing, as they have no relevance for dose visualization and scenes without dose do not crash but also cannot load the GenericProperty.

Dec 14 2020, 2:53 PM · Request for Discussion, MITK
floca closed T22412: Workbench crashes when using 2D Region Growin on DWI Image (.nii) on Ubuntu 16.04 as Wontfix.

Closed. @neher or who ever might stumple upon the prolem again, is welcome to open it again and provide data. :)

Dec 14 2020, 1:07 PM · Missing Info, Request for Discussion, MITK (2020)
floca added a comment to T22412: Workbench crashes when using 2D Region Growin on DWI Image (.nii) on Ubuntu 16.04.

@neher or @jaegerp can someone provide test data? Otherwise I would close this task for now, because I cannot check or reproduce the problem without data.

Dec 14 2020, 12:15 PM · Missing Info, Request for Discussion, MITK (2020)
floca added a comment to T27817: [Multilabel] Live Wire tool always assigns first label when being used with multiple labels.

Can D447 landed and this issue closed? If nothing speaks against it, it would be good, before I turning the rest of the seg tools upside down. Thanks.

Dec 14 2020, 12:11 PM · Cleared, MITK (2020)
floca reopened T25152: Cannot compare TemporoSpatialStringProperty as "Open".

@thomass This is the issue we talked about last week when you hat problem to use predicates to find some nodes by DICOM tags values.

Dec 14 2020, 10:46 AM · MITK

Dec 13 2020

floca claimed T28089: [CEST] Error loading custom data due to alleged spacing of 0.
Dec 13 2020, 10:03 PM · Missing Info, Restricted Project, MITK
floca added a comment to T28089: [CEST] Error loading custom data due to alleged spacing of 0.
  1. Could you provide also a SS example. As it should also work with SS and I would like to know the reason.
  2. A MAC version will be available with the next public MITK release (planned for next january).
  3. Thanks for the example data. I have some questions regarding it:
Dec 13 2020, 10:03 PM · Missing Info, Restricted Project, MITK

Dec 10 2020

floca claimed T27689: RTDose image can not be serialized and workbench crashes upon loading.

@thomass Please check the patch provided by https://phabricator.mitk.org/D449. It should solve you problem I hope. Would be cool if you could give feedback.

Dec 10 2020, 6:15 PM · Request for Discussion, MITK

Dec 9 2020

floca added a comment to T27608: [MITKDoc] Documentation Refurbish - Developer Manual.

@kompan What is the status here? Is it finish. If not, what has to be done to close it. Should be done before we make a release in january and if much is left, we should know what to do. Thanks.

Dec 9 2020, 2:23 PM · Cleared, MITK (2020)
floca moved T28076: [Multilabel Segmentation] Corrector tool 2D does not respect multiple layers from Backlog to Segmentation on the MITK (2020) board.
Dec 9 2020, 2:18 PM · MITK (2020)
floca moved T22412: Workbench crashes when using 2D Region Growin on DWI Image (.nii) on Ubuntu 16.04 from Backlog to Segmentation on the MITK (2020) board.
Dec 9 2020, 2:18 PM · Missing Info, Request for Discussion, MITK (2020)
floca placed T22412: Workbench crashes when using 2D Region Growin on DWI Image (.nii) on Ubuntu 16.04 up for grabs.
Dec 9 2020, 2:18 PM · Missing Info, Request for Discussion, MITK (2020)

Dec 8 2020

floca added a comment to T27153: Fit CRMO2-model to mean value of ROI.

@kompan Is this still open? You marked it in your report list as "in usage" or did you ment something else with "statsitical analysis of 17O data"?

Dec 8 2020, 4:25 PM · Restricted Project
floca added a project to T28089: [CEST] Error loading custom data due to alleged spacing of 0: Missing Info.

@makr Could you please let us know:

  1. if the problem still persists
  2. What OS do you use?
  3. Could you provide any kind of example data for us to reproduce the error?
Dec 8 2020, 3:53 PM · Missing Info, Restricted Project, MITK
floca added a comment to CEST User Manual.

@makr Sorry for not responding directly. I was not aware that the comment section was open and I was not subscribed to the document thus recieved no notification. I hope you are still interested. I moved the issued to T28089. Would be great if you could have a look and give feedback. Thanks.

Dec 8 2020, 3:51 PM · MITK
floca triaged T28089: [CEST] Error loading custom data due to alleged spacing of 0 as Normal priority.
Dec 8 2020, 3:48 PM · Missing Info, Restricted Project, MITK

Dec 7 2020

floca added a project to T22412: Workbench crashes when using 2D Region Growin on DWI Image (.nii) on Ubuntu 16.04: Missing Info.
In T22412#93426, @goch wrote:

This crutch should be removed when redesigning the tools.

@floca I stumbled upon this and I was wondering if this crutch can be removed with the changes made in T27490.

May be. We would need to test it.
@neher do we have suiteable testdata?

Dec 7 2020, 9:12 PM · Missing Info, Request for Discussion, MITK (2020)

Dec 4 2020

floca added a comment to T28060: CMake Policy CMP0091 does not work well with dependencies that are based on CMake version < 3.15.

Thanks. No it works again.

Dec 4 2020, 3:33 PM · MITK

Dec 3 2020

floca added a comment to T28060: CMake Policy CMP0091 does not work well with dependencies that are based on CMake version < 3.15.

thanks for taking care. ❤

Dec 3 2020, 9:32 PM · MITK

Dec 2 2020

floca placed T25832: Migrate ModelFit inspector plugin to MitkChart up for grabs.

Unclaime as I currently have no time to work on it. Will take on it again, if I have time or some else;)

Dec 2 2020, 11:00 AM · Restricted Project, Restricted Project, MITK

Nov 30 2020

floca added a comment to T27968: CTP gets stuck on large import.

Thanks for the answers!

Nov 30 2020, 9:00 PM · Kaapana (internal)

Nov 28 2020

floca added a project to T24398: Dicom plugin: Retrieve does not work: Missing Info.

@gaoh Could you please specify which PACs you used to provoke the error. Or did it have this problem with multiple systems?

Nov 28 2020, 10:00 PM · MITK (2020)

Nov 27 2020

floca added a comment to T27968: CTP gets stuck on large import.
  • Regarding 1: This is done to ensure that you are notfied if a problem arrises in the dcmsend step?
  • Regarding 2: Do we have a test to verify if the problem still exists before we go into production with this? @gaoh: Was this a problem on the CTP side or on the DICOM4CHE side? So, did also other PACS like orthanc had the same problem?
  • Regarding 3: This road I would only go, if we also have a test suite ready to benchmark the performance and to ensure that we don't have the same problem problem. What kind of reciever would you use here.
Nov 27 2020, 5:32 PM · Kaapana (internal)

Nov 24 2020

floca updated the task description for T27992: Release of MITK CLIs.
Nov 24 2020, 9:22 PM · MITK (2020), Request for Discussion
floca added a comment to T27696: Dicom loading does not work for some 4D data with the latest installer.

@thomass could you check if the problem was realy just cuased by slow network drive and is solved. If this is the case, could you close the task? If the problem still exists, may be the issue solved by Stefan is a solution.

Nov 24 2020, 5:17 PM · DICOM, Missing Info, MITK
floca added a comment to T24398: Dicom plugin: Retrieve does not work.

@gaoh could you check if the problem is solved either with the branch or as soon as it is in develop?

Nov 24 2020, 5:15 PM · MITK (2020)
floca added a comment to T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers.

I would see it positiv. No sense crying over spilt milk. Thanks for solving that problem!

Nov 24 2020, 5:12 PM · Cleared, MITK (2020)

Nov 23 2020

floca added a comment to T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers.

🤞

Nov 23 2020, 11:24 PM · Cleared, MITK (2020)
floca triaged T27992: Release of MITK CLIs as High priority.
Nov 23 2020, 9:53 AM · MITK (2020), Request for Discussion
floca placed T27974: Sarah requires an MITK installer containing the mitk file converter up for grabs.

I do not activly work on that issue.

Nov 23 2020, 9:00 AM · Missing Info, MITK

Nov 22 2020

floca updated the task description for T27568: US 2D image cannot be read: invalid tilt information.
Nov 22 2020, 5:54 PM · Restricted Project, MITK

Nov 16 2020

floca added a comment to T27952: Reduce LabelSetTest and ImageGeneratorTest execution times.

Could it be that the test time out time is 600 sec? Because in the last month all tests runs of LabelSetTest with worked (as long as the duration was below 600 sec). All failed tests took longer then 600 sec.
For what ever reason under win the test is relativaly fast ~150-200 sec. Under linux/mac it is lurking arround 590 sec +- 25...

Nov 16 2020, 4:33 PM · MITK (2020)

Nov 11 2020

floca placed T23746: MITK and DICOM (realization) up for grabs.
Nov 11 2020, 11:43 AM · MITK
floca added a comment to T25152: Cannot compare TemporoSpatialStringProperty.

@kalali was ist still an open issue?

Nov 11 2020, 11:40 AM · MITK
floca reopened T24738: Thumbnail preview of images for datastorage inspectors as "Open".
Nov 11 2020, 11:39 AM · Restricted Project, MITK
floca reopened T24738: Thumbnail preview of images for datastorage inspectors, a subtask of T23751: Introduction of new selection concept, as Open.
Nov 11 2020, 11:39 AM · Noteworthy, MITK
floca reopened T25357: Refactor DataNode::GetPropertylist(..) for more const correctness, a subtask of T22322: Changing a renderer-specific property list of a data node does not modify the data node, as Open.
Nov 11 2020, 11:36 AM · MITK
floca reopened T25357: Refactor DataNode::GetPropertylist(..) for more const correctness as "Open".
Nov 11 2020, 11:36 AM · MITK
floca added a parent task for T19711: Correct handling of RT-Properties in nodes and data: T23746: MITK and DICOM (realization).
Nov 11 2020, 11:34 AM · Bugzilla, MITK
floca added a subtask for T23746: MITK and DICOM (realization): T19711: Correct handling of RT-Properties in nodes and data.
Nov 11 2020, 11:34 AM · MITK
floca reopened T19711: Correct handling of RT-Properties in nodes and data as "Open".
Nov 11 2020, 11:33 AM · Bugzilla, MITK
floca reopened T24540: DICOMReader module does not support Philips US 3D files on its "own" as "Open".
Nov 11 2020, 11:32 AM · Restricted Project, MITK
floca raised the priority of T23748: Image should have a valid DICOM.0008.0018 proprety from Wishlist to Low.
Nov 11 2020, 11:16 AM · MITK
floca reopened T23748: Image should have a valid DICOM.0008.0018 proprety as "Open".

Still needed

Nov 11 2020, 11:12 AM · MITK
floca reopened T23748: Image should have a valid DICOM.0008.0018 proprety, a subtask of T23746: MITK and DICOM (realization), as Open.
Nov 11 2020, 11:12 AM · MITK
floca placed T27413: MITK 2020 Workflow Q&A up for grabs.
Nov 11 2020, 10:25 AM · Restricted Project, CI, MITK (2020)

Nov 3 2020

floca committed rRTTBc1f0afd65322: Corrected visiblity of base class (authored by floca).
Corrected visiblity of base class
Nov 3 2020, 10:53 AM

Nov 1 2020

floca added a comment to T27614: Equalize reinit behavior of Segmentation View and Multilabel Segmentation View.

@kislinsk do you have an opionon which option to choose UX wise?

Nov 1 2020, 10:16 PM · MITK