Page MenuHomePhabricator

significanceMap function raises warning about deprecated function call
Open, NormalPublic

Description

Calling 'structure(NULL, *)' is deprecated, as NULL cannot have attributes. Consider 'structure(list(), *)' instead.

Event Timeline

eisenman created this task.May 26 2020, 6:55 PM

@eisenman I don't get this warning. Could you give more details/ an example? or is this already solved/not relevant anymore?

comes from significanceMap.data.frame

th_get=theme_get()
 # grid on top
   lt=th_get$panel.grid$linetype
   if (is.null(lt)) lt=th_get$line$linetype

 #p=p+theme(panel.background = element_rect(fill = NA),panel.ontop=TRUE) #-> grid will be on top of diagonal
 #fix:
  f=ggplot_build(p)
   p= p + geom_vline(xintercept=f$layout$panel_params[[1]]$x.major_source,
                     linetype=lt,
                     color=th_get$panel.grid$colour,
                     size=rel(th_get$panel.grid.major$size))+
     geom_hline(yintercept=f$layout$panel_params[[1]]$y.major_source,
                linetype=lt,
                color=th_get$panel.grid$colour,
                size=rel(th_get$panel.grid.major$size))+
     geom_abline(slope=1)+
     geom_text(aes(x=algorithm,y=fixy,label=rank),
               nudge_y=.5,
               vjust = 0,
               size=size.rank,
               fontface="plain",family="sans"
     )

rel(th_get$panel.grid.major$size) is rel(NULL) raising the warning

wiesenfa claimed this task.Fri, Sep 25, 9:47 AM
wiesenfa moved this task from In Progress to Done on the challengeR (v1.0) board.Fri, Sep 25, 12:08 PM