Page MenuHomePhabricator

eisenman (Matthias Eisenmann)
User

Projects (8)

User Details

User Since
Aug 1 2016, 12:10 PM (205 w, 11 h)

Recent Activity

Mon, Jun 22

eisenman added a comment to T27420: report text.

Item 3 and 4 are already mentioned in separate tasks: T27474 and T27475

Mon, Jun 22, 8:03 PM · challengeR (v1.0)
eisenman added a comment to T27412: Description of variability of achieved rankings across tasks is missing in short report.

The error mentioned in the comment does not occur anymore in the latest develop branch.

Mon, Jun 22, 7:40 PM · challengeR (v1.0)
eisenman moved T27396: Represent single-task challenge as multi-task challenge with one task from In Progress to Done on the challengeR (v1.0) board.
Mon, Jun 22, 7:38 PM · challengeR (v1.0)
eisenman added a comment to T27396: Represent single-task challenge as multi-task challenge with one task.

Thanks @aguilera for extensive testing of report generation. The residual issues from this task will be handled in T27494.

Mon, Jun 22, 7:37 PM · challengeR (v1.0)
eisenman created T27494: Check which files are still relevant.
Mon, Jun 22, 7:35 PM · challengeR (v1.0)
eisenman committed rCHALLENGERb5cdf4dadc19: Merge branch 'feature/T27396-RepresentSingleTaskChallengeAsMultiTaskChallenge'… (authored by eisenman).
Merge branch 'feature/T27396-RepresentSingleTaskChallengeAsMultiTaskChallenge'…
Mon, Jun 22, 7:22 PM

Tue, Jun 9

eisenman committed rCHALLENGER49e1418ef12f: Show explanation of algorithm ordering only for multi-task data set (authored by eisenman).
Show explanation of algorithm ordering only for multi-task data set
Tue, Jun 9, 6:14 PM
eisenman committed rCHALLENGERc4e1f3546b4f: Show title of podium plot only for multi-task data sets (authored by eisenman).
Show title of podium plot only for multi-task data sets
Tue, Jun 9, 6:14 PM
eisenman committed rCHALLENGERd9becaa36315: Migrate reporting of top performing algorithms (authored by eisenman).
Migrate reporting of top performing algorithms
Tue, Jun 9, 5:53 PM
eisenman committed rCHALLENGERe687c165c83d: Show task name in front of ranking list only for multi-task data sets (authored by eisenman).
Show task name in front of ranking list only for multi-task data sets
Tue, Jun 9, 4:58 PM
eisenman triaged T27475: Legend of blob plot has missing legend title and algorithms as High priority.
Tue, Jun 9, 3:43 PM · challengeR (v1.0)
eisenman triaged T27474: Legend of line plot has missing legend title and algorithm as High priority.
Tue, Jun 9, 3:18 PM · challengeR (v1.0)

Mon, Jun 8

eisenman committed rCHALLENGER8c4351c0aa88: Use task name as title for blob plot when it's not added by facet wrap (authored by eisenman).
Use task name as title for blob plot when it's not added by facet wrap
Mon, Jun 8, 5:29 PM

May 28 2020

eisenman added a comment to T27396: Represent single-task challenge as multi-task challenge with one task.

From my side, the migration is completed now. As discussed in the meeting on Monday, the name of a task in a single-task data set is optional. I created test cases for the plot functions that return plot objects, separate issues are created for those who don't. The extraction of top performing algorithms and subsets of tasks from rankings is also migrated and tested. I calculated the package test coverage to identify code that is never executed and deleted what seemed obsolete to me. There are still files with unused code where I'm not sure whether they are needed in other scenarios that are not well documented:

  • select.R
  • benchmarkUtils.R
  • winner.R
  • S3.R
  • second.R
  • extract.workflow.R
  • compareRanks.R
May 28 2020, 6:58 PM · challengeR (v1.0)
eisenman committed rCHALLENGERa1f14731d11d: Remove dead code (authored by eisenman).
Remove dead code
May 28 2020, 6:58 PM
eisenman created T27456: Extraction of task subset from (bootstrap) ranking does not raise an error for invalid task name.
May 28 2020, 6:11 PM · challengeR (v1.0)
eisenman committed rCHALLENGER476102d4602a: Migrate extraction of task subset from bootstrap ranking (authored by eisenman).
Migrate extraction of task subset from bootstrap ranking
May 28 2020, 5:44 PM
eisenman committed rCHALLENGER075cc1785fbb: Migrate extraction of task subset from ranking (authored by eisenman).
Migrate extraction of task subset from ranking
May 28 2020, 5:30 PM
eisenman committed rCHALLENGERb2335241725b: Test that extraction of bootstrap ranking subset returns more algorithms then… (authored by eisenman).
Test that extraction of bootstrap ranking subset returns more algorithms then…
May 28 2020, 2:57 PM
eisenman committed rCHALLENGER47838643c974: Test that extraction of bootstrap ranking subset raises error for multi-task… (authored by eisenman).
Test that extraction of bootstrap ranking subset raises error for multi-task…
May 28 2020, 2:57 PM
eisenman committed rCHALLENGER5b20ca4bffb4: Test that extraction of bootstrap ranking subset returns all algorithms even… (authored by eisenman).
Test that extraction of bootstrap ranking subset returns all algorithms even…
May 28 2020, 2:57 PM
eisenman committed rCHALLENGER09e57193c67d: Migrate extraction of top performing algorithms from bootstrap ranking (authored by eisenman).
Migrate extraction of top performing algorithms from bootstrap ranking
May 28 2020, 2:50 PM
eisenman committed rCHALLENGER479fd58ca60e: Test that extraction of subset returns more algorithms then requested when ties… (authored by eisenman).
Test that extraction of subset returns more algorithms then requested when ties…
May 28 2020, 2:15 PM
eisenman committed rCHALLENGER411ef20371d2: Test that extraction of subset returns all algorithms even when more are… (authored by eisenman).
Test that extraction of subset returns all algorithms even when more are…
May 28 2020, 2:15 PM
eisenman committed rCHALLENGERd5459ec81a45: Test that top performing algorithms are extracted and data set is reduced… (authored by eisenman).
Test that top performing algorithms are extracted and data set is reduced…
May 28 2020, 2:15 PM
eisenman committed rCHALLENGER28ca5db44b15: Migrate extraction of top performing algorithms (authored by eisenman).
Migrate extraction of top performing algorithms
May 28 2020, 1:59 PM
eisenman committed rCHALLENGER0a0f1c61708a: Make task name optional for single-task data set (authored by eisenman).
Make task name optional for single-task data set
May 28 2020, 10:55 AM

May 27 2020

eisenman committed rCHALLENGER28a53885f53c: Ensure that stacked bar plot for visualizing ranking stability by algorithm is… (authored by eisenman).
Ensure that stacked bar plot for visualizing ranking stability by algorithm is…
May 27 2020, 7:06 PM
eisenman committed rCHALLENGERe87de5b18868: Ensure that blob plot for visualizing ranking stability by algorithm is only… (authored by eisenman).
Ensure that blob plot for visualizing ranking stability by algorithm is only…
May 27 2020, 6:58 PM
eisenman created T27453: Create complete network plot in its function.
May 27 2020, 6:15 PM · challengeR (v1.0)
eisenman committed rCHALLENGER2a5d152b852e: Ensure that network plot is only created for at least three tasks (authored by eisenman).
Ensure that network plot is only created for at least three tasks
May 27 2020, 6:10 PM
eisenman committed rCHALLENGER2e5f5161f3b2: Add third task to trigger creation of cluster analysis plots (authored by eisenman).
Add third task to trigger creation of cluster analysis plots
May 27 2020, 5:10 PM
eisenman added a comment to T27420: report text.

Let's use this task to collect what exactly needs to be revised.

May 27 2020, 4:59 PM · challengeR (v1.0)
eisenman created T27452: Provide plot function for dendrogram.
May 27 2020, 4:49 PM · challengeR (v1.0)
eisenman committed rCHALLENGERf1a402e3946a: Ensure that blob plot for visualizing ranking stability across tasks is only… (authored by eisenman).
Ensure that blob plot for visualizing ranking stability across tasks is only…
May 27 2020, 4:08 PM
eisenman committed rCHALLENGER34b55a87aabc: Remove violin plot function used for single-task data set (authored by eisenman).
Remove violin plot function used for single-task data set
May 27 2020, 3:28 PM
eisenman committed rCHALLENGERd58cc9b9e676: Show task names as tick mark labels only for multi-task data set in violin plot (authored by eisenman).
Show task names as tick mark labels only for multi-task data set in violin plot
May 27 2020, 3:25 PM
eisenman committed rCHALLENGERea91a2adcbb8: Test that line plot across ranking methods returns one plot for single- and… (authored by eisenman).
Test that line plot across ranking methods returns one plot for single- and…
May 27 2020, 2:29 PM
eisenman committed rCHALLENGERf209976c312b: Add option for showing blob plot label for visualizing ranking stability (authored by eisenman).
Add option for showing blob plot label for visualizing ranking stability
May 27 2020, 2:22 PM

May 26 2020

eisenman created T27450: Consistent use of attribute indicating whether small metric values lead to a better rank.
May 26 2020, 9:00 PM · challengeR (v1.0)
eisenman triaged T27449: Consistent handling of plots created for multi-task data sets as High priority.
May 26 2020, 8:31 PM · challengeR (v1.0)
eisenman committed rCHALLENGER10d13f5001c0: Test that line plot across ranking methods has no title for single-task data set (authored by eisenman).
Test that line plot across ranking methods has no title for single-task data set
May 26 2020, 8:17 PM
eisenman committed rCHALLENGERb05414b321b8: Remove single-task data set handling for line plots across ranking methods (authored by eisenman).
Remove single-task data set handling for line plots across ranking methods
May 26 2020, 7:15 PM
eisenman created T27447: significanceMap function raises warning about deprecated function call.
May 26 2020, 6:55 PM · challengeR (v1.0)
eisenman committed rCHALLENGERcc744ddd3c0f: Remove significance map function used for single-task data set (authored by eisenman).
Remove significance map function used for single-task data set
May 26 2020, 5:54 PM
eisenman committed rCHALLENGER9a3d0d68871c: Remove significance map title for single-task data set (authored by eisenman).
Remove significance map title for single-task data set
May 26 2020, 5:54 PM
eisenman committed rCHALLENGER654ad17ac744: Test that significance map titles are set depending on single- or multi-task… (authored by eisenman).
Test that significance map titles are set depending on single- or multi-task…
May 26 2020, 5:54 PM

May 25 2020

eisenman committed rCHALLENGERc816ae8fc27f: Remove ranking heatmap function used for single-task data set (authored by eisenman).
Remove ranking heatmap function used for single-task data set
May 25 2020, 10:27 PM
eisenman committed rCHALLENGER23771ce7f5cf: Test that ranking heatmap titles are set depending on single- or multi-task… (authored by eisenman).
Test that ranking heatmap titles are set depending on single- or multi-task…
May 25 2020, 10:27 PM
eisenman committed rCHALLENGERa1079f34da91: Remove ranking heatmap title for single-task data set (authored by eisenman).
Remove ranking heatmap title for single-task data set
May 25 2020, 10:27 PM
eisenman committed rCHALLENGERe76a71df4c3f: Remove boxplot function used for single-task data set (authored by eisenman).
Remove boxplot function used for single-task data set
May 25 2020, 8:28 PM
eisenman committed rCHALLENGERfed508c8133d: Test that boxplot titles are set depending on single- or multi-task data set (authored by eisenman).
Test that boxplot titles are set depending on single- or multi-task data set
May 25 2020, 8:22 PM
eisenman committed rCHALLENGERf9e5997a7c9b: Remove boxplot title for single-task data set (authored by eisenman).
Remove boxplot title for single-task data set
May 25 2020, 7:15 PM

May 19 2020

eisenman merged task T27430: Ranking heatmaps in mult task report don't have titles into T27325: Plot titles in rankingHeatmap missing in multi task report.
May 19 2020, 11:00 AM · challengeR (v1.0)
eisenman merged T27430: Ranking heatmaps in mult task report don't have titles into T27325: Plot titles in rankingHeatmap missing in multi task report.
May 19 2020, 11:00 AM · challengeR (v1.0)
eisenman added a comment to T27430: Ranking heatmaps in mult task report don't have titles.

This seems to be a duplicate of T27325 and should already be solved on develop branch. Which version did you use?

May 19 2020, 10:53 AM · challengeR (v1.0)

May 14 2020

eisenman committed rCHALLENGER48c2e17887e5: Test that reports for multi-task data set with bootstrapping are created (authored by eisenman).
Test that reports for multi-task data set with bootstrapping are created
May 14 2020, 6:40 PM
eisenman committed rCHALLENGERe36073bb41d7: Test that reports for multi-task data set without bootstrapping are created (authored by eisenman).
Test that reports for multi-task data set without bootstrapping are created
May 14 2020, 6:22 PM
eisenman committed rCHALLENGER9550cfc42ab9: Use default latex engine (authored by eisenman).
Use default latex engine
May 14 2020, 6:22 PM
eisenman added a comment to T27412: Description of variability of achieved rankings across tasks is missing in short report.

The variable "boot_object" that was introduced to the develop branch by this fix is not available in this report. The short multi-task report is without bootstrapping.

May 14 2020, 6:14 PM · challengeR (v1.0)
eisenman committed rCHALLENGER62bebafef38d: Test that reports for single-task data set with bootstrapping are created (authored by eisenman).
Test that reports for single-task data set with bootstrapping are created
May 14 2020, 5:38 PM
eisenman committed rCHALLENGER20f344722355: Test that report for single-task data set without bootstrapping is created (authored by eisenman).
Test that report for single-task data set without bootstrapping is created
May 14 2020, 4:11 PM
eisenman committed rCHALLENGER3a823f06d2f9: Find files when package is installed (authored by eisenman).
Find files when package is installed
May 14 2020, 2:48 PM
eisenman committed rCHALLENGER4c511e90e06e: List overview of contained plots (authored by eisenman).
List overview of contained plots
May 14 2020, 2:01 PM
eisenman committed rCHALLENGER358c1201126c: Adapt example for single-task data set (authored by eisenman).
Adapt example for single-task data set
May 14 2020, 1:27 PM
eisenman added a comment to T27396: Represent single-task challenge as multi-task challenge with one task.

Now I know what you were meaning with all your points ;)
I started to work on this during our hacking days on this branch. I managed to transform a single-task data set into multi-task data set including one task. I had to adapt some plot code. And for the reports many duplicate changes would have been necessary. So on the way, I decided to refactor the generation of the reports to lower the future maintenance effort: I extracted the report sections to separate files and include them depending on the variables isMultiTask and bootstrappingEnabled. So each text block and code snippet exists only once. And it's still possible to get four types of reports (single-task data set with and without bootstrapping, multi-task data set with and without bootstrapping). I compared the reports with the reference reports I generated from the master branch. They look the same apart from that the plots for single-task data sets are also labeled with the task name. The next step would be a general clean-up of the functionality that was used for single-task data sets.

May 14 2020, 1:04 PM · challengeR (v1.0)
eisenman committed rCHALLENGER2dccd31860f1: Remove report functionality used for single-task data sets (authored by eisenman).
Remove report functionality used for single-task data sets
May 14 2020, 12:41 PM
eisenman committed rCHALLENGER7e95abdd4b64: Remove unused report files (authored by eisenman).
Remove unused report files
May 14 2020, 12:41 PM
eisenman committed rCHALLENGER86ba2005a955: Extract report sections to separate files and include them depending on… (authored by eisenman).
Extract report sections to separate files and include them depending on…
May 14 2020, 12:01 PM
eisenman committed rCHALLENGER56d572ce781b: Move transformation to sanity check (authored by eisenman).
Move transformation to sanity check
May 14 2020, 12:01 PM

May 13 2020

eisenman triaged T27412: Description of variability of achieved rankings across tasks is missing in short report as High priority.
May 13 2020, 1:30 PM · challengeR (v1.0)
eisenman added a comment to T27326: autolayout networks in multi task report ugly.

Ok, I saw it now what is generated for the data set that comes with the package:

May 13 2020, 1:17 PM · challengeR (v1.0)
eisenman triaged T27411: Improve labels in cluster dendrogram as High priority.
May 13 2020, 1:14 PM · challengeR (v1.0)
eisenman triaged T27410: Correct description of variability of achieved rankings across tasks as High priority.
May 13 2020, 1:02 PM · challengeR (v1.0)

May 12 2020

eisenman committed rCHALLENGER878b2d589204: Adapt ranking heatmap plot to multi-task data set format (authored by eisenman).
Adapt ranking heatmap plot to multi-task data set format
May 12 2020, 11:29 PM
eisenman committed rCHALLENGER7d6205b24254: Adapt podium plot to multi-task data set format (authored by eisenman).
Adapt podium plot to multi-task data set format
May 12 2020, 11:29 PM
eisenman triaged T27408: Description of cluster analysis contains unnecessary symbol as High priority.
May 12 2020, 11:16 PM · challengeR (v1.0)
eisenman triaged T27301: Add on boarding tutorial as High priority.
May 12 2020, 10:49 PM · challengeR (v1.0)
eisenman triaged T27302: Add sections to the readme as High priority.
May 12 2020, 10:49 PM · challengeR (v1.0)
eisenman triaged T27404: Fix the 2.1 section title format of the report as High priority.
May 12 2020, 10:49 PM · challengeR (v1.0)
eisenman triaged T27241: Readme improvements as High priority.
May 12 2020, 10:48 PM · challengeR (v1.0)
eisenman triaged T27407: Warnings are shown in multi-task challenge report for violin plot as High priority.
May 12 2020, 10:47 PM · challengeR (v1.0)
eisenman committed rCHALLENGER3e7a90c0eaec: Adapt rank-then-aggregate tests to multi-task data set format (authored by eisenman).
Adapt rank-then-aggregate tests to multi-task data set format
May 12 2020, 4:06 PM
eisenman committed rCHALLENGERe866161b1ecd: Check for invalid NA treatment option in multi-task data set (authored by eisenman).
Check for invalid NA treatment option in multi-task data set
May 12 2020, 3:56 PM
eisenman committed rCHALLENGER6b6b6e59e0ea: Adapt aggregate-than-rank tests to multi-task data set format (authored by eisenman).
Adapt aggregate-than-rank tests to multi-task data set format
May 12 2020, 3:56 PM
eisenman committed rCHALLENGER8838dfaba572: Transform single-task data set into multi-task data set including one task (authored by eisenman).
Transform single-task data set into multi-task data set including one task
May 12 2020, 3:14 PM
eisenman claimed T27396: Represent single-task challenge as multi-task challenge with one task.
May 12 2020, 11:18 AM · challengeR (v1.0)
eisenman moved T27396: Represent single-task challenge as multi-task challenge with one task from Backlog to In Progress on the challengeR (v1.0) board.
May 12 2020, 11:17 AM · challengeR (v1.0)
eisenman added a comment to T27396: Represent single-task challenge as multi-task challenge with one task.

Thank you for your feedback!

May 12 2020, 10:27 AM · challengeR (v1.0)

May 11 2020

eisenman triaged T27396: Represent single-task challenge as multi-task challenge with one task as High priority.
May 11 2020, 1:09 PM · challengeR (v1.0)
eisenman added a comment to T27326: autolayout networks in multi task report ugly.

What is the tricky part?

May 11 2020, 11:57 AM · challengeR (v1.0)
eisenman added a comment to T27338: Report contains misleading information on missing values.

What do the others think? Which number of NAs should be stated in the report?

May 11 2020, 11:55 AM · challengeR (v1.0)
eisenman added a comment to T27385: Variables holding the aggregated value are named differently for single- and multi-task challenges.

@wiesenfa: Do you have any preference regarding the naming scheme?

May 11 2020, 11:33 AM · challengeR (v1.0)
eisenman claimed T27360: compatibility with R4.0.0.
May 11 2020, 10:51 AM · challengeR (v1.0)
eisenman moved T27360: compatibility with R4.0.0 from Backlog to In Progress on the challengeR (v1.0) board.
May 11 2020, 10:51 AM · challengeR (v1.0)

May 8 2020

eisenman added a comment to T27259: Render windows are not updated when last time step is selected.

The null pointer is returned because mitk::ArbitraryTimeGeometry::IsValidTimePoint(...) evaluates time point 160 ms to false.

May 8 2020, 3:38 PM · Cleared, MITK (2020)
eisenman added a comment to T27259: Render windows are not updated when last time step is selected.

The status is set as mentioned above because in QmitkImageNavigatorView::UpdateStatusBar() the call of mitk::FindTopmostVisibleNode(...) for time point 160 ms returns a null pointer.

May 8 2020, 3:07 PM · Cleared, MITK (2020)
eisenman added a comment to T27259: Render windows are not updated when last time step is selected.

Another observation in the current version: "No image information at this position!" is shown in the status bar when switching from second to third time step.

May 8 2020, 2:30 PM · Cleared, MITK (2020)
eisenman added a comment to T27259: Render windows are not updated when last time step is selected.

In 2016.11.0 it's showing different volumes for all of the three time steps.

May 8 2020, 11:06 AM · Cleared, MITK (2020)
eisenman added a comment to T27259: Render windows are not updated when last time step is selected.

I can do that. I already checked with 2018.4.0. In this version it's possible to select a third time step only by moving the time slider (not the spin box buttons), but for the third time steps it's showing the volume of the first.

May 8 2020, 10:51 AM · Cleared, MITK (2020)