- User Since
- Aug 1 2016, 12:10 PM (205 w, 11 h)
Mon, Jun 22
The error mentioned in the comment does not occur anymore in the latest develop branch.
Tue, Jun 9
Mon, Jun 8
May 28 2020
From my side, the migration is completed now. As discussed in the meeting on Monday, the name of a task in a single-task data set is optional. I created test cases for the plot functions that return plot objects, separate issues are created for those who don't. The extraction of top performing algorithms and subsets of tasks from rankings is also migrated and tested. I calculated the package test coverage to identify code that is never executed and deleted what seemed obsolete to me. There are still files with unused code where I'm not sure whether they are needed in other scenarios that are not well documented:
May 27 2020
Let's use this task to collect what exactly needs to be revised.
May 26 2020
May 25 2020
May 19 2020
This seems to be a duplicate of T27325 and should already be solved on develop branch. Which version did you use?
May 14 2020
The variable "boot_object" that was introduced to the develop branch by this fix is not available in this report. The short multi-task report is without bootstrapping.
Now I know what you were meaning with all your points ;)
I started to work on this during our hacking days on this branch. I managed to transform a single-task data set into multi-task data set including one task. I had to adapt some plot code. And for the reports many duplicate changes would have been necessary. So on the way, I decided to refactor the generation of the reports to lower the future maintenance effort: I extracted the report sections to separate files and include them depending on the variables isMultiTask and bootstrappingEnabled. So each text block and code snippet exists only once. And it's still possible to get four types of reports (single-task data set with and without bootstrapping, multi-task data set with and without bootstrapping). I compared the reports with the reference reports I generated from the master branch. They look the same apart from that the plots for single-task data sets are also labeled with the task name. The next step would be a general clean-up of the functionality that was used for single-task data sets.
May 13 2020
Ok, I saw it now what is generated for the data set that comes with the package:
May 12 2020
Thank you for your feedback!
May 11 2020
What is the tricky part?
What do the others think? Which number of NAs should be stated in the report?
@wiesenfa: Do you have any preference regarding the naming scheme?
May 8 2020
The null pointer is returned because mitk::ArbitraryTimeGeometry::IsValidTimePoint(...) evaluates time point 160 ms to false.
The status is set as mentioned above because in QmitkImageNavigatorView::UpdateStatusBar() the call of mitk::FindTopmostVisibleNode(...) for time point 160 ms returns a null pointer.
Another observation in the current version: "No image information at this position!" is shown in the status bar when switching from second to third time step.
In 2016.11.0 it's showing different volumes for all of the three time steps.
I can do that. I already checked with 2018.4.0. In this version it's possible to select a third time step only by moving the time slider (not the spin box buttons), but for the third time steps it's showing the volume of the first.