There are still files with unused code where I'm not sure whether they are needed in other scenarios that are not well documented:
- select.R
- benchmarkUtils.R
- winner.R
- S3.R
- second.R
- extract.workflow.R
- compareRanks.R
There are still files with unused code where I'm not sure whether they are needed in other scenarios that are not well documented:
ranking=challenge%>%aggregateThenRank(FUN = mean, # aggregation function, na.treat=0, # either "na.rm" to remove missing data, ties.method = "min" # a character string specifying ) winner(ranking)
ranking=challenge%>%aggregateThenRank(FUN = mean, # aggregation function, na.treat=0, # either "na.rm" to remove missing data, ties.method = "min" # a character string specifying ) ranking
ranking=challenge%>%rank() %>% aggregate(FUN = mean, na.treat=0) %>% rank() workfl <- extract.workflow(ranking) workfl <- extract.workflow(ranking) another_challenge_object %>% workfl # do the same to other challenge
comp1=compareRanks(a1_mean,a1_median) # exclude all tasks with 1 or 2 algorithms # comp1[sapply(comp1, function(x) nrow(x$mat)>2)] comp1%>% select.if(function(x) nrow(x)>2)
In my opinion, the functionality that we want to keep should also have unit tests to (1) indicate that it is maintained and (2) to demonstrate how to use it.
what about
keep S3, compareRanks and extract.workflow
but do not export (i.e. remove from namespace) compareRanks and extract.workflow. they can then only be accessed e.g. by challengeR:::compareRanks(). These might be of practical use.
?
kept select.if(), winner(), extract.workfolow and compareRanks()
and removed everything not supported anymore.
as.warehouse (benchmarkUtils) is not exported, recommend to leave because this may come handy for specific situations
I would suggest to keep it like this, if you feel uncomfortable @eisenman with this we could insert a message "not tested" for these function although like extract.workflow() are ridiculously simple.