Page MenuHomePhabricator
Create Task
Maniphest T27955

Debug vtkOpenGLRenderWindow::SupportsOpenGL() on Windows CI clients
Closed, ResolvedPublic
Actions

Description

Since VTK 9, vtkOpenGLRenderWindow::SupportsOpenGL() (called by mitk::RenderingTestHelper) seems to return true even though it is not the case, resulting in failing rendering tests instead of skipping them as before.

Related Objects

Event Timeline

kislinsk triaged this task as Unbreak Now! priority.Nov 15 2020, 12:37 PM
kislinsk created this task.
kislinsk edited projects, added MITK (v2021.02); removed MITK.
kislinsk added a comment.Nov 15 2020, 9:03 PM

Pushed new branch bugfix/T27955-FixRenderingTestHelper.

kislinsk mentioned this in rMITKc5c7e1db644e: Merge branch 'bugfix/T27955-FixRenderingTestHelper' into develop.Nov 15 2020, 9:04 PM
kislinsk mentioned this in rMITK0234c87ef730: Merge branch 'bugfix/T27955-FixRenderingTestHelper' into develop.Nov 15 2020, 10:09 PM
kislinsk mentioned this in rMITK75ee6b5528a7: Merge branch 'bugfix/T27955-FixRenderingTestHelper' into develop.Nov 15 2020, 10:27 PM
kislinsk mentioned this in rMITK42a9fbf8941e: Merge branch 'bugfix/T27955-FixRenderingTestHelper' into develop.Nov 15 2020, 11:08 PM
kislinsk added a project: Noteworthy.Nov 15 2020, 11:16 PM

It is not an OpenGL problem but a Windows policy that prevents remote SSH users to actually start GUI applications. It wasn't triggered before as VTK's OpenGL test succeeds now.

I added the label "Rendering Tests" to all rendering tests so that CTest can be executed with --label-exclude "Rendering Tests" if necessary.

I introduced the new variable MODULE_RENDERING_TESTS besides the already established MODULE_TESTS to discriminate rendering tests, as well as mitkAddCustomModuleRenderingTest() as a wrapper function for mitkAddCustomModuleTest().

kislinsk closed this task as Resolved.Nov 15 2020, 11:30 PM
kislinsk added a comment.Nov 16 2020, 9:18 PM

Deleted branch bugfix/T27955-FixRenderingTestHelper.

kislinsk added a comment.Nov 18 2020, 12:07 AM

Pushed new branch bugfix/T27955-RenderingTestsSerialRun.

kislinsk mentioned this in rMITKfacc43e1c260: Merge branch 'bugfix/T27955-RenderingTestsSerialRun' into develop.Nov 18 2020, 12:08 AM
kislinsk added a comment.Nov 18 2020, 12:08 AM

Deleted branch bugfix/T27955-RenderingTestsSerialRun.

kislinsk mentioned this in T27977: 2020 Week 47 (Mid November).Nov 19 2020, 2:50 PM
MITK · MIC · IMSY · DKFZ