Page MenuHomePhabricator

Blackbox class - reorder the loss function call try
Open, Needs TriagePublic

Description

Status: Currently in https://github.com/MIC-DKFZ/Hyppopy/blob/master/hyppopy/BlackboxFunction.py call it is first tried to call self.blackbox_func(self.data, kwargs) and then self.blackbox_func(self.data, **kwargs).

I think it makes sense to invert it and first check the **kwargs version as it is more specific because it needs to have a loss function with the the fitting named arguments. The other version can work with any function that has an one index parameter available. Thus it seems more like a fall back.

@kleina What do you think?