Page MenuHomePhabricator

Blackbox class - reorder the loss function call try
Closed, ResolvedPublic


Status: Currently in call it is first tried to call self.blackbox_func(, kwargs) and then self.blackbox_func(, **kwargs).

I think it makes sense to invert it and first check the **kwargs version as it is more specific because it needs to have a loss function with the the fitting named arguments. The other version can work with any function that has an one index parameter available. Thus it seems more like a fall back.

@kleina What do you think?

Revisions and Commits

rOBSHYPPOPY Hyppopy (Observed Repository)
Restricted Differential Revision

Event Timeline

Your argument makes sense to me. I did not have a specific order in mind when implementing it, so I do not have any counterargument here.

I propose, that I just go ahead and change it accordingly.

kleina added a revision: Restricted Differential Revision.Apr 21 2021, 1:21 PM