Page MenuHomePhabricator

kleina (André Klein)
Bone guy

Projects (9)

User Details

User Since
Aug 1 2016, 12:10 PM (254 w, 5 h)

Recent Activity

Today

kleina triaged T28548: Allow Zooming during creation of Segmentation. as Normal priority.
Mon, Jun 14, 4:51 PM · Request for Discussion, MITK (v2021.10)

Thu, Jun 10

kleina added a comment to T28544: Difference of loading RT data DicomBrowser vs. "Standard loading".

We commented out the entire if-else clause for the RT data and it seems to do what it is supposed to do, even without the special conditions. Need to check that in more detail.

Thu, Jun 10, 4:35 PM · MITK (v2021.10)
kleina removed a project from T28455: RT struct 3D visibility is not working correctly: Request for Discussion.
Thu, Jun 10, 3:36 PM · MITK (v2021.10)
kleina triaged T28544: Difference of loading RT data DicomBrowser vs. "Standard loading" as Normal priority.
Thu, Jun 10, 2:45 PM · MITK (v2021.10)
kleina added a comment to T28455: RT struct 3D visibility is not working correctly.

Pushed new branch to rMITK MITK: bugfix/T28455-rt-struct-3d-visibility.

Thu, Jun 10, 2:32 PM · MITK (v2021.10)

Tue, Jun 8

kleina committed rOBSHYPPOPYd59c6efb638f: Usage of default value for new member. (authored by kleina).
Usage of default value for new member.
Tue, Jun 8, 9:48 AM

Mon, Jun 7

kleina committed rOBSHYPPOPYb8dfe382dd47: Added .arcconfig for Hyppopy (authored by kleina).
Added .arcconfig for Hyppopy
Mon, Jun 7, 4:22 PM
kleina committed rOBSHYPPOPY4de04affc17e: Added test for setting of default value for _add_member (authored by kleina).
Added test for setting of default value for _add_member
Mon, Jun 7, 4:22 PM
kleina committed rOBSHYPPOPY019b7655537b: If the passed value for a new member equals 'None', (authored by kleina).
If the passed value for a new member equals 'None',
Mon, Jun 7, 4:22 PM
kleina moved T28300: [MPI] MPI as a general dependency might be problematic from In Progress to Bugfixes on the Hyppopy board.
Mon, Jun 7, 3:08 PM · Request for Discussion, Hyppopy

Fri, Jun 4

kleina updated subscribers of T28520: XNAT on e230-xnat.
Fri, Jun 4, 12:21 PM · Restricted Project
kleina updated the task description for T28520: XNAT on e230-xnat.
Fri, Jun 4, 12:21 PM · Restricted Project
kleina triaged T28520: XNAT on e230-xnat as Normal priority.
Fri, Jun 4, 12:06 PM · Restricted Project

Wed, Jun 2

kleina added a comment to T28455: RT struct 3D visibility is not working correctly.

Discussed it in the MITK meeting:

Wed, Jun 2, 11:39 AM · MITK (v2021.10)
kleina moved T28455: RT struct 3D visibility is not working correctly from Backlog to MITK Meeting on the Request for Discussion board.
Wed, Jun 2, 11:14 AM · MITK (v2021.10)

May 10 2021

kleina added a project to T28455: RT struct 3D visibility is not working correctly: Request for Discussion.
May 10 2021, 3:12 PM · MITK (v2021.10)
kleina updated subscribers of T28455: RT struct 3D visibility is not working correctly.

I narrowed it down.

May 10 2021, 3:11 PM · MITK (v2021.10)
kleina added a comment to T28455: RT struct 3D visibility is not working correctly.

If you load a RTStruct via DICOMBrwoser, the node has a special "visible" property for stdmulti.widget3 (the 3D view). You can enable/disbale it via the Properties plugin. #Workaround :-P

May 10 2021, 11:51 AM · MITK (v2021.10)
kleina added a comment to T28455: RT struct 3D visibility is not working correctly.

Ok, we tested it on several machines and it is as described above: After loading via DICOM Browser we can confirm the issue.

May 10 2021, 11:32 AM · MITK (v2021.10)
kleina added a comment to T28455: RT struct 3D visibility is not working correctly.

@s434n and I tried this on Windows and Linux. It looks like, if you load the data via "classical drag'n'drop", it works as expected. If we use the DICOM browser to load the exact same dataset, we can reproduce @nolden's issue.

May 10 2021, 10:43 AM · MITK (v2021.10)
kleina added a comment to T28332: Support cascaded MPI processing.

Sure, here it is:
https://phabricator.mitk.org/rOBSHYPPOPYa340b927d14acdef69cea4e64b92524270066920

May 10 2021, 9:32 AM · Hyppopy

Apr 22 2021

kleina committed rOBSHYPPOPY04b807b9d85f: Added .arcconfig (authored by kleina).
Added .arcconfig
Apr 22 2021, 10:26 AM
kleina closed T28410: MPISolverWrapper's direct call of blackbox internal seems wrong as Resolved by committing rOBSHYPPOPYace9c97f5ba3: Fixed MPISolverWrapper's direct call of blackbox internal.
Apr 22 2021, 10:08 AM · Hyppopy
kleina committed rOBSHYPPOPYace9c97f5ba3: Fixed MPISolverWrapper's direct call of blackbox internal (authored by kleina).
Fixed MPISolverWrapper's direct call of blackbox internal
Apr 22 2021, 10:08 AM

Apr 21 2021

kleina reopened T28410: MPISolverWrapper's direct call of blackbox internal seems wrong as "Open".
Apr 21 2021, 4:12 PM · Hyppopy
kleina committed rOBSHYPPOPY727320895a4e: Removed deprecated loss_function_batch_call (authored by kleina).
Removed deprecated loss_function_batch_call
Apr 21 2021, 3:57 PM
kleina committed rOBSHYPPOPY543bba87253a: Make sure fallback only gets executed when batch_call fails. (authored by kleina).
Make sure fallback only gets executed when batch_call fails.
Apr 21 2021, 3:33 PM
kleina closed T28410: MPISolverWrapper's direct call of blackbox internal seems wrong as Resolved by committing rOBSHYPPOPYa2cfa7ce75ac: Fixed MPISolverWrapper's direct call of blackbox internal.
Apr 21 2021, 3:33 PM · Hyppopy
kleina committed rOBSHYPPOPYa2cfa7ce75ac: Fixed MPISolverWrapper's direct call of blackbox internal (authored by kleina).
Fixed MPISolverWrapper's direct call of blackbox internal
Apr 21 2021, 3:32 PM
kleina added a project to T28300: [MPI] MPI as a general dependency might be problematic: Request for Discussion.
Apr 21 2021, 3:27 PM · Request for Discussion, Hyppopy
kleina moved T28376: Blackbox class - reorder the loss function call try from In Progress to Done on the Hyppopy board.
Apr 21 2021, 3:25 PM · Hyppopy
kleina moved T28298: Check for all print outputs in code base and convert them to log messages from In Progress to Done on the Hyppopy board.
Apr 21 2021, 3:25 PM · Hyppopy
kleina closed T28376: Blackbox class - reorder the loss function call try as Resolved by committing rOBSHYPPOPY5f8b57e426c0: Reordered the loss function call try..
Apr 21 2021, 3:25 PM · Hyppopy
kleina committed rOBSHYPPOPY5f8b57e426c0: Reordered the loss function call try. (authored by kleina).
Reordered the loss function call try.
Apr 21 2021, 3:25 PM
kleina added a revision to T28376: Blackbox class - reorder the loss function call try: Unknown Object (Differential Revision).
Apr 21 2021, 1:21 PM · Hyppopy
kleina committed rOBSHYPPOPYe704bebf3217: Reordered the loss function call try. (authored by kleina).
Reordered the loss function call try.
Apr 21 2021, 1:16 PM
kleina removed a project from T28376: Blackbox class - reorder the loss function call try: Request for Discussion.
Apr 21 2021, 1:13 PM · Hyppopy
kleina moved T28410: MPISolverWrapper's direct call of blackbox internal seems wrong from In Progress to Done on the Hyppopy board.
Apr 21 2021, 1:12 PM · Hyppopy
kleina added a revision to T28410: MPISolverWrapper's direct call of blackbox internal seems wrong: Unknown Object (Differential Revision).
Apr 21 2021, 1:10 PM · Hyppopy
kleina committed rOBSHYPPOPY19e487728222: Converted "print" outputs to "log" outputs. (authored by kleina).
Converted "print" outputs to "log" outputs.
Apr 21 2021, 1:01 PM
kleina moved T28410: MPISolverWrapper's direct call of blackbox internal seems wrong from Done to In Progress on the Hyppopy board.
Apr 21 2021, 12:18 PM · Hyppopy
kleina added a comment to T28376: Blackbox class - reorder the loss function call try.

Your argument makes sense to me. I did not have a specific order in mind when implementing it, so I do not have any counterargument here.

Apr 21 2021, 12:17 PM · Hyppopy
kleina moved T28376: Blackbox class - reorder the loss function call try from Backlog to In Progress on the Hyppopy board.
Apr 21 2021, 12:15 PM · Hyppopy
kleina committed rOBSHYPPOPY7384c8cad833: Changed blackbox call. (authored by kleina).
Changed blackbox call.
Apr 21 2021, 12:06 PM
kleina closed T28298: Check for all print outputs in code base and convert them to log messages as Resolved by committing rOBSHYPPOPY8c13e7810091: Converted "print" outputs to "log" outputs..
Apr 21 2021, 12:06 PM · Hyppopy
kleina committed rOBSHYPPOPY8c13e7810091: Converted "print" outputs to "log" outputs. (authored by kleina).
Converted "print" outputs to "log" outputs.
Apr 21 2021, 12:06 PM
kleina claimed T28455: RT struct 3D visibility is not working correctly.
Apr 21 2021, 11:33 AM · MITK (v2021.10)
kleina triaged T28455: RT struct 3D visibility is not working correctly as Normal priority.
Apr 21 2021, 11:33 AM · MITK (v2021.10)
kleina moved T28455: RT struct 3D visibility is not working correctly from Backlog to Cycle on the MITK (v2021.10) board.
Apr 21 2021, 11:33 AM · MITK (v2021.10)
kleina edited projects for T28455: RT struct 3D visibility is not working correctly, added: MITK (v2021.10); removed MITK.
Apr 21 2021, 11:32 AM · MITK (v2021.10)
kleina added a revision to T28298: Check for all print outputs in code base and convert them to log messages: Unknown Object (Differential Revision).
Apr 21 2021, 9:14 AM · Hyppopy
kleina reopened T28410: MPISolverWrapper's direct call of blackbox internal seems wrong as "Open".

Forgot something and didn't request review correctly. I will open this one agian.

Apr 21 2021, 8:33 AM · Hyppopy

Apr 20 2021

kleina committed rOBSHYPPOPYf1c392fea782: Converted "print" outputs to "log" outputs. (authored by kleina).
Converted "print" outputs to "log" outputs.
Apr 20 2021, 2:40 PM

Apr 19 2021

kleina moved T28332: Support cascaded MPI processing from In Progress to Testing/Evaluations on the Hyppopy board.
Apr 19 2021, 5:23 PM · Hyppopy
kleina added a member for BVM: d587s.
Apr 19 2021, 3:36 PM
kleina added a member for BVM: m813r.
Apr 19 2021, 3:36 PM

Apr 15 2021

kleina committed rOBSHYPPOPYa340b927d14a: * Added alternative loss_function draft, that does not use a callback function. (authored by kleina).
* Added alternative loss_function draft, that does not use a callback function.
Apr 15 2021, 5:22 PM
kleina claimed T28332: Support cascaded MPI processing.

I updated the draft in the branch directly (same file).

Apr 15 2021, 5:02 PM · Hyppopy
kleina moved T28332: Support cascaded MPI processing from Backlog to In Progress on the Hyppopy board.
Apr 15 2021, 4:59 PM · Hyppopy

Apr 9 2021

kleina triaged T28441: Volume Visualization fails for images with segmentations as Normal priority.
Apr 9 2021, 2:03 PM · MITK

Apr 7 2021

kleina committed rOBSHYPPOPY74953c92ecff: Merge branch 'fix/T28410-direct-call-of-blackbox-internal' into dev (authored by kleina).
Merge branch 'fix/T28410-direct-call-of-blackbox-internal' into dev
Apr 7 2021, 3:34 PM
kleina committed rOBSHYPPOPY7e25cd15aafb: Merge branch 'master' into dev (authored by kleina).
Merge branch 'master' into dev
Apr 7 2021, 3:34 PM
kleina committed rOBSHYPPOPY4b872a7644c7: Don't call internal blackbox_func dirctly. Instead we use blackbox.call() now. (authored by kleina).
Don't call internal blackbox_func dirctly. Instead we use blackbox.call() now.
Apr 7 2021, 3:34 PM
kleina moved T28300: [MPI] MPI as a general dependency might be problematic from Backlog to In Progress on the Hyppopy board.
Apr 7 2021, 2:19 PM · Request for Discussion, Hyppopy
kleina moved T28410: MPISolverWrapper's direct call of blackbox internal seems wrong from In Progress to Done on the Hyppopy board.
Apr 7 2021, 2:19 PM · Hyppopy
kleina moved T26148: Integrate virtual energy function for evaluations tasks from In Progress to Done on the Hyppopy board.
Apr 7 2021, 2:19 PM · Hyppopy
kleina closed T28410: MPISolverWrapper's direct call of blackbox internal seems wrong as Resolved.

fixed in https://github.com/MIC-DKFZ/Hyppopy/tree/fix/T28410-direct-call-of-blackbox-internal

Apr 7 2021, 2:18 PM · Hyppopy
kleina added a comment to T28410: MPISolverWrapper's direct call of blackbox internal seems wrong.

I agree with the raised point. I checked the classes again and do not see a valid reason behind the blackbox_func call. I will fix this.

Apr 7 2021, 1:48 PM · Hyppopy
kleina claimed T28410: MPISolverWrapper's direct call of blackbox internal seems wrong.
Apr 7 2021, 1:43 PM · Hyppopy
kleina moved T28410: MPISolverWrapper's direct call of blackbox internal seems wrong from Backlog to In Progress on the Hyppopy board.
Apr 7 2021, 1:43 PM · Hyppopy
kleina added a project to T28410: MPISolverWrapper's direct call of blackbox internal seems wrong: Hyppopy.
Apr 7 2021, 1:43 PM · Hyppopy
kleina moved T28298: Check for all print outputs in code base and convert them to log messages from Backlog to In Progress on the Hyppopy board.
Apr 7 2021, 1:42 PM · Hyppopy
kleina claimed T28298: Check for all print outputs in code base and convert them to log messages.
Apr 7 2021, 1:41 PM · Hyppopy
kleina added a comment to T28356: MITK v2021.02 does not recognize loaded mask as segmentation.

Sorry, I was on vacation.

Apr 7 2021, 9:03 AM · Next Milestone, MITK

Mar 10 2021

kleina updated the task description for T28356: MITK v2021.02 does not recognize loaded mask as segmentation.
Mar 10 2021, 3:29 PM · Next Milestone, MITK
kleina updated the task description for T28356: MITK v2021.02 does not recognize loaded mask as segmentation.
Mar 10 2021, 3:28 PM · Next Milestone, MITK
kleina triaged T28356: MITK v2021.02 does not recognize loaded mask as segmentation as High priority.
Mar 10 2021, 3:27 PM · Next Milestone, MITK

Mar 8 2021

kleina moved T25982: add all hp space modalities loguniform, ... from Backlog to Done on the Hyppopy board.
Mar 8 2021, 9:05 AM · Hyppopy
kleina moved T26086: Fix hard coded paths from Backlog to Done on the Hyppopy board.
Mar 8 2021, 9:05 AM · Hyppopy
kleina moved T26146: restructure gridsearch to be memory safe from Backlog to Done on the Hyppopy board.
Mar 8 2021, 9:05 AM · Hyppopy
kleina moved T26227: Own documentation section for hyper parameter aspects from Backlog to Done on the Hyppopy board.
Mar 8 2021, 9:05 AM · Hyppopy
kleina moved T26226: Different style for frequency definition in the parameter space definition (for grid search and alike) from Backlog to Done on the Hyppopy board.
Mar 8 2021, 9:05 AM · Hyppopy
kleina moved T26096: Add groups to hyperparameter dict structure from Backlog to Done on the Hyppopy board.
Mar 8 2021, 9:05 AM · Hyppopy
kleina moved T26241: VirtualFunction should get better name from Backlog to Done on the Hyppopy board.
Mar 8 2021, 9:05 AM · Hyppopy
kleina moved T26240: File headers are "strange" from Backlog to Done on the Hyppopy board.
Mar 8 2021, 9:05 AM · Hyppopy
kleina moved T26242: Solvers exceptions due to missing hyper parameter configs should be more telling. from Backlog to Done on the Hyppopy board.
Mar 8 2021, 9:04 AM · Hyppopy
kleina moved T26243: Missing number of iterations is not handled if there is an incomplete config section from Backlog to Done on the Hyppopy board.
Mar 8 2021, 9:04 AM · Hyppopy
kleina moved T26325: Add code coverage for hyppopy from Backlog to Done on the Hyppopy board.
Mar 8 2021, 9:04 AM · Hyppopy

Mar 5 2021

kleina accepted rOBSHYPPOPY75cdf9ddd63f: Fixed T28333.

The auto wrapping functionality for MPISolverWrapper looks correct and straightforward to me. A check for function type is already included in the HyppopySolver.

Mar 5 2021, 1:41 PM
kleina added a comment to rOBSHYPPOPYba147fa770ad: Add possibility to pass comm to MPI classes..

I agree. As we already said, we have to work on the mpiplayground anyways and convert it into a propper mpi_example. I will spawn a task for that and include your suggestion there.

Mar 5 2021, 1:36 PM

Feb 11 2021

kleina added a comment to rOBSHYPPOPY1358b14d22f9: Merge branch 'T26755_mpi4hyppopy' of https://github.com/MIC-DKFZ/Hyppopy into….

@kleina I think you should move the mpi playground stuff away from the top level. Examples would be better suited. Don't you think?

Feb 11 2021, 9:42 AM
kleina added a comment to T28300: [MPI] MPI as a general dependency might be problematic.

That makes a lot of sense. I personally like the idea of a "optional dependency" better. I will have a look.

Feb 11 2021, 9:40 AM · Request for Discussion, Hyppopy

Feb 9 2021

kleina updated kleina.
Feb 9 2021, 1:52 PM
kleina added a member for MIC: j038k.
Feb 9 2021, 11:16 AM
kleina added a member for Deep Learning: j038k.
Feb 9 2021, 11:15 AM

Jan 28 2021

kleina committed rOBSHYPPOPY38bf9e41f9e5: Merge branch 'T26755_mpi4hyppopy' (authored by kleina).
Merge branch 'T26755_mpi4hyppopy'
Jan 28 2021, 4:55 PM
kleina committed rOBSHYPPOPYfd1e3a1ce194: Fexed tests. Parameter "normed" was updated to "density" in scipy.stats.norm (authored by kleina).
Fexed tests. Parameter "normed" was updated to "density" in scipy.stats.norm
Jan 28 2021, 4:55 PM
kleina committed rOBSHYPPOPY1a7a0544bf5e: Merge branch 'T26755_mpi4hyppopy' of https://github.com/MIC-DKFZ/Hyppopy into… (authored by kleina).
Merge branch 'T26755_mpi4hyppopy' of https://github.com/MIC-DKFZ/Hyppopy into…
Jan 28 2021, 4:55 PM
kleina committed rOBSHYPPOPY9e0e45582629: removed loss_function_call, which is depricated and was no longer used anyway. (authored by kleina).
removed loss_function_call, which is depricated and was no longer used anyway.
Jan 28 2021, 4:55 PM
kleina committed rOBSHYPPOPY63a9cb87d47e: Merge branch 'T26755_mpi4hyppopy' (authored by kleina).
Merge branch 'T26755_mpi4hyppopy'
Jan 28 2021, 4:55 PM