Page MenuHomePhabricator

MPISolverWrapper's direct call of blackbox internal seems wrong
Closed, ResolvedPublic


Currently the MPISolverWrappercalls directly the loss function in the blackbox. ($111-114)

  loss = self._solver.blackbox.blackbox_func(params)
  loss = self._solver.blackbox.blackbox_func(**params)

It is unclear to me why id did it that way, and not just called aka blackbox().
The direct call of the blackbox_func misses i.a. the passing of data if set in the blackbox. Further it is redundant code, as the also checks for several blackbox_func signatures.

We should discuss and check if it does make sense like it is now. I have the feeling changing it would make much sense. (At least I currently see now argument against it.)

Revisions and Commits

rOBSHYPPOPY Hyppopy (Observed Repository)
Restricted Differential Revision
Restricted Differential Revision

Event Timeline

floca triaged this task as High priority.Mar 25 2021, 11:04 PM
floca created this task.
floca renamed this task from MPISolverWrapperdirect call of blackbox internal seems wrong to MPISolverWrapper's direct call of blackbox internal seems wrong.Mar 25 2021, 11:14 PM
kleina added a project: Hyppopy.
kleina moved this task from Backlog to In Progress on the Hyppopy board.

I agree with the raised point. I checked the classes again and do not see a valid reason behind the blackbox_func call. I will fix this.

Forgot something and didn't request review correctly. I will open this one agian.

kleina added a revision: Restricted Differential Revision.Apr 21 2021, 1:10 PM