Page MenuHomePhabricator

[SEG] segmentation view ends up in invalid state if segmentations are loaded before images
Closed, ResolvedPublic

Description

if data is loaded in the "wrong" order, the segmentationview ends up in invalid states (e.g. labels are not shown, or wrong labels).

How to reproduce:

  • emtpy workspace
  • open segmentation view
  • Load a multilabel segmentation file
  • Load a fitting image
  • The layer and the label widgets are not correctly filled (see picture; the have no content besides the buttons), interactions of tools do not work.

grafik.png (359×525 px, 22 KB)

Revisions and Commits

rMITK MITK
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision

Related Objects

Event Timeline

floca triaged this task as Unbreak Now! priority.Oct 10 2022, 5:33 PM
floca created this task.
floca updated the task description. (Show Details)

Looking at the code I noticed that there are quite a few possibilities to trigger invalid states which all have in common, that the selection of the reference image or working image are handled separately while neglecting the overall selection situation. I will refactor the two OnSelection handlers into a common one that can assess the overall situation without duplicating logic. This will also fix a few other bugs and will also enable to use the layer, label, and label set widgets when only a working image is selected. This is totally fine as all actions these widgets provide are independent from a reference image.

kislinsk added a revision: Restricted Differential Revision.Oct 13 2022, 4:51 PM

Deleted branch from rMITK MITK: bugfix/T29353-InvalidSegmentationViewStates.