Page MenuHomePhabricator
Create Task
Maniphest T29603

Warn (as error) in Visual Studio for unreferenced parameters and variables to match our GCC/Clang settings
Closed, WontfixPublic
Actions

Description

Most build fails we have in Differential that do not occur in Visual Studio but on any other platform are related to unused parameters and variables. Enable them for Visual Studio as well to save a lot of time and resources.

Revisions and Commits

Restricted Differential Revision

Event Timeline

kislinsk triaged this task as Normal priority.May 12 2023, 11:30 AM
kislinsk created this task.
kislinsk added a revision: Restricted Differential Revision.May 12 2023, 11:36 AM
kislinsk added a comment.May 12 2023, 12:39 PM

Additional checks necessary:

  • CMake version >= 3.24 (the feature was added before but didn't work until v3.24)
  • Visual Studio 2019 version >= 16.11 (according to MS 16.10 but CMake states 16.11 as minimum version)
kislinsk added a comment.May 12 2023, 12:54 PM

Pushed new branch to rMITK MITK: bugfix/T29603-MatchVisualStudioCompilerErrorsBetterToGCCAndClang.

kislinsk added a comment.May 12 2023, 12:55 PM

There seems to be still issues with CMake 3.26.3 regarding include directories of Qt 5. Seems like we have to be more patient if that's an issue for our purpose.

kislinsk closed this task as Wontfix.May 31 2023, 3:16 PM
kislinsk added a comment.Jun 19 2024, 11:28 AM

Deleted branch from rMITK MITK: bugfix/T29603-MatchVisualStudioCompilerErrorsBetterToGCCAndClang.

MITK · MIC · IMSY · DKFZ