Page MenuHomePhabricator
Create Task
Maniphest T30456

Upgrade ITK from v5.4 RC2 to v5.4.0
Closed, ResolvedPublic
Actions

Description

It seems like the minor upgrade will get rid of the CMake v3.28 issue on Windows.

A trivial bug needs to be fixed in MatchPoint, where a wrong class name was C&Ped into an ITK class macro that now complains with a static assert.

Revisions and Commits

rMITK MITK
Restricted Differential RevisionrMITK5f362d09ac17 Upgrade ITK from v5.4 RC 2 to v5.4.0
Restricted Differential RevisionrMITKf2261e100c19 Migrate MatchPoint to latest ITK upgrade
Restricted Differential RevisionrMITKfad30d88c5b6 Fix class names in itkTypeMacro for Exception class
Restricted Differential RevisionrMITK61a75c9e9d52 Use ITK's Eigen instead of a separate dependency
Restricted Differential RevisionrMITK2ef3ea1e6945 Make MatchPoint compatible to Ubuntu 20.04 and 22.04

Related Objects

Event Timeline

kislinsk triaged this task as High priority.Jun 3 2024, 1:08 PM
kislinsk created this task.
kislinsk mentioned this in rMP6a425290639f: Merge branch 'T30456-FixWrongClassNameInITKMacro'.Jun 3 2024, 1:11 PM
kislinsk added a comment.Jun 3 2024, 1:13 PM

I fixed MatchPoint with rMP6a425290639f: Merge branch 'T30456-FixWrongClassNameInITKMacro'.

kislinsk added a comment.Jun 3 2024, 1:45 PM

Pushed new branch to rMITK MITK: bugfix/T30456-UpgradeITK.

kislinsk added a comment.Jun 3 2024, 2:22 PM

ITK's Eigen interferes with our separate external dependency, so I will remove our own and change the dependencies to ITK's Eigen, which is just fine regarding its version.

kislinsk added a comment.EditedJun 3 2024, 2:24 PM

Migration:

  • Instead of depending on Eigen, depend on ITK|ITKEigen3.
  • Prefix header paths with itkeigen/, e.g. itkeigen/Eigen/Dense instead of Eigen/Dense
kislinsk added a revision: Restricted Differential Revision.Jun 3 2024, 2:40 PM
kislinsk mentioned this in rMP56957430a6a1: Merge branch 'T30456-RemoveFormatHeader'.Jun 4 2024, 8:12 AM
kislinsk mentioned this in rMITK949901083140: Merge branch 'bugfix/T30456-UpgradeITK' into develop.Jun 4 2024, 10:17 AM
kislinsk added a commit: rMITK2ef3ea1e6945: Make MatchPoint compatible to Ubuntu 20.04 and 22.04.
kislinsk added a commit: rMITK61a75c9e9d52: Use ITK's Eigen instead of a separate dependency.
kislinsk added a commit: rMITKfad30d88c5b6: Fix class names in itkTypeMacro for Exception class.
kislinsk added a commit: rMITKf2261e100c19: Migrate MatchPoint to latest ITK upgrade.
kislinsk added a commit: rMITK5f362d09ac17: Upgrade ITK from v5.4 RC 2 to v5.4.0.
kislinsk added a comment.Jun 4 2024, 10:17 AM

Deleted branch from rMITK MITK: bugfix/T30456-UpgradeITK.

kislinsk closed this task as Resolved.Jun 4 2024, 10:17 AM
kislinsk mentioned this in T30470: 2024 Week 24 (Mid June).Jun 14 2024, 12:43 AM
MITK · MIC · IMSY · DKFZ