Page MenuHomePhabricator

QmitkVtkLineProfileWidget and QmitkVtkHistogramWidget derive both from QDialog and itk::Object
Closed, ResolvedPublic

Description

QmitkVtkLineProfileWidget and QmitkVtkHistogramWidget derive both from QDialog and itk::Object. That leads to problems when e.g. closing QmitkImageStatisticsView (cf. T3475). What was the intension of this double derivation?

Event Timeline

The derivation from itk::Object does not seem necessary.

It currently is, since ITK set/get macros are used, and this->Modified() is called a few times. This is however not made use of and it should be possible to remove this without problems (rewrite set/get methods without macros, remove this->Modified() calls)

Ok, I'll fix that. Changed assignee and added party tag.

[SVN revision 22209]
FIX (#3504): removed inheritance of itk::Object and adapted Set/GetMethods and exceptions

[SVN revision 22212]
COMP (#3504): use std::invalid_argument instead of std::exception, because std::exception has no constructor taking char as parameters