Page MenuHomePhabricator
Create Task
Maniphest T5327

Double action execution after AcREMOVEALL in PointSetInteractor
Closed, ResolvedPublic
Actions

Description

The case AcREMOVEALL in method mitkPiointSetInteractor::ExecuteAction() does not set the return parameter so false is returned from the selected (this) statemachine. GlobalInteraction then fills the list of possible statemachines and asks this statemachine again. In both cases the actions were successfully executed.
This bug slows down the interaction of the statemachine pattern singlepointinteractorwithoutshiftclick and of all other PointSetInteractor patterns that call AcREMOVEALL.

Bug can be resolved by setting returnparameter "ok" to true after removing all points.

Event Timeline

wegner added projects: MITK, Bugzilla.Sep 13 2010, 9:51 AM
muellerm added a subscriber: muellerm.Sep 13 2010, 2:04 PM

ingmar can you please add a patch with your changes?

muellerm added a comment.Sep 13 2010, 2:05 PM

... including the test case?

wegner added a subscriber: wegner.Sep 13 2010, 3:19 PM

patch for 5327 including changes

5327.patch13 KBDownload

wegner added a comment.Sep 13 2010, 3:20 PM

As written in the scpecification page a test can't check for this bug. The methods got executed two times with success, checking this doesn't really make sense. But I extended mitkPointSetINteractorTest to also check this pattern (see patch).

wegner added a comment.Sep 13 2010, 3:33 PM

...or at least the interface doesn't allow to test this case... ;)

wegner added a comment.Sep 14 2010, 10:01 AM

[SVN revision 26074]
FIX (#5327): fixing bug in Action AcREMOVEALL (wrong return statement), testing singlepointinteractorwithoutshiftclick pattern in mitkPointSetInteractorTest and cleaning up pattern

MITK · MIC · IMSY · DKFZ