update
Concern Raised0dd5b03404fb
Actions

Description

update

Auditors

Provenance

• kausch	Authored on Sep 28 2018, 12:49 PM
• kausch	Pushed on Sep 28 2018, 10:50 AM

Parents

Branches

Unknown

Tags

Unknown

floca raised a concern with this commit.Sep 28 2018, 12:22 PM

floca added a subscriber: floca.

floca added inline comments.

/Modules/Core/src/Rendering/vtkMitkThickSlicesFilter.cpp
322	can be removed
/Modules/QtWidgets/src/QmitkRenderWindowMenu.cpp
798	Why must this be static?
827–844	Just remove commented out code
989–992	Ensure if the widget boundary is enough (as started with maximum). If this is the case, completly remove the bondary checks here. They are redundant.
991–992	remove it

This commit now has outstanding concerns.Sep 28 2018, 12:22 PM

• kausch marked 2 inline comments as done.Sep 28 2018, 2:28 PM

• kausch added inline comments.

/Modules/QtWidgets/src/QmitkRenderWindowMenu.cpp
798	I used static because then the variable is instantiated only on the first call, if the reslice.thickness property is changed this mode should be new default mode for num>0
991–992	The reslice.thickness.num property, sets the value of the slider but the slider is connected afterwards to its action. That means currently the view is not updated when the slice number is changed in the properties. Not sure why it's done this way.