Diffusion MITK 2bc40635a1fc

Fixed T27266
2bc40635a1fc
Actions

Description

Fixed T27266

Summary:
Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Removed some deprecated internals

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Fixed T27441

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Test Plan: Review, unit test and Check in Workbench (load PF without views opened)

Reviewers: O3 MITK Reviewer Group II, O1 MITK Reviewer Group I, kislinsk

Reviewed By: O3 MITK Reviewer Group II, O1 MITK Reviewer Group I, kislinsk

Maniphest Tasks: T27266, T27441

Differential Revision: https://phabricator.mitk.org/D305

Details

Provenance

floca	Authored on May 24 2020, 11:57 AM
floca	Pushed on May 24 2020, 8:21 PM

Reviewer

O3: MITK Reviewer Group II

Differential Revision

Restricted Differential Revision

Parents

rMITK7939c3fd2826: Adde private dependency that is missing after PlanarFigure IO refactoring
rMITKcfe5ef0b4943: Fixed T27416

Branches

Unknown

Tags

Unknown

Tasks

T27441: PlanarFigure clone is in invalid state due to copy of unmanged/uncontrolled pointer for PlaneGeometry
T27266: [Image Statistics] Planar figures cannot be read or written until one of the quantification views is open

Event Timeline

floca committed rMITK2bc40635a1fc: Fixed T27266 (authored by floca).May 24 2020, 8:21 PM

floca added an edge: Restricted Differential Revision.

floca added a task: T27441: PlanarFigure clone is in invalid state due to copy of unmanged/uncontrolled pointer for PlaneGeometry.

floca added a task: T27266: [Image Statistics] Planar figures cannot be read or written until one of the quantification views is open.

Merged Changes

7939c3fd2826 Adde private dependency that is missing after PlanarFigure IO refactoring
Author
floca
Browse Repository
No Builds
No Audits
c46a6fd291ff Fixed T27441
Author
floca
Browse Repository
No Builds
No Audits
4a45ecf98627 Removed some deprecated internals
Author
floca
Browse Repository
No Builds
No Audits
77f3b11d8239 Fixed T27266
Author
floca
Browse Repository
No Builds
No Audits

Changes (36)

Path

Size

Packages

Modules/

MatchPointRegistration/

mitkMAPRegistrationWrapperObjectFactory.cpp

O3: MITK Reviewer Group II

mitkMAPRegistrationWrapperObjectFactory.h

O3: MITK Reviewer Group II

Multilabel/

autoload/

IO/

CMakeLists.txt

O1: MITK Reviewer Group I

mitkMultilabelObjectFactory.cpp

O1: MITK Reviewer Group I

mitkMultilabelObjectFactory.h

O1: MITK Reviewer Group I

PlanarFigure/

CMakeLists.txt

O1: MITK Reviewer Group I

autoload

O1: MITK Reviewer Group I

CMakeLists.txt

O1: MITK Reviewer Group I

files.cmake

O1: MITK Reviewer Group I

mitkPlanarFigureIO.cpp

O1: MITK Reviewer Group I

mitkPlanarFigureIO.h

O1: MITK Reviewer Group I

	autoload/	IO/
	src/	IO/

mitkPlanarFigureSerializer.cpp

O1: MITK Reviewer Group I

mitkPlanarFigureSerializer.h

O1: MITK Reviewer Group I

mitkPlanarFigureSubclassesSerializer.cpp

O1: MITK Reviewer Group I

files.cmake

O1: MITK Reviewer Group I

include/

mitkPlanarFigureObjectFactory.h

O1: MITK Reviewer Group I

mitkPlanarFigureReader.h

O1: MITK Reviewer Group I

mitkPlanarFigureWriter.h

O1: MITK Reviewer Group I

src/

Algorithms/

mitkPlanarFigureObjectFactory.cpp

O1: MITK Reviewer Group I

DataManagement/

mitkPlanarFigure.cpp

O1: MITK Reviewer Group I

mitkPlanarFigureIOFactory.cpp

O1: MITK Reviewer Group I

mitkPlanarFigureIOFactory.h

O1: MITK Reviewer Group I

mitkPlanarFigureReader.cpp

O1: MITK Reviewer Group I

mitkPlanarFigureSerializer.cpp

O1: MITK Reviewer Group I

mitkPlanarFigureSerializer.h

O1: MITK Reviewer Group I

mitkPlanarFigureSubclassesSerializer.cpp

O1: MITK Reviewer Group I

mitkPlanarFigureWriter.cpp

O1: MITK Reviewer Group I

mitkPlanarFigureWriterFactory.cpp

O1: MITK Reviewer Group I

mitkPlanarFigureWriterFactory.h

O1: MITK Reviewer Group I

test/

mitkPlanarFigureIOTest.cpp

O1: MITK Reviewer Group I

mitkPlanarFigureInteractionTest.cpp

O1: MITK Reviewer Group I

	PlanarFigure/	autoload/	IO/
	Multilabel/	autoload/	IO/

	mitkPlanarFigureIOActivator.cpp
	mitkMultilabelActivator.cpp

O1: MITK Reviewer Group I

QtWidgetsExt/

CMakeLists.txt

O3: MITK Reviewer Group II

US/

CMakeLists.txt

rMITK2bc40635a1fc

View Options

Modules/MatchPointRegistration/mitkMAPRegistrationWrapperObjectFactory.cpp

View Options

Modules/MatchPointRegistration/mitkMAPRegistrationWrapperObjectFactory.h

View Options

Modules/Multilabel/autoload/IO/CMakeLists.txt

View Options

Modules/Multilabel/mitkMultilabelObjectFactory.cpp

View Options

Modules/Multilabel/mitkMultilabelObjectFactory.h

View Options

Modules/PlanarFigure/CMakeLists.txt

View Options

Modules/PlanarFigure/autoload/IO/CMakeLists.txt

View Options

Modules/PlanarFigure/autoload/IO/files.cmake

View Options

Modules/PlanarFigure/autoload/IO/mitkPlanarFigureIO.cpp

View Options

Modules/PlanarFigure/autoload/IO/mitkPlanarFigureIO.h

View Options

Modules/PlanarFigure/autoload/IO/mitkPlanarFigureIOActivator.cpp

View Options

Modules/PlanarFigure/autoload/IO/mitkPlanarFigureSerializer.cpp

View Options

Modules/PlanarFigure/autoload/IO/mitkPlanarFigureSerializer.h

View Options

Modules/PlanarFigure/autoload/IO/mitkPlanarFigureSubclassesSerializer.cpp

View Options

Modules/PlanarFigure/files.cmake

View Options

Modules/PlanarFigure/include/mitkPlanarFigureObjectFactory.h

View Options

Modules/PlanarFigure/include/mitkPlanarFigureReader.h

View Options

Modules/PlanarFigure/include/mitkPlanarFigureWriter.h

View Options

Modules/PlanarFigure/src/Algorithms/mitkPlanarFigureObjectFactory.cpp

View Options

Modules/PlanarFigure/src/DataManagement/mitkPlanarFigure.cpp

View Options

Modules/PlanarFigure/src/IO

View Options

Modules/PlanarFigure/src/IO/mitkPlanarFigureIOFactory.cpp

View Options

Modules/PlanarFigure/src/IO/mitkPlanarFigureIOFactory.h

View Options

Modules/PlanarFigure/src/IO/mitkPlanarFigureReader.cpp

View Options

Modules/PlanarFigure/src/IO/mitkPlanarFigureSerializer.cpp

View Options

Modules/PlanarFigure/src/IO/mitkPlanarFigureSerializer.h

View Options

Modules/PlanarFigure/src/IO/mitkPlanarFigureSubclassesSerializer.cpp

View Options

Modules/PlanarFigure/src/IO/mitkPlanarFigureWriter.cpp

View Options

Modules/PlanarFigure/src/IO/mitkPlanarFigureWriterFactory.cpp

View Options

Modules/PlanarFigure/src/IO/mitkPlanarFigureWriterFactory.h

View Options

Modules/PlanarFigure/test/mitkPlanarFigureIOTest.cpp

View Options

Modules/PlanarFigure/test/mitkPlanarFigureInteractionTest.cpp

View Options

Modules/QtWidgetsExt/CMakeLists.txt

View Options

Fixed T272662bc40635a1fcActions

Description

Details

Event Timeline

Merged Changes

Changes (36)

rMITK2bc40635a1fc

Modules/MatchPointRegistration/mitkMAPRegistrationWrapperObjectFactory.cpp

Modules/MatchPointRegistration/mitkMAPRegistrationWrapperObjectFactory.h

Modules/Multilabel/autoload/IO/CMakeLists.txt

Modules/Multilabel/mitkMultilabelObjectFactory.cpp

Modules/Multilabel/mitkMultilabelObjectFactory.h

Modules/PlanarFigure/CMakeLists.txt

Modules/PlanarFigure/autoload/IO/CMakeLists.txt

Modules/PlanarFigure/autoload/IO/files.cmake

Modules/PlanarFigure/autoload/IO/mitkPlanarFigureIO.cpp

Modules/PlanarFigure/autoload/IO/mitkPlanarFigureIO.h

Modules/PlanarFigure/autoload/IO/mitkPlanarFigureIOActivator.cpp

Modules/PlanarFigure/autoload/IO/mitkPlanarFigureSerializer.cpp

Modules/PlanarFigure/autoload/IO/mitkPlanarFigureSerializer.h

Modules/PlanarFigure/autoload/IO/mitkPlanarFigureSubclassesSerializer.cpp

Modules/PlanarFigure/files.cmake

Modules/PlanarFigure/include/mitkPlanarFigureObjectFactory.h

Modules/PlanarFigure/include/mitkPlanarFigureReader.h

Modules/PlanarFigure/include/mitkPlanarFigureWriter.h

Modules/PlanarFigure/src/Algorithms/mitkPlanarFigureObjectFactory.cpp

Modules/PlanarFigure/src/DataManagement/mitkPlanarFigure.cpp

Modules/PlanarFigure/src/IO

Modules/PlanarFigure/src/IO/mitkPlanarFigureIOFactory.cpp

Modules/PlanarFigure/src/IO/mitkPlanarFigureIOFactory.h

Modules/PlanarFigure/src/IO/mitkPlanarFigureReader.cpp

Modules/PlanarFigure/src/IO/mitkPlanarFigureSerializer.cpp

Modules/PlanarFigure/src/IO/mitkPlanarFigureSerializer.h

Modules/PlanarFigure/src/IO/mitkPlanarFigureSubclassesSerializer.cpp

Modules/PlanarFigure/src/IO/mitkPlanarFigureWriter.cpp

Modules/PlanarFigure/src/IO/mitkPlanarFigureWriterFactory.cpp

Modules/PlanarFigure/src/IO/mitkPlanarFigureWriterFactory.h

Modules/PlanarFigure/test/mitkPlanarFigureIOTest.cpp

Modules/PlanarFigure/test/mitkPlanarFigureInteractionTest.cpp

Modules/QtWidgetsExt/CMakeLists.txt

Modules/US/CMakeLists.txt

Fixed T27266
2bc40635a1fc
Actions