HomePhabricator
Diffusion MITK 3556308125b3

Created new ui, where you can choose a threshold, and apply a filter.

Description

Created new ui, where you can choose a threshold, and apply a filter. Refactored code in modules and plugins.

Details

Provenance
lahaAuthored on Jul 19 2017, 5:29 PM
lahaPushed on Jul 19 2017, 5:29 PM
Parents
rMITKd30705972b35: Signed-off-by: Angelika Laha <a.laha@dkfz-heidelberg.de>
Branches
Unknown
Tags
Unknown

Event Timeline

kislinsk added inline comments.
/Modules/PhotoacousticArtifacts/include/mitkPhotoacousticArtifact.h
47

Doesn't need to be virtual as this class is marked as final. Only makes sense if someone would derive from this class.

/Modules/PhotoacousticArtifacts/src/Algorithms/mitkPhotoacousticArtifact.cpp
30–31

I think this will not compile with GCC/Clang. When there's another template in a typedef, you need to tell the compiler that it is a typename:

typedef typename itk::Image<TPixel, VImageDimension> ImageType;
typedef typename itk::ShiftScaleImageFilter<ImageType, ImageType> FilterType;

Guess we have to fix this in the ProjectTemplate as well.

49

Forgotten output? :-)

/Plugins/org.mitk.gui.qt.photoacousticartifacts/src/internal/PhotoacousticArtifact.cpp
116–131

Prefer to delete such code unless you really need it for reference later.