HomePhabricator
Diffusion MITK 7cfb5d5d7209

Description

Fixed T27259

Summary:
It is still the problem explained in https://phabricator.mitk.org/T24766#131411.

I have thought about different possibilities to solve it; e.g.

  1. Ensure that we have no collapsed final time steps.
  2. Support infinite time bounds for the last time bounds.
  3. Introduce the support of the corner case of a collapsed final time step in ArbitratyTimeGeometry. In this case we accept time points as valid and within the last time step if the equal the max time bound

Option 1 I have dismissed, because it would mean to introduce a rule to deduce the duration of the last time step for most dynamic DICOM images as it is not stored. This is not trivial and can introduce new pit falls (and we somehow alter the dicom data which is also not good). 
Option 2 I have dismissed, as for dicom it is just a special version of option 1 with all strings attached.  And DICOM images are what causes the pain right now.

So I have opted for option 3 to fix T27259. It seems the minimal invasive but still acceptable clean solution for the problem.

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Test Plan: review, unit test and application test (see T27259)

Reviewers: O1 MITK Reviewer Group I, kislinsk

Reviewed By: O1 MITK Reviewer Group I, kislinsk

Subscribers: kislinsk

Maniphest Tasks: T27259

Differential Revision: https://phabricator.mitk.org/D314

Details

Provenance
flocaAuthored on Jun 2 2020, 5:53 PM
flocaPushed on Jun 2 2020, 6:49 PM
Reviewer
O1: MITK Reviewer Group I
Differential Revision
Restricted Differential Revision
Parents
rMITK0c760db11818: Fixed typo
rMITKefba18f80b67: Fixed unit test for T27200
Branches
Unknown
Tags
Unknown
Tasks
T27259: Render windows are not updated when last time step is selected