HomePhabricator
Diffusion MITK 861611779b17

start to rework PropertyRelationRuleBase

Description

start to rework PropertyRelationRuleBase

Summary:
Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Merge branch 'master' into T25807-Generalize_PropertyRelationRuleBase

  1. Conflicts:
  2. Modules/Core/src/DataManagement/mitkPropertyRelationRuleBase.cpp

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Generalization done.

Open Todo:

  • Check unit test
  • Add test of abstract rule behavior

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Fixed all old tests.

Open todo: Tests for abstract rule mode

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Fixed T25807

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Fixed StatisitcManager test

T24729 was no also problematic in other routines. Fixed/refactored that workarround code.

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Test Plan: unit tests

Reviewers: MITK Reviewer Group I, kislinsk

Reviewed By: MITK Reviewer Group I, kislinsk

Subscribers: kislinsk

Maniphest Tasks: T25807

Differential Revision: https://phabricator.mitk.org/D187

Details

Provenance
flocaAuthored on Mar 5 2019, 2:43 PM
flocaPushed on Mar 5 2019, 3:20 PM
Reviewer
MITK Reviewer Group I
Differential Revision
Restricted Differential Revision
Parents
rMITKd4b18d4fbe22: Merge branch 'T26100-FixOrderOfVariables'
Branches
Unknown
Tags
Unknown
Tasks
Restricted Maniphest Task

Event Timeline