Fix weak pointer usage
9235478ae848
Actions

Description

Fix weak pointer usage

Summary:
Fix expiry checks before actual use of objects referenced by mitk::WeakPointer or berry::WeakPointer.

A call to .IsExpired() or .Expired() does not guarantee that the reference is still valid after the check.
Actually .Lock() the pointer and check against null to ensure valid pointers.

Fix weak pointer usage9235478ae848Actions

Description

Details

Event Timeline

Merged Changes

Changes (56)

rMITK9235478ae848

Examples/Plugins/org.mitk.example.gui.imaging/src/internal/colourimageprocessing/QmitkColourImageProcessingView.cpp

Examples/Plugins/org.mitk.example.gui.imaging/src/internal/volumetry/QmitkVolumetryView.cpp

Modules/AlgorithmsExt/src/mitkSegmentationSink.cpp

Modules/Core/src/DataManagement/mitkNodePredicateFirstLevel.cpp

Modules/Core/src/Interactions/mitkDataInteractor.cpp

Modules/Core/src/Interactions/mitkDispatcher.cpp

Modules/Core/src/Interactions/mitkDisplayActionEventHandler.cpp

Modules/Core/src/Rendering/mitkPlaneGeometryDataVtkMapper3D.cpp

Modules/DICOM/src/mitkDICOMImageBlockDescriptor.cpp

Modules/QtWidgets/include/QmitkAbstractDataStorageModel.h

Modules/QtWidgets/src/QmitkAbstractDataStorageInspector.cpp

Modules/QtWidgets/src/QmitkAbstractDataStorageModel.cpp

Modules/QtWidgets/src/QmitkDataStorageComboBox.cpp

Modules/QtWidgets/src/QmitkDataStorageDefaultListModel.cpp

Modules/QtWidgets/src/QmitkDataStorageHistoryModel.cpp

Modules/QtWidgets/src/QmitkDataStorageSimpleTreeModel.cpp

Modules/QtWidgets/src/QmitkDataStorageTableModel.cpp

Modules/QtWidgets/src/QmitkDataStorageTreeModel.cpp

Modules/QtWidgets/src/QmitkPropertiesTableModel.cpp

Modules/QtWidgets/src/QmitkPropertyItemDelegate.cpp

Modules/QtWidgets/src/QmitkPropertyItemModel.cpp

Modules/QtWidgetsExt/src/QmitkPointListViewWidget.cpp

Modules/RenderWindowManagerUI/include/QmitkRenderWindowDataStorageListModel.h

Modules/RenderWindowManagerUI/include/QmitkRenderWindowDataStorageTreeModel.h

Modules/RenderWindowManagerUI/src/QmitkDataStorageLayerStackModel.cpp

Modules/RenderWindowManagerUI/src/QmitkRenderWindowDataStorageInspector.cpp

Modules/RenderWindowManagerUI/src/QmitkRenderWindowDataStorageListModel.cpp

Modules/RenderWindowManagerUI/src/QmitkRenderWindowDataStorageTreeModel.cpp

Modules/Segmentation/Controllers/mitkToolManager.cpp

Modules/Segmentation/Controllers/mitkToolManager.h

Modules/SemanticRelations/src/mitkSemanticRelationsDataStorageAccess.cpp

Modules/SemanticRelationsUI/src/QmitkLesionTreeModel.cpp

Modules/SemanticRelationsUI/src/QmitkPatientTableInspector.cpp

Modules/SemanticRelationsUI/src/QmitkStatisticsCalculator.cpp

Modules/SemanticRelationsUI/src/QmitkStatisticsTreeModel.cpp

Plugins/org.mitk.gui.qt.application/src/QmitkAbstractDataNodeAction.cpp

Plugins/org.mitk.gui.qt.application/src/QmitkDataNodeContextMenu.cpp

Plugins/org.mitk.gui.qt.application/src/QmitkDataNodeGlobalReinitAction.cpp

Plugins/org.mitk.gui.qt.application/src/QmitkDataNodeReinitAction.cpp

Plugins/org.mitk.gui.qt.application/src/QmitkDataNodeRemoveAction.cpp

Plugins/org.mitk.gui.qt.application/src/QmitkDataNodeShowSelectedNodesAction.cpp

Plugins/org.mitk.gui.qt.application/src/QmitkDataNodeToggleVisibilityAction.cpp

Plugins/org.mitk.gui.qt.application/src/QmitkFileSaveAction.cpp

Plugins/org.mitk.gui.qt.common/src/QmitkNodeSelectionDialog.cpp

Plugins/org.mitk.gui.qt.datamanager/src/internal/QmitkNodeTableViewKeyFilter.cpp

Plugins/org.mitk.gui.qt.ext/src/QmitkExtWorkbenchWindowAdvisor.cpp

Plugins/org.mitk.gui.qt.flowapplication/src/internal/QmitkFlowApplicationWorkbenchWindowAdvisor.cpp

Plugins/org.mitk.gui.qt.semanticrelations/src/internal/QmitkDataNodeAddToSemanticRelationsAction.cpp

Plugins/org.mitk.gui.qt.semanticrelations/src/internal/QmitkDataNodeRemoveFromSemanticRelationsAction.cpp

Plugins/org.mitk.gui.qt.semanticrelations/src/internal/QmitkDataNodeSetControlPointAction.cpp

Plugins/org.mitk.gui.qt.semanticrelations/src/internal/QmitkDataNodeSetInformationTypeAction.cpp

Plugins/org.mitk.gui.qt.semanticrelations/src/internal/QmitkDataSetOpenInAction.cpp

Plugins/org.mitk.gui.qt.semanticrelations/src/internal/QmitkFocusOnLesionAction.cpp

Plugins/org.mitk.gui.qt.semanticrelations/src/internal/QmitkLabelSetJumpToAction.cpp

Plugins/org.mitk.gui.qt.semanticrelations/src/internal/QmitkLesionInfoWidget.cpp

Plugins/org.mitk.gui.qt.volumevisualization/src/internal/QmitkVolumeVisualizationView.cpp

Fix weak pointer usage
9235478ae848
Actions