HomePhabricator
Diffusion MITK db73d5cf65f9

Fix: Some more catch-by-reference.
Auditeddb73d5cf65f9
Actions

Description

Fix: Some more catch-by-reference.

Details

Auditors
kislinsk
Provenance
• hettichAuthored on Nov 9 2018, 5:16 PM
• hettichPushed on Nov 9 2018, 5:17 PM
Parents
rMITKfeb991aee298: Merge branch 'personal/hettich/BetaV2018q4_catch-by-reference' of https…
Branches
Unknown
Tags
Unknown
References
personal/hettich/BetaV2018q4_catch-by-reference

Event Timeline

• hettich committed rMITKdb73d5cf65f9: Fix: Some more catch-by-reference. (authored by • hettich).Nov 9 2018, 5:16 PM
kislinsk raised a concern with this commit.Nov 13 2018, 10:21 AM
kislinsk added a subscriber: kislinsk.
kislinsk added inline comments.
/Modules/DiffusionImaging/DiffusionCore/Testing/mitkImageReconstructionTest.cpp
138

const ref

143

const ref

/Modules/DiffusionImaging/DiffusionCore/autoload/IO/mitkNrrdOdfImageWriter.cpp
107

Why? Was already const ref.

/Modules/DiffusionImaging/DiffusionCore/autoload/IO/mitkShImageWriter.cpp
75

Why? Was already const ref.

/Plugins/org.mitk.gui.qt.segmentation/src/internal/QmitkSegmentationView.cpp
270

const ref

This commit now has outstanding concerns.Nov 13 2018, 10:21 AM
kislinsk accepted this commit.Nov 13 2018, 10:51 AM
All concerns with this commit have now been addressed.Nov 13 2018, 10:51 AM

Changes (4)

PathSizePackages
Modules/
DiffusionImaging/
DiffusionCore/
Testing/
autoload/
IO/
Plugins/
org.mitk.gui.qt.segmentation/
src/
internal/
O1: MITK Reviewer Group I

rMITKdb73d5cf65f9

View Options

Modules/DiffusionImaging/DiffusionCore/Testing/mitkImageReconstructionTest.cpp

Loading...
View Options

Modules/DiffusionImaging/DiffusionCore/autoload/IO/mitkNrrdOdfImageWriter.cpp

Loading...
View Options

Modules/DiffusionImaging/DiffusionCore/autoload/IO/mitkShImageWriter.cpp

Loading...
View Options

Plugins/org.mitk.gui.qt.segmentation/src/internal/QmitkSegmentationView.cpp

Loading...
MITK · MIC · IMSY · DKFZ