HomePhabricator
Diffusion RTTB 1305b3f0ca8e

Refactoring and documentation
Concern Raised1305b3f0ca8e
Actions

This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Refactoring and documentation

Details

Auditors
hentsch
Provenance
• strubelpAuthored on Jun 7 2017, 4:30 PM
• strubelpPushed on Jun 9 2017, 1:43 PM

Event Timeline

• strubelp committed rRTTB1305b3f0ca8e: Refactoring and documentation (authored by • strubelp).Jun 9 2017, 11:06 AM
hentsch raised a concern with this commit.Jun 12 2017, 4:53 PM
hentsch added a subscriber: hentsch.

Sehr gute Arbeit!
Ich würde dich noch bitten, etwas ausführlichere Doku zu schreiben:

  • jede Klasse dokumentieren
  • jede public funktion in DoseToVolumeMeasure und VolumeToDoseMeasure dokumentieren (es sei denn, sie sind selbsterklärend)
/code/algorithms/rttbMaxOHxVolumeToDoseMeasureCalculator.h
41

gibts einen Grund dafür, warum du die zu protected geändert hast?

This commit now has outstanding concerns.Jun 12 2017, 4:53 PM

Commit No Longer Exists

This commit no longer exists in the repository.
MITK · MIC · IMSY · DKFZ