User Details
User Details
- User Since
- Aug 1 2016, 12:10 PM (435 w, 4 d)
May 29 2019
May 29 2019
hentsch committed rMITK4d4bbd1e4227: Merge branch 'T25401-DCMQIParametricMapsIntegration' (authored by hentsch).
Merge branch 'T25401-DCMQIParametricMapsIntegration'
fixed renaming issue
hentsch renamed T26367: [ModelFitInspector] Remove bookmark doesn't work from Remove bookmark doesn't work to [ModelFitInspector] Remove bookmark doesn't work.
hentsch triaged T26368: [ModelFitInspector] Performance if multiple bookmark points are added as Normal priority.
hentsch added a comment to T25832: Migrate ModelFit inspector plugin to MitkChart.
GCC compiles also fine
May 24 2019
May 24 2019
hentsch added a comment to T25832: Migrate ModelFit inspector plugin to MitkChart.
all functions implemented, just need to test compiling with GCC
removed unused code
hentsch committed rMITK017b30053f81: saved xAxisLabel/yAxisLabel and retain color while changing data (authored by hentsch).
saved xAxisLabel/yAxisLabel and retain color while changing data
Implemented resetting minMaxValue
hentsch committed rMITKfb424ab3e01e: connects to changes of minMaxXYView signals (authored by hentsch).
connects to changes of minMaxXYView signals
removed output
format due to style guide
function not longer needed
hentsch committed rMITKf0f168371896: Show() is not longer necessary due to Update()/Reset() (authored by hentsch).
Show() is not longer necessary due to Update()/Reset()
hentsch committed rMITK7561b0f5bde2: Implemented ResetMinMaxXView/ResetMinMaxYView (authored by hentsch).
Implemented ResetMinMaxXView/ResetMinMaxYView
removed unused function declaration
hentsch committed rMITKe42eaa180963: Merge branch 'T25832-migrateModelFit2019-05' into T25832-migrateModelFit2019-05. (authored by hentsch).
Merge branch 'T25832-migrateModelFit2019-05' into T25832-migrateModelFit2019-05.
hentsch committed rMITK75b6054896a5: update the chart data instead of redraw the chart widget all the time (authored by hentsch).
update the chart data instead of redraw the chart widget all the time
hentsch added a comment to T25832: Migrate ModelFit inspector plugin to MitkChart.
Pushed new branch T25832-migrateModelFit2019-05.2.
hentsch merged task T12220: [image statistics] compute statistics even when closed planar figure is partially out of the image geometry bounds into Restricted Maniphest Task.
hentsch added a comment to T12220: [image statistics] compute statistics even when closed planar figure is partially out of the image geometry bounds.
At least the statistics table should not show the old values but instead show maybe no values and display a warning for wrong placed mask.
hentsch updated subscribers of T25831: [MITDoc][ImageStatistics] Improve documentation.
hentsch added a comment to T25831: [MITDoc][ImageStatistics] Improve documentation.
the checklist may be of help. It's here: E130-Data/Release\Checklisten\MITK Workbench Release/Checkliste NEW Image Statistics.docx
May 23 2019
May 23 2019
hentsch committed rMITKf240b66e6515: Merge branch 'T26320-update-chart-widget' (authored by hentsch).
Merge branch 'T26320-update-chart-widget'
hentsch committed rMITK5539b57629ef: Optimized SetShowSubchart Now directly changed in QmitkChartData instead of… (authored by hentsch).
Optimized SetShowSubchart Now directly changed in QmitkChartData instead of…
removed unused function
Removed convenience function
removed output
hentsch committed rMITK727e77c6ad09: Add function to update an existing data label (authored by hentsch).
Add function to update an existing data label
Also the error data is cleared
hentsch committed rMITKb3fd5ee59afd: Added connections to instantly change global options in Chart example. The… (authored by hentsch).
Added connections to instantly change global options in Chart example. The…
hentsch committed rMITK109c1623dced: Implements the updateData functionality. Updates of the data are now directly… (authored by hentsch).
Implements the updateData functionality. Updates of the data are now directly…
boost::thread & co is removed.
boost::thread is no longer needed
May 16 2019
May 16 2019
adds connect for m_C3xyData
adds connect for m_C3Data variables
hentsch committed rMITK3a289212b988: extracted chart type data generation in function (authored by hentsch).
extracted chart type data generation in function
hentsch committed rMITK0d20dcf765c1: extracted data generation for legend position in function (authored by hentsch).
extracted data generation for legend position in function
removed multiply defined variable
hentsch committed rMITKa7d13a99d3f9: legend position in chart is directly changed when user changes GUI (authored by hentsch).
legend position in chart is directly changed when user changes GUI
emit signal in case of x/y data change
adapted to MITK Style guide
hentsch committed rMITK4c0ab7018d73: initialize xyData object with size of data vector (authored by hentsch).
initialize xyData object with size of data vector
hentsch committed rMITK009f58c400f5: initialization in header instead of constructor (authored by hentsch).
initialization in header instead of constructor
new tests for update chart
hentsch committed rMITK88e23ac189b3: added function for creating all necessary GUI connections (authored by hentsch).
added function for creating all necessary GUI connections
hentsch committed rMITK110756acb3b6: added labelCount variable to use this information in js updating routine (authored by hentsch).
added labelCount variable to use this information in js updating routine
hentsch committed rMITK423535fa1642: added UpdateData* functions for updating existing data values (authored by hentsch).
added UpdateData* functions for updating existing data values
hentsch removed a parent task for T24795: ModelFit visualization bug?: Unknown Object (Maniphest Task).
hentsch changed the visibility for T24795: ModelFit visualization bug?.
hentsch removed a parent task for T24566: 3d+t image loaded with wrong timegeometry: Unknown Object (Maniphest Task).
May 15 2019
May 15 2019
hentsch triaged T26332: [ImageStatistics] ImageStatisticsContainerManager as function as Normal priority.
hentsch committed rMITK5713480ee556: Merge branch 'T26324-optimizeZoomingOption' (authored by hentsch).
Merge branch 'T26324-optimizeZoomingOption'
hentsch committed rMITK2032acedce06: prevent updating min/max values if they are null (authored by hentsch).
prevent updating min/max values if they are null
May 10 2019
May 10 2019
hentsch committed rMITK14805bb60f51: Merge branch 'T25832-migrateModelFitToMitkCHart' into T25832… (authored by hentsch).
Merge branch 'T25832-migrateModelFitToMitkCHart' into T25832…
hentsch committed rMITK44c6919eebcc: colored current timepoint blue like in the old version (authored by hentsch).
colored current timepoint blue like in the old version
hentsch added a comment to T25832: Migrate ModelFit inspector plugin to MitkChart.
Pushed new branch T25832-migrateModelFit2019-05.
hentsch committed rMITKce9437ef2d48: Merge branch 'T26324-optimizeZoomingOption' (authored by hentsch).
Merge branch 'T26324-optimizeZoomingOption'
hentsch closed T26324: [MitkChart] optimize zooming option as Resolved by committing rMITK8b388b272304: resolved T26324 min/max values of x and y are now stored as variable in….
hentsch committed rMITK8b388b272304: resolved T26324 min/max values of x and y are now stored as variable in… (authored by hentsch).
resolved T26324 min/max values of x and y are now stored as variable in…
hentsch added a comment to T26324: [MitkChart] optimize zooming option.
Pushed new branch T26324-optimizeZoomingOption.
hentsch committed rMITK14a7ff9f8e73: removed unnecessary workaround after T26222 was fixed (authored by hentsch).
removed unnecessary workaround after T26222 was fixed
hentsch added a comment to T25832: Migrate ModelFit inspector plugin to MitkChart.
T26323 is needed to highlight the current point
hentsch added a comment to T25832: Migrate ModelFit inspector plugin to MitkChart.
Feedback from @floca:
- Der Titel der X-Achse und die Achsenbeschriftungen liegen über einander und sind deshalb nicht zu lesen.
- is already fixed with T26274, but not yet in this branch
- Fixed Scaling (für X und Y) funktioniert nicht richtig.
- true
- In der Methode OnFullPlotClicked ist ein Task (T26222) referenziert, den es gar nicht gibt. Vielleicht ist das aber jetzt auch schon durch meinen Fix erledigt.
- code was deleted, works fine
- Kritische Regression gegenüber dem alten Widget: Im Moment flackert es immer sobald man die Achsen anpasst oder (noch schlimmer) wenn man einen neuen Punkt ansteuert. Dass ist insbesondere beim explorieren von Daten nicht gut, da es leicht laggt und sehr irritiert.
- opened T26320
- Kritische Regression gegenüber dem alten Widget: Im Moment aktualisiert sich der Plot erst wenn man die Maus wieder loslässt (wenn man im SliceNavigator oder direkt im Bild neue Punkte anfährt). Früher wurde automatisch immer gleich mit aktualisiert, es wäre sehr gut, wenn das wieder so wäre. Entsprechend müsste der Chart neugemalt werden, jedesmal wenn die Positionsänderung propagiert wird. Im Moment sieht es so aus, als würde gewartet, bis der Main-Thread idelt.
- can't reproduce. The update takes a while (probably because of new painting of the widget), but has nothing to do with mouse click release. @floca we should look again if T26320 is fixed.
Merge branch 'T25871-chartTypePie'
hentsch closed T25871: [chart] Implement the chart type pie, a subtask of T23104: Deprecate QmitkPlotWidget, as Resolved.
hentsch closed T25871: [chart] Implement the chart type pie as Resolved by committing rMITK95bf067aebbd: fixed T25871.
improved chart example plugin
fixed T25871
hentsch added a comment to T25871: [chart] Implement the chart type pie.
Pushed new branch T25871-chartTypePie.
May 8 2019
May 8 2019
hentsch added a comment to T23104: Deprecate QmitkPlotWidget.
This would be favorable. However, if we deprecate the QmitkPlotDialog/QmitkPlotWidget/QtHistogram classes, this leads to warnings (and errors because of warnings-as-errors).
@kislinsk do you see a possibility?
hentsch added a comment to T26029: [image statistics plugin] 4D image + 4D segmentation as mask does not work.
@hentsch Is the one time step segmentation applied to all time steps? What is the expected behavior?
Apr 12 2019
Apr 12 2019
hentsch placed T25871: [chart] Implement the chart type pie up for grabs.
hentsch closed T23408: Image Statistics plugin: histogram for small bin sizes is not visible as Invalid.
Does not longer occur with plotly.js.
Long live plotly!! Thanks to @steint
hentsch committed rMITK2460d50651af: Merge branch 'T26274-chartXAxisLabelCovers' (authored by hentsch).
Merge branch 'T26274-chartXAxisLabelCovers'
resolved T26274
hentsch closed T26222: [MitkChart] Maximizing mitkChartWidget does not lead to maximization of chart as Invalid.
Was only due to a wrong qt layout, works now.
Deleted PlotWidget.
added zoom in in Y-direction
hentsch committed rMITKfc2cb3ad07ba: Merge branch 'T26268-addYZoomChart' into T25832-migrateModelFitToMitkCHart (authored by hentsch).
Merge branch 'T26268-addYZoomChart' into T25832-migrateModelFitToMitkCHart
At least, there are fewer warnings. Couldn't prevent all warnings.
Merge branch 'T26272-chartWarning2'
hentsch committed rMITKdcacfbb4b0f1: Only register objects that have not been registered yet (authored by hentsch).
Only register objects that have not been registered yet
hentsch added a comment to T26272: [MitkChart] warning about new registered objects.
Pushed new branch T26272-chartWarning2.
hentsch updated subscribers of T26029: [image statistics plugin] 4D image + 4D segmentation as mask does not work.
hentsch committed rMITK6496d0d3aa45: Only register objects that have not been registered yet (authored by hentsch).
Only register objects that have not been registered yet
hentsch added a comment to T26272: [MitkChart] warning about new registered objects.
Pushed new branch T26272-chartWarningNewRegisteredObjects.