Page MenuHomePhabricator
Feed Advanced Search

Wed, May 15

kislinsk removed a project from T30446: Decouple Workbench plugin from optional views: Request for Discussion.

Discussion result: Option B.

Wed, May 15, 1:19 PM · Next Milestone, MITK
kislinsk moved T30446: Decouple Workbench plugin from optional views from Backlog to MITK Meeting on the Request for Discussion board.
Wed, May 15, 9:20 AM · Next Milestone, MITK

Tue, May 14

kislinsk triaged T30446: Decouple Workbench plugin from optional views as Normal priority.
Tue, May 14, 9:57 AM · Next Milestone, MITK
kislinsk committed rMITK085d28103a7a: Merge branch 'bugfix/T30445-ChangeDefaultBuildConfig' into develop (authored by kislinsk).
Merge branch 'bugfix/T30445-ChangeDefaultBuildConfig' into develop
Tue, May 14, 8:29 AM
kislinsk closed T30445: Change default build configuration from Custom to WorkbenchRelease as Resolved.
Tue, May 14, 8:29 AM · MITK
kislinsk committed rMITK889397425908: Propagate CMAKE_CONFIGURATION_TYPES to MITK build (authored by kislinsk).
Propagate CMAKE_CONFIGURATION_TYPES to MITK build
Tue, May 14, 8:29 AM
kislinsk committed rMITK5a6eec50ba1a: Change default build configuration from Custom to WorkbenchRelease (authored by kislinsk).
Change default build configuration from Custom to WorkbenchRelease
Tue, May 14, 8:29 AM
kislinsk added a comment to T30445: Change default build configuration from Custom to WorkbenchRelease.

Deleted branch from rMITK MITK: bugfix/T30445-ChangeDefaultBuildConfig.

Tue, May 14, 8:29 AM · MITK
kislinsk added a comment to T30445: Change default build configuration from Custom to WorkbenchRelease.

Pushed new branch to rMITK MITK: bugfix/T30445-ChangeDefaultBuildConfig.

Tue, May 14, 8:28 AM · MITK
kislinsk triaged T30445: Change default build configuration from Custom to WorkbenchRelease as Low priority.
Tue, May 14, 8:22 AM · MITK

Mon, May 13

kislinsk added a revision to T30444: [SEG] Crash when working a lot with labels on label delete : Unknown Object (Differential Revision).
Mon, May 13, 12:05 PM · MITK (v2024.06)
kislinsk closed T30443: Tab button of 2nd view is not correctly rendered as Resolved.

Could also verify with Ubuntu and macOS installers that it only seems to happen on the Windows installers with Qt 6.6.1. Close as resolved.

Mon, May 13, 9:54 AM · MITK (v2024.06)
kislinsk added a comment to T30443: Tab button of 2nd view is not correctly rendered.

Qt 6.6.3 is the latest version of the Qt 6.6 range. I upgraded e230-nuc03. e230-nuc01 is not accessible via Remote Desktop because of expired credentials, have to upgrade later in office. Ubuntu 20.04 and 22.04 clients already build with Qt 6.6.2.

Mon, May 13, 9:33 AM · MITK (v2024.06)
kislinsk added a comment to T30443: Tab button of 2nd view is not correctly rendered.

I was surprised not being able to reproduce this issue anymore with my local build. I then tested the snapshot installer and I was able to reproduce. The only difference I see is Qt 6.6.1 (installer) vs. Qt 6.6.2 (local). I will upgrade Qt on our Windows CI clients and check again...

Mon, May 13, 9:00 AM · MITK (v2024.06)
kislinsk triaged T30443: Tab button of 2nd view is not correctly rendered as Normal priority.
Mon, May 13, 8:43 AM · MITK (v2024.06)
kislinsk claimed T30443: Tab button of 2nd view is not correctly rendered.
Mon, May 13, 8:43 AM · MITK (v2024.06)

Fri, May 10

kislinsk added a comment to T26934: Multiple logos in screenshot when using screenshot maker plugin.

Deleted branch from rMITK MITK: bugfix/T26934-FixLogoAnnotation.

Fri, May 10, 2:57 PM · MITK (v2024.06)
kislinsk committed rMITKe6532b6e2a0f: Remove multi widget decoration manager duplicate (authored by kislinsk).
Remove multi widget decoration manager duplicate
Fri, May 10, 2:56 PM
kislinsk closed T26934: Multiple logos in screenshot when using screenshot maker plugin as Resolved by committing rMITK208cf8597f01: Remove multi widget decoration manager duplicate.
Fri, May 10, 2:56 PM · MITK (v2024.06)
kislinsk committed rMITK208cf8597f01: Remove multi widget decoration manager duplicate (authored by kislinsk).
Remove multi widget decoration manager duplicate
Fri, May 10, 2:56 PM
kislinsk added a revision to T26934: Multiple logos in screenshot when using screenshot maker plugin: Unknown Object (Differential Revision).
Fri, May 10, 10:25 AM · MITK (v2024.06)
kislinsk added a comment to T26934: Multiple logos in screenshot when using screenshot maker plugin.

Pushed new branch to rMITK MITK: bugfix/T26934-FixLogoAnnotation.

Fri, May 10, 10:23 AM · MITK (v2024.06)
kislinsk added a comment to T26934: Multiple logos in screenshot when using screenshot maker plugin.

Deleted branch from rMITK MITK: bugfix/T26934-FixHighResScreenshots.

Fri, May 10, 10:18 AM · MITK (v2024.06)
kislinsk added a revision to T26934: Multiple logos in screenshot when using screenshot maker plugin: Unknown Object (Differential Revision).
Fri, May 10, 1:14 AM · MITK (v2024.06)
kislinsk added a comment to T26934: Multiple logos in screenshot when using screenshot maker plugin.

Pushed new branch to rMITK MITK: bugfix/T26934-FixHighResScreenshots.

Fri, May 10, 1:08 AM · MITK (v2024.06)
kislinsk edited projects for T26934: Multiple logos in screenshot when using screenshot maker plugin, added: MITK (v2024.06); removed Auto-closed, MITK.
Fri, May 10, 1:06 AM · MITK (v2024.06)
kislinsk reopened T26934: Multiple logos in screenshot when using screenshot maker plugin as "Open".
Fri, May 10, 1:05 AM · MITK (v2024.06)

Wed, May 8

kislinsk closed T30414: [Documentation] Help contents have wrong titles and root pages as Resolved.
Wed, May 8, 3:11 PM · Checklist, MITK (v2024.06)
kislinsk added a comment to T30414: [Documentation] Help contents have wrong titles and root pages.

Deleted branch from rMITK MITK: bugfix/T30414-MakeIndexDefaultPage.

Wed, May 8, 3:10 PM · Checklist, MITK (v2024.06)
kislinsk committed rMITK020a66f6cbc3: Make Help Index the default page of the Help Perspective (authored by kislinsk).
Make Help Index the default page of the Help Perspective
Wed, May 8, 3:10 PM
kislinsk committed rMITK897afafbd408: Merge branch 'bugfix/T30414-MakeIndexDefaultPage' into develop (authored by kislinsk).
Merge branch 'bugfix/T30414-MakeIndexDefaultPage' into develop
Wed, May 8, 3:09 PM
kislinsk added a comment to T30414: [Documentation] Help contents have wrong titles and root pages.

Pushed new branch to rMITK MITK: bugfix/T30414-MakeIndexDefaultPage.

Wed, May 8, 3:08 PM · Checklist, MITK (v2024.06)
kislinsk added a comment to T30414: [Documentation] Help contents have wrong titles and root pages.

In the past we used the XLST functionalities from Qt 5 to remove certain parts for the help files. Since Qt 6 we removed the transformation as it is not easy to set up a feasible alternative with libxml for example. The downside now is to have a little bit more clutter in the Help Contents. Since the Help Index still looks like the Help Contents before, I think we should simply change the default view of the Help Perspective to Help Index and live with the Help Contents as-is.

Wed, May 8, 2:53 PM · Checklist, MITK (v2024.06)
kislinsk closed T30438: Clean up old pages and Doxygen code as Resolved.
Wed, May 8, 2:19 PM · MITK
kislinsk added a comment to T30438: Clean up old pages and Doxygen code.

Deleted branch from rMITK MITK: bugfix/T30438-CleanUpHelpAndDoxygenCode.

Wed, May 8, 2:19 PM · MITK
kislinsk committed rMITKf334cf284601: Remove parsing of CMake files by Doxygen (authored by kislinsk).
Remove parsing of CMake files by Doxygen
Wed, May 8, 2:19 PM
kislinsk committed rMITK9f0bc7eef1b2: Fix Doxygen warnings (authored by kislinsk).
Fix Doxygen warnings
Wed, May 8, 2:19 PM
kislinsk committed rMITKf7fbf08cb62c: Merge branch 'bugfix/T30438-CleanUpHelpAndDoxygenCode' into develop (authored by kislinsk).
Merge branch 'bugfix/T30438-CleanUpHelpAndDoxygenCode' into develop
Wed, May 8, 2:19 PM
kislinsk added a comment to T30438: Clean up old pages and Doxygen code.

Pushed new branch to rMITK MITK: bugfix/T30438-CleanUpHelpAndDoxygenCode.

Wed, May 8, 2:01 PM · MITK
kislinsk triaged T30438: Clean up old pages and Doxygen code as Normal priority.
Wed, May 8, 1:52 PM · MITK
kislinsk added a comment to T30416: [Measurement] Selecting a shape enforces drawing it / finishing a path not obvious.

Deleted branch from rMITK MITK: bugfix/T30416-AddUsageHintsToMeasurementView.

Wed, May 8, 1:49 PM · MITK (v2024.06), Checklist
kislinsk added a comment to T30413: [Documentation] Help pages are blank in certain situations.

Deleted branch from rMITK MITK: bugfix/T30413-FixBlankHelpPages.

Wed, May 8, 1:49 PM · Checklist, MITK (v2024.06)
kislinsk added a comment to T29525: Pixel Value View should be aware of label set images.

Deleted branch from rMITK MITK: bugfix/T29525-IgnoreLabelSetImagesInPixelValueView.

Wed, May 8, 1:49 PM · MITK
kislinsk committed rMITKd1d7a9b8627f: Let berry::HelpPluginActivator manage URL scheme handler for qthelp (authored by kislinsk).
Let berry::HelpPluginActivator manage URL scheme handler for qthelp
Wed, May 8, 1:47 PM
kislinsk committed rMITK772e994e409b: Fix initialization order (authored by kislinsk).
Fix initialization order
Wed, May 8, 1:47 PM
kislinsk closed T30413: [Documentation] Help pages are blank in certain situations as Resolved by committing rMITK262b488cf8fa: Fix blank help pages.
Wed, May 8, 1:47 PM · Checklist, MITK (v2024.06)
kislinsk committed rMITK262b488cf8fa: Fix blank help pages (authored by kislinsk).
Fix blank help pages
Wed, May 8, 1:47 PM
kislinsk committed rMITKacb7c13c6a23: Show usage hint when drawing planar figures (authored by kislinsk).
Show usage hint when drawing planar figures
Wed, May 8, 1:46 PM
kislinsk committed rMITKb723e24abc7e: Show usage hint when drawing planar figures (authored by kislinsk).
Show usage hint when drawing planar figures
Wed, May 8, 1:46 PM
kislinsk closed T30416: [Measurement] Selecting a shape enforces drawing it / finishing a path not obvious as Resolved by committing rMITKb723e24abc7e: Show usage hint when drawing planar figures.
Wed, May 8, 1:46 PM · MITK (v2024.06), Checklist
kislinsk committed rMITK6326d8f1413d: Ignore label set images in Pixel Value view (authored by kislinsk).
Ignore label set images in Pixel Value view
Wed, May 8, 1:45 PM
kislinsk closed T29525: Pixel Value View should be aware of label set images as Resolved by committing rMITK750a0ef57a2e: Ignore label set images in Pixel Value view.
Wed, May 8, 1:45 PM · MITK
kislinsk committed rMITK750a0ef57a2e: Ignore label set images in Pixel Value view (authored by kislinsk).
Ignore label set images in Pixel Value view
Wed, May 8, 1:45 PM
kislinsk added a revision to T30413: [Documentation] Help pages are blank in certain situations: Unknown Object (Differential Revision).
Wed, May 8, 12:19 PM · Checklist, MITK (v2024.06)
kislinsk added a comment to T30413: [Documentation] Help pages are blank in certain situations.

Pushed new branch to rMITK MITK: bugfix/T30413-FixBlankHelpPages.

Wed, May 8, 12:17 PM · Checklist, MITK (v2024.06)
kislinsk claimed T30413: [Documentation] Help pages are blank in certain situations.
Wed, May 8, 12:10 PM · Checklist, MITK (v2024.06)
kislinsk claimed T30414: [Documentation] Help contents have wrong titles and root pages.
Wed, May 8, 9:04 AM · Checklist, MITK (v2024.06)

Tue, May 7

kislinsk assigned T30421: [SEG] Undo/Redo problems with Fill/Erase tool reported to floca.
Tue, May 7, 9:58 PM · Missing Info, Checklist, MITK (v2024.06)
kislinsk added a comment to T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX.

This is a good idea.

Tue, May 7, 4:31 PM · Request for Discussion, Checklist, MITK (v2024.06)
kislinsk added a comment to T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX.

That you cannot tell. You don't know how testers would react to option A. May be it is equaly irritating to them. And may be they would missing the highlighting of invisible labels if the realy would work with it... 🤔

Tue, May 7, 3:57 PM · Request for Discussion, Checklist, MITK (v2024.06)
kislinsk added a revision to T29526: [Segmentation] Workbench crashes when closing render window part with active tool: Unknown Object (Differential Revision).
Tue, May 7, 3:36 PM · MITK (v2024.06)
kislinsk added a revision to T30420: [SEG] Fill/Erase tool does not work due to geometry error: Unknown Object (Differential Revision).
Tue, May 7, 3:03 PM · Checklist, MITK (v2024.06)
kislinsk added a comment to T30412: [Statistics] Planar figure cannot be set as ROI for askew images.

With a reinit it works but boy is this unintuitive for users. Like when starting the Workbench and opening brain.nrrd, there's no indication that a reinit is necessary (and what a reinit is and where to find it is another story). You can draw a planar figure on it just fine.

Tue, May 7, 3:00 PM · MITK, Next Milestone
kislinsk added a comment to T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX.

Yes, I agree. Well, not completely I guess, since I vote for B. The current state confused all testers (and me at first when I double-checked what's going on, and after I understood I still would consider it a bug in this state). I see the good intentions why you changed it from initial B to something else, but the disadvantages proved to outweigh.

Tue, May 7, 2:53 PM · Request for Discussion, Checklist, MITK (v2024.06)
kislinsk added a revision to T30416: [Measurement] Selecting a shape enforces drawing it / finishing a path not obvious: Unknown Object (Differential Revision).
Tue, May 7, 12:00 PM · MITK (v2024.06), Checklist
kislinsk added a comment to T30416: [Measurement] Selecting a shape enforces drawing it / finishing a path not obvious.

Pushed new branch to rMITK MITK: bugfix/T30416-AddUsageHintsToMeasurementView.

Tue, May 7, 11:58 AM · MITK (v2024.06), Checklist
kislinsk added a comment to T30416: [Measurement] Selecting a shape enforces drawing it / finishing a path not obvious.

The Measurement view is quite a historically grown abomination that would greatly benefit from a complete overhaul. Hence, to keep complexity down to a minimum for the upcoming release, I suggest to not implement canceling but instead to add a hint to the GUI on how to finish continuous planar figures.

Tue, May 7, 11:08 AM · MITK (v2024.06), Checklist
kislinsk claimed T30416: [Measurement] Selecting a shape enforces drawing it / finishing a path not obvious.
Tue, May 7, 11:05 AM · MITK (v2024.06), Checklist
kislinsk added a revision to T29525: Pixel Value View should be aware of label set images: Unknown Object (Differential Revision).
Tue, May 7, 8:50 AM · MITK
kislinsk added a comment to T29525: Pixel Value View should be aware of label set images.

Pushed new branch to rMITK MITK: bugfix/T29525-IgnoreLabelSetImagesInPixelValueView.

Tue, May 7, 8:46 AM · MITK
kislinsk claimed T29525: Pixel Value View should be aware of label set images.

For now, I suggest the most simple solution which is to ignore label set images all together, as long as we do not correctly support probing pixel values at a certain location. This is a much more complex problem that can be tackled in the future if requested, for example:

Tue, May 7, 8:43 AM · MITK

Sun, May 5

kislinsk triaged T30419: [Segmentation] "Preview" button of GrowCut tools needs to be clicked twice before "Confirm segmentation" button gets active as High priority.
Sun, May 5, 6:45 AM · Checklist, MITK (v2024.06)
kislinsk triaged T30418: [Segmentation / Pixel Value] Pixel values only shown for active group as Normal priority.
Sun, May 5, 5:56 AM · Checklist, MITK (v2024.06)
kislinsk triaged T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX as Normal priority.
Sun, May 5, 5:49 AM · Request for Discussion, Checklist, MITK (v2024.06)
kislinsk renamed T30416: [Measurement] Selecting a shape enforces drawing it / finishing a path not obvious from [Measurement] Selecting a shape enforces drawing it to [Measurement] Selecting a shape enforces drawing it / finishing a path not obvious.
Sun, May 5, 5:26 AM · MITK (v2024.06), Checklist
kislinsk triaged T30416: [Measurement] Selecting a shape enforces drawing it / finishing a path not obvious as Low priority.
Sun, May 5, 5:18 AM · MITK (v2024.06), Checklist
kislinsk triaged T30415: [Level Window] Changing level window with multiple images is confusing as Normal priority.
Sun, May 5, 5:10 AM · MITK (v2024.06), Checklist
kislinsk changed the visibility for F3633453: Screenshot 2024-05-05 043710.png.
Sun, May 5, 4:38 AM
kislinsk changed the visibility for F3633454: Screenshot 2024-05-05 043502.png.
Sun, May 5, 4:38 AM
kislinsk triaged T30414: [Documentation] Help contents have wrong titles and root pages as High priority.
Sun, May 5, 4:38 AM · Checklist, MITK (v2024.06)
kislinsk triaged T30413: [Documentation] Help pages are blank in certain situations as Normal priority.
Sun, May 5, 4:32 AM · Checklist, MITK (v2024.06)
kislinsk added a comment to T30410: [Segmentation] 2-d interpolation does not interpolate between multiple slices.

thanks for the research. Are you already working on that ticket?

Sun, May 5, 4:30 AM · MITK, Next Milestone

Sat, May 4

kislinsk added a comment to T30410: [Segmentation] 2-d interpolation does not interpolate between multiple slices.

This can be also reproduced with just two slices. The crux is to stay at the last drawn contour.

Sat, May 4, 2:58 AM · MITK, Next Milestone

Fri, May 3

kislinsk triaged T30412: [Statistics] Planar figure cannot be set as ROI for askew images as Normal priority.
Fri, May 3, 12:10 PM · MITK, Next Milestone
kislinsk added a comment to T30410: [Segmentation] 2-d interpolation does not interpolate between multiple slices.

Just checked... yes!

Fri, May 3, 10:23 AM · MITK, Next Milestone

Thu, May 2

kislinsk triaged T30410: [Segmentation] 2-d interpolation does not interpolate between multiple slices as Unbreak Now! priority.
Thu, May 2, 4:42 PM · MITK, Next Milestone
kislinsk triaged T30409: [Segmentation] Clear content in label context menu does not update render windows as Normal priority.
Thu, May 2, 4:34 PM · Checklist, MITK (v2024.06)
kislinsk closed T29352: Segmentation Options Checklist - "Create Smoothed Polygon" Seems Not to Work as Resolved.
Thu, May 2, 4:32 PM · MITK (v2024.06), Cleared, Checklist
kislinsk triaged T30408: [Segmentation] Cancelling the "Create label" dialog creates a label/segmentation anyway as High priority.
Thu, May 2, 4:24 PM · MITK (v2024.06), Checklist
kislinsk edited the content of 2024 Week 18 (Very Early May).
Thu, May 2, 10:25 AM
kislinsk closed T30407: 2024 Week 18 (Very Early May) as Resolved.
Thu, May 2, 9:38 AM · MITK (v2024.06)
kislinsk edited the content of Changelog.
Thu, May 2, 9:38 AM · MITK
kislinsk added a comment to T30407: 2024 Week 18 (Very Early May).

Deleted branch from rMITK MITK: release/T30407-2024-Week-18.

Thu, May 2, 9:37 AM · MITK (v2024.06)
kislinsk committed rMITKfc5b483f0372: Merge branch 'master' into develop (authored by kislinsk).
Merge branch 'master' into develop
Thu, May 2, 9:35 AM
kislinsk committed rMITK3fa97dc67d46: 2024 Week 18 (Very Early May) (authored by kislinsk).
2024 Week 18 (Very Early May)
Thu, May 2, 9:34 AM
kislinsk edited the content of 2024 Week 11 (Mid March).
Thu, May 2, 9:29 AM
kislinsk published a new version of 2024 Week 18 (Very Early May).
Thu, May 2, 9:29 AM
kislinsk added a comment to T30407: 2024 Week 18 (Very Early May).

Pushed new branch to rMITK MITK: release/T30407-2024-Week-18.

Thu, May 2, 7:56 AM · MITK (v2024.06)
kislinsk triaged T30407: 2024 Week 18 (Very Early May) as Normal priority.
Thu, May 2, 7:51 AM · MITK (v2024.06)
kislinsk created an object: 2024 Week 18 (Very Early May).
Thu, May 2, 7:50 AM