If a string is supposed to be passed on from the GUI to the command line only an empty string is passed on.
please can you review CTK issue #306 and #307, which i believe fix this issue. These are not yet merged to master.
So, this will require a new CTK version in MITK.
I just updated both issue 306 and 307.
307 took much longer than I thought.... as in our project we call command line scripts that pass their parameters onto a binary, so we also had problems with spaces in our scripts, and I thought it was coming from the CLI stuff in CTK. Anyway, I think it is ok now.
which I think are ok.... except I just spotted #include <iostream> unnecessarily included... anyway... I am testing it combined here:
so that I could put it in our overnight build, and get more people to take a look on Monday. But I think it should be ok.
I will let you know.
i found a problem for this issue, where if a string parameter had a default set, and the user removed the default and intended to send an empty string, then the code automatically always replaced the empty string with a default.
THis is probably not useful.
So, I pushed this change:
So I think that both CTK issue #306, and #307 should be OK. But I have not had time to integrate a new merged CTK (master + 306 + 307) within our NifTK build.
I think your changes are perfectly valid - thanks! I guess you could just merge them to master, checkt that the CTK unit tests still run and push everything. Maybe I can manage to update the CTK in MITK this evening.
I just pushed to CTK master:
There were unit test failures, but nothing that looked relevant to this.
So I pushed anyway.
[0a9d56]: Merge branch 'bug-14692-update-ctk-to-fix-strings-in-cmdlinemodules'
2013-03-26 16:26:49 Sascha Zelzer [4f7ab1]
Updated CTK to fix cmd line module string handling.