Page MenuHomePhabricator
Create Task
Maniphest T15746

Normalize the orientation Quaternion in VirtualTrackingDevice
Closed, ResolvedPublic
Actions

Description

Currently sets x = y = z = r = 1.0 which is not normalized.

Event Timeline

nocnokneo added projects: MITK, Bugzilla.Jul 30 2013, 11:08 PM
nocnokneo added a subscriber: nocnokneo.Jul 30 2013, 11:13 PM

Github pull request: https://github.com/MITK/MITK/pull/13

• groch added a subscriber: • groch.Aug 7 2013, 2:28 PM

New remote branch pushed: bug-15746-Normalize_orientation_quaternion_in_VirtualTrackingDevice

• groch added a comment.Aug 7 2013, 2:33 PM

[b21b36]: Merge branch 'bug-15746-Normalize_orientation_quaternion_in_VirtualTra

Merged commits:

2013-08-07 14:27:25 Anja Groch [f77832]
Normalizing the quaternion before calling SetOrientation() as proposed by Taylor Braun-Jones.
I'm not sure, if this is needed for this method, but in any case it is correct with normalization.

zelzer added a subscriber: zelzer.Aug 28 2013, 10:22 PM

Looks like the issue is resolved.

Sorry for not merging your branch directly. We are currently in the process of training our committers how to handle external pull requests.

nocnokneo added a comment.Aug 28 2013, 11:10 PM

No problem, I figured it was something like that. I can see from the number of GitHub pull requests that it's not frequently used process.

MITK · MIC · IMSY · DKFZ