Page MenuHomePhabricator
Create Task
Maniphest T16674

Fix memory leaks in MITK Core
Closed, ResolvedPublic
Actions

Description

Reduce the number of issues that are reported by Valgrind on the Dashboard

Event Timeline

nolden added projects: MITK, Bugzilla.Dec 12 2013, 2:17 PM
nolden added a subscriber: nolden.

New remote branch pushed: bug-16674-fix-memory-leaks

nolden added a comment.Dec 12 2013, 8:33 PM

[d3a519]: Merge branch 'bug-16674-fix-memory-leaks'

Merged commits:

2013-12-12 17:47:49 Marco Nolden [8dc9b9]
Fix memory leak in PropertyList::InternalClone

2013-12-12 14:15:19 Marco Nolden [f59201]
Fix self-copy of data in ImageDataItem

nolden added a comment.Dec 13 2013, 7:12 PM

[62769a]: Merge branch 'bug-16674-fix-memory-leaks'

Merged commits:

2013-12-13 12:21:59 Marco Nolden [eab780]
Fixed more InternalClone implementations

nocnokneo added a subscriber: nocnokneo.Sep 10 2014, 4:43 PM

Pull request for leak fixes in ImageReadAccessor:
https://github.com/MITK/MITK/pull/80

nocnokneo added a comment.Sep 10 2014, 4:56 PM

Pull request for several leaks found while running unit tests against a build of VTK with VTK_DEBUG_LEAKS enabled:
https://github.com/MITK/MITK/pull/81

zelzer added a subscriber: zelzer.Sep 10 2014, 8:59 PM

[017f0b]: Merge branch 'bug-16674-fix-memory-leaks-VTK_DEBUG_LEAKS'

Merged commits:

2014-09-09 22:04:22 Taylor Braun-Jones [955376]
Fix leaks found by running non-rendering unit tests with VTK_DEBUG_LEAKS

Signed-off-by: Taylor Braun-Jones <taylor.braun-jones@ge.com>

zelzer added a comment.Sep 10 2014, 8:59 PM

[1cc716]: Merge branch 'bug-16674-fix-memory-leaks-ImageReadAccessor'

Merged commits:

2014-09-10 15:54:48 Taylor Braun-Jones [35d48b]
Fix memory leak when creating a ImageReadAccessor with IgnoreLock enabled

Signed-off-by: Taylor Braun-Jones <taylor.braun-jones@ge.com>

2014-09-10 15:53:52 Taylor Braun-Jones [9de134]
Fix memory leak when image accessor fails to construct

Make sure to free any already allocated memory before allowing an
exception to propagate out of the constructor because the destructor
will not be called on the non-completely-constructed ImageReadAccessor
object.

Signed-off-by: Taylor Braun-Jones <taylor.braun-jones@ge.com>

zelzer added a comment.Sep 10 2014, 9:00 PM

Awesome, thanks!

nocnokneo added a comment.Sep 10 2014, 11:26 PM

Another leak fix:
https://github.com/MITK/MITK/pull/82

nocnokneo added a comment.Sep 11 2014, 12:48 AM

Fix for memory leak in VtkPropRenderer::Initialize2DvtkCamera:
https://github.com/MITK/MITK/pull/83

nocnokneo added a comment.Sep 11 2014, 2:49 PM

Fix memory leak in mitkImageVtkMapper2DLevelWindow unit test:
https://github.com/MITK/MITK/pull/84

nocnokneo added a comment.Sep 11 2014, 3:22 PM

FYI - Just updated pull request 83

zelzer added a comment.Sep 11 2014, 5:29 PM

[cb0495]: Merge branch 'bug-16674-fix-memory-leaks-ImageVtkMapper2DLevelWindowTe

Merged commits:

2014-09-11 14:42:14 Taylor Braun-Jones [6c3cc2]
Fix memory leak in mitkImageVtkMapper2DLevelWindow unit test

Signed-off-by: Taylor Braun-Jones <taylor.braun-jones@ge.com>

zelzer added a comment.Sep 11 2014, 5:29 PM

[4f3c16]: Merge branch 'bug-16674-fix-memory-leaks-VtkPropRenderer'

Merged commits:

2014-09-11 00:40:56 Taylor Braun-Jones [6afb05]
Fix memory leaks in VtkPropRenderer::Initialize2DvtkCamera

Signed-off-by: Taylor Braun-Jones <taylor.braun-jones@ge.com>

zelzer added a comment.Sep 11 2014, 5:29 PM

[3d99b0]: Merge branch 'bug-16674-fix-memory-leaks-SurfaceToImageFilter'

Merged commits:

2014-09-10 23:17:14 Taylor Braun-Jones [a6a2fc]
Fix VTK memory leaks in SurfaceToImageFilter

... due to invalid vtkSmartPointer usage.

Signed-off-by: Taylor Braun-Jones <taylor.braun-jones@ge.com>

MITK · MIC · IMSY · DKFZ