Page MenuHomePhabricator

nolden (Marco Nolden)
UserAdministrator

Projects (12)

User Details

User Since
Aug 1 2016, 12:10 PM (181 w, 3 d)
Roles
Administrator

Recent Activity

Thu, Jan 9

nolden updated subscribers of T26962: Improve dynamic analysis and test coverage reporting.

As @kalali pointed out there was some previous tooling research done internally: T22218

Thu, Jan 9, 6:42 PM · CI, MITK
nolden closed T13690: Missing tests in Core\Code\Rendering as Resolved.

I will close this task now. There was valuable work done on adding and updating tests, but this will never be finished anyway. New developments in that area will be tracked in T26962.

Thu, Jan 9, 6:40 PM · Bugzilla, MITK
nolden closed T13692: Missing Tests in Core as Resolved.

I will close this task now. There was valuable work done on adding and updating tests, but this will never be finished anyway. New developments in that area will be tracked in T26962.

Thu, Jan 9, 6:40 PM · MITK, Bugzilla
nolden renamed T26962: Improve dynamic analysis and test coverage reporting from Improve dynamic analysis reporting to Improve dynamic analysis and test coverage reporting.
Thu, Jan 9, 6:39 PM · CI, MITK

Wed, Jan 8

nolden triaged T26962: Improve dynamic analysis and test coverage reporting as Wishlist priority.
Wed, Jan 8, 10:32 AM · CI, MITK

Tue, Jan 7

nolden added a comment to T26955: MitkQtPythonTest fails because of missing library dependencies on Linux.

I can confirm this works. One downside I realized with the current solution is that it only works if the test is executed through ctest, i.e. ctest -R Pytohn , but if you start the driver directly the same problem occurs. I think it is ok for now, but would be some motivation to find a solution that works without a special environment, since for example while debugging you usually start the executable directly.

Tue, Jan 7, 5:45 PM · MITK

Dec 19 2019

nolden triaged T26942: Crash on DICOM loading as Normal priority.
Dec 19 2019, 1:54 PM · DICOM, d:cipher, MITK

Dec 16 2019

nolden created T26934: Multiple logos in screenshot when using screenshot maker plugin.
Dec 16 2019, 5:35 PM · MITK

Nov 25 2019

nolden committed rMITK83f50cd74bc2: Removed some unnecessary copying of BoundsArrays (authored by nolden).
Removed some unnecessary copying of BoundsArrays
Nov 25 2019, 1:06 PM

Oct 25 2019

nolden added a member for MITK-MBI: k656s.
Oct 25 2019, 4:52 PM
nolden added a member for MITK: k656s.
Oct 25 2019, 4:44 PM

Oct 22 2019

nolden added a comment to T23293: Apply C++ 11 modernizations.

Thanks for picking up!

Oct 22 2019, 5:33 PM · MITK
nolden added inline comments to rMITK029a4ba313e1: Modernize usage of auto keyword with clang-tidy.
Oct 22 2019, 5:31 PM

Oct 19 2019

nolden updated the task description for T26721: Prepare Qt 5.13 compatibility.
Oct 19 2019, 9:28 AM · MITK
nolden renamed T26721: Prepare Qt 5.13 compatibility from Fix Qt 5.13 compatibility to Prepare Qt 5.13 compatibility.
Oct 19 2019, 9:27 AM · MITK

Oct 11 2019

nolden added a comment to F1442653: grafik.png.

@hentsch Thanks, is this complete? Could you mail it if it should stay confidential?

Oct 11 2019, 2:47 PM

Oct 2 2019

nolden triaged T26721: Prepare Qt 5.13 compatibility as Low priority.
Oct 2 2019, 1:54 PM · MITK

Oct 1 2019

nolden created T26720: Fix build problems with Qt 5.13.
Oct 1 2019, 4:04 PM

Sep 30 2019

nolden added a revision to T26431: Fix gcc 9 and clang 8 compilation: Unknown Object (Differential Revision).
Sep 30 2019, 4:34 PM · MITK (2018-04-4)
nolden committed rMITK1a5a833c568b: Fixed Python 3.7 build errors and some warnings (authored by nolden).
Fixed Python 3.7 build errors and some warnings
Sep 30 2019, 1:20 PM
nolden committed rMITK6fc185bd8f1f: Fixed some exception catch warnings (authored by nolden).
Fixed some exception catch warnings
Sep 30 2019, 1:20 PM
nolden committed rMITK14e2a7bd2858: Fixed exception catch warnings (authored by nolden).
Fixed exception catch warnings
Sep 30 2019, 1:20 PM
nolden committed rMITKbda8c3526996: Don't treat cast function warnings as errors (authored by nolden).
Don't treat cast function warnings as errors
Sep 30 2019, 1:20 PM
nolden committed rMITKc83dbd285d90: Fixed threads related python build error (authored by nolden).
Fixed threads related python build error
Sep 30 2019, 1:20 PM
nolden committed rMITK4080d473bc81: Fixed warnings in exception handling (authored by nolden).
Fixed warnings in exception handling
Sep 30 2019, 1:20 PM

Sep 24 2019

nolden added a revision to T26701: Build errors with Python 3.7 and latest gcc: Unknown Object (Differential Revision).
Sep 24 2019, 2:28 PM · MITK
nolden added a comment to T26701: Build errors with Python 3.7 and latest gcc.

Possible fix is a reordering of includes in mitkPythonService.h , I could not find out exactly what's wrong.

Sep 24 2019, 10:38 AM · MITK
nolden triaged T26701: Build errors with Python 3.7 and latest gcc as High priority.
Sep 24 2019, 10:29 AM · MITK

Jul 2 2019

nolden added a comment to T25535: DCMTK won't build if Anaconda is installed.

Sorry for jumping in late. I'm afraid currently we are anyway not testing any encoding stuff sufficiently.

Jul 2 2019, 2:24 PM · MITK
nolden committed rMITK5ad6bccb0282: Use a more recent version of ITK for GCC 9 compatibility (authored by nolden).
Use a more recent version of ITK for GCC 9 compatibility
Jul 2 2019, 2:03 PM

Jul 1 2019

nolden added a revision to T26431: Fix gcc 9 and clang 8 compilation: Unknown Object (Differential Revision).
Jul 1 2019, 5:26 PM · MITK (2018-04-4)

Jun 27 2019

nolden committed rMITKb215d08c5417: Compilation fixes for recent GCC and clang compilers (authored by nolden).
Compilation fixes for recent GCC and clang compilers
Jun 27 2019, 2:27 PM
nolden added a revision to T26431: Fix gcc 9 and clang 8 compilation: Unknown Object (Differential Revision).
Jun 27 2019, 2:19 PM · MITK (2018-04-4)
nolden committed rMITKcd9f24b3ede4: Fixed some exception handling code to be more correct (authored by nolden).
Fixed some exception handling code to be more correct
Jun 27 2019, 1:40 PM
nolden committed rMITK5011a62ca142: Don't fail on gcc 9 warnings about copy ctors (authored by nolden).
Don't fail on gcc 9 warnings about copy ctors
Jun 27 2019, 1:40 PM
nolden committed rMITK8182f13b5cd9: Fixes for clang compilation (authored by nolden).
Fixes for clang compilation
Jun 27 2019, 1:40 PM
nolden added a comment to T26431: Fix gcc 9 and clang 8 compilation.

Pushed new branch T26431-compilation-fixes-gcc9-clang8.

Jun 27 2019, 1:40 PM · MITK (2018-04-4)
nolden triaged T26431: Fix gcc 9 and clang 8 compilation as Normal priority.
Jun 27 2019, 10:17 AM · MITK (2018-04-4)

Apr 5 2019

nolden accepted rMITK1dbcb6d9ec91: First fix.
Apr 5 2019, 3:07 PM

Mar 28 2019

nolden closed T23268: Build errors with clang 3.8.1 (Debian 9.1 "Stretch") as Resolved.
Mar 28 2019, 5:16 PM · MITK

Feb 8 2019

nolden added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

Looks like the Slicer warning is important, but still it succeeds in loading the data. The numerical error is rather low. Found this discussion which also links to the python code Slicer is using and which emits the warning. Could be of some use for further investigations. https://discourse.slicer.org/t/dicom-scalar-volume-load-irregular-geometry-warning-overly-stringent/3761/14

Feb 8 2019, 8:39 AM · MITK (2018-04-4)

Feb 6 2019

nolden changed the join policy for DICOM.
Feb 6 2019, 1:37 PM
nolden added projects to T25984: add Meaning of dicom tags to data (node) properties: MITK, DICOM.
Feb 6 2019, 11:01 AM · DICOM, MITK, Restricted Project

Feb 4 2019

nolden triaged T25983: Update DICOM related toolkits as Normal priority.
Feb 4 2019, 2:35 PM · MITK, DICOM

Dec 20 2018

nolden moved T25490: OP4.1 workshop demonstration from Backlog to Konsortialtreffen Juli 2018 on the OP 4.1 board.
Dec 20 2018, 2:33 PM · OP 4.1 (Konsortialtreffen Juli 2018), Restricted Project

Dec 11 2018

nolden claimed T25745: Integrate new DICOM browser widget from CTK.
Dec 11 2018, 11:59 PM · MITK
nolden triaged T25745: Integrate new DICOM browser widget from CTK as Normal priority.
Dec 11 2018, 11:57 PM · MITK

Nov 30 2018

nolden added a project to T25702: DICOM sort fails for RWV modality: Restricted Project.
Nov 30 2018, 1:53 PM · Restricted Project, MITK
nolden triaged T25702: DICOM sort fails for RWV modality as High priority.
Nov 30 2018, 1:53 PM · Restricted Project, MITK
nolden closed T25701: Please enter a meaningful title as Invalid.
Nov 30 2018, 1:49 PM · MITK
nolden created T25701: Please enter a meaningful title.
Nov 30 2018, 1:48 PM · MITK

Nov 27 2018

nolden updated subscribers of T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

@full @schererj @kislinsk : how did you convert these files exactly? If I load the DICOM with a current MITK Workbench -> no problem, re-init fine. Save as nifti, quit, restart, load nifti, re-init -> no problem as well.

Nov 27 2018, 5:45 PM · MITK (2018-04-4)
nolden added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

@isensee : what is the source of these images? any chance to get the original DICOM?

Nov 27 2018, 9:37 AM · MITK (2018-04-4)

Nov 26 2018

nolden updated subscribers of T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..
Nov 26 2018, 5:35 PM · MITK (2018-04-4)
nolden updated subscribers of T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

Log output with debug version:

Nov 26 2018, 5:35 PM · MITK (2018-04-4)

Oct 26 2018

nolden assigned T24303: A segmentation should generate all DICOM relevant IDs as soon as it can be referenced. to floca.
Oct 26 2018, 11:59 AM · DICOM, MITK
nolden moved T24303: A segmentation should generate all DICOM relevant IDs as soon as it can be referenced. from Backlog to MITK Meeting on the Request for Discussion board.
Oct 26 2018, 11:59 AM · DICOM, MITK
nolden raised the priority of T20061: MITK crashes when loading 2D segmentation from Low to Normal.

Discussed at MITK meeting: workbench should not crash, no matter how we handle 2D segmentations

Oct 26 2018, 11:58 AM · MITK (2018-04), Restricted Project
nolden removed a project from T24936: Extend render window manager to include functionality of the data manager: Request for Discussion.

Discussed in the MITK meeting: actions will be kept, @kalali will split this task further

Oct 26 2018, 11:24 AM · Restricted Project, MITK
nolden lowered the priority of T25357: Refactor DataNode::GetPropertylist(..) for more const correctness from Normal to Low.
Oct 26 2018, 11:09 AM · MITK
nolden removed a project from T25357: Refactor DataNode::GetPropertylist(..) for more const correctness: Request for Discussion.

Discussed this in the MITK meeting, we agreed this would be an improvement

Oct 26 2018, 11:09 AM · MITK

Oct 22 2018

nolden added a member for OP 4.1: metzger.
Oct 22 2018, 10:54 AM

Oct 12 2018

nolden closed T25469: Improve MITK build experience as Resolved.

Ok, warning level harmonization for Linux and Windows turns out to be impossible at the moment, we have to wait for MSVC updates. The other ideas have been fixed and merged.

Oct 12 2018, 4:11 PM · MITK (2018-04)
nolden committed rMITKa831e1a0c0d1: Improve CMake doxygen handling for WorkbenchRelease configuration (authored by nolden).
Improve CMake doxygen handling for WorkbenchRelease configuration
Oct 12 2018, 11:03 AM

Sep 30 2018

nolden committed rMITKe376a9c250c0: Another fixup for Boost patch (authored by nolden).
Another fixup for Boost patch
Sep 30 2018, 3:40 PM
nolden committed rMITK53778c43fdd1: Deactivate unused parameter warnings on MSVC again (authored by nolden).
Deactivate unused parameter warnings on MSVC again
Sep 30 2018, 2:14 PM
nolden added a comment to T25469: Improve MITK build experience.

Seems we cannot even turn on unused parameter warnings since to many are triggered by external code. There are workarounds, but the proper solution would be on the MSVC side to handle external include directories different from standard ones. This is ongoing work, and at some point there will be CMake support as well

Sep 30 2018, 2:09 PM · MITK (2018-04)
nolden committed rMITK4bc421a754d9: More Boost patch fixups (authored by nolden).
More Boost patch fixups
Sep 30 2018, 2:01 PM
nolden committed rMITKbdca3357c07f: Fixup line endings in Boost patch (authored by nolden).
Fixup line endings in Boost patch
Sep 30 2018, 1:52 PM
nolden committed rMITKbf702e5482e2: Update Boost to 1.68.0 and patch for MSVC 2017 (authored by nolden).
Update Boost to 1.68.0 and patch for MSVC 2017
Sep 30 2018, 12:59 PM
nolden committed rMITK791fc9c1169d: Turn on unused parameter warnings for MSVC (authored by nolden).
Turn on unused parameter warnings for MSVC
Sep 30 2018, 12:59 PM
nolden committed rMITK2b4ed277a869: Update ITK to 4.13.1 (authored by nolden).
Update ITK to 4.13.1
Sep 30 2018, 12:59 PM
nolden added a comment to T25469: Improve MITK build experience.

Latest MSVC update is incompatible with our boost version and leads to compile errors. I will update Boost and add a patch to include the commit mentioned in this thread: https://github.com/boostorg/iostreams/issues/60

Sep 30 2018, 10:57 AM · MITK (2018-04)

Sep 26 2018

nolden added a comment to T25469: Improve MITK build experience.

Ok, further reading lead to the /permissive- option which actually should detect some of these issues in the latest MSVC 2017 Update 15.8 . But I guess this will detect also a lot of other non-standard stuff. Let's see, could be worth the effort in the long run, I will test and report here
`

Sep 26 2018, 10:41 PM · MITK (2018-04)
nolden added a comment to T25469: Improve MITK build experience.

If VS has a warning for these. It would be great to activate them.

Sep 26 2018, 10:37 PM · MITK (2018-04)

Sep 25 2018

nolden updated subscribers of T25469: Improve MITK build experience.

First suggestion: /W34100 , make unused parameters a level 3 warning (our warning level)

Sep 25 2018, 12:32 PM · MITK (2018-04)
nolden created T25469: Improve MITK build experience.
Sep 25 2018, 12:13 PM · MITK (2018-04)
nolden raised a concern with rMITK1dbcb6d9ec91: First fix.

Compile errors in mitkBaseData.cpp

Sep 25 2018, 11:44 AM

Aug 30 2018

nolden closed T24948: MITK doesn't build with gcc 8 as Resolved.
Aug 30 2018, 2:53 PM · MITK (2018-04)
nolden added a comment to T24790: Build fails on Fedora 28.

update: gcc works

Aug 30 2018, 2:52 PM · MITK (2018-04)

Aug 27 2018

nolden added a project to T25192: Enable DICOM SEG conversion for nrrd segmentations: MICO (Demo MICCAI 2018).
Aug 27 2018, 3:52 PM · MICO (Demo MICCAI 2018), MITK

Aug 7 2018

nolden raised the priority of T23340: Wiki page for DICOM QI in MITK from Normal to High.
Aug 7 2018, 7:41 PM · MICO (Demo MICCAI 2018)
nolden created MICO (Demo MICCAI 2018).
Aug 7 2018, 7:38 PM

Aug 6 2018

nolden created DICOM.
Aug 6 2018, 5:57 PM
nolden updated subscribers of T25193: Enable DCMQI in ReleaseConfiguration.
Aug 6 2018, 4:51 PM · MITK (2018-04)
nolden created T25193: Enable DCMQI in ReleaseConfiguration.
Aug 6 2018, 4:50 PM · MITK (2018-04)
nolden created T25192: Enable DICOM SEG conversion for nrrd segmentations.
Aug 6 2018, 4:23 PM · MICO (Demo MICCAI 2018), MITK
nolden assigned T23343: Dicom editor can not load dicom segmentation objects to metzger.

I would have (minor) concerns with directly merging it. The comments raised for the last commit.

Aug 6 2018, 4:15 PM · MICO (Demo MICCAI 2018), MITK (2018-04)

Jul 26 2018

nolden committed rMITK42b27f4153e2: Update DCMQI and DCMTK (authored by nolden).
Update DCMQI and DCMTK
Jul 26 2018, 11:28 AM
nolden added a comment to T24628: DCMQI build fails on ubuntu.

Pushed new branch T24628-dcm-toolkit-update.

Jul 26 2018, 11:28 AM · MITK (2018-04)
nolden committed rMITK802da3e5f2ed: Merge branch 'T24628-update-dicom-toolkits' into T24609-v2018.04-alpha (authored by nolden).
Merge branch 'T24628-update-dicom-toolkits' into T24609-v2018.04-alpha
Jul 26 2018, 11:18 AM
nolden committed rMITK54aeb3e88aed: Changed dcmtk download to tarball (authored by nolden).
Changed dcmtk download to tarball
Jul 26 2018, 11:18 AM
nolden committed rMITK14353400f161: Update DCMQI and DCMTK (authored by nolden).
Update DCMQI and DCMTK
Jul 26 2018, 11:18 AM

Jul 19 2018

nolden committed rMITK47257ca2c29d: Fixed patch again (authored by nolden).
Fixed patch again
Jul 19 2018, 3:26 PM
nolden committed rMITK7f5c57887b32: Fixed line endings in patch file (authored by nolden).
Fixed line endings in patch file
Jul 19 2018, 3:19 PM

Jul 11 2018

nolden updated the image for OP 4.1 (Konsortialtreffen Juli 2018) from F1110276: profile to F1110278: profile.
Jul 11 2018, 12:56 PM
nolden set the image for OP 4.1 (Konsortialtreffen Juli 2018) to F1110276: profile.
Jul 11 2018, 12:55 PM
nolden created OP 4.1 (Konsortialtreffen Juli 2018).
Jul 11 2018, 12:52 PM
nolden updated the image for OP 4.1 from F1110243: profile to F1110245: profile.
Jul 11 2018, 11:58 AM
nolden updated the image for OP 4.1 from F1110241: profile to F1110243: profile.
Jul 11 2018, 11:55 AM