Page MenuHomePhabricator | MITK

nolden (Marco Nolden)Administrator
User

Projects (12)

User Details

User Since
Aug 1 2016, 12:10 PM (115 w, 2 d)
Roles
Administrator

Recent Activity

Fri, Oct 12

nolden closed T25469: Improve MITK build experience as Resolved.

Ok, warning level harmonization for Linux and Windows turns out to be impossible at the moment, we have to wait for MSVC updates. The other ideas have been fixed and merged.

Fri, Oct 12, 4:11 PM · MITK (2018-04)
nolden committed rMITKa831e1a0c0d1: Improve CMake doxygen handling for WorkbenchRelease configuration (authored by nolden).
Improve CMake doxygen handling for WorkbenchRelease configuration
Fri, Oct 12, 11:03 AM

Sun, Sep 30

nolden committed rMITKe376a9c250c0: Another fixup for Boost patch (authored by nolden).
Another fixup for Boost patch
Sun, Sep 30, 3:40 PM
nolden committed rMITK53778c43fdd1: Deactivate unused parameter warnings on MSVC again (authored by nolden).
Deactivate unused parameter warnings on MSVC again
Sun, Sep 30, 2:14 PM
nolden added a comment to T25469: Improve MITK build experience.

Seems we cannot even turn on unused parameter warnings since to many are triggered by external code. There are workarounds, but the proper solution would be on the MSVC side to handle external include directories different from standard ones. This is ongoing work, and at some point there will be CMake support as well

Sun, Sep 30, 2:09 PM · MITK (2018-04)
nolden committed rMITK4bc421a754d9: More Boost patch fixups (authored by nolden).
More Boost patch fixups
Sun, Sep 30, 2:01 PM
nolden committed rMITKbdca3357c07f: Fixup line endings in Boost patch (authored by nolden).
Fixup line endings in Boost patch
Sun, Sep 30, 1:52 PM
nolden committed rMITKbf702e5482e2: Update Boost to 1.68.0 and patch for MSVC 2017 (authored by nolden).
Update Boost to 1.68.0 and patch for MSVC 2017
Sun, Sep 30, 12:59 PM
nolden committed rMITK791fc9c1169d: Turn on unused parameter warnings for MSVC (authored by nolden).
Turn on unused parameter warnings for MSVC
Sun, Sep 30, 12:59 PM
nolden committed rMITK2b4ed277a869: Update ITK to 4.13.1 (authored by nolden).
Update ITK to 4.13.1
Sun, Sep 30, 12:59 PM
nolden added a comment to T25469: Improve MITK build experience.

Latest MSVC update is incompatible with our boost version and leads to compile errors. I will update Boost and add a patch to include the commit mentioned in this thread: https://github.com/boostorg/iostreams/issues/60

Sun, Sep 30, 10:57 AM · MITK (2018-04)

Wed, Sep 26

nolden added a comment to T25469: Improve MITK build experience.

Ok, further reading lead to the /permissive- option which actually should detect some of these issues in the latest MSVC 2017 Update 15.8 . But I guess this will detect also a lot of other non-standard stuff. Let's see, could be worth the effort in the long run, I will test and report here
`

Wed, Sep 26, 10:41 PM · MITK (2018-04)
nolden added a comment to T25469: Improve MITK build experience.

If VS has a warning for these. It would be great to activate them.

Wed, Sep 26, 10:37 PM · MITK (2018-04)

Tue, Sep 25

nolden updated subscribers of T25469: Improve MITK build experience.

First suggestion: /W34100 , make unused parameters a level 3 warning (our warning level)

Tue, Sep 25, 12:32 PM · MITK (2018-04)
nolden created T25469: Improve MITK build experience.
Tue, Sep 25, 12:13 PM · MITK (2018-04)
nolden raised a concern with rMITK1dbcb6d9ec91: First fix.

Compile errors in mitkBaseData.cpp

Tue, Sep 25, 11:44 AM

Aug 30 2018

nolden closed T24948: MITK doesn't build with gcc 8 as Resolved.
Aug 30 2018, 2:53 PM · MITK (2018-04)
nolden added a comment to T24790: Build fails on Fedora 28.

update: gcc works

Aug 30 2018, 2:52 PM · MITK (2018-04)

Aug 27 2018

nolden added a project to T25192: Enable DICOM SEG conversion for nrrd segmentations: MICO (Demo MICCAI 2018).
Aug 27 2018, 3:52 PM · MICO (Demo MICCAI 2018), MITK

Aug 7 2018

nolden raised the priority of T23340: Wiki page for DICOM QI in MITK from Normal to High.
Aug 7 2018, 7:41 PM · MICO (Demo MICCAI 2018)
nolden created MICO (Demo MICCAI 2018).
Aug 7 2018, 7:38 PM

Aug 6 2018

nolden created DICOM.
Aug 6 2018, 5:57 PM
nolden added a comment to T24585: Mirror MITK-Data to Github.com.

To use it one can easily turn on the build applications option in a GDCM-build within a MITK Superbuild

Aug 6 2018, 5:51 PM · MITK (2018-04)
nolden added a comment to T24585: Mirror MITK-Data to Github.com.

DICOM compression could be an option, I used gdcmconv -d and it reduced 4D_TEE_Data_MV.dcm from 100MB to 30MB

Aug 6 2018, 5:50 PM · MITK (2018-04)
nolden updated subscribers of T25193: Enable DCMQI in ReleaseConfiguration.
Aug 6 2018, 4:51 PM · MITK (2018-04)
nolden created T25193: Enable DCMQI in ReleaseConfiguration.
Aug 6 2018, 4:50 PM · MITK (2018-04)
nolden created T25192: Enable DICOM SEG conversion for nrrd segmentations.
Aug 6 2018, 4:23 PM · MICO (Demo MICCAI 2018), MITK
nolden assigned T23343: Dicom editor can not load dicom segmentation objects to metzger.

I would have (minor) concerns with directly merging it. The comments raised for the last commit.

Aug 6 2018, 4:15 PM · MICO (Demo MICCAI 2018), MITK (2018-04)

Jul 26 2018

nolden committed rMITK42b27f4153e2: Update DCMQI and DCMTK (authored by nolden).
Update DCMQI and DCMTK
Jul 26 2018, 11:28 AM
nolden added a comment to T24628: DCMQI build fails on ubuntu.

Pushed new branch T24628-dcm-toolkit-update.

Jul 26 2018, 11:28 AM · MITK (2018-04)
nolden committed rMITK802da3e5f2ed: Merge branch 'T24628-update-dicom-toolkits' into T24609-v2018.04-alpha (authored by nolden).
Merge branch 'T24628-update-dicom-toolkits' into T24609-v2018.04-alpha
Jul 26 2018, 11:18 AM
nolden committed rMITK54aeb3e88aed: Changed dcmtk download to tarball (authored by nolden).
Changed dcmtk download to tarball
Jul 26 2018, 11:18 AM
nolden committed rMITK14353400f161: Update DCMQI and DCMTK (authored by nolden).
Update DCMQI and DCMTK
Jul 26 2018, 11:18 AM

Jul 19 2018

nolden committed rMITK47257ca2c29d: Fixed patch again (authored by nolden).
Fixed patch again
Jul 19 2018, 3:26 PM
nolden committed rMITK7f5c57887b32: Fixed line endings in patch file (authored by nolden).
Fixed line endings in patch file
Jul 19 2018, 3:19 PM

Jul 11 2018

nolden updated the image for OP 4.1 (Konsortialtreffen Juli 2018) from F1110276: profile to F1110278: profile.
Jul 11 2018, 12:56 PM
nolden set the image for OP 4.1 (Konsortialtreffen Juli 2018) to F1110276: profile.
Jul 11 2018, 12:55 PM
nolden created OP 4.1 (Konsortialtreffen Juli 2018).
Jul 11 2018, 12:52 PM
nolden updated the image for OP 4.1 from F1110243: profile to F1110245: profile.
Jul 11 2018, 11:58 AM
nolden updated the image for OP 4.1 from F1110241: profile to F1110243: profile.
Jul 11 2018, 11:55 AM
nolden set the image for OP 4.1 to F1110241: profile.
Jul 11 2018, 11:54 AM
nolden created OP 4.1.
Jul 11 2018, 11:53 AM

Jun 27 2018

nolden created T24994: Qt library version mix crashes Workbench on first launch.
Jun 27 2018, 12:54 PM · MITK
nolden created T24993: DICOM Plugin doesn't build.
Jun 27 2018, 12:52 PM · MITK (2018-04)

Jun 26 2018

nolden added a comment to T24628: DCMQI build fails on ubuntu.

And another thing: update requires clean builds of DCMQI and DCMTK, so continuous clients will probably fail

Jun 26 2018, 7:02 PM · MITK (2018-04)
nolden added a revision to T24628: DCMQI build fails on ubuntu: Unknown Object (Differential Revision).
Jun 26 2018, 7:01 PM · MITK (2018-04)
nolden added a comment to T24628: DCMQI build fails on ubuntu.

Ok, I updated my fork to use the latest DCMQI with our modifications as well as a new jsoncpp version which solves the compilation issues. As a side effect, we have to update DCMTK, but I think it should be worth it before the release.

Jun 26 2018, 6:56 PM · MITK (2018-04)

Jun 25 2018

nolden committed rMITK5cca5d8fda62: Fix issues with GCC 8 (authored by nolden).
Fix issues with GCC 8
Jun 25 2018, 5:50 PM
nolden committed rMITKc306590d032b: Summary: Fixed Linux-specific Qt plugin path (authored by nolden).
Summary: Fixed Linux-specific Qt plugin path
Jun 25 2018, 5:38 PM

Jun 22 2018

nolden added a revision to T24609: v2018.04-alpha: Unknown Object (Differential Revision).
Jun 22 2018, 4:01 PM · MITK (2018-04)
nolden added a revision to T24609: v2018.04-alpha: Unknown Object (Differential Revision).
Jun 22 2018, 3:16 PM · MITK (2018-04)
nolden edited projects for T23040: PluginGenerator doesn't work, added: MITK (2018-04); removed MITK.

I have seen the fixes deactivating QNetwork in 1881c497af3e4b810d131a2c05bb819e485bf4e7 . However this also removed the
-n option command line option to disable networking. This option is used by the plugin generator tests. I could remove it there, but @kislinsk I think we should discuss the general strategy.

Jun 22 2018, 10:16 AM · MITK (2018-04)
nolden triaged T24951: mitkGIFVolumetricDensityStatisticsTest fails randomly as High priority.
Jun 22 2018, 10:03 AM · MITK (2018-04)
nolden claimed T24948: MITK doesn't build with gcc 8.
Jun 22 2018, 9:34 AM · MITK (2018-04)
nolden created T24948: MITK doesn't build with gcc 8.
Jun 22 2018, 9:13 AM · MITK (2018-04)

May 18 2018

nolden committed rMITKb6b7765231c3: Fixed some warnings (authored by nolden).
Fixed some warnings
May 18 2018, 11:04 AM
nolden committed rMITKa668342973e8: Fixed some warnings (authored by nolden).
Fixed some warnings
May 18 2018, 10:36 AM

May 17 2018

nolden added a revision to T24790: Build fails on Fedora 28: Unknown Object (Differential Revision).
May 17 2018, 7:35 PM · MITK (2018-04)
nolden created T24790: Build fails on Fedora 28.
May 17 2018, 7:24 PM · MITK (2018-04)

Mar 16 2018

nolden added a watcher for MITK (2018-04): nolden.
Mar 16 2018, 1:40 PM

Mar 14 2018

nolden created T24402: Improve clang-format support.
Mar 14 2018, 7:39 AM · MITK
nolden committed rMITKcf75ee78bdd2: C++11 modernizations and warning fixes (authored by nolden).
C++11 modernizations and warning fixes
Mar 14 2018, 2:23 AM

Mar 8 2018

nolden committed rMITK81491e3f5dfb: Merge branch 'T23293-modernization-fixup' (authored by nolden).
Merge branch 'T23293-modernization-fixup'
Mar 8 2018, 2:58 PM
nolden committed rMITKe75305ecc20b: Fixed NumberOfExtractedPoints issue in SurfaceInterpolation (authored by nolden).
Fixed NumberOfExtractedPoints issue in SurfaceInterpolation
Mar 8 2018, 2:57 PM
nolden added a comment to T23293: Apply C++ 11 modernizations.

Pushed new branch T23293-modernization-fixup.

Mar 8 2018, 2:57 PM · MITK

Mar 6 2018

kislinsk awarded T23293: Apply C++ 11 modernizations a Hungry Hippo token.
Mar 6 2018, 1:00 PM · MITK

Mar 5 2018

nolden added a revision to T23293: Apply C++ 11 modernizations: Unknown Object (Differential Revision).
Mar 5 2018, 5:29 PM · MITK
nolden committed rMITKd68b665b72b0: C++11 modernizations (authored by nolden).
C++11 modernizations
Mar 5 2018, 5:04 PM
nolden committed rMITKcd2d656228e1: Fixed some warnings (authored by nolden).
Fixed some warnings
Mar 5 2018, 5:04 PM
nolden committed rMITK59dcace96cdf: Fixed ambiguous naming of template parameter ShOrder (authored by nolden).
Fixed ambiguous naming of template parameter ShOrder
Mar 5 2018, 5:04 PM
nolden committed rMITKefb6f7ea0957: Fixed initialization order warning (authored by nolden).
Fixed initialization order warning
Mar 5 2018, 5:04 PM
nolden committed rMITKc684203445fb: Removed unneccesary overload of GetNumberOfExtractedPoints (authored by nolden).
Removed unneccesary overload of GetNumberOfExtractedPoints
Mar 5 2018, 5:04 PM
nolden committed rMITK04bf0b4d4a66: Fixed auto_ptr usage in CppUnit (authored by nolden).
Fixed auto_ptr usage in CppUnit
Mar 5 2018, 5:04 PM
nolden added a comment to T23293: Apply C++ 11 modernizations.

Pushed new branch T23293-more-modernizations-and-warning-fixes.

Mar 5 2018, 5:03 PM · MITK
nolden added a comment to T24346: Wrong handling of overlap parameter in tractography evaluation.

Same for threshold in FiberExtractionRoi

Mar 5 2018, 10:17 AM · MITK
nolden created T24346: Wrong handling of overlap parameter in tractography evaluation.
Mar 5 2018, 10:14 AM · MITK

Mar 2 2018

nolden added a comment to T24342: Make ToFProcessing memory safe.

The patch:

Mar 2 2018, 3:26 PM · MITK
nolden created T24342: Make ToFProcessing memory safe.
Mar 2 2018, 3:25 PM · MITK
nolden committed rMITKc22088fa1723: Fix linker error related to ITKIOBruker and ITKIOMINC (authored by nolden).
Fix linker error related to ITKIOBruker and ITKIOMINC
Mar 2 2018, 12:09 PM

Feb 8 2018

nolden committed rMITK0a2e648b9842: Enforce Python 3 in VTK build (authored by nolden).
Enforce Python 3 in VTK build
Feb 8 2018, 5:04 PM
nolden committed rMITKeaa849b9174e: Don't enforce CMAKE_PREFIX_PATH setting (authored by nolden).
Don't enforce CMAKE_PREFIX_PATH setting
Feb 8 2018, 5:04 PM
nolden committed rMITKdcbb38a9afe2: Fix linker error related to ITKIOBruker and ITKIOMINC (authored by nolden).
Fix linker error related to ITKIOBruker and ITKIOMINC
Feb 8 2018, 5:04 PM

Dec 19 2017

nolden committed rMITKb7c20d3e8f55: Merge branch 'T23775-warnings-no-errors-for-apps' (authored by nolden).
Merge branch 'T23775-warnings-no-errors-for-apps'
Dec 19 2017, 7:10 PM
nolden committed rMITKa43a844682c2: Add WARNINGS_NO_ERRORS option for command line tool build (authored by nolden).
Add WARNINGS_NO_ERRORS option for command line tool build
Dec 19 2017, 7:07 PM
nolden added a comment to T23775: "ExtensionPoint" support for SuperBuild.

Pushed new branch T23775-warnings-no-errors-for-apps.

Dec 19 2017, 7:07 PM · MITK
nolden claimed T23775: "ExtensionPoint" support for SuperBuild.
Dec 19 2017, 7:03 PM · MITK
nolden reopened T23775: "ExtensionPoint" support for SuperBuild as "Open".

I will add a little feature: a WARNINGS_NO_ERRORS option for the mitkFunctionCreateCommandLineApp CMake function

Dec 19 2017, 7:03 PM · MITK
nolden reopened T23775: "ExtensionPoint" support for SuperBuild, a subtask of T23721: Project "Astonishing Angelfish", as Open.
Dec 19 2017, 7:03 PM · MITK

Dec 18 2017

nolden triaged T23973: Improve MITK HiDPI support as Wishlist priority.
Dec 18 2017, 4:07 PM · MITK

Nov 21 2017

nolden created T23798: MITK has new memory leaks breaking unit tests.
Nov 21 2017, 8:32 PM · MITK
nolden committed rMITK69e45e2f9f0f: More C++11 'override' additions (authored by nolden).
More C++11 'override' additions
Nov 21 2017, 5:56 PM
nolden committed rMITK0b7158a90336: Merge branch 'T23268-more-clang-fixes' (authored by nolden).
Merge branch 'T23268-more-clang-fixes'
Nov 21 2017, 5:55 PM
nolden committed rMITKf7cf92d38c03: Fixed some warnings (authored by nolden).
Fixed some warnings
Nov 21 2017, 5:26 PM
nolden committed rMITK19385df73433: COMP: wrong member gradationLabel (authored by nolden).
COMP: wrong member gradationLabel
Nov 21 2017, 5:25 PM

Nov 17 2017

nolden committed rMITKc102a13cca53: More C++11 'override' additions (authored by nolden).
More C++11 'override' additions
Nov 17 2017, 12:34 PM
nolden added a comment to T23737: Introduce IIdentifiable.

if the ID is unique, this should maybe named getUID . And I wonder if we should make the IDType a proper class, did you discuss this?

Nov 17 2017, 11:50 AM · MITK

Nov 13 2017

nolden added a comment to T23554: MitkChart: Memory management of QmitkChartxyData.

I included this in my "clang" branch since I thought it was a local problem. You can cherry pick the fix, don't know when I can merge

Nov 13 2017, 9:08 AM · MITK, Restricted Project
nolden added a revision to T23268: Build errors with clang 3.8.1 (Debian 9.1 "Stretch"): Unknown Object (Differential Revision).
Nov 13 2017, 8:28 AM · MITK
nolden committed rMITK94bfc6a7773a: More C++11 'override' additions (authored by nolden).
More C++11 'override' additions
Nov 13 2017, 8:15 AM
nolden committed rMITKa7b4b26e5673: COMP: qDeleteAll reference problem (authored by nolden).
COMP: qDeleteAll reference problem
Nov 13 2017, 8:15 AM