- User Since
- Aug 1 2016, 12:10 PM (159 w, 2 d)
Jul 2 2019
Sorry for jumping in late. I'm afraid currently we are anyway not testing any encoding stuff sufficiently.
Jul 1 2019
Jun 27 2019
Pushed new branch T26431-compilation-fixes-gcc9-clang8.
Apr 5 2019
Mar 28 2019
Feb 8 2019
Looks like the Slicer warning is important, but still it succeeds in loading the data. The numerical error is rather low. Found this discussion which also links to the python code Slicer is using and which emits the warning. Could be of some use for further investigations. https://discourse.slicer.org/t/dicom-scalar-volume-load-irregular-geometry-warning-overly-stringent/3761/14
Feb 6 2019
Feb 4 2019
Dec 20 2018
Dec 11 2018
Nov 30 2018
Nov 27 2018
@full @schererj @kislinsk : how did you convert these files exactly? If I load the DICOM with a current MITK Workbench -> no problem, re-init fine. Save as nifti, quit, restart, load nifti, re-init -> no problem as well.
@isensee : what is the source of these images? any chance to get the original DICOM?
Nov 26 2018
Log output with debug version:
Oct 26 2018
Discussed at MITK meeting: workbench should not crash, no matter how we handle 2D segmentations
Discussed in the MITK meeting: actions will be kept, @kalali will split this task further
Discussed this in the MITK meeting, we agreed this would be an improvement
Oct 22 2018
Oct 12 2018
Ok, warning level harmonization for Linux and Windows turns out to be impossible at the moment, we have to wait for MSVC updates. The other ideas have been fixed and merged.
Sep 30 2018
Seems we cannot even turn on unused parameter warnings since to many are triggered by external code. There are workarounds, but the proper solution would be on the MSVC side to handle external include directories different from standard ones. This is ongoing work, and at some point there will be CMake support as well
Latest MSVC update is incompatible with our boost version and leads to compile errors. I will update Boost and add a patch to include the commit mentioned in this thread: https://github.com/boostorg/iostreams/issues/60
Sep 26 2018
Ok, further reading lead to the /permissive- option which actually should detect some of these issues in the latest MSVC 2017 Update 15.8 . But I guess this will detect also a lot of other non-standard stuff. Let's see, could be worth the effort in the long run, I will test and report here
Sep 25 2018
First suggestion: /W34100 , make unused parameters a level 3 warning (our warning level)
Compile errors in mitkBaseData.cpp
Aug 30 2018
update: gcc works
Aug 27 2018
Aug 7 2018
Aug 6 2018
Jul 26 2018
Pushed new branch T24628-dcm-toolkit-update.
Jul 19 2018
Jul 11 2018
Jun 27 2018
Jun 26 2018
And another thing: update requires clean builds of DCMQI and DCMTK, so continuous clients will probably fail
Ok, I updated my fork to use the latest DCMQI with our modifications as well as a new jsoncpp version which solves the compilation issues. As a side effect, we have to update DCMTK, but I think it should be worth it before the release.
Jun 25 2018
Jun 22 2018
I have seen the fixes deactivating QNetwork in 1881c497af3e4b810d131a2c05bb819e485bf4e7 . However this also removed the
-n option command line option to disable networking. This option is used by the plugin generator tests. I could remove it there, but @kislinsk I think we should discuss the general strategy.
May 18 2018
May 17 2018
Mar 16 2018
Mar 14 2018
Mar 8 2018
Pushed new branch T23293-modernization-fixup.