Page MenuHomePhabricator

nolden (Marco Nolden)
UserAdministrator

Projects (12)

User Details

User Since
Aug 1 2016, 12:10 PM (191 w, 5 d)
Roles
Administrator

Recent Activity

Fri, Mar 27

nolden edited projects for T26959: Newly created LabelSet segmentation is not displayed as "outline binary", added: MITK (2020); removed MITK.
Fri, Mar 27, 4:35 PM · MITK (2020)
nolden edited projects for T27086: Long file names force segmentation plugin to expand in order to be usable., added: MITK (2020); removed MITK.
Fri, Mar 27, 4:34 PM · MITK (2020)
nolden edited projects for T27085: 2D region growing tool fails for low intensity regions, added: MITK (2020); removed MITK.

This was reported as relevant for medical expert segmentation work

Fri, Mar 27, 4:34 PM · MITK (2020)
nolden added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

We discussed this in the MITK meeting today and identified two possible reasons.

Fri, Mar 27, 11:32 AM · MITK, Request for Discussion

Fri, Mar 20

nolden triaged T27247: MITK_SHOW_CONSOLE_WINDOW is not honored in mitk_create_executable function as Normal priority.
Fri, Mar 20, 11:43 AM · MITK (2020)

Fri, Mar 6

nolden added a comment to T27203: QmitkAbstractNodeSelectionWidgetTest regularly fails on headless Linux.

Nice work! I ran into this as well just a few hours ago and thought it would be nice to evaluate alternative Qt platform options for tests ;)

Fri, Mar 6, 4:30 PM · MITK
nolden lowered the priority of T27177: Segmentation based on Multiframe CT can not be saved as DICOM without error message from Unbreak Now! to Low.

The modality of the referenced image is a so-called Enhanced CT Image originating from a 3D C-Arm. It is a current limitation of dcmqi to handle these multiframe series as input, see https://github.com/QIICR/dcmqi/issues/217 . It's not an easy fix in dcmqi and we already discussed with the developers. For now I think we have to keep this in our backlog.

Fri, Mar 6, 4:22 PM · Restricted Project, MITK
nolden renamed T27177: Segmentation based on Multiframe CT can not be saved as DICOM without error message from Dicom segmentation can not be saved as .dcm without error message to Segmentation based on Multiframe CT can not be saved as DICOM without error message.
Fri, Mar 6, 3:38 PM · Restricted Project, MITK

Mar 3 2020

nolden created T27186: New segmentation behaviour can be confusing.
Mar 3 2020, 4:09 PM · MITK
nolden triaged T27185: Create new segmentation is sometimes disabled as Unbreak Now! priority.
Mar 3 2020, 4:05 PM · MITK
nolden created T27184: Clipping plane deformation tool doesn't show updates in 3d window.
Mar 3 2020, 3:53 PM · MITK
nolden added a comment to T27177: Segmentation based on Multiframe CT can not be saved as DICOM without error message.

@thomass Which version did you test this with?

Mar 3 2020, 11:23 AM · Restricted Project, MITK

Feb 14 2020

nolden added a revision to T25745: Integrate new DICOM browser widget from CTK: Unknown Object (Differential Revision).
Feb 14 2020, 2:08 PM · MITK

Feb 10 2020

nolden committed rMITKc55b6aae65cd: Don't reorder includes during clang-format (authored by nolden).
Don't reorder includes during clang-format
Feb 10 2020, 11:55 AM
nolden committed rMITK28a1559a42c5: Don't format anything in the PluginGenerator and templates (authored by nolden).
Don't format anything in the PluginGenerator and templates
Feb 10 2020, 11:55 AM
nolden committed rMITKea713e14c00a: Change inner namespace indentation (authored by nolden).
Change inner namespace indentation
Feb 10 2020, 11:55 AM
nolden committed rMITK2739cf55c171: Fix missing include for MitkIpPicDescriptor (authored by nolden).
Fix missing include for MitkIpPicDescriptor
Feb 10 2020, 11:54 AM
nolden added a comment to T24402: Improve clang-format support.

Pushed new branch T24402-clang-format-improvements.

Feb 10 2020, 11:54 AM · MITK
nolden committed rMITKa41a8d973980: Fix PluginGenerator tests (authored by nolden).
Fix PluginGenerator tests
Feb 10 2020, 11:53 AM
nolden added a comment to T27084: Clean up, improve and test PluginGenerator, ProjectTemplate and MITK_EXTENSION_DIRS mechanism.

Pushed new branch T27084-fix-plugin-generator-tests.

Feb 10 2020, 11:52 AM · Request for Discussion, MITK
nolden updated subscribers of T27084: Clean up, improve and test PluginGenerator, ProjectTemplate and MITK_EXTENSION_DIRS mechanism.
Feb 10 2020, 11:40 AM · Request for Discussion, MITK
nolden triaged T27084: Clean up, improve and test PluginGenerator, ProjectTemplate and MITK_EXTENSION_DIRS mechanism as Normal priority.
Feb 10 2020, 11:40 AM · Request for Discussion, MITK
nolden closed T23040: PluginGenerator doesn't work as Resolved.

Just tested this, works for me. If this is still an issue please re-open.

Feb 10 2020, 11:26 AM · MITK

Feb 7 2020

nolden reassigned T23163: MBI Wiki inventory from nolden to neher.

Peter, Du warst der letzte Aktive ;)

Feb 7 2020, 5:35 PM · Restricted Project
nolden committed rMITKb1587c557765: Fix DICOM SEG read error by updating DCMQI (authored by nolden).
Fix DICOM SEG read error by updating DCMQI
Feb 7 2020, 5:30 PM
nolden closed T25745: Integrate new DICOM browser widget from CTK as Resolved.

This was resolved by T25983

Feb 7 2020, 5:10 PM · MITK
nolden committed rMITKba4a121c0bbc: Use a more recent version of ITK for GCC 9 compatibility (authored by nolden).
Use a more recent version of ITK for GCC 9 compatibility
Feb 7 2020, 5:06 PM

Feb 4 2020

nolden added a comment to T24402: Improve clang-format support.

For the transition process, these bits from the git merge manpage could be useful as well:

Feb 4 2020, 4:28 PM · MITK
nolden added a comment to T24402: Improve clang-format support.

I just picked this up in a small experiment:

Feb 4 2020, 3:12 PM · MITK

Feb 2 2020

nolden closed T25983: Update DICOM related toolkits as Resolved.

Nightly CI looks good as well.

Feb 2 2020, 9:08 AM · MITK, DICOM

Feb 1 2020

nolden committed rMITKd530fc949cb2: Updated CTK and DICOM related toolkits (authored by nolden).
Updated CTK and DICOM related toolkits
Feb 1 2020, 10:52 AM
nolden committed rMITK24d31e394802: Updated CTK and DICOM related toolkits (authored by nolden).
Updated CTK and DICOM related toolkits
Feb 1 2020, 10:52 AM
nolden committed rMITKeedccf5124d6: Fixed CTK URL (authored by nolden).
Fixed CTK URL
Feb 1 2020, 10:52 AM

Jan 31 2020

nolden added a revision to T25983: Update DICOM related toolkits: Unknown Object (Differential Revision).
Jan 31 2020, 5:21 PM · MITK, DICOM

Jan 9 2020

nolden updated subscribers of T26962: Improve dynamic analysis and test coverage reporting.

As @kalali pointed out there was some previous tooling research done internally: T22218

Jan 9 2020, 6:42 PM · CI, MITK
nolden closed T13690: Missing tests in Core\Code\Rendering as Resolved.

I will close this task now. There was valuable work done on adding and updating tests, but this will never be finished anyway. New developments in that area will be tracked in T26962.

Jan 9 2020, 6:40 PM · Bugzilla, MITK
nolden closed T13692: Missing Tests in Core as Resolved.

I will close this task now. There was valuable work done on adding and updating tests, but this will never be finished anyway. New developments in that area will be tracked in T26962.

Jan 9 2020, 6:40 PM · MITK, Bugzilla
nolden renamed T26962: Improve dynamic analysis and test coverage reporting from Improve dynamic analysis reporting to Improve dynamic analysis and test coverage reporting.
Jan 9 2020, 6:39 PM · CI, MITK

Jan 8 2020

nolden triaged T26962: Improve dynamic analysis and test coverage reporting as Wishlist priority.
Jan 8 2020, 10:32 AM · CI, MITK

Jan 7 2020

nolden added a comment to T26955: MitkQtPythonTest fails because of missing library dependencies on Linux.

I can confirm this works. One downside I realized with the current solution is that it only works if the test is executed through ctest, i.e. ctest -R Pytohn , but if you start the driver directly the same problem occurs. I think it is ok for now, but would be some motivation to find a solution that works without a special environment, since for example while debugging you usually start the executable directly.

Jan 7 2020, 5:45 PM · MITK

Dec 19 2019

nolden triaged T26942: Crash on DICOM loading as Normal priority.
Dec 19 2019, 1:54 PM · DICOM, d:cipher, MITK

Dec 16 2019

nolden created T26934: Multiple logos in screenshot when using screenshot maker plugin.
Dec 16 2019, 5:35 PM · MITK

Nov 25 2019

nolden committed rMITK83f50cd74bc2: Removed some unnecessary copying of BoundsArrays (authored by nolden).
Removed some unnecessary copying of BoundsArrays
Nov 25 2019, 1:06 PM

Oct 25 2019

nolden added a member for MITK-MBI: k656s.
Oct 25 2019, 4:52 PM
nolden added a member for MITK: k656s.
Oct 25 2019, 4:44 PM

Oct 22 2019

nolden added a comment to T23293: Apply C++ 11 modernizations.

Thanks for picking up!

Oct 22 2019, 5:33 PM · MITK
nolden added inline comments to rMITK029a4ba313e1: Modernize usage of auto keyword with clang-tidy.
Oct 22 2019, 5:31 PM

Oct 19 2019

nolden updated the task description for T26721: Prepare Qt 5.13 compatibility.
Oct 19 2019, 9:28 AM · MITK
nolden renamed T26721: Prepare Qt 5.13 compatibility from Fix Qt 5.13 compatibility to Prepare Qt 5.13 compatibility.
Oct 19 2019, 9:27 AM · MITK

Oct 11 2019

nolden added a comment to F1442653: grafik.png.

@hentsch Thanks, is this complete? Could you mail it if it should stay confidential?

Oct 11 2019, 2:47 PM

Oct 2 2019

nolden triaged T26721: Prepare Qt 5.13 compatibility as Low priority.
Oct 2 2019, 1:54 PM · MITK

Oct 1 2019

nolden created T26720: Fix build problems with Qt 5.13.
Oct 1 2019, 4:04 PM

Sep 30 2019

nolden added a revision to T26431: Fix gcc 9 and clang 8 compilation: Unknown Object (Differential Revision).
Sep 30 2019, 4:34 PM · MITK
nolden committed rMITK1a5a833c568b: Fixed Python 3.7 build errors and some warnings (authored by nolden).
Fixed Python 3.7 build errors and some warnings
Sep 30 2019, 1:20 PM
nolden committed rMITK6fc185bd8f1f: Fixed some exception catch warnings (authored by nolden).
Fixed some exception catch warnings
Sep 30 2019, 1:20 PM
nolden committed rMITK14e2a7bd2858: Fixed exception catch warnings (authored by nolden).
Fixed exception catch warnings
Sep 30 2019, 1:20 PM
nolden committed rMITKbda8c3526996: Don't treat cast function warnings as errors (authored by nolden).
Don't treat cast function warnings as errors
Sep 30 2019, 1:20 PM
nolden committed rMITKc83dbd285d90: Fixed threads related python build error (authored by nolden).
Fixed threads related python build error
Sep 30 2019, 1:20 PM
nolden committed rMITK4080d473bc81: Fixed warnings in exception handling (authored by nolden).
Fixed warnings in exception handling
Sep 30 2019, 1:20 PM

Sep 24 2019

nolden added a revision to T26701: Build errors with Python 3.7 and latest gcc: Unknown Object (Differential Revision).
Sep 24 2019, 2:28 PM · MITK
nolden added a comment to T26701: Build errors with Python 3.7 and latest gcc.

Possible fix is a reordering of includes in mitkPythonService.h , I could not find out exactly what's wrong.

Sep 24 2019, 10:38 AM · MITK
nolden triaged T26701: Build errors with Python 3.7 and latest gcc as High priority.
Sep 24 2019, 10:29 AM · MITK

Jul 2 2019

nolden added a comment to T25535: DCMTK won't build if Anaconda is installed.

Sorry for jumping in late. I'm afraid currently we are anyway not testing any encoding stuff sufficiently.

Jul 2 2019, 2:24 PM · MITK
nolden committed rMITK5ad6bccb0282: Use a more recent version of ITK for GCC 9 compatibility (authored by nolden).
Use a more recent version of ITK for GCC 9 compatibility
Jul 2 2019, 2:03 PM

Jul 1 2019

nolden added a revision to T26431: Fix gcc 9 and clang 8 compilation: Unknown Object (Differential Revision).
Jul 1 2019, 5:26 PM · MITK

Jun 27 2019

nolden committed rMITKb215d08c5417: Compilation fixes for recent GCC and clang compilers (authored by nolden).
Compilation fixes for recent GCC and clang compilers
Jun 27 2019, 2:27 PM
nolden added a revision to T26431: Fix gcc 9 and clang 8 compilation: Unknown Object (Differential Revision).
Jun 27 2019, 2:19 PM · MITK
nolden committed rMITKcd9f24b3ede4: Fixed some exception handling code to be more correct (authored by nolden).
Fixed some exception handling code to be more correct
Jun 27 2019, 1:40 PM
nolden committed rMITK5011a62ca142: Don't fail on gcc 9 warnings about copy ctors (authored by nolden).
Don't fail on gcc 9 warnings about copy ctors
Jun 27 2019, 1:40 PM
nolden committed rMITK8182f13b5cd9: Fixes for clang compilation (authored by nolden).
Fixes for clang compilation
Jun 27 2019, 1:40 PM
nolden added a comment to T26431: Fix gcc 9 and clang 8 compilation.

Pushed new branch T26431-compilation-fixes-gcc9-clang8.

Jun 27 2019, 1:40 PM · MITK
nolden triaged T26431: Fix gcc 9 and clang 8 compilation as Normal priority.
Jun 27 2019, 10:17 AM · MITK

Apr 5 2019

nolden accepted rMITK1dbcb6d9ec91: First fix.
Apr 5 2019, 3:07 PM

Mar 28 2019

nolden closed T23268: Build errors with clang 3.8.1 (Debian 9.1 "Stretch") as Resolved.
Mar 28 2019, 5:16 PM · MITK

Feb 8 2019

nolden added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

Looks like the Slicer warning is important, but still it succeeds in loading the data. The numerical error is rather low. Found this discussion which also links to the python code Slicer is using and which emits the warning. Could be of some use for further investigations. https://discourse.slicer.org/t/dicom-scalar-volume-load-irregular-geometry-warning-overly-stringent/3761/14

Feb 8 2019, 8:39 AM · MITK

Feb 6 2019

nolden changed the join policy for DICOM.
Feb 6 2019, 1:37 PM
nolden added projects to T25984: add Meaning of dicom tags to data (node) properties: MITK, DICOM.
Feb 6 2019, 11:01 AM · DICOM, MITK, Restricted Project

Feb 4 2019

nolden triaged T25983: Update DICOM related toolkits as Normal priority.
Feb 4 2019, 2:35 PM · MITK, DICOM

Dec 20 2018

nolden moved T25490: OP4.1 workshop demonstration from Backlog to Konsortialtreffen Juli 2018 on the OP 4.1 board.
Dec 20 2018, 2:33 PM · OP 4.1 (Konsortialtreffen Juli 2018), Restricted Project

Dec 11 2018

nolden claimed T25745: Integrate new DICOM browser widget from CTK.
Dec 11 2018, 11:59 PM · MITK
nolden triaged T25745: Integrate new DICOM browser widget from CTK as Normal priority.
Dec 11 2018, 11:57 PM · MITK

Nov 30 2018

nolden added a project to T25702: DICOM sort fails for RWV modality: Restricted Project.
Nov 30 2018, 1:53 PM · Restricted Project, MITK
nolden triaged T25702: DICOM sort fails for RWV modality as High priority.
Nov 30 2018, 1:53 PM · Restricted Project, MITK
nolden closed T25701: Please enter a meaningful title as Invalid.
Nov 30 2018, 1:49 PM · MITK
nolden created T25701: Please enter a meaningful title.
Nov 30 2018, 1:48 PM · MITK

Nov 27 2018

nolden updated subscribers of T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

@full @schererj @kislinsk : how did you convert these files exactly? If I load the DICOM with a current MITK Workbench -> no problem, re-init fine. Save as nifti, quit, restart, load nifti, re-init -> no problem as well.

Nov 27 2018, 5:45 PM · MITK
nolden added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

@isensee : what is the source of these images? any chance to get the original DICOM?

Nov 27 2018, 9:37 AM · MITK

Nov 26 2018

nolden updated subscribers of T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..
Nov 26 2018, 5:35 PM · MITK
nolden updated subscribers of T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

Log output with debug version:

Nov 26 2018, 5:35 PM · MITK

Oct 26 2018

nolden assigned T24303: A segmentation should generate all DICOM relevant IDs as soon as it can be referenced. to floca.
Oct 26 2018, 11:59 AM · DICOM, MITK
nolden moved T24303: A segmentation should generate all DICOM relevant IDs as soon as it can be referenced. from Backlog to MITK Meeting on the Request for Discussion board.
Oct 26 2018, 11:59 AM · DICOM, MITK
nolden raised the priority of T20061: MITK crashes when loading 2D segmentation from Low to Normal.

Discussed at MITK meeting: workbench should not crash, no matter how we handle 2D segmentations

Oct 26 2018, 11:58 AM · MITK (2018-04), Restricted Project
nolden removed a project from T24936: Extend render window manager to include functionality of the data manager: Request for Discussion.

Discussed in the MITK meeting: actions will be kept, @kalali will split this task further

Oct 26 2018, 11:24 AM · Restricted Project, MITK
nolden lowered the priority of T25357: Refactor DataNode::GetPropertylist(..) for more const correctness from Normal to Low.
Oct 26 2018, 11:09 AM · MITK
nolden removed a project from T25357: Refactor DataNode::GetPropertylist(..) for more const correctness: Request for Discussion.

Discussed this in the MITK meeting, we agreed this would be an improvement

Oct 26 2018, 11:09 AM · MITK

Oct 22 2018

nolden added a member for OP 4.1: metzger.
Oct 22 2018, 10:54 AM

Oct 12 2018

nolden closed T25469: Improve MITK build experience as Resolved.

Ok, warning level harmonization for Linux and Windows turns out to be impossible at the moment, we have to wait for MSVC updates. The other ideas have been fixed and merged.

Oct 12 2018, 4:11 PM · MITK (2018-04)
nolden committed rMITKa831e1a0c0d1: Improve CMake doxygen handling for WorkbenchRelease configuration (authored by nolden).
Improve CMake doxygen handling for WorkbenchRelease configuration
Oct 12 2018, 11:03 AM

Sep 30 2018

nolden committed rMITKe376a9c250c0: Another fixup for Boost patch (authored by nolden).
Another fixup for Boost patch
Sep 30 2018, 3:40 PM
nolden committed rMITK53778c43fdd1: Deactivate unused parameter warnings on MSVC again (authored by nolden).
Deactivate unused parameter warnings on MSVC again
Sep 30 2018, 2:14 PM