- User Since
- Aug 1 2016, 12:10 PM (115 w, 2 d)
Fri, Oct 12
Ok, warning level harmonization for Linux and Windows turns out to be impossible at the moment, we have to wait for MSVC updates. The other ideas have been fixed and merged.
Sun, Sep 30
Seems we cannot even turn on unused parameter warnings since to many are triggered by external code. There are workarounds, but the proper solution would be on the MSVC side to handle external include directories different from standard ones. This is ongoing work, and at some point there will be CMake support as well
Latest MSVC update is incompatible with our boost version and leads to compile errors. I will update Boost and add a patch to include the commit mentioned in this thread: https://github.com/boostorg/iostreams/issues/60
Wed, Sep 26
Ok, further reading lead to the /permissive- option which actually should detect some of these issues in the latest MSVC 2017 Update 15.8 . But I guess this will detect also a lot of other non-standard stuff. Let's see, could be worth the effort in the long run, I will test and report here
Tue, Sep 25
First suggestion: /W34100 , make unused parameters a level 3 warning (our warning level)
Compile errors in mitkBaseData.cpp
Aug 30 2018
update: gcc works
Aug 27 2018
Aug 7 2018
Aug 6 2018
To use it one can easily turn on the build applications option in a GDCM-build within a MITK Superbuild
DICOM compression could be an option, I used gdcmconv -d and it reduced 4D_TEE_Data_MV.dcm from 100MB to 30MB
Jul 26 2018
Pushed new branch T24628-dcm-toolkit-update.
Jul 19 2018
Jul 11 2018
Jun 27 2018
Jun 26 2018
And another thing: update requires clean builds of DCMQI and DCMTK, so continuous clients will probably fail
Ok, I updated my fork to use the latest DCMQI with our modifications as well as a new jsoncpp version which solves the compilation issues. As a side effect, we have to update DCMTK, but I think it should be worth it before the release.
Jun 25 2018
Jun 22 2018
I have seen the fixes deactivating QNetwork in 1881c497af3e4b810d131a2c05bb819e485bf4e7 . However this also removed the
-n option command line option to disable networking. This option is used by the plugin generator tests. I could remove it there, but @kislinsk I think we should discuss the general strategy.
May 18 2018
May 17 2018
Mar 16 2018
Mar 14 2018
Mar 8 2018
Pushed new branch T23293-modernization-fixup.
Mar 6 2018
Mar 5 2018
Pushed new branch T23293-more-modernizations-and-warning-fixes.
Same for threshold in FiberExtractionRoi
Mar 2 2018
Feb 8 2018
Dec 19 2017
Pushed new branch T23775-warnings-no-errors-for-apps.
I will add a little feature: a WARNINGS_NO_ERRORS option for the mitkFunctionCreateCommandLineApp CMake function
Dec 18 2017
Nov 21 2017
Nov 17 2017
if the ID is unique, this should maybe named getUID . And I wonder if we should make the IDType a proper class, did you discuss this?
Nov 13 2017
I included this in my "clang" branch since I thought it was a local problem. You can cherry pick the fix, don't know when I can merge