Page MenuHomePhabricator

nolden (Marco Nolden)
UserAdministrator

Projects (12)

User Details

User Since
Aug 1 2016, 12:10 PM (216 w, 6 d)
Roles
Administrator

Recent Activity

Fri, Sep 25

nolden added a comment to T27669: Dicom import issue with MITK binaries (package) and Ubuntu.

@schererj we looked at the debug output, thanks. Unfortunately it seems to be complicated ... I would ask you to try another thing:

Fri, Sep 25, 12:09 PM · Missing Info, DICOM, MITK
nolden added a comment to T27701: Plugin Generator tests fail.

@kislinsk : I just noticed we had some earlier discussions and there is a branch which fixes two minor issues, not sure if relevant for option (1):

Fri, Sep 25, 11:45 AM · MITK (2020)

Wed, Sep 23

nolden closed T27438: Fix compile errors on Fedora 32 using gcc 10.1 as Resolved.

This is resolved, dart client is running on my workstation

Wed, Sep 23, 9:46 AM · MITK (2020)
nolden closed T27612: Fix build errors with clang 10.x as Resolved.

Clang 10 on Linux configuration is running now nightly on my desktop machine. "WorkbenchRelease" is green, "All" unfortunately hits an internal clang error [1][2]. Setting this up on ubuntu would probably solve this, or some update on fedora.

Wed, Sep 23, 9:45 AM · Breaking Change, MITK (2020)

Fri, Sep 11

nolden added a comment to T27569: US DICOM images are displayed turquoise and LUT cannot be changed.

http://gdcm.sourceforge.net/wiki/index.php/Color_Space_Transformations

Fri, Sep 11, 2:30 PM · Restricted Project, MITK
nolden added a comment to T27569: US DICOM images are displayed turquoise and LUT cannot be changed.

Just checked GDCM 3.0.7 if by chance the issue was fixed there, unfortunately not.

Fri, Sep 11, 2:27 PM · Restricted Project, MITK
nolden added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

@jsolislemus Sorry for the long delay, I kind of missed your comment and related discussions happened in T27669

Fri, Sep 11, 11:45 AM · MITK, Request for Discussion
nolden added a comment to T27669: Dicom import issue with MITK binaries (package) and Ubuntu.

@schererj we just discussed this in the MITK meeting. Could you try something? It would be interesting to compare the outputs of

Fri, Sep 11, 11:22 AM · Missing Info, DICOM, MITK
nolden added a project to T27701: Plugin Generator tests fail: Request for Discussion.

Since we have this task now I suggest to deactivate them "somewhere globally" and discuss later how to proceed. My guess would be it is quite some effort. Having tests for the generator, packging and the extension mechanism is very important I think, but I'm not sure what the current tests cover and if it's worth to fix.

Fri, Sep 11, 10:15 AM · MITK (2020)

Jul 30 2020

nolden added a comment to T27612: Fix build errors with clang 10.x .

I'm setting up a clang 10 dart client right now. If that is submitting successfully I would close the task

Jul 30 2020, 9:35 AM · Breaking Change, MITK (2020)

Jul 29 2020

nolden committed rMITK64c4c822e255: Fix ImageCropper startup crash (authored by nolden).
Fix ImageCropper startup crash
Jul 29 2020, 11:47 AM
nolden committed rMITKbe8970e7a285: Fix ImageCropper startup crash (authored by nolden).
Fix ImageCropper startup crash
Jul 29 2020, 11:47 AM

Jul 28 2020

nolden committed rMITK3d31d74f9e36: Patch VTK to properly detect gcc 10 (authored by nolden).
Patch VTK to properly detect gcc 10
Jul 28 2020, 4:54 PM
nolden committed rMITKbc8bf3835b5e: Patch VTK to properly detect gcc 10 (authored by nolden).
Patch VTK to properly detect gcc 10
Jul 28 2020, 4:54 PM
nolden committed rMITK467d01b492e2: Fix some clang triggered issues (authored by nolden).
Fix some clang triggered issues
Jul 28 2020, 11:25 AM
nolden committed rMITKb73371b41722: Silence clang on float int conversion in uServices (authored by nolden).
Silence clang on float int conversion in uServices
Jul 28 2020, 11:24 AM
nolden committed rMITKefc061e82760: Use std::string instead of const char* in file extension handling (authored by nolden).
Use std::string instead of const char* in file extension handling
Jul 28 2020, 11:24 AM
nolden committed rMITK87e3bb7e499b: Git ignore .clangd (authored by nolden).
Git ignore .clangd
Jul 28 2020, 11:24 AM
nolden committed rMITKf2d1b2910f34: Fixed some range-based loops (authored by nolden).
Fixed some range-based loops
Jul 28 2020, 11:24 AM

Jul 27 2020

nolden triaged T27612: Fix build errors with clang 10.x as High priority.
Jul 27 2020, 4:27 PM · Breaking Change, MITK (2020)

Jul 20 2020

nolden triaged T27578: Make sure libwrap isn't linked anymore as High priority.
Jul 20 2020, 3:45 PM · MITK (2020)

Jul 16 2020

nolden added a project to T27554: Handling of 2D and 2D+t sonographic (US) images: Restricted Project.

Added FS-E IT since this is coming from DKFZ radiology

Jul 16 2020, 2:08 PM · Restricted Project, MITK

Jul 8 2020

nolden added a comment to T27085: 2D region growing tool fails for low intensity regions.

soon'ish == 2 weeks ;)

Jul 8 2020, 11:04 AM · Cleared, MITK (2020)
nolden added a comment to T27085: 2D region growing tool fails for low intensity regions.

@norajitr We discussed this today in the MITK 2020 meeting and it stays on the high priority list, no promises regarding a date for a fix but at least some investigation of the underlying cause should happen soon'ish

Jul 8 2020, 11:02 AM · Cleared, MITK (2020)

Jun 19 2020

nolden committed rMITK79cadd0edb2b: Fix CMake variable type of MITK_XVFB_TESTING_COMMAND (authored by nolden).
Fix CMake variable type of MITK_XVFB_TESTING_COMMAND
Jun 19 2020, 2:08 PM
nolden committed rMITKa0144be45fa8: Fix CMake variable type of MITK_XVFB_TESTING_COMMAND (authored by nolden).
Fix CMake variable type of MITK_XVFB_TESTING_COMMAND
Jun 19 2020, 2:08 PM
nolden edited projects for T27483: DICOM import of multi-channel data not working, added: MITK (2020); removed MITK.
Jun 19 2020, 11:26 AM · MITK (2020), Restricted Project, DICOM

Jun 17 2020

nolden added projects to T27483: DICOM import of multi-channel data not working: DICOM, Restricted Project.
Jun 17 2020, 8:18 PM · MITK (2020), Restricted Project, DICOM

Jun 15 2020

nolden removed a project from T23249: Ensure openSSL availability for MITK installers using XNAT plugin or other REST services: Auto-closed.
Jun 15 2020, 11:12 AM · Restricted Project, CSI-HD, MITK
nolden renamed T23249: Ensure openSSL availability for MITK installers using XNAT plugin or other REST services from Xnat Plugin: How to deal with openSSL dependency to Ensure openSSL availability for MITK installers using XNAT plugin or other REST services.
Jun 15 2020, 11:06 AM · Restricted Project, CSI-HD, MITK
nolden reopened T23249: Ensure openSSL availability for MITK installers using XNAT plugin or other REST services, a subtask of T23301: XNAT improvements, as Open.
Jun 15 2020, 11:05 AM · Auto-closed, MITK
nolden reopened T23249: Ensure openSSL availability for MITK installers using XNAT plugin or other REST services as "Open".

I am re-opening this since I think this will also become more relevant with the foreseeable use of other REST APIs from MITK , e.g. how did the nvidia segmentation tool resolve this issue for the windows installer? @kislinsk could you comment?

Jun 15 2020, 11:05 AM · Restricted Project, CSI-HD, MITK

Jun 3 2020

nolden added a comment to T27437: Migrate MITK to use ITK 5.x .

@floca : thanks. Not the whole trick but helped a lot. I will follow up with more geometry questions later ;)

Jun 3 2020, 3:07 PM · MITK
nolden edited projects for T27085: 2D region growing tool fails for low intensity regions, added: Cleared; removed Missing Info.

I put a _non-shareable_ dataset in /ad/fs/E132-Projekte/Share/MarcoToMitkTeam .

Jun 3 2020, 12:55 PM · Cleared, MITK (2020)

Jun 2 2020

nolden triaged T27461: Update MITK to use VTK 9 as Wishlist priority.
Jun 2 2020, 3:56 PM · MITK (2020)

May 25 2020

nolden triaged T27443: Enable debug configurations for CI as Normal priority.
May 25 2020, 9:44 AM · CI, Restricted Project, MITK
nolden committed rMITK9aaf58fd273e: Fix initialization of vnl_vector to fix assert failure (authored by nolden).
Fix initialization of vnl_vector to fix assert failure
May 25 2020, 9:26 AM
nolden committed rMITKc0f481bc8123: Fix initialization of vnl_vector to fix assert failure (authored by nolden).
Fix initialization of vnl_vector to fix assert failure
May 25 2020, 9:26 AM

May 24 2020

nolden committed rMITK88a9b297dde6: Turn off some warnings-as-errors (authored by nolden).
Turn off some warnings-as-errors
May 24 2020, 9:36 PM
nolden renamed T27308: [statistics] Statistics with segmentations are not automatically updated if segmentation is changed. from [statistics] Statistics with segmentations are not automatically actualized if segmentation is changed. to [statistics] Statistics with segmentations are not automatically updated if segmentation is changed..
May 24 2020, 9:02 PM · Cleared, MITK (2020)
nolden added a comment to T27188: [ImageStatistics] mitkImageStatisticsCalculatorTest fails on some platforms.

Sorry, did not see your claim, was already working on it. Proposed fix in D308

May 24 2020, 7:39 PM · Cleared, MITK (2020), Restricted Project, CI

May 22 2020

nolden added a comment to T27438: Fix compile errors on Fedora 32 using gcc 10.1.

Pushed new branch feature/T27438-fix-gcc10-errors.

May 22 2020, 2:29 PM · MITK (2020)
nolden updated subscribers of T27437: Migrate MITK to use ITK 5.x .

I changed the superbuild to use ITK 5 with compatibilty and fixed some straightforward issues. This branch can be used for further investigations @floca : some ideas about the geometry issues would be very helpful. The migration guide has an overview on the topic but my experience in that area is limited

May 22 2020, 2:22 PM · MITK
nolden added a comment to T27437: Migrate MITK to use ITK 5.x .

Pushed new branch feature/T27437-migrate-to-ITK-5.

May 22 2020, 2:17 PM · MITK
nolden triaged T27438: Fix compile errors on Fedora 32 using gcc 10.1 as Normal priority.
May 22 2020, 1:31 PM · MITK (2020)
nolden triaged T27437: Migrate MITK to use ITK 5.x as Normal priority.
May 22 2020, 1:27 PM · MITK
nolden edited projects for T27188: [ImageStatistics] mitkImageStatisticsCalculatorTest fails on some platforms, added: Cleared; removed Missing Info, Request for Discussion.

Seems the reason this passes on all official clients is Debug vs Release. We currently only test release which ignores asserts. Thus, this should be investigated properly by tracing the problem, Windows and Linux are both affected

May 22 2020, 11:26 AM · Cleared, MITK (2020), Restricted Project, CI

May 8 2020

nolden closed T25702: DICOM sort fails for RWV modality as Resolved.

I got some data now which shows a problem with MITK 2018.4 but works with the current master. I don't see though the RWV thing. Can't remember exactly how I investigated this back then. Let's hope the more robust handling of DICOM fixed this as @floca noted , I informed the reporting users that they should comment if this should be investigated again.

May 8 2020, 3:24 PM · MITK (2020), Restricted Project
nolden edited projects for T25702: DICOM sort fails for RWV modality, added: MITK (2020); removed MITK.

I'm currently trying to get access to the relevant data again.

May 8 2020, 10:39 AM · MITK (2020), Restricted Project

May 7 2020

nolden committed rMITK1780784feb8e: Fixed Qt test invocation (authored by nolden).
Fixed Qt test invocation
May 7 2020, 8:52 PM
nolden committed rMITKf06596f70f8d: Fixed Qt test invocation (authored by nolden).
Fixed Qt test invocation
May 7 2020, 8:52 PM
nolden triaged T27383: Update external toolkits as High priority.
May 7 2020, 4:12 PM · Request for Discussion, MITK
nolden added a comment to T27085: 2D region growing tool fails for low intensity regions.

Does the MITK team have access rights on the NAKO dataset? Then I would suggest an example from there.

May 7 2020, 1:58 PM · Cleared, MITK (2020)
nolden added a revision to T27367: Graphical unit tests fail on some linux setups: Unknown Object (Differential Revision).
May 7 2020, 1:26 PM · MITK (2020)
nolden committed rMITKa93a881e0170: Make linux headless UI testing more configurable (authored by nolden).
Make linux headless UI testing more configurable
May 7 2020, 10:42 AM
nolden committed rMITKeaa893583df1: Moved XVFB testing configuration to superbuild (authored by nolden).
Moved XVFB testing configuration to superbuild
May 7 2020, 10:42 AM
nolden committed rMITKe95eb8546215: Make linux headless UI testing more configurable (authored by nolden).
Make linux headless UI testing more configurable
May 7 2020, 10:42 AM

May 6 2020

nolden triaged T27379: Set up Ubuntu 20.04 CI clients as High priority.
May 6 2020, 4:59 PM · Cleared, Restricted Project, MITK (2020)
nolden closed T25497: Auto-loading of module MitkDICOMQIIO fails in tests as Resolved.

Tests don't fail anymore

May 6 2020, 3:19 PM · MITK
nolden set the image for Missing Info to F1576941: profile.
May 6 2020, 3:14 PM
nolden added a comment to T27085: 2D region growing tool fails for low intensity regions.

@norajitr or someone else: is there an example image in MITK Data to show this behavior?
@norajitr do you know when this stopped working?

May 6 2020, 2:43 PM · Cleared, MITK (2020)
nolden created T27377: Suppress or fix all build warnings .
May 6 2020, 1:55 PM · MITK (2020)

May 5 2020

nolden added a revision to T27367: Graphical unit tests fail on some linux setups: Unknown Object (Differential Revision).
May 5 2020, 4:10 PM · MITK (2020)

May 4 2020

nolden edited projects for T27367: Graphical unit tests fail on some linux setups, added: MITK (2020); removed MITK.

Ok, on fedora there is a newer xvfb version which includes a new option for a more robust choice of a suitable display number which seems to fix the issue for me.

May 4 2020, 2:46 PM · MITK (2020)

Apr 30 2020

nolden triaged T27367: Graphical unit tests fail on some linux setups as High priority.
Apr 30 2020, 10:29 PM · MITK (2020)
nolden raised the priority of T27188: [ImageStatistics] mitkImageStatisticsCalculatorTest fails on some platforms from Normal to High.

Diffusion still shows this:

Apr 30 2020, 6:57 AM · Cleared, MITK (2020), Restricted Project, CI
nolden renamed T27188: [ImageStatistics] mitkImageStatisticsCalculatorTest fails on some platforms from [ImageStatistics] Test failed and is not detected by CTest to [ImageStatistics] mitkImageStatisticsCalculatorTest fails on some platforms.
Apr 30 2020, 6:56 AM · Cleared, MITK (2020), Restricted Project, CI

Apr 27 2020

nolden added a comment to T27001: Rename org.mitk.gui.qt.dicom to org.mitk.gui.qt.dicombrowser.

Strong agree on dicombrowser and avoiding the term editor ...

Apr 27 2020, 10:29 AM · Breaking Change, MITK (2020), Cleared

Apr 23 2020

nolden closed T17637: CppMicroServices compile error with VS2013 as Wontfix.

Probably not relevant anymore and VS2013 is not supported anymore

Apr 23 2020, 11:29 AM · Bugzilla, MITK
nolden closed T27344: mitkPackageTest fails on OS X during CI as Resolved.

Test finished successfully after 2h11min ... Still room for optimitzation but this task is resolved ;)

Apr 23 2020, 9:46 AM · MITK

Apr 22 2020

nolden committed rMITK6cb785db3f67: Increase timeout for mitkPackage test (authored by nolden).
Increase timeout for mitkPackage test
Apr 22 2020, 8:48 PM
nolden committed rMITKe5959208343f: Increase timeout for mitkPackage test (authored by nolden).
Increase timeout for mitkPackage test
Apr 22 2020, 8:48 PM
nolden added a revision to T27344: mitkPackageTest fails on OS X during CI: Unknown Object (Differential Revision).
Apr 22 2020, 12:31 PM · MITK
nolden triaged T27344: mitkPackageTest fails on OS X during CI as Normal priority.
Apr 22 2020, 12:00 PM · MITK
nolden added a project to T27177: Segmentation based on Multiframe CT can not be saved as DICOM without error message: Request for Discussion.
Apr 22 2020, 10:15 AM · Request for Discussion, Restricted Project, MITK
nolden added a comment to T27177: Segmentation based on Multiframe CT can not be saved as DICOM without error message.

As stated before, we encountered more examples that raised the unknown exception, so I don’t agree to lower the priority on that.

Apr 22 2020, 10:10 AM · Request for Discussion, Restricted Project, MITK

Apr 10 2020

nolden added a comment to T27289: Different coverage results with OpenCppCoverage and Gcov.

But I think the reason for the different results might be that opencppcoverage does not use any testfiles and cannot load pictures because it cannot find these and there is no option to pass them to opencppcoverage.

Apr 10 2020, 6:36 PM · Restricted Project, MITK

Apr 7 2020

nolden added a comment to T27289: Different coverage results with OpenCppCoverage and Gcov.

If I look at the outputs side by side there is e.g. a difference in the SetSecondaryMask method: it's called 24 times in the CDash run but in the OpenCppCoverage it's red. Which tests did you execute? I think if I remember correctly the numbers in the CTest/CDash result are aggregated over all tests in the default config. Could this make the difference?

Apr 7 2020, 9:51 PM · Restricted Project, MITK

Mar 27 2020

nolden edited projects for T26959: Newly created LabelSet segmentation is not displayed as "outline binary", added: MITK (2020); removed MITK.
Mar 27 2020, 4:35 PM · MITK (2020)
nolden edited projects for T27086: Long file names force segmentation plugin to expand in order to be usable., added: MITK (2020); removed MITK.
Mar 27 2020, 4:34 PM · MITK (2020)
nolden edited projects for T27085: 2D region growing tool fails for low intensity regions, added: MITK (2020); removed MITK.

This was reported as relevant for medical expert segmentation work

Mar 27 2020, 4:34 PM · Cleared, MITK (2020)
nolden added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

We discussed this in the MITK meeting today and identified two possible reasons.

Mar 27 2020, 11:32 AM · MITK, Request for Discussion

Mar 20 2020

nolden triaged T27247: MITK_SHOW_CONSOLE_WINDOW is not honored in mitk_create_executable function as Normal priority.
Mar 20 2020, 11:43 AM · Pull Request, Cleared, MITK (2020)

Mar 6 2020

nolden added a comment to T27203: QmitkAbstractNodeSelectionWidgetTest regularly fails on headless Linux.

Nice work! I ran into this as well just a few hours ago and thought it would be nice to evaluate alternative Qt platform options for tests ;)

Mar 6 2020, 4:30 PM · MITK
nolden lowered the priority of T27177: Segmentation based on Multiframe CT can not be saved as DICOM without error message from Unbreak Now! to Low.

The modality of the referenced image is a so-called Enhanced CT Image originating from a 3D C-Arm. It is a current limitation of dcmqi to handle these multiframe series as input, see https://github.com/QIICR/dcmqi/issues/217 . It's not an easy fix in dcmqi and we already discussed with the developers. For now I think we have to keep this in our backlog.

Mar 6 2020, 4:22 PM · Request for Discussion, Restricted Project, MITK
nolden renamed T27177: Segmentation based on Multiframe CT can not be saved as DICOM without error message from Dicom segmentation can not be saved as .dcm without error message to Segmentation based on Multiframe CT can not be saved as DICOM without error message.
Mar 6 2020, 3:38 PM · Request for Discussion, Restricted Project, MITK

Mar 3 2020

nolden created T27186: New segmentation behaviour can be confusing.
Mar 3 2020, 4:09 PM · MITK
nolden triaged T27185: Create new segmentation is sometimes disabled as Unbreak Now! priority.
Mar 3 2020, 4:05 PM · MITK
nolden created T27184: Clipping plane deformation tool doesn't show updates in 3d window.
Mar 3 2020, 3:53 PM · Missing Info, Restricted Project, MITK (2020)
nolden added a comment to T27177: Segmentation based on Multiframe CT can not be saved as DICOM without error message.

@thomass Which version did you test this with?

Mar 3 2020, 11:23 AM · Request for Discussion, Restricted Project, MITK

Feb 14 2020

nolden added a revision to T25745: Integrate new DICOM browser widget from CTK: Unknown Object (Differential Revision).
Feb 14 2020, 2:08 PM · MITK

Feb 10 2020

nolden committed rMITKc55b6aae65cd: Don't reorder includes during clang-format (authored by nolden).
Don't reorder includes during clang-format
Feb 10 2020, 11:55 AM
nolden committed rMITK28a1559a42c5: Don't format anything in the PluginGenerator and templates (authored by nolden).
Don't format anything in the PluginGenerator and templates
Feb 10 2020, 11:55 AM
nolden committed rMITKea713e14c00a: Change inner namespace indentation (authored by nolden).
Change inner namespace indentation
Feb 10 2020, 11:55 AM
nolden committed rMITK2739cf55c171: Fix missing include for MitkIpPicDescriptor (authored by nolden).
Fix missing include for MitkIpPicDescriptor
Feb 10 2020, 11:54 AM
nolden added a comment to T24402: Improve clang-format support.

Pushed new branch T24402-clang-format-improvements.

Feb 10 2020, 11:54 AM · MITK
nolden committed rMITKa41a8d973980: Fix PluginGenerator tests (authored by nolden).
Fix PluginGenerator tests
Feb 10 2020, 11:53 AM
nolden added a comment to T27084: Clean up, improve and test PluginGenerator, ProjectTemplate and MITK_EXTENSION_DIRS mechanism.

Pushed new branch T27084-fix-plugin-generator-tests.

Feb 10 2020, 11:52 AM · Request for Discussion, MITK
nolden updated subscribers of T27084: Clean up, improve and test PluginGenerator, ProjectTemplate and MITK_EXTENSION_DIRS mechanism.
Feb 10 2020, 11:40 AM · Request for Discussion, MITK
nolden triaged T27084: Clean up, improve and test PluginGenerator, ProjectTemplate and MITK_EXTENSION_DIRS mechanism as Normal priority.
Feb 10 2020, 11:40 AM · Request for Discussion, MITK