Page MenuHomePhabricator
Create Task
Maniphest T17877

Side effects due to changed inheritance of Geometry classes
Closed, ResolvedPublic
Actions

Description

The inheritance structure was introduced by the resolution of T17035 (Platformproject Esther)

Before: The AbstractTransformGeometry was derived from Geometry2D and could not be casted to a PlaneGeometry. This fact was used on multiple places to distinguish the types of the input object.

  • in the mitkExtractSliceFilter to handle curved plane geometries differently than regular plane geometries.
  • the BaseRenderer in SetWorldGeometry3D
  • possibly more places ...

current master: AbstractTransformGeometry inherits the mitk::PlaneGeometry class and can thus be casted to such.

Event Timeline

• hering added projects: MITK, Bugzilla.Jun 18 2014, 4:36 PM
• hering added a subscriber: • hering.Jun 25 2014, 1:50 PM

Next place:

  • mitk::PlaneGeometryDataMapper2D::Paint() has different handlings for planar and abstract geometries -> affected by the new hierarchy issue
• hering added a comment.Jun 25 2014, 2:53 PM
  • mitk::PlaneGeometryDataToSurfaceFilter::GenerateOutputInformation()

    separate handling of AbstractTransform and PlaneGeometry!
• git-user added a subscriber: • git-user.Jul 9 2014, 5:43 PM

User wildes has pushed new remote branch:

bug-17877-CorrectForChangedInheritanceOfAbstractTransformGeometry
maerz added a subscriber: maerz.Jul 10 2014, 12:12 PM

Complete List of possibly problematic places (PPP):

https://docs.google.com/spreadsheets/d/1IAdxGmWxIHAajBo-vi0BCcVCRlrznlHSo0Aw53icWqE/edit?usp=sharing

• git-user added a comment.Jul 16 2014, 2:29 PM

User maharana has pushed new remote branch:

bug-17877-SebsAndAdyashas_changes_for_geometry_inheritence_check
• git-user added a comment.Jul 16 2014, 2:47 PM

User heime has pushed new remote branch:

bug-17877-VtkPropRenderer
• git-user added a comment.Jul 16 2014, 3:27 PM

User heime has pushed new remote branch:

bug-17877-ExtractDirectedPlaneImageFilter
• git-user added a comment.Jul 16 2014, 4:48 PM

User lichtenn has pushed new remote branch:

bug-17877-Nils_changes_for_geometry_inheritence_check
• git-user added a comment.Jul 16 2014, 4:59 PM

User iszatt has pushed new remote branch:

bug-17877-DrBWins
zelzer added a subscriber: zelzer.Jul 28 2014, 3:08 PM

If you haven't done so already: Please add a unit test which fails for one of the problematic code pieces in the core library (and which succeeds after fixing the code). This is extremely important.

maerz added a comment.Aug 14 2014, 10:37 AM

[03db3f]: Merge branch 'bug-17877-CorrectForChangedInheritanceOfAbstractTransfor

Merged commits:

2014-08-13 17:33:58 Keno März [793ace]
New Test to test inheritance behaviour

2014-08-13 16:39:30 Keno März [62bc6c]
Fixed missing return value

2014-08-13 16:36:57 Keno März [a4d12a]
Wrapped old spaggethitest to work with CPPUnit

2014-08-13 16:03:59 Keno März [12b805]
Restructerd a few tests, one of them is failing

2014-08-13 15:28:02 Keno März [25b0b8]
Made PlaneTest a CPP Unit Suite, now to restructure Tests

2014-07-23 13:28:37 Esther Wild [875ca8]
Merge branch 'bug-17877-SebsAndAdyashas_changes_for_geometry_inheritence_check' into bug-17877-CorrectForChangedInheritanceOfAbstractTransformGeometry

2014-07-23 13:27:48 Esther Wild [d3c6a3]
Adapt logic for PlaneGeometryDataMapper

2014-07-23 13:24:52 Esther Wild [078a90]
Merge branch 'bug-17877-VtkPropRenderer' into bug-17877-CorrectForChangedInheritanceOfAbstractTransformGeometry

2014-07-23 13:24:17 Esther Wild [fb2745]
Merge branch 'bug-17877-Nils_changes_for_geometry_inheritence_check' into bug-17877-CorrectForChangedInheritanceOfAbstractTransformGeometry

2014-07-23 13:24:02 Esther Wild [fd0972]
Merge branch 'bug-17877-ExtractDirectedPlaneImageFilter' into bug-17877-CorrectForChangedInheritanceOfAbstractTransformGeometry

2014-07-23 13:23:52 Esther Wild [d55c83]
Merge branch 'bug-17877-DrBWins' into bug-17877-CorrectForChangedInheritanceOfAbstractTransformGeometry

2014-07-16 16:55:57 Justin Iszatt [772bda]
Changed files to the new geometry concept

2014-07-16 16:42:10 Nils Lichtenberg [66feaf]
added changes, see PPP list for double check

2014-07-16 15:50:28 Esther Wild [c191e5]
Merge branch 'bug-17877-CorrectForChangedInheritanceOfAbstractTransformGeometry' of mitk.org:MITK into bug-17877-CorrectForChangedInheritanceOfAbstractTransformGeometry

2014-07-16 15:48:57 Esther Wild [b485a8]
changed logic

2014-07-16 15:16:17 Eric Heim [66dac1]
check if it is not a abstractTransformGeometry

2014-07-16 14:49:52 Keno März [6a8d81]
Added sanity checks to SlicesRotationController

2014-07-16 14:46:40 Eric Heim [34a02b]
excluding abstract geometry from the transformations

2014-07-16 14:22:49 Esther Wild [a4595b]
Changed logic for SliceNavigationController and PlaneGeometryData. T17877

2014-07-16 13:45:20 Esther Wild [a31d23]
Changed logic for PlaneGeometryDataToSurfaceFilter: different behavior for ABstTransfGeometry

2014-07-09 17:40:29 Esther Wild [85d18a]
Changed logic in line 134.
It is checked if it is an AbstractTransformGeometry, not if it is a Plane Geometry, as ATG inherits from PG.

maerz added a comment.Aug 14 2014, 10:40 AM

Wrote a test to assert inheritance behaviour that will fail if the current inheritance scheme changes.

MITK · MIC · IMSY · DKFZ