Page MenuHomePhabricator

Enhance stability of the rigid registration plugin for release
Closed, ResolvedPublic

Description

Following bugs in the functionality of the registration plugin were reported
T18904, T18902, T18901, T18900, T18899, T18898, T18897

Some of them originate from the vast amount of possible settings combintation provided by the 'Advanced Mode'. To increase the stability of the whole plugin, following steps are planned:

(i) deactivate the advanced mode

(ii) replace the deactivated mode by a selectable list of fixed settings ( the Preferences are already there, need an adaptation ) for the most common registration tasks

Event Timeline

User hering has pushed new remote branch:

bug-18936-StableRigidRegistrationPlugin

[c53c7d]: Merge branch 'bug-18936-StableRigidRegistrationPlugin'

Merged commits:

2015-04-14 13:52:43 Jan Hering [ebc9b3]
GUI Enhancement, better configuration


2015-04-08 18:15:44 Jan Hering [45698c]
Enhanced preset loading

  • better GUI for selecting the preset
  • button enabling based on selection

2015-04-08 16:16:51 Jan Hering [cade24]
Simplified RegistrationView UI for release

  • add combo-box for more intuitive preset loading
  • set default preset to Affine+MI+LinearInterp
  • deactivated second tab (Advanced View)

2015-04-08 16:11:59 Jan Hering [84fb1a]
Added common registration settings to the general preferences


2015-04-08 16:10:50 Jan Hering [c54177]
RegistrationPreset API enhancement and code cleanup

  • provides not the list of avialable preset names

[2bb044]: Merge branch 'bug-18936-StableRigidRegistrationPlugin'

Merged commits:

2015-04-14 14:25:40 Jan Hering [bf08a3]
COMP revert accidentaly removed return value statement

Currently, the manual registration frame is shown after checking the 'Manual Registration' box, however the complete frame (all sliders) are inactive.

[8d5952]: Merge branch 'bug-18936-StableRigidRegistrationPlugin'

Merged commits:

2015-04-15 15:12:09 Jan Hering [b85d9f]
Fix GUI activatino logic

  • now the manual registration frame is activated correctly, it must not depend on the preset-selected value

The main part is finished, there is one issue left regarding saving the images (which was possibly already there before my simplifications of the UI)

  • the right-click on the datanode for selecting 'Save' causes sometimes a reset/change of the node's geometry, hence the computed registration transformation is lost

[ceca14]: Merge branch 'bug-18936-StableRigidRegistrationPlugin'

Merged commits:

2015-04-17 15:34:15 Jan Hering [aa08c6]
Add affine with correlation metric to presets

Could not reproduce the issue with the saving. One more preset added to the own resource list.

I now consider the issue fixed.