Page MenuHomePhabricator
Create Task
Maniphest T19331

Remove doxygen warnings DOCBOOK_PROGRAMLISTING, PLANTUML_JAR_PATH, FreeSans
Closed, ResolvedPublic
Actions

Description

Hi there,

this sort of thing polutes my dashboard:

Generating resources/uk_ac_ucl_cmic_igiundistort.qch
Warning: ignoring unsupported tag `DOCBOOK_PROGRAMLISTING =' at line 1854, file /Users/mattclarkson/build/NifTK-4338-SuperBuild-Debug/NifTK-build/Code/Gui/MITK/Plugins/uk.ac.ucl.cmic.igipivotcalibration/documentation/UserManual/doxygen.conf
Warning: ignoring unsupported tag `PLANTUML_JAR_PATH      =' at line 2277, file /Users/mattclarkson/build/NifTK-4338-SuperBuild-Debug/NifTK-build/Code/Gui/MITK/Plugins/uk.ac.ucl.cmic.igipivotcalibration/documentation/UserManual/doxygen.conf
Warning: doxygen no longer ships with the FreeSans font.
You may want to clear or change DOT_FONTNAME.
Otherwise you run the risk that the wrong font is being used for dot generated graphs.

Please can it be fixed?

Thanks

Matt

Event Timeline

clarkson added projects: MITK, Bugzilla.Sep 17 2015, 4:28 PM
clarkson added a subscriber: clarkson.Sep 17 2015, 4:42 PM

Patch coming.

• goch added a subscriber: • goch.Sep 18 2015, 11:59 AM

DOCBOOK_PROGRAMLISTING and PLANTUML_JAR_PATH are both options that were introduced in the 1.8.8 release of doxygen (so I assume you are using 1.8.7).
So while I do not really so a pressing reason to remove them, neither is there one to keep them, as we are not using them anyway.

The FreeSans to Helvetica switch seems reasonable.

If you sign-off your commit I will integrate it.

clarkson added a comment.Sep 18 2015, 12:32 PM

Hi there,

I was using 1.8.7. Is that the recommended version? If thats the wrong version, then my fix is probably non-sensical.

Also, Ive forgotten how to "sign off" commits. Can you remind me what the process is?

M

• goch added a comment.Sep 18 2015, 12:49 PM

Currently 1.8.7 is our minimum required version, so running it should be fine. However the doxygen.conf might be geared to whatever version the last person to update it was using at the time.

In this case that was probably me and 1.8.8 when running "doxygen -u <config_file>"

To sign a commit:

-s
--signoff

Add Signed-off-by line by the committer at the end of the commit log message.

just add the flag to your "git commit". That will either use a key, if you have one configured, or add just a plain-text line.

clarkson added a comment.Sep 18 2015, 1:05 PM

Hi there,

Well, maybe, I think the best solution here is for you to decide if any change is required at all. It looks like these changes are not necessary.

If I know which version to update to, then Im happy.

M

• goch added a comment.Sep 18 2015, 1:10 PM

The FreeSans to Helvetica switch is reasonable either way. The unsupported tags I am happy to change, if for some reason you are restricted to your doxgen version.

• goch added a comment.Sep 21 2015, 1:28 PM

Hi Matt,

if you want me to integrate your commit I still need the sign-off. I can also create my own commit and mention you in the commit message if you do not care either way.

clarkson added a comment.Sep 21 2015, 1:48 PM

Hi there,

Im not available right now. Can you procede without me? I don't really mind about the commit message or authorship.

M

• goch added a comment.Sep 21 2015, 2:13 PM

Will do

• git-user added a subscriber: • git-user.Sep 21 2015, 5:54 PM

User goch has pushed new remote branch:

bug-19331-replace-doxygen-font
• goch added a comment.Sep 21 2015, 5:56 PM

Core Modification:

Just replacing the font in the doxygen config files.

• goch added a comment.Sep 22 2015, 12:39 PM

[806e12]: Merge branch 'bug-19331-replace-doxygen-font'

Merged commits:

2015-09-21 17:51:50 Caspar Goch [9240ee]
Replace old default font with new one

As noted by Matt Clarkson doxygen does not include FreeSans anymore. One
should use Helvetica instead.

MITK · MIC · IMSY · DKFZ