MITK Core Team
- User Since
- Aug 1 2016, 12:10 PM (77 w, 2 h)
Fri, Jan 19
Just to clarify, two versions of the plugin means just two different histogram widgets in the statistics view.
Thu, Jan 18
Has been fixed.
Pushed new branch T24021-fix-segmentationinterpolationtest.
That seems to be it, my regular build still uses a ITK 4.11 template header instead of the ITK 4.12.2 one.
The cause of the error seems to be in
in the following lines (std::cout added for debugging purposes)
isoContourFilter->SetInput(binaryImage); isoContourFilter->SetFarValue(maximumDistance + 1); isoContourFilter->SetLevelSetValue(0.5); std::cout << "LevelSetValue: " << isoContourFilter->GetLevelSetValue() <<std::endl; // Prints // LevelSetValue: 0 - for my regular build // LevelSetValue: 0.50 - for the dart client
Mon, Jan 15
Fri, Jan 12
Pushed new branch T24021-fix-logo-annotation-test.
Pushed new branch T24021-fix-debug-leaks.
Thu, Jan 11
Pushed new branch T24043-fix-dashboard-errors.
Wed, Jan 10
Tue, Jan 9
Pushed new branch T24021-fix-test.
I believe this has happened at some point.
Tests no longer fail as there is no longer a uid property.
Mon, Jan 8
Pushed new branch T23988-cest-normalization-handle-zero-division.
Has been merged
Seems to have been solved with the switch to external directories in T23775: "ExtensionPoint" support for SuperBuild. External autoload modules are included in the installer.
Dec 22 2017
I agree that the viewer has too many signals and selection capability for my understanding of a viewer.
Dec 18 2017
On Ubuntu I need to add -fPIC to the CXX compiler flags in cmake to have a successful cotire based build. Otherwise I had the following error message
cc1plus: error: /MITK-build/Modules/QtWidgets/test/cotire/MitkQtWidgetsTestDriver_CXX_prefix.hxx.gch: created and used with different settings of -fpic [-Werror]
Dec 15 2017
Pushed new branch T23756-cotire.
Dec 11 2017
Dec 8 2017
Pushed new branch T23920-fix-debug-leaks.
Pushed new branch T23922-unresolved-external-symbol.
Pushed new branch T23268-some-more-clang-fixes2.
Solved for now by checking whether the context is valid in mitkDICOMIOHelper.cpp, gives a warning instead of crashing if the context does not exist. This should solve the dashboard crashes, but will not guarantee all DICOMQI tags of interest are registered correctly. However they should work as well as before.
Pushed new branch T23810-MitkDICOMQIIO-crash.
Nov 23 2017
Moving the this->AddDICOMTagsToService(); line from the constructor somewhere else removes the crash.
Call stack is
MitkDICOMReader.dll!us::GetModuleContext() Line 57 MitkDICOMReader.dll!mitk::GetDicomTagsOfInterestService() Line 32 MitkDICOMQIIO.dll!mitk::DICOMSegmentationIO::AddDICOMTagsToService() Line 59 MitkDICOMQIIO.dll!mitk::DICOMSegmentationIO::DICOMSegmentationIO() Line 54 MitkDICOMQIIO.dll!mitk::DICOMQIIOModulActivator::Load(us::ModuleContext * context) Line 50 CppMicroServices.dll!us::Module::Start() Line 160 CppMicroServices.dll!us::ModuleRegistry::Register(us::ModuleInfo * info) Line 129
Nov 22 2017
Seems to be a lot of manual effort as well you have to extract all include paths (from e.g. the CMakeFiles/ModuleName.dir/flags.make). Call it on the source directory with these paths and manually integrate the suggestions offered.
I did just run include what you use on MitkCore and accepted the suggested changes. This results in a number of errors like
mitkPlaneGeometryDataToSurfaceFilter.cpp:111:22: error: unknown type name 'AbstractTransformGeometry' mitkPlaneGeometryDataToSurfaceFilter.cpp:118:32: error: no member named 'GetPlane' in 'mitk::PlaneGeometry' mitkCoreObjectFactory.cpp:194:27: error: no member named 'PlaneGeometryDataVtkMapper3D' in namespace 'mitk'; did you mean 'PlaneGeometryDataMapper2D'? mitkCoreObjectFactory.cpp:80:7: error: deleting pointer to incomplete type 'mitk::LegacyFileReaderService' may cause undefined behavior mitkOperationEvent.cpp:106:30: error: 'OperationEvent' does not refer to a value mitkSurfaceToSurfaceFilter.cpp:75:23: error: member access into incomplete type 'OutputType' (aka 'mitk::Surface') mitkRenderingManager.cpp:293:64: error: too many arguments to function call, expected single argument '_arg', have 2 arguments error: "Do not include itkExceptionObject.h directly, include itkMacro.h instead."
Pushed new branch T23268-some-more-clang-fixes.
Probably, the dicom folder read implementation was a bit cobbled together and could probably use some more thought.
I approve. Although the offending commit should be one of three
Nov 21 2017
Nov 14 2017
Nov 13 2017
Thanks for the info. Quoting from the link you posted above:
Nov 10 2017
One current use case of error bars is in the CEST view: