goch (Caspar Jonas Goch)Administrator
Developer

Projects (8)

User Details

User Since
Aug 1 2016, 12:10 PM (77 w, 2 h)
Roles
Administrator

MITK Core Team

Recent Activity

Fri, Jan 19

goch triaged T24085: MITK make PACKAGE does not work on windows if Python is enabled as Normal priority.
Fri, Jan 19, 11:17 AM · MITK
goch added a comment to T24011: ImageStatisticsView crashes after calculating image statistics.

Just to clarify, two versions of the plugin means just two different histogram widgets in the statistics view.

Fri, Jan 19, 10:55 AM · Restricted Project, MITK

Thu, Jan 18

goch closed T24043: [Dashboard] Fix Photoacoustics build errors as Resolved.
Thu, Jan 18, 2:25 PM · MITK
goch closed T23798: MITK has new memory leaks breaking unit tests as Resolved.

Has been fixed.

Thu, Jan 18, 2:25 PM · MITK
goch added a task to rMITK3d69740b7215: Fixes T24021 and fixes T23800: T23800: Fix mitkSegmentationInterpolationTest.
Thu, Jan 18, 2:22 PM
goch added a task to rMITK3d69740b7215: Fixes T24021 and fixes T23800: T24021: [Dashboard] mitkImageStatisticsCalculatorTest, mitkSegmentationInterpolationTest and more fail.
Thu, Jan 18, 2:22 PM
goch changed the status of T23800: Fix mitkSegmentationInterpolationTest from Duplicate to Resolved by committing rMITK3d69740b7215: Fixes T24021 and fixes T23800.
Thu, Jan 18, 2:22 PM · Restricted Project, MITK
goch committed rMITKcb312717ee6e: Merge branch 'T24021-fix-segmentationinterpolationtest' (authored by goch).
Merge branch 'T24021-fix-segmentationinterpolationtest'
Thu, Jan 18, 2:22 PM
goch closed T24021: [Dashboard] mitkImageStatisticsCalculatorTest, mitkSegmentationInterpolationTest and more fail as Resolved by committing rMITK3d69740b7215: Fixes T24021 and fixes T23800.
Thu, Jan 18, 2:22 PM · MITK
goch committed rMITK3d69740b7215: Fixes T24021 and fixes T23800 (authored by goch).
Fixes T24021 and fixes T23800
Thu, Jan 18, 2:21 PM
goch added a comment to T24021: [Dashboard] mitkImageStatisticsCalculatorTest, mitkSegmentationInterpolationTest and more fail.

Pushed new branch T24021-fix-segmentationinterpolationtest.

Thu, Jan 18, 2:21 PM · MITK
goch added a comment to T23800: Fix mitkSegmentationInterpolationTest.

That seems to be it, my regular build still uses a ITK 4.11 template header instead of the ITK 4.12.2 one.

Thu, Jan 18, 2:13 PM · Restricted Project, MITK
goch added a comment to T23800: Fix mitkSegmentationInterpolationTest.

The cause of the error seems to be in

Modules\Segmentation\Algorithms\mitkShapeBasedInterpolationAlgorithm.cpp

in the following lines (std::cout added for debugging purposes)

isoContourFilter->SetInput(binaryImage);
isoContourFilter->SetFarValue(maximumDistance + 1);
isoContourFilter->SetLevelSetValue(0.5);
std::cout << "LevelSetValue: " << isoContourFilter->GetLevelSetValue() <<std::endl;
// Prints
//   LevelSetValue: 0     - for my regular build
//   LevelSetValue: 0.50 - for the dart client
Thu, Jan 18, 1:44 PM · Restricted Project, MITK
goch added a comment to T23800: Fix mitkSegmentationInterpolationTest.

See also T24021: [Dashboard] mitkImageStatisticsCalculatorTest, mitkSegmentationInterpolationTest and more fail

Thu, Jan 18, 11:30 AM · Restricted Project, MITK

Mon, Jan 15

goch committed rMITKb12a23090b25: Merge branch 'T24021-fix-logo-annotation-test' (authored by goch).
Merge branch 'T24021-fix-logo-annotation-test'
Mon, Jan 15, 11:07 AM
goch committed rMITK3f6294d1831d: Update test data hash (authored by goch).
Update test data hash
Mon, Jan 15, 11:05 AM
goch committed rMD6001ab9cd6c6: Add new alternatives for rendering tests (authored by goch).
Add new alternatives for rendering tests
Mon, Jan 15, 11:00 AM

Fri, Jan 12

goch committed rMITKf781f9c1b1cc: Add capability to actually load logos from disk (authored by goch).
Add capability to actually load logos from disk
Fri, Jan 12, 5:57 PM
goch added a comment to T24021: [Dashboard] mitkImageStatisticsCalculatorTest, mitkSegmentationInterpolationTest and more fail.

Pushed new branch T24021-fix-logo-annotation-test.

Fri, Jan 12, 5:57 PM · MITK
goch committed rMDfb03141ee609: Use new logo in reference screenshot (authored by goch).
Use new logo in reference screenshot
Fri, Jan 12, 5:49 PM
goch renamed T24021: [Dashboard] mitkImageStatisticsCalculatorTest, mitkSegmentationInterpolationTest and more fail from [Dashboard] mitkImageStatisticsCalculatorTest and mitkSegmentationInterpolationTest fail to [Dashboard] mitkImageStatisticsCalculatorTest, mitkSegmentationInterpolationTest and more fail.
Fri, Jan 12, 5:43 PM · MITK
goch committed rMITKdd46eee88a3f: Merge branch 'T24021-fix-debug-leaks' (authored by goch).
Merge branch 'T24021-fix-debug-leaks'
Fri, Jan 12, 11:18 AM
goch committed rMITK722518ed42c9: Fix debug leaks (authored by goch).
Fix debug leaks
Fri, Jan 12, 11:17 AM
goch added a comment to T24021: [Dashboard] mitkImageStatisticsCalculatorTest, mitkSegmentationInterpolationTest and more fail.

Pushed new branch T24021-fix-debug-leaks.

Fri, Jan 12, 11:17 AM · MITK

Thu, Jan 11

goch committed rMITK3cba4ed2bea7: Merge branch 'T24043-fix-dashboard-errors' (authored by goch).
Merge branch 'T24043-fix-dashboard-errors'
Thu, Jan 11, 12:54 PM
goch committed rMITKf716b5ca56f4: Do not build files that require OpenCL if no OpenCL (authored by goch).
Do not build files that require OpenCL if no OpenCL
Thu, Jan 11, 12:54 PM
goch added a comment to T24043: [Dashboard] Fix Photoacoustics build errors.

Pushed new branch T24043-fix-dashboard-errors.

Thu, Jan 11, 12:53 PM · MITK
goch triaged T24043: [Dashboard] Fix Photoacoustics build errors as Unbreak Now! priority.
Thu, Jan 11, 12:53 PM · MITK
goch awarded T24041: VolumeMapperVtkSmart3D illegaly changes spacing of every mitk::Image's vtkImageData to (1, 1, 1) a Manufacturing Defect? token.
Thu, Jan 11, 11:06 AM · MITK

Wed, Jan 10

goch moved T23988: Handle CEST normalization for M0 voxels that are zero from Backlog to Resolved on the FS-E IT Restructuring board.
Wed, Jan 10, 10:11 AM · FS-E IT Restructuring, MITK
goch added a project to T23988: Handle CEST normalization for M0 voxels that are zero: FS-E IT Restructuring.
Wed, Jan 10, 10:11 AM · FS-E IT Restructuring, MITK

Tue, Jan 9

goch committed rMITK41b44de83ee6: Merge branch 'T24021-fix-test' (authored by goch).
Merge branch 'T24021-fix-test'
Tue, Jan 9, 1:50 PM
goch committed rMITK97c3db136aa1: Use 4D accessor for 4D images (authored by goch).
Use 4D accessor for 4D images
Tue, Jan 9, 1:50 PM
goch added a comment to T24021: [Dashboard] mitkImageStatisticsCalculatorTest, mitkSegmentationInterpolationTest and more fail.

Pushed new branch T24021-fix-test.

Tue, Jan 9, 1:49 PM · MITK
goch triaged T24021: [Dashboard] mitkImageStatisticsCalculatorTest, mitkSegmentationInterpolationTest and more fail as High priority.
Tue, Jan 9, 10:27 AM · MITK
goch closed T8235: ENH: Create Modules ImageStatistics and ImageExtraction as Resolved.

I believe this has happened at some point.

Tue, Jan 9, 10:26 AM · Bugzilla, MITK
goch added a comment to T23741: Specify default UID generation method.

Tests no longer fail as there is no longer a uid property.

Tue, Jan 9, 10:18 AM · MITK

Mon, Jan 8

goch committed rMITKb8ba5eacc37f: Fixes T23988 - set to zero instead of dividing by it (authored by goch).
Fixes T23988 - set to zero instead of dividing by it
Mon, Jan 8, 4:35 PM
goch added a task to rMITK683c54630510: Fixes T23988 - set to zero instead of dividing by it: T23988: Handle CEST normalization for M0 voxels that are zero.
Mon, Jan 8, 4:31 PM
goch committed rMITK0a98e98347bc: Merge branch 'T23988-cest-normalization-handle-zero-division' (authored by goch).
Merge branch 'T23988-cest-normalization-handle-zero-division'
Mon, Jan 8, 4:31 PM
goch closed T23988: Handle CEST normalization for M0 voxels that are zero as Resolved by committing rMITK683c54630510: Fixes T23988 - set to zero instead of dividing by it.
Mon, Jan 8, 4:31 PM · FS-E IT Restructuring, MITK
goch committed rMITK683c54630510: Fixes T23988 - set to zero instead of dividing by it (authored by goch).
Fixes T23988 - set to zero instead of dividing by it
Mon, Jan 8, 4:30 PM
goch added a comment to T23988: Handle CEST normalization for M0 voxels that are zero.

Pushed new branch T23988-cest-normalization-handle-zero-division.

Mon, Jan 8, 4:30 PM · FS-E IT Restructuring, MITK
goch closed T23339: Change default: Open DICOM data with new dicom reader as Resolved.

Has been merged

Mon, Jan 8, 3:19 PM · MITK, MICO (Demo_MICCAI_2017)
goch closed T23526: Autoload modules not installed on MITK based projects as Resolved.

Seems to have been solved with the switch to external directories in T23775: "ExtensionPoint" support for SuperBuild. External autoload modules are included in the installer.

Mon, Jan 8, 3:04 PM · MITK-ProjectTemplate, MITK

Dec 22 2017

goch triaged T23988: Handle CEST normalization for M0 voxels that are zero as Low priority.
Dec 22 2017, 3:56 PM · FS-E IT Restructuring, MITK
goch added a comment to rMITKdab8aa4b04e1: T23749: Initial commit of the data storage viewer base class.

I agree that the viewer has too many signals and selection capability for my understanding of a viewer.

Dec 22 2017, 2:21 PM
goch added a comment to T22870: Crash on segmentation threshold [0, 1[.

@goyette I assume you meant to add this comment to T23248, T22929, T23985 or most likely T22065? I do not see a connection to this task?

Dec 22 2017, 9:41 AM · Pull Request, MITK

Dec 18 2017

goch added a comment to T23756: Investigate use of precompiled headers.

On Ubuntu I need to add -fPIC to the CXX compiler flags in cmake to have a successful cotire based build. Otherwise I had the following error message

cc1plus: error: /MITK-build/Modules/QtWidgets/test/cotire/MitkQtWidgetsTestDriver_CXX_prefix.hxx.gch: created and used with different settings of -fpic [-Werror]
Dec 18 2017, 5:45 PM · MITK

Dec 15 2017

goch committed rMITK84be0fbeb5da: Add cotire (authored by goch).
Add cotire
Dec 15 2017, 4:25 PM
goch added a comment to T23756: Investigate use of precompiled headers.

Pushed new branch T23756-cotire.

Dec 15 2017, 4:25 PM · MITK
goch claimed T23756: Investigate use of precompiled headers.
Dec 15 2017, 2:34 PM · MITK

Dec 11 2017

goch committed rMITK0ddb023bf426: Move openGL check to constructor (authored by goch).
Move openGL check to constructor
Dec 11 2017, 3:49 PM

Dec 8 2017

goch committed rMITKc0703aa9108b: Use rendering helper for interaction tests as well (authored by goch).
Use rendering helper for interaction tests as well
Dec 8 2017, 1:22 PM
goch closed T23924: Reader preference list test fails due to change in default dicom reader as Resolved.
Dec 8 2017, 1:04 PM · MITK
goch committed rMITK21dda7058d2e: Tell the test what to expect due to changed default readers (authored by goch).
Tell the test what to expect due to changed default readers
Dec 8 2017, 1:03 PM
goch added a revision to T23924: Reader preference list test fails due to change in default dicom reader : Unknown Object (Differential Revision).
Dec 8 2017, 1:01 PM · MITK
goch triaged T23924: Reader preference list test fails due to change in default dicom reader as Normal priority.
Dec 8 2017, 12:53 PM · MITK
goch closed T23810: MitkDICOMQIIO.dll causes crashes for VerifyDICOMMitkImageDump.exe as Resolved.
Dec 8 2017, 12:37 PM · MITK
goch closed T23922: [Dashboard] Clustering metrics unresolved external symbols as Resolved.
Dec 8 2017, 12:37 PM · MITK
goch closed T23920: [Dashboard] vtkDebug Leaks as Resolved.
Dec 8 2017, 12:37 PM · MITK
goch closed T23755: Clean up includes as Wontfix.
Dec 8 2017, 11:45 AM · MITK
goch closed T23755: Clean up includes, a subtask of T23721: Project "Astonishing Angelfish", as Wontfix.
Dec 8 2017, 11:45 AM · MITK
goch committed rMITK1dbcecc4589d: Merge branch 'T23920-fix-debug-leaks' (authored by goch).
Merge branch 'T23920-fix-debug-leaks'
Dec 8 2017, 11:37 AM
goch committed rMITK79c91e4e4260: Delete vtk smart pointers at the end (authored by goch).
Delete vtk smart pointers at the end
Dec 8 2017, 11:37 AM
goch added a comment to T23920: [Dashboard] vtkDebug Leaks.

Pushed new branch T23920-fix-debug-leaks.

Dec 8 2017, 11:37 AM · MITK
goch committed rMITK90b2bdea1ce0: Merge branch 'T23922-unresolved-external-symbol' (authored by goch).
Merge branch 'T23922-unresolved-external-symbol'
Dec 8 2017, 11:17 AM
goch committed rMITKed5fb03c19d8: Do not export header only classes (authored by goch).
Do not export header only classes
Dec 8 2017, 11:17 AM
goch added a comment to T23922: [Dashboard] Clustering metrics unresolved external symbols.

Pushed new branch T23922-unresolved-external-symbol.

Dec 8 2017, 11:17 AM · MITK
goch triaged T23922: [Dashboard] Clustering metrics unresolved external symbols as High priority.
Dec 8 2017, 11:15 AM · MITK
goch committed rMITK3fe2da2642db: Merge branch 'T23268-some-more-clang-fixes2' (authored by goch).
Merge branch 'T23268-some-more-clang-fixes2'
Dec 8 2017, 11:00 AM
goch committed rMITK6748967b973d: Use std::abs explicitly (authored by goch).
Use std::abs explicitly
Dec 8 2017, 10:59 AM
goch added a comment to T23268: Build errors with clang 3.8.1 (Debian 9.1 "Stretch").

Pushed new branch T23268-some-more-clang-fixes2.

Dec 8 2017, 10:59 AM · MITK
goch triaged T23920: [Dashboard] vtkDebug Leaks as High priority.
Dec 8 2017, 10:37 AM · MITK
goch added a comment to T23810: MitkDICOMQIIO.dll causes crashes for VerifyDICOMMitkImageDump.exe.

Solved for now by checking whether the context is valid in mitkDICOMIOHelper.cpp, gives a warning instead of crashing if the context does not exist. This should solve the dashboard crashes, but will not guarantee all DICOMQI tags of interest are registered correctly. However they should work as well as before.

Dec 8 2017, 9:15 AM · MITK
goch committed rMITK027faedcbf3e: Merge branch 'T23810-MitkDICOMQIIO-crash' (authored by goch).
Merge branch 'T23810-MitkDICOMQIIO-crash'
Dec 8 2017, 8:49 AM
goch committed rMITK8dcbdf68d028: Give warning instead of crashing (authored by goch).
Give warning instead of crashing
Dec 8 2017, 8:47 AM
goch committed rMITKaf27b49580d0: Move and rename classes for cleanupx (authored by goch).
Move and rename classes for cleanupx
Dec 8 2017, 8:47 AM
goch added a comment to T23810: MitkDICOMQIIO.dll causes crashes for VerifyDICOMMitkImageDump.exe.

Pushed new branch T23810-MitkDICOMQIIO-crash.

Dec 8 2017, 8:47 AM · MITK

Nov 23 2017

goch added a comment to T23810: MitkDICOMQIIO.dll causes crashes for VerifyDICOMMitkImageDump.exe.

Moving the this->AddDICOMTagsToService(); line from the constructor somewhere else removes the crash.

Nov 23 2017, 1:31 PM · MITK
goch added a comment to T23810: MitkDICOMQIIO.dll causes crashes for VerifyDICOMMitkImageDump.exe.

Call stack is

MitkDICOMReader.dll!us::GetModuleContext() Line 57	
MitkDICOMReader.dll!mitk::GetDicomTagsOfInterestService() Line 32	
MitkDICOMQIIO.dll!mitk::DICOMSegmentationIO::AddDICOMTagsToService() Line 59	
MitkDICOMQIIO.dll!mitk::DICOMSegmentationIO::DICOMSegmentationIO() Line 54	
MitkDICOMQIIO.dll!mitk::DICOMQIIOModulActivator::Load(us::ModuleContext * context) Line 50	
CppMicroServices.dll!us::Module::Start() Line 160	
CppMicroServices.dll!us::ModuleRegistry::Register(us::ModuleInfo * info) Line 129
Nov 23 2017, 12:43 PM · MITK

Nov 22 2017

goch claimed T23810: MitkDICOMQIIO.dll causes crashes for VerifyDICOMMitkImageDump.exe.
Nov 22 2017, 5:46 PM · MITK
goch created T23810: MitkDICOMQIIO.dll causes crashes for VerifyDICOMMitkImageDump.exe.
Nov 22 2017, 5:46 PM · MITK
goch placed T23755: Clean up includes up for grabs.
Nov 22 2017, 3:09 PM · MITK
goch lowered the priority of T23755: Clean up includes from Low to Wishlist.
Nov 22 2017, 3:09 PM · MITK
goch added a comment to T23755: Clean up includes.

Seems to be a lot of manual effort as well you have to extract all include paths (from e.g. the CMakeFiles/ModuleName.dir/flags.make). Call it on the source directory with these paths and manually integrate the suggestions offered.

Nov 22 2017, 3:08 PM · MITK
goch added a comment to T23755: Clean up includes.

I did just run include what you use on MitkCore and accepted the suggested changes. This results in a number of errors like

mitkPlaneGeometryDataToSurfaceFilter.cpp:111:22: error: unknown type name 'AbstractTransformGeometry'
mitkPlaneGeometryDataToSurfaceFilter.cpp:118:32: error: no member named 'GetPlane' in 'mitk::PlaneGeometry'
mitkCoreObjectFactory.cpp:194:27: error: no member named 'PlaneGeometryDataVtkMapper3D' in namespace 'mitk'; did you mean 'PlaneGeometryDataMapper2D'?
mitkCoreObjectFactory.cpp:80:7: error: deleting pointer to incomplete type 'mitk::LegacyFileReaderService' may cause undefined behavior
mitkOperationEvent.cpp:106:30: error: 'OperationEvent' does not refer to a value
mitkSurfaceToSurfaceFilter.cpp:75:23: error: member access into incomplete type 'OutputType' (aka 'mitk::Surface')
mitkRenderingManager.cpp:293:64: error: too many arguments to function call, expected single argument '_arg', have 2 arguments
error: "Do not include itkExceptionObject.h directly,  include itkMacro.h instead."
Nov 22 2017, 1:46 PM · MITK
goch committed rMITK91d61dabba24: Merge branch 'T23268-some-more-clang-fixes' (authored by goch).
Merge branch 'T23268-some-more-clang-fixes'
Nov 22 2017, 12:59 PM
goch committed rMITK7998534d5799: Use std::abs instead of abs in a number of cases (authored by goch).
Use std::abs instead of abs in a number of cases
Nov 22 2017, 12:58 PM
goch added a comment to T23268: Build errors with clang 3.8.1 (Debian 9.1 "Stretch").

Pushed new branch T23268-some-more-clang-fixes.

Nov 22 2017, 12:58 PM · MITK
goch added a comment to T23343: Dicom editor can not load dicom segmentation objects.

Probably, the dicom folder read implementation was a bit cobbled together and could probably use some more thought.

Nov 22 2017, 10:06 AM · MICO (Demo_MICCAI_2017), MITK
goch added a comment to T23798: MITK has new memory leaks breaking unit tests.

I approve. Although the offending commit should be one of three
http://cdash.mitk.org/index.php?project=MITK&date=2017-11-15&display=project

Nov 22 2017, 9:47 AM · MITK

Nov 21 2017

goch claimed T23755: Clean up includes.
Nov 21 2017, 1:27 PM · MITK

Nov 14 2017

goch added a member for IGT: mittmann.
Nov 14 2017, 3:00 PM
goch added a member for MITK: mittmann.
Nov 14 2017, 2:59 PM
goch added a member for Deep Learning: kamphenk.
Nov 14 2017, 10:29 AM

Nov 13 2017

goch added a comment to T23288: MITK superbuild may fail with visual studio 2017 at boost.

Thanks for the info. Quoting from the link you posted above:

Nov 13 2017, 9:13 AM · MITK

Nov 10 2017

goch added a member for MITK: kahl.
Nov 10 2017, 3:09 PM
goch added a comment to T23384: Insert error functionality in MitkChart.

One current use case of error bars is in the CEST view:

Nov 10 2017, 3:02 PM · Restricted Project, MITK

Nov 7 2017

goch committed rMITK3a0c9ce39180: Enable test skipping if advanced openGL is not supported (authored by goch).
Enable test skipping if advanced openGL is not supported
Nov 7 2017, 4:30 PM