Page MenuHomePhabricator

Properties view crash when ReplaceProperty used
Closed, ResolvedPublic

Description

If the Properties view is switched on and a property of the selected data node is replaced, it makes the application crash.

The crash happens at this point:

https://phabricator.mitk.org/source/mitk/browse/master/Modules/QtWidgets/src/QmitkPropertyItemModel.cpp;1606179f64986d98b469c5e13e627b8e264ff790$136

As I see, the property item model is not listening to the modify event of the property list (only the individual properties), and the model is not updated when a new property is added or removed. The crash happens when the property tree view is re-rendered for the first time after the property has been replaced. The reason is that model item still points to the old property that has been replaced and destroyed.

This happened with 2015.05.2, but as I see the class has not changed significantly since then, apart from some clean-up and style fixes and the class being moved to a module.