Page MenuHomePhabricator | MITK

espak (Miklos Espak)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 1 2016, 12:10 PM (158 w, 5 d)

Recent Activity

Apr 4 2019

espak added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

Another place where inverse matrix calculation has been introduced:

Apr 4 2019, 1:26 PM · MITK (2018-04-4)
espak added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

As I see, the inverse matrix calculation came in with this commit of mine:

Apr 4 2019, 1:10 PM · MITK (2018-04-4)

Apr 3 2019

espak added a comment to T25682: mitkBaseGeometry.cpp: Internal ITK matrix inversion error, cannot proceed..

The meaning of the dominant axes is also documented here:

Apr 3 2019, 5:10 PM · MITK (2018-04-4)

Aug 6 2018

espak committed rMITK917d31e6fcfc: Merge branch 'master' into niftk (authored by espak).
Merge branch 'master' into niftk
Aug 6 2018, 4:12 PM
espak committed rMITK9df515e9ef66: Merge branch 'MITK-bug-12302-trac-1577-provide-control-of-interactors-via… (authored by espak).
Merge branch 'MITK-bug-12302-trac-1577-provide-control-of-interactors-via…
Aug 6 2018, 4:11 PM
espak committed rMITKb977ae94ad98: CTK upgrade (no more ctkRuntimeException::getClause()) (authored by espak).
CTK upgrade (no more ctkRuntimeException::getClause())
Aug 6 2018, 4:11 PM
espak committed rMITKafd4b5d77219: Merge branch 'master' into niftk (authored by espak).
Merge branch 'master' into niftk
Aug 6 2018, 4:11 PM

Mar 6 2018

espak committed rMITKd15bbe0f162b: Allow setting limit to undo history (authored by espak).
Allow setting limit to undo history
Mar 6 2018, 11:22 AM

Oct 2 2017

espak committed rMITKf6c452e1b464: Nodes are inserted in data manager at position according to their layer (authored by espak).
Nodes are inserted in data manager at position according to their layer
Oct 2 2017, 4:06 PM

Jul 14 2017

espak added a comment to T22572: Migrate plugins from deprecated org.mitk.gui.qt.common.legacy dependency to org.mitk.gui.qt.common.

I wanted to open new tasks for the individual plugins that need a similar fix as the segmentation plugin, so that we can track the progress.

Jul 14 2017, 3:43 PM · Pull Request, MITK

Jul 1 2017

espak added a comment to T22963: Ensure consistency of "selected" property with Data Manager selection.

The only way I see to figure out the difference between the two ways of setting the "selected" property is to put a breakpoint at SetBoolProperty("selected") and to through all the listeners, step by step, systematically. Hopefully there are not so many.

Jul 1 2017, 10:10 AM · MITK

Jun 28 2017

espak added a comment to T22963: Ensure consistency of "selected" property with Data Manager selection.

I would try this->GetSelectionProvider()->SetSelection(...) and right after this->GetSelectionProvider()->GetSelection() and check if the two are the same.

Jun 28 2017, 5:46 PM · MITK
espak added a comment to T22963: Ensure consistency of "selected" property with Data Manager selection.

So, the render window manager plugin uses its own selection provider, right? If you set its selection and and right after you get the selection from it, do you get the back the same?

Jun 28 2017, 5:11 PM · MITK
espak added a comment to T22963: Ensure consistency of "selected" property with Data Manager selection.

Do you have the Properties view open? I know that it is listening to the property list changes because the ReplaceProperty calls caused crash. I reported this not long ago and Stefan fixed it. It would be surprising, but maybe...

Jun 28 2017, 4:55 PM · MITK
espak added a comment to T22963: Ensure consistency of "selected" property with Data Manager selection.

I thought about that blocking the signals might cause such errors, but it did not occur here, so I thought it is fine. It may depend on the platform as well, and the qt version. I use Qt4 on Mac.

Jun 28 2017, 4:43 PM · MITK
espak added a comment to T22963: Ensure consistency of "selected" property with Data Manager selection.

I can also imagine that we see different behaviour because I am testing with 2015.05.2, and just rebased my patch on the master.

Jun 28 2017, 4:14 PM · MITK
espak added a comment to T22963: Ensure consistency of "selected" property with Data Manager selection.

Actually, there was no PR, so I opened one:

Jun 28 2017, 4:00 PM · MITK
espak added a comment to T22963: Ensure consistency of "selected" property with Data Manager selection.

What I told above about the data roles was wrong. That part works correctly. I made a mistake. After I set the selection of the selection model, like in QmitkAbstractView::FireSelectedNodes(), I also set the selection through the selection provider that overwrote what I've just set.

Jun 28 2017, 3:30 PM · MITK

Jun 26 2017

espak added a comment to T22775: DCMTK build fails with clang 7.

It seems that they fixed this other error already. This works for me:

Jun 26 2017, 7:02 PM · MITK
espak added a comment to T22775: DCMTK build fails with clang 7.

I tried, but I get a different error:

Jun 26 2017, 6:53 PM · MITK
espak added a comment to T22775: DCMTK build fails with clang 7.

//Flags used to enable C++11 support.
DCMTK_CXX11_FLAGS:STRING=-std=c++11

Jun 26 2017, 6:51 PM · MITK
espak added a comment to T22775: DCMTK build fails with clang 7.

You remember well, but I do not know if this can be matched this to the official numbering.

Jun 26 2017, 6:46 PM · MITK
espak added a comment to T22775: DCMTK build fails with clang 7.

It reports this:

Jun 26 2017, 6:33 PM · MITK
espak added a comment to T22963: Ensure consistency of "selected" property with Data Manager selection.

As I see, PropertyList::SetProperty() does an equality check, and returns early if the parameter is equal to the current value. No modified event is sent, either.

Jun 26 2017, 5:54 PM · MITK

Jun 23 2017

espak added a comment to T22990: SlicedGeometry3D crash when volume is rotated by 45 degrees.

I sent a new PR and closed the previous one.

Jun 23 2017, 6:59 PM · Pull Request, MITK
espak added a comment to T22990: SlicedGeometry3D crash when volume is rotated by 45 degrees.

I have to allow an epsilon difference for rounding error, but it is not enough, it still crashes when the volume is rotated around two world axes by 45 degrees. I get a matrix that I thought is invalid but it is not.

Jun 23 2017, 3:59 PM · Pull Request, MITK
espak added a comment to T22990: SlicedGeometry3D crash when volume is rotated by 45 degrees.

Our tests failed. :-(

Jun 23 2017, 2:48 PM · Pull Request, MITK
espak added a comment to T22963: Ensure consistency of "selected" property with Data Manager selection.

node->SetBoolProperty("selected", true/false); and node->SetSelected(true/false); are almost exactly the same.

Jun 23 2017, 12:53 PM · MITK
espak committed rMITK1902529f7c30: Update renderers after removing point selection (authored by espak).
Update renderers after removing point selection
Jun 23 2017, 11:26 AM

Jun 22 2017

espak updated the task description for T22990: SlicedGeometry3D crash when volume is rotated by 45 degrees.
Jun 22 2017, 6:03 PM · Pull Request, MITK
espak updated subscribers of T22990: SlicedGeometry3D crash when volume is rotated by 45 degrees.
Jun 22 2017, 5:59 PM · Pull Request, MITK
espak added a comment to T22990: SlicedGeometry3D crash when volume is rotated by 45 degrees.

All the geometry tests of MITK pass on Linux, although probably there is not a test for this special case.

Jun 22 2017, 5:59 PM · Pull Request, MITK
espak created T22990: SlicedGeometry3D crash when volume is rotated by 45 degrees.
Jun 22 2017, 5:43 PM · Pull Request, MITK
espak added a comment to T22775: DCMTK build fails with clang 7.

I am testing a PR with the latest master and ran into this again.

Jun 22 2017, 3:54 PM · MITK

Jun 16 2017

espak added a comment to T22971: Point selection does not disappear when moving the mouse away.

https://github.com/MITK/MITK/pull/201

Jun 16 2017, 6:22 PM · Pull Request, MITK
espak created T22971: Point selection does not disappear when moving the mouse away.
Jun 16 2017, 5:28 PM · Pull Request, MITK

Jun 13 2017

espak created T22963: Ensure consistency of "selected" property with Data Manager selection.
Jun 13 2017, 7:08 PM · MITK
espak created T22962: Data manager item highlighting not updated after changing data manager selection through BlueBerry.
Jun 13 2017, 6:56 PM · MITK

Jun 6 2017

espak added a comment to T22890: Properties view crash when ReplaceProperty used.

It works perfectly, thank you!

Jun 6 2017, 12:54 PM · MITK

May 23 2017

espak added a comment to T22890: Properties view crash when ReplaceProperty used.

I do not have a fix for this, so no pull request this time. Any fix is welcome. :-)

May 23 2017, 8:51 PM · MITK
espak created T22890: Properties view crash when ReplaceProperty used.
May 23 2017, 8:47 PM · MITK

May 12 2017

espak added a comment to T22254: Render windows show *not* the corresponding orientation after reinit with permuted axes.

Maybe the rotation matrix is not set for the clipping plane? Just guessing...

May 12 2017, 12:52 PM · Pull Request, MITK (2016-11)
espak added a comment to T22254: Render windows show *not* the corresponding orientation after reinit with permuted axes.

What do you think is wrong? It looks correct to me.

May 12 2017, 12:29 PM · Pull Request, MITK (2016-11)

Apr 28 2017

espak committed rMITK7b23beb55ac8: Make feedback contour node derived from working data (authored by espak).
Make feedback contour node derived from working data
Apr 28 2017, 10:25 AM

Apr 27 2017

espak added a comment to T22774: crash because unlimited undo history.

I updated the PR because the limit was applied only in one of the undo models. (The verbose undo model overrode the function in which the superclass applied the limit.)

Apr 27 2017, 4:42 PM · Pull Request, MITK
espak added a comment to T22774: crash because unlimited undo history.

PR sent:

Apr 27 2017, 12:00 PM · Pull Request, MITK
espak created T22775: DCMTK build fails with clang 7.
Apr 27 2017, 11:40 AM · MITK

Apr 26 2017

espak added a comment to T22774: crash because unlimited undo history.

The fix is probably easy. There are several ways.

Apr 26 2017, 9:59 PM · Pull Request, MITK
espak created T22774: crash because unlimited undo history.
Apr 26 2017, 9:46 PM · Pull Request, MITK

Mar 9 2017

espak added a comment to T22606: Feedback contour tool should add its data node 'under' the working data.

It is a trivial, one line fix, and does not change anything for the MITK Display.

Mar 9 2017, 9:17 AM · MITK
espak created T22606: Feedback contour tool should add its data node 'under' the working data.
Mar 9 2017, 9:11 AM · MITK

Mar 8 2017

espak added a comment to T19500: Setting "selected" property should highlight item in data manager.

That sounds cool! Is there a prototype already to try out?

Mar 8 2017, 4:55 PM · Bugzilla, MITK
espak added a comment to T19859: Incorrect ordering of nodes when initialising data manager from data storage.

Rebased on master and conflicts resolved:

Mar 8 2017, 11:19 AM · MITK
espak added a comment to T19500: Setting "selected" property should highlight item in data manager.

We follow a different way in our plugins. They show which images you are working on, but by labels, not combo boxes. We have not seen problem with this approach, but this does not mean that you need to change the MITK Segmentation plugin if you are happy with it.

Mar 8 2017, 10:37 AM · Bugzilla, MITK

Mar 3 2017

espak committed rMITK1be7ffb8eaca: Decouple multilabelsegmentation view from multi widget (authored by espak).
Decouple multilabelsegmentation view from multi widget
Mar 3 2017, 2:29 PM
espak committed rMITK3975fb47fa4e: Decouple diffusionimaging plugin from multi widget (authored by espak).
Decouple diffusionimaging plugin from multi widget
Mar 3 2017, 2:29 PM
espak committed rMITK84b7513bc91c: Remove references to deprecated class from comments in xnat plugin (authored by espak).
Remove references to deprecated class from comments in xnat plugin
Mar 3 2017, 2:29 PM
espak committed rMITKa7c91185c351: Remove reference to deprecated class from comment in ultrasound plugin (authored by espak).
Remove reference to deprecated class from comment in ultrasound plugin
Mar 3 2017, 2:29 PM
espak committed rMITK20213787b692: Turn Qt style for loop to C++11 style (authored by espak).
Turn Qt style for loop to C++11 style
Mar 3 2017, 2:29 PM
espak committed rMITK5c771369f975: Decouple ugvisualization plugin from multi widget (authored by espak).
Decouple ugvisualization plugin from multi widget
Mar 3 2017, 2:29 PM
espak committed rMITK244b8055f212: Decouple tubegraph plugin from multi widget (authored by espak).
Decouple tubegraph plugin from multi widget
Mar 3 2017, 2:29 PM
espak committed rMITK26aee47cb4ad: Remove direct references to multi widget from tofutil plugin (authored by espak).
Remove direct references to multi widget from tofutil plugin
Mar 3 2017, 2:29 PM
espak committed rMITK9dc0a4382a46: Decouple segmentation plugin from multi widget (authored by espak).
Decouple segmentation plugin from multi widget
Mar 3 2017, 2:29 PM
espak committed rMITK93b291fb6739: Decouple ToFTutorial plugin from multi widget (authored by espak).
Decouple ToFTutorial plugin from multi widget
Mar 3 2017, 2:29 PM
espak committed rMITKbc05ba4ebd27: Decouple registration plugin from multi widget (authored by espak).
Decouple registration plugin from multi widget
Mar 3 2017, 2:29 PM
espak committed rMITK206564d3df42: Decouple poinsetinteraction plugin from multi widget (authored by espak).
Decouple poinsetinteraction plugin from multi widget
Mar 3 2017, 2:28 PM
espak committed rMITK0c2b36ec22bb: Make overriding function virtual in properties plugin (authored by espak).
Make overriding function virtual in properties plugin
Mar 3 2017, 2:28 PM
espak committed rMITK594af95f9447: Decouple moviemaker plugin from multi widget (authored by espak).
Decouple moviemaker plugin from multi widget
Mar 3 2017, 2:28 PM
espak committed rMITK8b42daa460ed: Style fixes on the measurementtoolbox plugin related to decoupling the views… (authored by espak).
Style fixes on the measurementtoolbox plugin related to decoupling the views…
Mar 3 2017, 2:28 PM
espak committed rMITKb182d3f7f65e: Decouple materialeditor plugin from multi widget (authored by espak).
Decouple materialeditor plugin from multi widget
Mar 3 2017, 2:28 PM
espak committed rMITK7daa8a68415b: Decouple imagecropper plugin from multi widget (authored by espak).
Decouple imagecropper plugin from multi widget
Mar 3 2017, 2:28 PM
espak committed rMITKdc117115023f: Decouple igttracking plugin from multi widget (authored by espak).
Decouple igttracking plugin from multi widget
Mar 3 2017, 2:28 PM
espak committed rMITK05ccd68d28c9: Remove references to multi widget from igtexamples plugin (authored by espak).
Remove references to multi widget from igtexamples plugin
Mar 3 2017, 2:28 PM
espak committed rMITKe759880f38c9: Remove reference to deprecated class from comment in geometrytools plugin (authored by espak).
Remove reference to deprecated class from comment in geometrytools plugin
Mar 3 2017, 2:28 PM
espak committed rMITKb40fda7bd329: Remove (commented) references to multi widget from org.mitk.gui.qt.ext and… (authored by espak).
Remove (commented) references to multi widget from org.mitk.gui.qt.ext and…
Mar 3 2017, 2:28 PM
espak committed rMITKdc0c9c40b43d: Decouple datamanager plugin from multi widget (authored by espak).
Decouple datamanager plugin from multi widget
Mar 3 2017, 2:28 PM
espak committed rMITK0c4b0b53068c: Decouple basicimageprocessing plugin from multi widget (authored by espak).
Decouple basicimageprocessing plugin from multi widget
Mar 3 2017, 2:27 PM

Feb 24 2017

espak added a comment to T22572: Migrate plugins from deprecated org.mitk.gui.qt.common.legacy dependency to org.mitk.gui.qt.common.

The code compiles, at least everything that I could switch on. :)

Feb 24 2017, 7:55 PM · Pull Request, MITK
espak added a comment to T22572: Migrate plugins from deprecated org.mitk.gui.qt.common.legacy dependency to org.mitk.gui.qt.common.

PR 175:
https://github.com/MITK/MITK/pull/175

Feb 24 2017, 7:44 PM · Pull Request, MITK
espak created T22572: Migrate plugins from deprecated org.mitk.gui.qt.common.legacy dependency to org.mitk.gui.qt.common.
Feb 24 2017, 7:40 PM · Pull Request, MITK

Jan 23 2017

espak closed T20180: Axial renderer origin in top-left-front corner, not in the bottom-left-back as Resolved.

Resolved in T22254.

Jan 23 2017, 8:01 PM · Request for Discussion, MITK
espak added a comment to T22254: Render windows show *not* the corresponding orientation after reinit with permuted axes.

Yippie yay!

Jan 23 2017, 5:46 PM · Pull Request, MITK (2016-11)

Jan 20 2017

espak added a comment to T22254: Render windows show *not* the corresponding orientation after reinit with permuted axes.

I pushed a few fixes here:

Jan 20 2017, 8:55 PM · Pull Request, MITK (2016-11)
espak added a comment to T22254: Render windows show *not* the corresponding orientation after reinit with permuted axes.

Ah, ok, so the behaviour is good.

Jan 20 2017, 10:27 AM · Pull Request, MITK (2016-11)

Jan 19 2017

espak added a comment to T22254: Render windows show *not* the corresponding orientation after reinit with permuted axes.

For the image test, the missing image geometry flag wasn't the actual problem. The problem is that mitk::Image::Initialize() has a parameter called flipped. As you changed a similar signature in the InitializeByStandardPlane() methods of a geometry, this bool flag was now passed as number of slices (false -> 0). I fixed it by making the Initialize() method deprecated and adding a new signature without the flag.
I have trouble with the mitkSliceNavigationControllerTest, though. The frontal case fails and I didn't get it. It doesn't seem to be a changed sign problem alone. Would be really cool, if you could have a look at the test. It can be executed by the CoreTestDriver.
The PointSetInteraction test seems to be tricky as well as a few points out of many have a difference of 1 in the second coordinate (128.x vs 127.x).

Jan 19 2017, 3:44 PM · Pull Request, MITK (2016-11)

Jan 17 2017

espak added a comment to T22254: Render windows show *not* the corresponding orientation after reinit with permuted axes.

For my best understanding, scrolling up should move right in sagittal, posterior in coronal and superior in axial. And as I remember, only the coronal did not match, because the coronal renderer had left-handed coordinate system. So, the scrolling direction changed there as a consequence of the changes. I might remember wrong.

Jan 17 2017, 11:49 AM · Pull Request, MITK (2016-11)
espak added a comment to T22254: Render windows show *not* the corresponding orientation after reinit with permuted axes.

"scrolling up brings us to the heart"

Jan 17 2017, 11:15 AM · Pull Request, MITK (2016-11)
espak added a comment to T22254: Render windows show *not* the corresponding orientation after reinit with permuted axes.

No, scrolling up should go to the slice behind in any render window. In sagittal, scrolling up should go towards the patient's right. It was like this when I was testing. If it is not like that, something is wrong.

Jan 17 2017, 11:03 AM · Pull Request, MITK (2016-11)
espak added a comment to T22254: Render windows show *not* the corresponding orientation after reinit with permuted axes.

The actual values all look correct to me.

Jan 17 2017, 10:58 AM · Pull Request, MITK (2016-11)
espak added a comment to T22254: Render windows show *not* the corresponding orientation after reinit with permuted axes.

In sagittal we see the left side of the face of the patient, i.e. we are looking towards the patient's right, what is on their other side. We can't see their right.

Jan 17 2017, 10:08 AM · Pull Request, MITK (2016-11)

Jan 12 2017

espak added a comment to T22254: Render windows show *not* the corresponding orientation after reinit with permuted axes.

Are these isotropic voxels? I mean the slice thickness is 2mm in all the directions?

Jan 12 2017, 7:57 PM · Pull Request, MITK (2016-11)
espak added a comment to T22254: Render windows show *not* the corresponding orientation after reinit with permuted axes.

The assumptions are valid at the top.

Jan 12 2017, 7:00 PM · Pull Request, MITK (2016-11)

Jan 11 2017

espak added a comment to T22254: Render windows show *not* the corresponding orientation after reinit with permuted axes.

These tests fail, as I see:
http://cdash.mitk.org/viewTest.php?onlyfailed&buildid=643361

Jan 11 2017, 2:02 PM · Pull Request, MITK (2016-11)
espak closed T22333: Show file path in data manager file info dialog ('Details...' ) as Resolved.

Closing this. As @goch noted on the list, this feature is already there. I was using 2015.05.2.

Jan 11 2017, 1:16 PM

Jan 10 2017

espak added a comment to T22254: Render windows show *not* the corresponding orientation after reinit with permuted axes.

My guess is that the minus sign has to be removed from line 750 and 773.

Jan 10 2017, 5:00 PM · Pull Request, MITK (2016-11)
espak added a comment to T22254: Render windows show *not* the corresponding orientation after reinit with permuted axes.

The direction can be either way, as you can create left or right handed systems as well. If right handed, the direction is the same as the cross product of the righ and bottomvectors. If left-handed then the normal points in the opposite direction. You can create left-handed plande geometries by specifying negative thickness.

Jan 10 2017, 3:51 PM · Pull Request, MITK (2016-11)
espak added a comment to T22254: Render windows show *not* the corresponding orientation after reinit with permuted axes.

Which asserts?
Line 468 and 496 here?
https://phabricator.mitk.org/source/mitk/browse/T22254-GeometryFixesAsProposed/Modules/Core/test/mitkPlaneGeometryTest.cpp;4261ef7a44c7e44b4a7b38a9781533235a366293

Jan 10 2017, 3:47 PM · Pull Request, MITK (2016-11)

Jan 4 2017

espak created T22333: Show file path in data manager file info dialog ('Details...' ).
Jan 4 2017, 3:12 PM

Dec 21 2016

espak added a comment to T22254: Render windows show *not* the corresponding orientation after reinit with permuted axes.

That's totally possible. The PlaneGeometry API was already a bit messy, and my commit made it worse by adding 'top' at the end. (Some functions had 'top' somewhere at the beginning already, not directly before the 'frontside' and 'rotated' args as usual.)

Dec 21 2016, 1:25 PM · Pull Request, MITK (2016-11)
kislinsk awarded T22254: Render windows show *not* the corresponding orientation after reinit with permuted axes a Party Time token.
Dec 21 2016, 12:07 PM · Pull Request, MITK (2016-11)