Page MenuHomePhabricator

Update HDF5 to remove a bug on Visual Studio's RelWithDebInfo mode.
Closed, WontfixPublic

Description

Hello,

As was previously reported on the mailing list, the currently bundled HDF5 (1.8.17) trigger a problem when installing, under Visual Studio (tested with both 2013u5 and 2015u3).
It prevent specifically the compilation in "RelWithDebInfo", having no effect on Debug & Release.

I just tried a more recent one (1.8.19) and it worked, at least on the machines that were having the problem :


It requires to add the "hdf5::" namespace when MITK is asking CMake to locate a library (in CMake/mitkFunctionGetLibrarySearchPaths.cmake).

Resulting "HDF5-build/src/cmake_install.cmake" is correct :

107 : if("${CMAKE_INSTALL_COMPONENT}" STREQUAL "libraries" OR NOT CMAKE_INSTALL_COMPONENT)
108 :   if("${CMAKE_INSTALL_CONFIG_NAME}" MATCHES "^([Rr][Ee][Ll][Ww][Ii][Tt][Hh][Dd][Ee][Bb][Ii][Nn][Ff][Oo])$")
109 :     file(INSTALL DESTINATION "${CMAKE_INSTALL_PREFIX}/bin" TYPE FILE FILES "D:/MITK/build-mitk/ep/src/HDF5-build/bin/RelWithDebInfo/hdf5.pdb")
110 :   endif()
111 : endif()

Best,

Pierre-Yves Menguy

Event Timeline

goch added a subscriber: goch.

Thanks for the pointer and patch. The last upgrade of HDF proved to be a bit troublesome due to a changing internal structure. Not the highest priority for us as we usually do not usually use RelWithDebInfo ourselves.

kislinsk claimed this task.
kislinsk added a project: Auto-closed.
kislinsk added a subscriber: kislinsk.

Hi there! 🙂

This task was auto-closed according to our Task Lifecycle Management.
Please follow this link for more information and don't forget that you are encouraged to reasonable re-open tasks to revive them. 🚑

Best wishes,
The MITK devs

kislinsk removed kislinsk as the assignee of this task.May 26 2020, 12:05 PM
kislinsk removed a subscriber: kislinsk.