Page MenuHomePhabricator
Create Task
Maniphest T24264

HDF5 error in external projects
Closed, ResolvedPublic
Actions

Description

Plattform: Windows

Problem: External projects (e.g. MatchPoint) that use CMake's find_package to find HDF5 run into problems when build debug and release. The second build generates an CMake error:

CMake Error at C:/Program Files/CMake/share/cmake-3.9/Modules/FindHDF5.cmake:450 (get_target_property):

get_target_property called with incorrect number of arguments

Remark. It seems to be fixed when using CMake >3.10. There where several fixes in CMake's find HDF5.

Related Objects

Event Timeline

floca created this task.Feb 14 2018, 2:44 PM

So maybe we have to raise the CMake requirement to CMake 3.10 < *sigh*.

kislinsk added a subscriber: kislinsk.Feb 14 2018, 2:47 PM

If it is really just the FindHDF5.cmake file, there's also the option to copy the latest version into our own CMake folder, as long as it uses no brand new CMake features (which should be rarely the case).

floca edited projects, added MITK (2018-04); removed MITK.Mar 2 2018, 11:25 AM
kislinsk added a comment.Mar 9 2018, 10:27 AM

@floca Can you copy the following file into MITK's CMake folder and see if it resolves this issue, please?

FindHDF5.cmake39 KBDownload

floca mentioned this in T23540: CMake Error when building MatchPoint with current master.Mar 16 2018, 3:06 PM
kislinsk triaged this task as Normal priority.Mar 19 2018, 11:19 AM
kislinsk moved this task from Backlog to Blocking v2018.04 on the MITK (2018-04) board.Mar 26 2018, 10:00 AM
floca claimed this task.Mar 26 2018, 11:10 AM

I'll test the findHDF5 file

floca added a comment.Mar 27 2018, 9:54 AM

Great, the fix seems to work. I will add the patch into the master.

floca added a comment.Mar 27 2018, 10:01 AM

Pushed new branch T24264-HDF5_error_in_external_projects.

floca closed this task as Resolved.Mar 27 2018, 10:04 AM

Fixed Issue. Used CMake 3.10 find file.

MITK · MIC · IMSY · DKFZ