Page MenuHomePhabricator
Create Task
Maniphest T24437

Workbench crashes when inspecting segmentation node in Properties view
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  • Load image
  • Create segmentation
  • Select segmentation node in Data Manager
  • Open Properties view
  • Close Project (and remove all data objects)
  • Load image
  • Create segmentation
  • Select segmentation node

--> Workbench crashes

Related Objects

Event Timeline

eisenman triaged this task as High priority.Mar 16 2018, 2:28 PM
eisenman created this task.
kislinsk claimed this task.Mar 19 2018, 12:00 PM
kislinsk added a comment.Mar 19 2018, 12:22 PM
QmitkPropertyItemModel.cpp:185-186
auto propertyMap = m_PropertyList.Lock()->GetMap(); // <- m_PropertyList weak pointer is expired (should already crash here)
auto it = std::find_if(propertyMap->begin(), propertyMap->end(), PropertyEqualTo(property)); // <- crash

Adding a check if the property list isn't expired... that's consistent to all other locations in QmitkPropertyItemModel where the property list is used.

kislinsk added a comment.Mar 19 2018, 12:23 PM

Pushed new branch T24437-CrashOnUncheckedWeakPointerAccess.

kislinsk mentioned this in rMITK035201825473: Merge branch 'T24437-CrashOnUncheckedWeakPointerAccess'.Mar 19 2018, 12:24 PM
kislinsk closed this task as Resolved.Mar 19 2018, 12:25 PM
MITK · MIC · IMSY · DKFZ