Page MenuHomePhabricator
Create Task
Maniphest T25311

OpenCV 3.4.1 doesn't compile with Python 3 on Windows with VS 2017
Closed, ResolvedPublic
Actions

Description

Seems to be fixed in OpenCV 3.4.2.

Revisions and Commits

Restricted Differential Revision

Related Objects

Event Timeline

kislinsk triaged this task as Normal priority.Aug 28 2018, 1:33 PM
kislinsk created this task.
kislinsk added a comment.Aug 28 2018, 1:47 PM

Pushed new branch T25311-OpenCV-v3.4.2.

kislinsk mentioned this in rMITK2be7e53223bc: Merge branch 'T25311-OpenCV-v3.4.2'.Aug 28 2018, 1:48 PM
kislinsk added a comment.EditedAug 28 2018, 2:32 PM

Compiles now but cannot link to python37.lib. This is because of the value of PYTHON3_LIBRARY in the CMake cache of OpenCV-build: optimized;optimized;debug;C:/Python37/libs/python37_d.lib. This should be simply C:/Python37/libs/python37_d.lib instead. PYTHON3_LIBRARY_DEBUG is set correctly.

Possible solution: Instead of passing PYTHON_LIBRARY to the external project, try to pass PYTHON3_LIBRARY. If it gets overridden, pass it as CMAKE_CACHE_ARGS instead of CMAKE_ARGS in CMakeExternals/OpenCV.cmake. This way OpenCV shouldn't be able to override this value anymore.

One has to understand how OpenCV-build/cmake/OpenCVDetectPython.cmake works to fix this issue I guess.

kislinsk reassigned this task from kislinsk to neher.Aug 28 2018, 2:32 PM
neher added a comment.Aug 31 2018, 2:40 PM

Since we use system python we do not need to build the opencv python bindings.

neher added a comment.Aug 31 2018, 2:42 PM

The same is true for vtk by the way

neher added a comment.Aug 31 2018, 4:11 PM

Pushed new branch T25311-OpencvPython.

neher added a revision: Restricted Differential Revision.Aug 31 2018, 4:21 PM
neher mentioned this in rMITKbc551865e997: Disable opencv and vtk python.Sep 5 2018, 1:08 PM
neher closed this task as Resolved.Sep 5 2018, 2:26 PM
kislinsk mentioned this in T27033: Clean up stale remote branches.Jan 25 2020, 9:00 PM
MITK · MIC · IMSY · DKFZ